From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA60C3B185 for ; Mon, 10 Feb 2020 08:10:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BE432080C for ; Mon, 10 Feb 2020 08:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BE432080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3320F6E90F; Mon, 10 Feb 2020 08:10:11 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id D11956E90C; Mon, 10 Feb 2020 08:10:07 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20169875-1500050 for multiple; Mon, 10 Feb 2020 08:09:48 +0000 MIME-Version: 1.0 To: DRI Development , Daniel Vetter From: Chris Wilson In-Reply-To: <20200204150146.2006481-6-daniel.vetter@ffwll.ch> References: <20200204150146.2006481-1-daniel.vetter@ffwll.ch> <20200204150146.2006481-6-daniel.vetter@ffwll.ch> Message-ID: <158132218598.7138.16056756566358710107@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH 5/5] drm: Nerf drm_global_mutex BKL for good drivers Date: Mon, 10 Feb 2020 08:09:46 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Sam Ravnborg , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Daniel Vetter (2020-02-04 15:01:46) > This catches the majority of drivers (unfortunately not if we take > users into account, because all the big drivers have at least a > lastclose hook). > > With the prep patches out of the way all drm state is fully protected > and either prevents or can deal with the races from dropping the BKL > around open/close. The only thing left to audit are the various driver > hooks - by keeping the BKL around if any of them are set we have a > very simple cop-out! > > Note that one of the biggest prep pieces to get here was making > dev->open_count atomic, which was done in > > commit 7e13ad896484a0165a68197a2e64091ea28c9602 > Author: Chris Wilson > Date: Fri Jan 24 13:01:07 2020 +0000 > > drm: Avoid drm_global_mutex for simple inc/dec of dev->open_count > > v2: > - Rebase and fix locking in drm_open() (Chris) > - Indentation fix in drm_release > - Typo fix in the commit message (Sam) > > Cc: Chris Wilson > Cc: Sam Ravnborg > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4655C352A4 for ; Mon, 10 Feb 2020 08:10:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1B412080C for ; Mon, 10 Feb 2020 08:10:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1B412080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 363BA6E913; Mon, 10 Feb 2020 08:10:14 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id D11956E90C; Mon, 10 Feb 2020 08:10:07 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20169875-1500050 for multiple; Mon, 10 Feb 2020 08:09:48 +0000 MIME-Version: 1.0 To: DRI Development , Daniel Vetter From: Chris Wilson In-Reply-To: <20200204150146.2006481-6-daniel.vetter@ffwll.ch> References: <20200204150146.2006481-1-daniel.vetter@ffwll.ch> <20200204150146.2006481-6-daniel.vetter@ffwll.ch> Message-ID: <158132218598.7138.16056756566358710107@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Mon, 10 Feb 2020 08:09:46 +0000 Subject: Re: [Intel-gfx] [PATCH 5/5] drm: Nerf drm_global_mutex BKL for good drivers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Sam Ravnborg , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Daniel Vetter (2020-02-04 15:01:46) > This catches the majority of drivers (unfortunately not if we take > users into account, because all the big drivers have at least a > lastclose hook). > > With the prep patches out of the way all drm state is fully protected > and either prevents or can deal with the races from dropping the BKL > around open/close. The only thing left to audit are the various driver > hooks - by keeping the BKL around if any of them are set we have a > very simple cop-out! > > Note that one of the biggest prep pieces to get here was making > dev->open_count atomic, which was done in > > commit 7e13ad896484a0165a68197a2e64091ea28c9602 > Author: Chris Wilson > Date: Fri Jan 24 13:01:07 2020 +0000 > > drm: Avoid drm_global_mutex for simple inc/dec of dev->open_count > > v2: > - Rebase and fix locking in drm_open() (Chris) > - Indentation fix in drm_release > - Typo fix in the commit message (Sam) > > Cc: Chris Wilson > Cc: Sam Ravnborg > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx