All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg()
@ 2020-02-10  3:29 Randy Dunlap
  2020-02-10  7:41 ` Vincent Guittot
  2020-02-11 12:47 ` [tip: sched/urgent] sched/fair: Fix " tip-bot2 for Randy Dunlap
  0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-02-10  3:29 UTC (permalink / raw)
  To: LKML, Ingo Molnar, Peter Zijlstra; +Cc: Vincent Guittot, Dietmar Eggemann

From: Randy Dunlap <rdunlap@infradead.org>

Fix kernel-doc warning in kernel/sched/fair.c, caused by a recent
function parameter removal:

../kernel/sched/fair.c:3526: warning: Excess function parameter 'flags' description in 'attach_entity_load_avg'

Fixes: a4f9a0e51bbf ("sched/fair: Remove redundant call to cpufreq_update_util()")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org> (SCHED_NORMAL)
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> (SCHED_NORMAL)
---
 kernel/sched/fair.c |    1 -
 1 file changed, 1 deletion(-)

--- lnx-56-rc1.orig/kernel/sched/fair.c
+++ lnx-56-rc1/kernel/sched/fair.c
@@ -3516,7 +3516,6 @@ update_cfs_rq_load_avg(u64 now, struct c
  * attach_entity_load_avg - attach this entity to its cfs_rq load avg
  * @cfs_rq: cfs_rq to attach to
  * @se: sched_entity to attach
- * @flags: migration hints
  *
  * Must call update_cfs_rq_load_avg() before this, since we rely on
  * cfs_rq->avg.last_update_time being current.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg()
  2020-02-10  3:29 [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg() Randy Dunlap
@ 2020-02-10  7:41 ` Vincent Guittot
  2020-02-11 12:47 ` [tip: sched/urgent] sched/fair: Fix " tip-bot2 for Randy Dunlap
  1 sibling, 0 replies; 3+ messages in thread
From: Vincent Guittot @ 2020-02-10  7:41 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: LKML, Ingo Molnar, Peter Zijlstra, Dietmar Eggemann

On Mon, 10 Feb 2020 at 04:29, Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in kernel/sched/fair.c, caused by a recent
> function parameter removal:
>
> ../kernel/sched/fair.c:3526: warning: Excess function parameter 'flags' description in 'attach_entity_load_avg'
>
> Fixes: a4f9a0e51bbf ("sched/fair: Remove redundant call to cpufreq_update_util()")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Vincent Guittot <vincent.guittot@linaro.org> (SCHED_NORMAL)
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> (SCHED_NORMAL)

Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

>
> ---
>  kernel/sched/fair.c |    1 -
>  1 file changed, 1 deletion(-)
>
> --- lnx-56-rc1.orig/kernel/sched/fair.c
> +++ lnx-56-rc1/kernel/sched/fair.c
> @@ -3516,7 +3516,6 @@ update_cfs_rq_load_avg(u64 now, struct c
>   * attach_entity_load_avg - attach this entity to its cfs_rq load avg
>   * @cfs_rq: cfs_rq to attach to
>   * @se: sched_entity to attach
> - * @flags: migration hints
>   *
>   * Must call update_cfs_rq_load_avg() before this, since we rely on
>   * cfs_rq->avg.last_update_time being current.
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip: sched/urgent] sched/fair: Fix kernel-doc warning in attach_entity_load_avg()
  2020-02-10  3:29 [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg() Randy Dunlap
  2020-02-10  7:41 ` Vincent Guittot
@ 2020-02-11 12:47 ` tip-bot2 for Randy Dunlap
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Randy Dunlap @ 2020-02-11 12:47 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Randy Dunlap, Peter Zijlstra (Intel),
	Ingo Molnar, Vincent Guittot, x86, LKML

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID:     e9f5490c3574b435ce7fe7a71724aa3866babc7f
Gitweb:        https://git.kernel.org/tip/e9f5490c3574b435ce7fe7a71724aa3866babc7f
Author:        Randy Dunlap <rdunlap@infradead.org>
AuthorDate:    Sun, 09 Feb 2020 19:29:12 -08:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 11 Feb 2020 13:05:10 +01:00

sched/fair: Fix kernel-doc warning in attach_entity_load_avg()

Fix kernel-doc warning in kernel/sched/fair.c, caused by a recent
function parameter removal:

  ../kernel/sched/fair.c:3526: warning: Excess function parameter 'flags' description in 'attach_entity_load_avg'

Fixes: a4f9a0e51bbf ("sched/fair: Remove redundant call to cpufreq_update_util()")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lkml.kernel.org/r/cbe964e4-6879-fd08-41c9-ef1917414af4@infradead.org
---
 kernel/sched/fair.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 94c3b84..3c8a379 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3516,7 +3516,6 @@ update_cfs_rq_load_avg(u64 now, struct cfs_rq *cfs_rq)
  * attach_entity_load_avg - attach this entity to its cfs_rq load avg
  * @cfs_rq: cfs_rq to attach to
  * @se: sched_entity to attach
- * @flags: migration hints
  *
  * Must call update_cfs_rq_load_avg() before this, since we rely on
  * cfs_rq->avg.last_update_time being current.

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-11 12:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10  3:29 [PATCH RESEND] sched: fix kernel-doc warning in attach_entity_load_avg() Randy Dunlap
2020-02-10  7:41 ` Vincent Guittot
2020-02-11 12:47 ` [tip: sched/urgent] sched/fair: Fix " tip-bot2 for Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.