* [PATCH] target/i386: enable monitor and ucode revision with -cpu max
@ 2020-02-12 15:23 Paolo Bonzini
2020-02-12 19:20 ` Eduardo Habkost
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2020-02-12 15:23 UTC (permalink / raw)
To: qemu-devel; +Cc: ehabkost
These two features were incorrectly tied to host_cpuid_required rather than
cpu->max_features. As a result, -cpu max was not enabling either MONITOR
features or ucode revision.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 32efa46..92fafa2 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6414,7 +6414,9 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
error_setg(&local_err, "CPU model '%s' requires KVM", name);
goto out;
}
+ }
+ if (cpu->max_features && accel_uses_host_cpuid()) {
if (enable_cpu_pm) {
host_cpuid(5, 0, &cpu->mwait.eax, &cpu->mwait.ebx,
&cpu->mwait.ecx, &cpu->mwait.edx);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/i386: enable monitor and ucode revision with -cpu max
2020-02-12 15:23 [PATCH] target/i386: enable monitor and ucode revision with -cpu max Paolo Bonzini
@ 2020-02-12 19:20 ` Eduardo Habkost
0 siblings, 0 replies; 2+ messages in thread
From: Eduardo Habkost @ 2020-02-12 19:20 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Wed, Feb 12, 2020 at 04:23:29PM +0100, Paolo Bonzini wrote:
> These two features were incorrectly tied to host_cpuid_required rather than
> cpu->max_features. As a result, -cpu max was not enabling either MONITOR
> features or ucode revision.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-12 19:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 15:23 [PATCH] target/i386: enable monitor and ucode revision with -cpu max Paolo Bonzini
2020-02-12 19:20 ` Eduardo Habkost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.