From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] syscalls/kill11, abort01: Also raise hard limit when possible
Date: Thu, 13 Feb 2020 18:35:20 +0800 [thread overview]
Message-ID: <1581590121-4626-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> (raw)
Currently, running this two cases will report EINVAL error if I run "ulimit -c
1023" command firstly. From setrlimit(2)manpage, it got EINVAL error because
rlim->rlim_cur was greater than rlim->rlim_max. So raise the limit when possible.
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
testcases/kernel/syscalls/abort/abort01.c | 9 +++++++++
testcases/kernel/syscalls/kill/kill11.c | 8 ++++++++
2 files changed, 17 insertions(+)
diff --git a/testcases/kernel/syscalls/abort/abort01.c b/testcases/kernel/syscalls/abort/abort01.c
index 386a22f26..6fde3721c 100644
--- a/testcases/kernel/syscalls/abort/abort01.c
+++ b/testcases/kernel/syscalls/abort/abort01.c
@@ -70,6 +70,15 @@ static void setup(void)
/* make sure we get core dumps */
SAFE_GETRLIMIT(RLIMIT_CORE, &rlim);
+
+ if (rlim.rlim_max < MIN_RLIMIT_CORE) {
+ if (geteuid() != 0) {
+ tst_brk(TCONF, "hard limit(%lu)less than MIN_RLIMT_CORE(%i)",
+ rlim.rlim_max, MIN_RLIMIT_CORE);
+ }
+ tst_res(TINFO, "Raising rlim_max to %i", MIN_RLIMIT_CORE);
+ rlim.rlim_max = MIN_RLIMIT_CORE;
+ }
if (rlim.rlim_cur < MIN_RLIMIT_CORE) {
rlim.rlim_cur = MIN_RLIMIT_CORE;
SAFE_SETRLIMIT(RLIMIT_CORE, &rlim);
diff --git a/testcases/kernel/syscalls/kill/kill11.c b/testcases/kernel/syscalls/kill/kill11.c
index 83fba5beb..4025fcc87 100644
--- a/testcases/kernel/syscalls/kill/kill11.c
+++ b/testcases/kernel/syscalls/kill/kill11.c
@@ -201,6 +201,14 @@ void setup(void)
SAFE_GETRLIMIT(NULL, RLIMIT_CORE, &rlim);
+ if (rlim.rlim_max < MIN_RLIMIT_CORE) {
+ if (geteuid() != 0) {
+ tst_brkm(TCONF, NULL, "hard limit(%lu)less than MIN_RLIMT_CORE(%i)",
+ rlim.rlim_max, MIN_RLIMIT_CORE);
+ }
+ tst_resm(TINFO, "Raising rlim_max to %i", MIN_RLIMIT_CORE);
+ rlim.rlim_max = MIN_RLIMIT_CORE;
+ }
if (rlim.rlim_cur < MIN_RLIMIT_CORE) {
tst_resm(TINFO, "Adjusting RLIMIT_CORE to %i", MIN_RLIMIT_CORE);
rlim.rlim_cur = MIN_RLIMIT_CORE;
--
2.18.0
next reply other threads:[~2020-02-13 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 10:35 Yang Xu [this message]
2020-02-13 10:35 ` [LTP] [PATCH v2 2/2] syscalls/kill11, abort01: lower MIN_RLIMIT_CORE size Yang Xu
2020-02-13 12:40 ` Jan Stancek
2020-02-14 5:48 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581590121-4626-1-git-send-email-xuyang2018.jy@cn.fujitsu.com \
--to=xuyang2018.jy@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.