From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF45C35254 for ; Mon, 17 Feb 2020 09:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 969232064C for ; Mon, 17 Feb 2020 09:29:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RDCvw7tH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728885AbgBQJ3g (ORCPT ); Mon, 17 Feb 2020 04:29:36 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:32672 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728773AbgBQJ3g (ORCPT ); Mon, 17 Feb 2020 04:29:36 -0500 X-UUID: 62babae891504fdc96b7d46612dea2b6-20200217 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+AZRRBU+eXyDNfzUrhQQGTkVM4JM0kpcUBh6dZge9tA=; b=RDCvw7tHLfWuqmOGS911L2SXvA9CN9I/QCntQmRrc4VGTjml9DqeQNDiCsMEJAgxO6Vvx9S5J2s8E+8K9iyuOX1LGmyMMP2AiYWwwYl6TeCK8S8zaroegAj8Kw9dj98NG2G/V3WVJ1EIxW9QOrigMu7cTCRUinOPcnsCF7Bter0=; X-UUID: 62babae891504fdc96b7d46612dea2b6-20200217 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1424113595; Mon, 17 Feb 2020 17:29:32 +0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Feb 2020 17:28:46 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 17 Feb 2020 17:27:27 +0800 Message-ID: <1581931765.12547.0.camel@mtksdaap41> Subject: Re: [PATCH v1 2/3] mailbox: mediatek: implement flush function From: CK Hu To: Bibby Hsieh CC: Jassi Brar , Matthias Brugger , Rob Herring , , , , , , Nicolas Boichat , Dennis-YC Hsieh , Houlong Wei Date: Mon, 17 Feb 2020 17:29:25 +0800 In-Reply-To: <20200217090532.16019-3-bibby.hsieh@mediatek.com> References: <20200217090532.16019-1-bibby.hsieh@mediatek.com> <20200217090532.16019-3-bibby.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGksIEJpYmJ5Og0KDQpPbiBNb24sIDIwMjAtMDItMTcgYXQgMTc6MDUgKzA4MDAsIEJpYmJ5IEhz aWVoIHdyb3RlOg0KPiBGb3IgY2xpZW50IGRyaXZlciB3aGljaCBuZWVkIHRvIHJlb3JnYW5pemUg dGhlIGNvbW1hbmQgYnVmZmVyLCBpdCBjb3VsZA0KPiB1c2UgdGhpcyBmdW5jdGlvbiB0byBmbHVz aCB0aGUgc2VuZCBjb21tYW5kIGJ1ZmZlci4NCj4gSWYgdGhlIGNoYW5uZWwgZG9lc24ndCBiZSBz dGFydGVkICh1c3VhbGx5IGluIHdhaXRpbmcgZm9yIGV2ZW50KSwgdGhpcw0KPiBmdW5jdGlvbiB3 aWxsIGFib3J0IGl0IGRpcmVjdGx5Lg0KPiANCg0KUmV2aWV3ZWQtYnk6IENLIEh1IDxjay5odUBt ZWRpYXRlay5jb20+DQoNCj4gU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVo QG1lZGlhdGVrLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL21haWxib3gvbXRrLWNtZHEtbWFpbGJv eC5jIHwgNTIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ICAxIGZpbGUgY2hhbmdl ZCwgNTIgaW5zZXJ0aW9ucygrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWFpbGJveC9t dGstY21kcS1tYWlsYm94LmMgYi9kcml2ZXJzL21haWxib3gvbXRrLWNtZHEtbWFpbGJveC5jDQo+ IGluZGV4IDlhNmNlOWY1YTdkYi4uMGRhNWUyZGMyYzBlIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJz L21haWxib3gvbXRrLWNtZHEtbWFpbGJveC5jDQo+ICsrKyBiL2RyaXZlcnMvbWFpbGJveC9tdGst Y21kcS1tYWlsYm94LmMNCj4gQEAgLTQzMiwxMCArNDMyLDYyIEBAIHN0YXRpYyB2b2lkIGNtZHFf bWJveF9zaHV0ZG93bihzdHJ1Y3QgbWJveF9jaGFuICpjaGFuKQ0KPiAgew0KPiAgfQ0KPiAgDQo+ ICtzdGF0aWMgaW50IGNtZHFfbWJveF9mbHVzaChzdHJ1Y3QgbWJveF9jaGFuICpjaGFuLCB1bnNp Z25lZCBsb25nIHRpbWVvdXQpDQo+ICt7DQo+ICsJc3RydWN0IGNtZHFfdGhyZWFkICp0aHJlYWQg PSAoc3RydWN0IGNtZHFfdGhyZWFkICopY2hhbi0+Y29uX3ByaXY7DQo+ICsJc3RydWN0IGNtZHFf dGFza19jYiAqY2I7DQo+ICsJc3RydWN0IGNtZHFfY2JfZGF0YSBkYXRhOw0KPiArCXN0cnVjdCBj bWRxICpjbWRxID0gZGV2X2dldF9kcnZkYXRhKGNoYW4tPm1ib3gtPmRldik7DQo+ICsJc3RydWN0 IGNtZHFfdGFzayAqdGFzaywgKnRtcDsNCj4gKwl1bnNpZ25lZCBsb25nIGZsYWdzOw0KPiArCXUz MiBlbmFibGU7DQo+ICsNCj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmdGhyZWFkLT5jaGFuLT5sb2Nr LCBmbGFncyk7DQo+ICsJaWYgKGxpc3RfZW1wdHkoJnRocmVhZC0+dGFza19idXN5X2xpc3QpKQ0K PiArCQlnb3RvIG91dDsNCj4gKw0KPiArCVdBUk5fT04oY21kcV90aHJlYWRfc3VzcGVuZChjbWRx LCB0aHJlYWQpIDwgMCk7DQo+ICsJaWYgKCFjbWRxX3RocmVhZF9pc19pbl93ZmUodGhyZWFkKSkN Cj4gKwkJZ290byB3YWl0Ow0KPiArDQo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHRhc2ss IHRtcCwgJnRocmVhZC0+dGFza19idXN5X2xpc3QsDQo+ICsJCQkJIGxpc3RfZW50cnkpIHsNCj4g KwkJY2IgPSAmdGFzay0+cGt0LT5hc3luY19jYjsNCj4gKwkJaWYgKGNiLT5jYikgew0KPiArCQkJ ZGF0YS5zdGEgPSBDTURRX0NCX0VSUk9SOw0KPiArCQkJZGF0YS5kYXRhID0gY2ItPmRhdGE7DQo+ ICsJCQljYi0+Y2IoZGF0YSk7DQo+ICsJCX0NCj4gKwkJbGlzdF9kZWwoJnRhc2stPmxpc3RfZW50 cnkpOw0KPiArCQlrZnJlZSh0YXNrKTsNCj4gKwl9DQo+ICsNCj4gKwljbWRxX3RocmVhZF9yZXN1 bWUodGhyZWFkKTsNCj4gKwljbWRxX3RocmVhZF9kaXNhYmxlKGNtZHEsIHRocmVhZCk7DQo+ICsJ Y2xrX2Rpc2FibGUoY21kcS0+Y2xvY2spOw0KPiArDQo+ICtvdXQ6DQo+ICsJc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmdGhyZWFkLT5jaGFuLT5sb2NrLCBmbGFncyk7DQo+ICsJcmV0dXJuIDA7DQo+ ICsNCj4gK3dhaXQ6DQo+ICsJY21kcV90aHJlYWRfcmVzdW1lKHRocmVhZCk7DQo+ICsJc3Bpbl91 bmxvY2tfaXJxcmVzdG9yZSgmdGhyZWFkLT5jaGFuLT5sb2NrLCBmbGFncyk7DQo+ICsJaWYgKHJl YWRsX3BvbGxfdGltZW91dF9hdG9taWModGhyZWFkLT5iYXNlICsgQ01EUV9USFJfRU5BQkxFX1RB U0ssDQo+ICsJCQkJICAgICAgZW5hYmxlLCBlbmFibGUgPT0gMCwgMSwgdGltZW91dCkpIHsNCj4g KwkJZGV2X2VycihjbWRxLT5tYm94LmRldiwgIkZhaWwgdG8gd2FpdCBHQ0UgdGhyZWFkIDB4JXgg ZG9uZVxuIiwNCj4gKwkJCSh1MzIpKHRocmVhZC0+YmFzZSAtIGNtZHEtPmJhc2UpKTsNCj4gKw0K PiArCQlyZXR1cm4gLUVGQVVMVDsNCj4gKwl9DQo+ICsJcmV0dXJuIDA7DQo+ICt9DQo+ICsNCj4g IHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWJveF9jaGFuX29wcyBjbWRxX21ib3hfY2hhbl9vcHMgPSB7 DQo+ICAJLnNlbmRfZGF0YSA9IGNtZHFfbWJveF9zZW5kX2RhdGEsDQo+ICAJLnN0YXJ0dXAgPSBj bWRxX21ib3hfc3RhcnR1cCwNCj4gIAkuc2h1dGRvd24gPSBjbWRxX21ib3hfc2h1dGRvd24sDQo+ ICsJLmZsdXNoID0gY21kcV9tYm94X2ZsdXNoLA0KPiAgfTsNCj4gIA0KPiAgc3RhdGljIHN0cnVj dCBtYm94X2NoYW4gKmNtZHFfeGxhdGUoc3RydWN0IG1ib3hfY29udHJvbGxlciAqbWJveCwNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B5AC7619F for ; Mon, 17 Feb 2020 09:33:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 254A920726 for ; Mon, 17 Feb 2020 09:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o6Q267fj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RDCvw7tH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 254A920726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8esusLANwZvHFxhn4QBkZ3Fwx0hcID+EuYs/LAkNR4o=; b=o6Q267fjBur8/M AGwSTlcZuZ4vNYE59V2sAoW1uoqp31OZFW0gngJxxLX8SO8UnxQl7nLgElT9Lo2OwwgTNT1Rw+n+k QomdkSmrdiGRshMB/ZDoh9ldFMAGQ6zdqjB/JJPGZOTRORIGXuERIy290BaEnezf0mnlcPz4rw46u dASZc9suYvVeAeE6gwaJMlwzAglxdofA5xyWj03z+E8YxRZp3nrX/wPz6qmVIbRtkK5rSYs9U9qqM PnEVuKwWkEJ/q+8x/rHV4L2yPwXfH5UU5W/fVeRPq3+QCeDladQ1bnRsUFrXfaTDylcVnY2uxf/gs 0v0MrnwFo7npI3wJhVJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3clo-0003Cc-Ct; Mon, 17 Feb 2020 09:32:52 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3cif-0006wR-Tq; Mon, 17 Feb 2020 09:29:39 +0000 X-UUID: 468e4642296e46f28bfccc384afe54ad-20200217 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+AZRRBU+eXyDNfzUrhQQGTkVM4JM0kpcUBh6dZge9tA=; b=RDCvw7tHLfWuqmOGS911L2SXvA9CN9I/QCntQmRrc4VGTjml9DqeQNDiCsMEJAgxO6Vvx9S5J2s8E+8K9iyuOX1LGmyMMP2AiYWwwYl6TeCK8S8zaroegAj8Kw9dj98NG2G/V3WVJ1EIxW9QOrigMu7cTCRUinOPcnsCF7Bter0=; X-UUID: 468e4642296e46f28bfccc384afe54ad-20200217 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1712034361; Mon, 17 Feb 2020 01:29:34 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Feb 2020 01:29:52 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Feb 2020 17:28:46 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 17 Feb 2020 17:27:27 +0800 Message-ID: <1581931765.12547.0.camel@mtksdaap41> Subject: Re: [PATCH v1 2/3] mailbox: mediatek: implement flush function From: CK Hu To: Bibby Hsieh Date: Mon, 17 Feb 2020 17:29:25 +0800 In-Reply-To: <20200217090532.16019-3-bibby.hsieh@mediatek.com> References: <20200217090532.16019-1-bibby.hsieh@mediatek.com> <20200217090532.16019-3-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_012937_986872_EFFEB178 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Dennis-YC Hsieh , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Mon, 2020-02-17 at 17:05 +0800, Bibby Hsieh wrote: > For client driver which need to reorganize the command buffer, it could > use this function to flush the send command buffer. > If the channel doesn't be started (usually in waiting for event), this > function will abort it directly. > Reviewed-by: CK Hu > Signed-off-by: Bibby Hsieh > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 52 ++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 9a6ce9f5a7db..0da5e2dc2c0e 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -432,10 +432,62 @@ static void cmdq_mbox_shutdown(struct mbox_chan *chan) > { > } > > +static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout) > +{ > + struct cmdq_thread *thread = (struct cmdq_thread *)chan->con_priv; > + struct cmdq_task_cb *cb; > + struct cmdq_cb_data data; > + struct cmdq *cmdq = dev_get_drvdata(chan->mbox->dev); > + struct cmdq_task *task, *tmp; > + unsigned long flags; > + u32 enable; > + > + spin_lock_irqsave(&thread->chan->lock, flags); > + if (list_empty(&thread->task_busy_list)) > + goto out; > + > + WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0); > + if (!cmdq_thread_is_in_wfe(thread)) > + goto wait; > + > + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, > + list_entry) { > + cb = &task->pkt->async_cb; > + if (cb->cb) { > + data.sta = CMDQ_CB_ERROR; > + data.data = cb->data; > + cb->cb(data); > + } > + list_del(&task->list_entry); > + kfree(task); > + } > + > + cmdq_thread_resume(thread); > + cmdq_thread_disable(cmdq, thread); > + clk_disable(cmdq->clock); > + > +out: > + spin_unlock_irqrestore(&thread->chan->lock, flags); > + return 0; > + > +wait: > + cmdq_thread_resume(thread); > + spin_unlock_irqrestore(&thread->chan->lock, flags); > + if (readl_poll_timeout_atomic(thread->base + CMDQ_THR_ENABLE_TASK, > + enable, enable == 0, 1, timeout)) { > + dev_err(cmdq->mbox.dev, "Fail to wait GCE thread 0x%x done\n", > + (u32)(thread->base - cmdq->base)); > + > + return -EFAULT; > + } > + return 0; > +} > + > static const struct mbox_chan_ops cmdq_mbox_chan_ops = { > .send_data = cmdq_mbox_send_data, > .startup = cmdq_mbox_startup, > .shutdown = cmdq_mbox_shutdown, > + .flush = cmdq_mbox_flush, > }; > > static struct mbox_chan *cmdq_xlate(struct mbox_controller *mbox, _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C883C35254 for ; Mon, 17 Feb 2020 09:33:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05AE420679 for ; Mon, 17 Feb 2020 09:33:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IqRSlUls"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="RDCvw7tH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05AE420679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CVoaSQnVTyCfFxoiVl7n3Oq27MSO1s/BtNMpA+1WYuU=; b=IqRSlUlspycvEb nHFmSTpueDxsgcL1inKl/qJLv4TkeaXF8EUpvLaitTf01A9pPeqWUEf+WNUjcQtSsj8uEiYi/GR4i qx1yinoO/olh+CTXtCTrjyDQkFB0pV/pe1NpgKqLFM0FXIZHZMZV8mCAMMuVCyHfXMXteqXLi4OfB t26D6XpGHlB3XmsmsMCAUoclv9D6MP0u6xW217nq7Z/mx/deKOX1LSMAAP8pDILwqS+Ay20jDB55O MkHF9bS0ElS/GfOnjXC4Ew55zDFDb8xjCy1ODfAabZyS5XcIh0DH6lFxC2Z8V4t4sAqRMOjrq0NZJ 1oOmPaXRFbNxU9gTDZvg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3clu-0003H3-0V; Mon, 17 Feb 2020 09:32:58 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3cif-0006wR-Tq; Mon, 17 Feb 2020 09:29:39 +0000 X-UUID: 468e4642296e46f28bfccc384afe54ad-20200217 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=+AZRRBU+eXyDNfzUrhQQGTkVM4JM0kpcUBh6dZge9tA=; b=RDCvw7tHLfWuqmOGS911L2SXvA9CN9I/QCntQmRrc4VGTjml9DqeQNDiCsMEJAgxO6Vvx9S5J2s8E+8K9iyuOX1LGmyMMP2AiYWwwYl6TeCK8S8zaroegAj8Kw9dj98NG2G/V3WVJ1EIxW9QOrigMu7cTCRUinOPcnsCF7Bter0=; X-UUID: 468e4642296e46f28bfccc384afe54ad-20200217 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1712034361; Mon, 17 Feb 2020 01:29:34 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Feb 2020 01:29:52 -0800 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 17 Feb 2020 17:28:46 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 17 Feb 2020 17:27:27 +0800 Message-ID: <1581931765.12547.0.camel@mtksdaap41> Subject: Re: [PATCH v1 2/3] mailbox: mediatek: implement flush function From: CK Hu To: Bibby Hsieh Date: Mon, 17 Feb 2020 17:29:25 +0800 In-Reply-To: <20200217090532.16019-3-bibby.hsieh@mediatek.com> References: <20200217090532.16019-1-bibby.hsieh@mediatek.com> <20200217090532.16019-3-bibby.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200217_012937_986872_EFFEB178 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Dennis-YC Hsieh , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Bibby: On Mon, 2020-02-17 at 17:05 +0800, Bibby Hsieh wrote: > For client driver which need to reorganize the command buffer, it could > use this function to flush the send command buffer. > If the channel doesn't be started (usually in waiting for event), this > function will abort it directly. > Reviewed-by: CK Hu > Signed-off-by: Bibby Hsieh > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 52 ++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 9a6ce9f5a7db..0da5e2dc2c0e 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -432,10 +432,62 @@ static void cmdq_mbox_shutdown(struct mbox_chan *chan) > { > } > > +static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout) > +{ > + struct cmdq_thread *thread = (struct cmdq_thread *)chan->con_priv; > + struct cmdq_task_cb *cb; > + struct cmdq_cb_data data; > + struct cmdq *cmdq = dev_get_drvdata(chan->mbox->dev); > + struct cmdq_task *task, *tmp; > + unsigned long flags; > + u32 enable; > + > + spin_lock_irqsave(&thread->chan->lock, flags); > + if (list_empty(&thread->task_busy_list)) > + goto out; > + > + WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0); > + if (!cmdq_thread_is_in_wfe(thread)) > + goto wait; > + > + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, > + list_entry) { > + cb = &task->pkt->async_cb; > + if (cb->cb) { > + data.sta = CMDQ_CB_ERROR; > + data.data = cb->data; > + cb->cb(data); > + } > + list_del(&task->list_entry); > + kfree(task); > + } > + > + cmdq_thread_resume(thread); > + cmdq_thread_disable(cmdq, thread); > + clk_disable(cmdq->clock); > + > +out: > + spin_unlock_irqrestore(&thread->chan->lock, flags); > + return 0; > + > +wait: > + cmdq_thread_resume(thread); > + spin_unlock_irqrestore(&thread->chan->lock, flags); > + if (readl_poll_timeout_atomic(thread->base + CMDQ_THR_ENABLE_TASK, > + enable, enable == 0, 1, timeout)) { > + dev_err(cmdq->mbox.dev, "Fail to wait GCE thread 0x%x done\n", > + (u32)(thread->base - cmdq->base)); > + > + return -EFAULT; > + } > + return 0; > +} > + > static const struct mbox_chan_ops cmdq_mbox_chan_ops = { > .send_data = cmdq_mbox_send_data, > .startup = cmdq_mbox_startup, > .shutdown = cmdq_mbox_shutdown, > + .flush = cmdq_mbox_flush, > }; > > static struct mbox_chan *cmdq_xlate(struct mbox_controller *mbox, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel