Re: [PATCH 0/3] Migration mechanism with FD

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20200219163344.27651-1-ovoshcha@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/3] Migration mechanism with FD
Message-id: 20200219163344.27651-1-ovoshcha@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5429c0a Acceptance test: FD migration
f415c4c Updates send_fd_scm function
810c13a Adding functions _send_fds and _recv_fds

=== OUTPUT BEGIN ===
1/3 Checking commit 810c13a52356 (Adding functions _send_fds and _recv_fds)
WARNING: line over 80 characters
#33: FILE: python/qemu/machine.py:161:
+        Function from https://docs.python.org/3/library/socket.html#socket.socket.recvmsg

ERROR: line over 90 characters
#36: FILE: python/qemu/machine.py:164:
+        msg, ancdata, flags, addr = sock.recvmsg(msglen, socket.CMSG_LEN(maxfds * fds.itemsize))

WARNING: line over 80 characters
#38: FILE: python/qemu/machine.py:166:
+            if cmsg_level == socket.SOL_SOCKET and cmsg_type == socket.SCM_RIGHTS:

ERROR: line over 90 characters
#39: FILE: python/qemu/machine.py:167:
+                fds.frombytes(cmsg_data[:len(cmsg_data) - (len(cmsg_data) % fds.itemsize)])

WARNING: line over 80 characters
#44: FILE: python/qemu/machine.py:172:
+        Function from https://docs.python.org/3/library/socket.html#socket.socket.sendmsg

ERROR: line over 90 characters
#46: FILE: python/qemu/machine.py:174:
+        return sock.sendmsg([msg], [(socket.SOL_SOCKET, socket.SCM_RIGHTS, array.array("i", fds))])

total: 3 errors, 3 warnings, 30 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/3 Checking commit f415c4c2bd6a (Updates send_fd_scm function)
WARNING: line over 80 characters
#32: FILE: python/qemu/machine.py:182:
+        Exactly one of fd and file_path must be given to the case of socket_scm_helper

ERROR: line over 90 characters
#45: FILE: python/qemu/machine.py:191:
+                raise QEMUMachineError("No path to socket_scm_helper set or data not provided")

WARNING: line over 80 characters
#68: FILE: python/qemu/machine.py:214:
+            proc = subprocess.Popen(fd_param, stdin=devnull, stdout=subprocess.PIPE,

ERROR: line over 90 characters
#91: FILE: python/qemu/machine.py:223:
+            sock_fd = socket.fromfd(self._qmp.get_sock_fd(), socket.AF_UNIX, socket.SOCK_STREAM)

total: 2 errors, 2 warnings, 78 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 5429c0afdc21 (Acceptance test: FD migration)
ERROR: line over 90 characters
#34: FILE: tests/acceptance/migration.py:84:
+        data_to_send = b"{\"execute\": \"getfd\",  \"arguments\": {\"fdname\": \"fd-migration\"}}"

total: 1 errors, 0 warnings, 30 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200219163344.27651-1-ovoshcha@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com