All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <zanussi@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>
Cc: artem.bityutskiy@linux.intel.com, linux-kernel@vger.kernel.org,
	linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] tracing: Skip software disabled event at __synth_event_trace_end()
Date: Thu, 20 Feb 2020 13:51:48 -0600	[thread overview]
Message-ID: <1582228308.12738.1.camel@kernel.org> (raw)
In-Reply-To: <20200220143412.65432e7c@gandalf.local.home>

Hi Steve,

On Thu, 2020-02-20 at 14:34 -0500, Steven Rostedt wrote:
> On Mon, 17 Feb 2020 18:33:40 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > >  static inline void
> > >  __synth_event_trace_end(struct synth_event_trace_state
> > > *trace_state)
> > >  {
> > > +	if (trace_state->disabled)
> > > +		return;
> > > +  
> > 
> > Aah, I assumed that trace_state should be initialized with 0, but
> > in really, it could be just allocated on the stack.
> > We has to set trace_state->disabled = false in
> > __synth_event_trace_start().
> 
> Is this patch good enough to take, or is there another one coming?
> 

I think this patch is good to take.  The fix for setting trace_state-
>disabled to false would be covered by this later patch:

  [PATCH 2/2] tracing: Clear trace_state when starting trace

https://lore.kernel.org/lkml/158193315899.8868.1781259176894639952.stgit@devnote2/

Tom

> -- Steve

  reply	other threads:[~2020-02-20 19:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12  5:54 [PATCH] tracing: Skip software disabled event at __synth_event_trace_end() Masami Hiramatsu
2020-02-12 16:03 ` Tom Zanussi
2020-02-17  9:33 ` Masami Hiramatsu
2020-02-20 19:34   ` Steven Rostedt
2020-02-20 19:51     ` Tom Zanussi [this message]
2020-02-20 19:54       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1582228308.12738.1.camel@kernel.org \
    --to=zanussi@kernel.org \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.