From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B37E4C35641 for ; Fri, 21 Feb 2020 23:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B45F206DB for ; Fri, 21 Feb 2020 23:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582329474; bh=n0vjHVM2DuhbpPYoxUKATWLMuk00e4mnD7YQoWp4vUk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=PbKKjgx6lBlMbITa/O5PaM86LNpBQfiMB/lsoft7r6A46pn+X/9WV/t6rAam6gDwO cZuP6NrPJYKkB5UtSjbfE7VRct5eKlhQvjLACrRT5+GLYFxY4xuwqrlw/nRFvIIJVc Ab5x/Z0hpUht8Fto9RsTrMAd0gzRRXd3cmZVxX8A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729804AbgBUX5x (ORCPT ); Fri, 21 Feb 2020 18:57:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:35302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbgBUX5x (ORCPT ); Fri, 21 Feb 2020 18:57:53 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92B862068F; Fri, 21 Feb 2020 23:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582329472; bh=n0vjHVM2DuhbpPYoxUKATWLMuk00e4mnD7YQoWp4vUk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OIc0H/6FEBoyV45z3mlrdQOZGlTjYb5cKOX8tyqwAiMmkIlY4O9/GD+thIk3aXxsG jIjtFlVnom2DIHf7DacvmaOFcDdyLjsT6f8EY9Pmpo3a9lwbkeFP/VA7/hGESogbek ZcPYRqs8Jucy3hrPeOGTK7yh2xCobn+qyOSRBAc4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1582266716-19821-1-git-send-email-Anson.Huang@nxp.com> References: <1582266716-19821-1-git-send-email-Anson.Huang@nxp.com> Subject: Re: [PATCH] clk: imx: pll14xx: Return error if pll type is invalid From: Stephen Boyd Cc: Linux-imx@nxp.com To: Anson Huang , festevam@gmail.com, kernel@pengutronix.de, leonard.crestez@nxp.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, peng.fan@nxp.com, ping.bai@nxp.com, s.hauer@pengutronix.de, shawnguo@kernel.org, yuehaibing@huawei.com Date: Fri, 21 Feb 2020 15:57:51 -0800 Message-ID: <158232947182.258574.584668677246692139@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anson Huang (2020-02-20 22:31:56) > When pll type is invalid, ONLY output error message is NOT enough, > should return error immediately. >=20 > Signed-off-by: Anson Huang > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03448C35669 for ; Fri, 21 Feb 2020 23:57:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C99CC206DB for ; Fri, 21 Feb 2020 23:57:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gVWgGY3O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OIc0H/6F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C99CC206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IebXw6dXoVqwYcqRYvBBz9fk91gVc26cZ8Cv7Cr1iIc=; b=gVWgGY3O+OPNg1 kFQSGctOVn1UNGpaFnHYNc9w16VbruMqT6mywJutfxxuG7vlvYhBghroyNWKQ0Tomo8JVtYIJlK0H HkEXpuakMODF1wkXyVOw3haco/u5xnWXOyZUdqVP6348UkjCCQvD6ghghzOx9RpAKl8XOyFdfAr2C IWXpIjZ+vwWr+1ZTL8JVNWyXia1rEZeMdErdCrNJKoREiDihCBFWZ+pIbgyo6Ot1ApxmR99dgAVT8 E7lAeoF5c5TE1b4eNfklm+zowgT2bNllx9iPdGBdvpIhtDiCrKUSVBPVUMuV8jnsejyjuG6+FYb2R R3O91O1xA+HUiwJ61uOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5IBA-00078C-7d; Fri, 21 Feb 2020 23:57:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5IB6-00077V-Vk for linux-arm-kernel@lists.infradead.org; Fri, 21 Feb 2020 23:57:54 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92B862068F; Fri, 21 Feb 2020 23:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582329472; bh=n0vjHVM2DuhbpPYoxUKATWLMuk00e4mnD7YQoWp4vUk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=OIc0H/6FEBoyV45z3mlrdQOZGlTjYb5cKOX8tyqwAiMmkIlY4O9/GD+thIk3aXxsG jIjtFlVnom2DIHf7DacvmaOFcDdyLjsT6f8EY9Pmpo3a9lwbkeFP/VA7/hGESogbek ZcPYRqs8Jucy3hrPeOGTK7yh2xCobn+qyOSRBAc4= MIME-Version: 1.0 In-Reply-To: <1582266716-19821-1-git-send-email-Anson.Huang@nxp.com> References: <1582266716-19821-1-git-send-email-Anson.Huang@nxp.com> Subject: Re: [PATCH] clk: imx: pll14xx: Return error if pll type is invalid From: Stephen Boyd To: Anson Huang , festevam@gmail.com, kernel@pengutronix.de, leonard.crestez@nxp.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, peng.fan@nxp.com, ping.bai@nxp.com, s.hauer@pengutronix.de, shawnguo@kernel.org, yuehaibing@huawei.com Date: Fri, 21 Feb 2020 15:57:51 -0800 Message-ID: <158232947182.258574.584668677246692139@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200221_155753_036061_67179CE6 X-CRM114-Status: UNSURE ( 5.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Anson Huang (2020-02-20 22:31:56) > When pll type is invalid, ONLY output error message is NOT enough, > should return error immediately. > > Signed-off-by: Anson Huang > --- Reviewed-by: Stephen Boyd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel