From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Fri, 28 Feb 2020 14:18:34 +0000 Subject: Re: [PATCH] drm/i915/selftests: Fix return in assert_mmap_offset() Message-Id: <158289951401.24106.17765805022733010158@skylake-alporthouse-com> List-Id: References: <20200228141413.qfjf4abr323drlo4@kili.mountain> In-Reply-To: <20200228141413.qfjf4abr323drlo4@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , Jani Nikula Cc: David Airlie , kernel-janitors@vger.kernel.org, Matthew Auld , intel-gfx@lists.freedesktop.org Quoting Dan Carpenter (2020-02-28 14:14:13) > The assert_mmap_offset() returns type bool so if we return an error > pointer that is "return true;" or success. If we have an error, then > we should return false. > > Fixes: 3d81d589d6e3 ("drm/i915: Test exhaustion of the mmap space") > Signed-off-by: Dan Carpenter > --- > Not tested. In theory it's correct, but when you're adding new error > paths it's always good to test. > > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index ef7c74cff28a..43912e9b683d 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -570,7 +570,7 @@ static bool assert_mmap_offset(struct drm_i915_private *i915, > > obj = i915_gem_object_create_internal(i915, size); > if (IS_ERR(obj)) > - return PTR_ERR(obj); > + return false; "This is not the error you are looking for" Fits the use, Reviewed-by: Chris Wilson -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C2CBC3F2CD for ; Fri, 28 Feb 2020 14:18:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FE1B246A8 for ; Fri, 28 Feb 2020 14:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FE1B246A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 987886F460; Fri, 28 Feb 2020 14:18:44 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBE286F460 for ; Fri, 28 Feb 2020 14:18:42 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 20386155-1500050 for multiple; Fri, 28 Feb 2020 14:18:36 +0000 MIME-Version: 1.0 To: Dan Carpenter , Jani Nikula From: Chris Wilson In-Reply-To: <20200228141413.qfjf4abr323drlo4@kili.mountain> References: <20200228141413.qfjf4abr323drlo4@kili.mountain> Message-ID: <158289951401.24106.17765805022733010158@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Fri, 28 Feb 2020 14:18:34 +0000 Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix return in assert_mmap_offset() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kernel-janitors@vger.kernel.org, Matthew Auld , intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Dan Carpenter (2020-02-28 14:14:13) > The assert_mmap_offset() returns type bool so if we return an error > pointer that is "return true;" or success. If we have an error, then > we should return false. > > Fixes: 3d81d589d6e3 ("drm/i915: Test exhaustion of the mmap space") > Signed-off-by: Dan Carpenter > --- > Not tested. In theory it's correct, but when you're adding new error > paths it's always good to test. > > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > index ef7c74cff28a..43912e9b683d 100644 > --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c > @@ -570,7 +570,7 @@ static bool assert_mmap_offset(struct drm_i915_private *i915, > > obj = i915_gem_object_create_internal(i915, size); > if (IS_ERR(obj)) > - return PTR_ERR(obj); > + return false; "This is not the error you are looking for" Fits the use, Reviewed-by: Chris Wilson -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx