From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C643C3F2D1 for ; Wed, 4 Mar 2020 17:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D46FD2465D for ; Wed, 4 Mar 2020 17:48:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="k6YAwfak" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729849AbgCDRsL (ORCPT ); Wed, 4 Mar 2020 12:48:11 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34339 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729662AbgCDRsL (ORCPT ); Wed, 4 Mar 2020 12:48:11 -0500 Received: by mail-pg1-f195.google.com with SMTP id t3so1339485pgn.1 for ; Wed, 04 Mar 2020 09:48:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=twGLnt+lmzXmDy1fmr6l/q0nR+L298UBQxbGpY/MAj8=; b=k6YAwfak0/W2GVfXJfFjcN+yUxxw9CfC/ZDF0pN8DxQ9RY/NFfw1tlOwloaFkEzku0 zYUPFBB8Jm4t9mUk1WcmmHonxbFKFRtqYc1UrWhZIGWBmjpGp8o60J5KAla6g4lFNxIG yt9AAuoCDNXz+t9V+oMMAt3ytn93GlzKJgKZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=twGLnt+lmzXmDy1fmr6l/q0nR+L298UBQxbGpY/MAj8=; b=clLeyndll0cfnUlkfBMl3uwjTizNFWDIdupdzOxq4ZT/e6M2qFP5sMXcv0GY+ZrLPg JdhqRmdD7TrMmy5jQOevrQa7Ge/g3CG8l7vn3DHaKhwYrWaKdWQF84W8Tk6lwHB6YGHg IV8yibtldbe/iJ9PzKRf4YMnb23iRWyZmmjiPxtEL1eHbSKZsrHs2knJQjT9IeA/JbZ5 QOyVsE7HG4hsJCysF/5X2mETMLv9nUHiKzatCdeS4/kHHK9BRvaynSDdQvFi6yIEjD6G +xtt35+k8AH8dLRobhDuMzXkKA1jW9mUORdQ/GfeWRNnhYyBcsjIWlfCwUnJ8mV33K6R qD+w== X-Gm-Message-State: ANhLgQ21c+2xjwT2aAUfoqYHgnYPxV3+2daYuZejhl/n4vCeo/sQI8pS geYg8ok9HvukmM/+ZU/f9PKEDw== X-Google-Smtp-Source: ADFU+vubQzHiwMT605UwbFGoQU9KrBzbPaI/Yk1SN96yMJN8ZKf97NgPO6eQPQtzCbnOP6XNMi0biw== X-Received: by 2002:a63:c546:: with SMTP id g6mr3442441pgd.243.1583344090047; Wed, 04 Mar 2020 09:48:10 -0800 (PST) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id y1sm25767982pgs.74.2020.03.04.09.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2020 09:48:09 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <1582638862-9344-1-git-send-email-skakit@codeaurora.org> <1582638862-9344-2-git-send-email-skakit@codeaurora.org> <158293088963.112031.11417422453396901116@swboyd.mtv.corp.google.com> Subject: Re: [PATCH V2 1/2] tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe From: Stephen Boyd Cc: gregkh@linuxfoundation.org, mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, akashast@codeaurora.org, rojay@codeaurora.org, msavaliy@qti.qualcomm.com To: skakit@codeaurora.org Date: Wed, 04 Mar 2020 09:48:08 -0800 Message-ID: <158334408852.7173.11568704753978099578@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting skakit@codeaurora.org (2020-03-04 05:34:20) > As we mentioned in the V1 patch, we are passing drop=3D"true" to handle_r= x=20 > function so it will read and discard whatever data present in RX FIFO,=20 > it won't send to upper layers. > static int handle_rx_uart(struct uart_port *uport, u32 bytes, bool drop) > { > .... > ioread32_rep(uport->membase + SE_GENI_RX_FIFOn, port->rx_fifo,=20 > words); > if (drop) > return 0; > .... > } > In general uart_startup() is called before set_termios() ,but as per the = > crash logs shared, it seems RX engine is active(which can only happen=20 > from set_termios) before startup() is called.So, if we allocate=20 > port->rx_fifo in probe we can overcome this crash. Ok. Thanks for clarifying. Can you please mention in the commit text that the fifo contents are read into rx_fifo but then dropped?