From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752E2C3F2D2 for ; Fri, 6 Mar 2020 02:34:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DFF9206D7 for ; Fri, 6 Mar 2020 02:34:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="e6ayxYvJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726378AbgCFCeU (ORCPT ); Thu, 5 Mar 2020 21:34:20 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:7777 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726191AbgCFCeU (ORCPT ); Thu, 5 Mar 2020 21:34:20 -0500 X-UUID: 0bcd69818ec44aa19b87aa0671e71ffa-20200306 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lw7Z2hh6lxCttqw2IBWx1RQ1VaA6UHtHaJjaKiScxsU=; b=e6ayxYvJPghsOeTmMKrxd+rDVv0LvxracPf2u1WBaq49Z7bf7awGJRY7Z9RXTt8/QyLyOp6nBUPB/iuIuHDkxt80A9kyPZ9ZMmjB8bJs6tJlqhBxcfDfOxmyxMltr6TCrFy6XOwb04o6zTxdOMyGNUjxdVoXWcum5c0B1+qgdZg=; X-UUID: 0bcd69818ec44aa19b87aa0671e71ffa-20200306 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1834358050; Fri, 06 Mar 2020 10:34:16 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Mar 2020 10:33:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Mar 2020 10:34:16 +0800 Message-ID: <1583462055.4947.6.camel@mtksdaap41> Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 From: Nick Fan To: Nicolas Boichat CC: Rob Herring , Sj Huang , "David Airlie" , Daniel Vetter , Mark Rutland , Matthias Brugger , "Tomeu Vizoso" , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , Devicetree List , lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Ulf Hansson Date: Fri, 6 Mar 2020 10:34:15 +0800 In-Reply-To: References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org U29ycnkgZm9yIG15IGxhdGUgcmVwbHkuDQpJIGhhdmUgY2hlY2tlZCBpbnRlcm5hbGx5Lg0KVGhl IE1UODE4M19QT1dFUl9ET01BSU5fTUZHXzJEIGlzIGp1c3QgYSBsZWdhY3kgbmFtZSwgbm90IHJl YWxseSAyRA0KZG9tYWluLg0KDQpJZiB0aGUgbmFtaW5nIHRvbyBjb25mdXNpbmcsIHdlIGNhbiBj aGFuZ2UgdGhpcyBuYW1lIHRvDQpNVDgxODNfUE9XRVJfRE9NQUlOX01GR19DT1JFMiBmb3IgY29u c2lzdGVuY3kuDQoNClRoYW5rcw0KDQpOaWNrIEZhbg0KDQpPbiBXZWQsIDIwMjAtMDItMjYgYXQg MDg6NTUgKzA4MDAsIE5pY29sYXMgQm9pY2hhdCB3cm90ZToNCg0KPiArTmljayBGYW4gK1NqIEh1 YW5nIEAgTVRLDQo+IA0KPiBPbiBXZWQsIEZlYiAyNiwgMjAyMCBhdCAxOjE2IEFNIFJvYiBIZXJy aW5nIDxyb2JoQGtlcm5lbC5vcmc+IHdyb3RlOg0KPiA+DQo+ID4gT24gRnJpLCBGZWIgMDcsIDIw MjAgYXQgMDE6MjY6MjFQTSArMDgwMCwgTmljb2xhcyBCb2ljaGF0IHdyb3RlOg0KPiA+ID4gRGVm aW5lIGEgY29tcGF0aWJsZSBzdHJpbmcgZm9yIHRoZSBNYWxpIEJpZnJvc3QgR1BVIGZvdW5kIGlu DQo+ID4gPiBNZWRpYXRlaydzIE1UODE4MyBTb0NzLg0KPiA+ID4NCj4gPiA+IFNpZ25lZC1vZmYt Ynk6IE5pY29sYXMgQm9pY2hhdCA8ZHJpbmtjYXRAY2hyb21pdW0ub3JnPg0KPiA+ID4gUmV2aWV3 ZWQtYnk6IEFseXNzYSBSb3Nlbnp3ZWlnIDxhbHlzc2Eucm9zZW56d2VpZ0Bjb2xsYWJvcmEuY29t Pg0KPiA+ID4gLS0tDQo+ID4gPg0KPiA+ID4gdjQ6DQo+ID4gPiAgLSBBZGQgcG93ZXItZG9tYWlu LW5hbWVzIGRlc2NyaXB0aW9uDQo+ID4gPiAgICAoa2VwdCBBbHlzc2EncyByZXZpZXdlZC1ieSBh cyB0aGUgY2hhbmdlIGlzIG1pbm9yKQ0KPiA+ID4gdjM6DQo+ID4gPiAgLSBObyBjaGFuZ2UNCj4g PiA+DQo+ID4gPiAgLi4uL2JpbmRpbmdzL2dwdS9hcm0sbWFsaS1iaWZyb3N0LnlhbWwgICAgICAg IHwgMjUgKysrKysrKysrKysrKysrKysrKw0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNl cnRpb25zKCspDQo+ID4gPg0KPiA+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9ncHUvYXJtLG1hbGktYmlmcm9zdC55YW1sIGIvRG9jdW1lbnRhdGlvbi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2dwdS9hcm0sbWFsaS1iaWZyb3N0LnlhbWwNCj4gPiA+IGluZGV4 IDRlYTZhODc4OTY5OTcwOS4uMGQ5M2IzOTgxNDQ1OTc3IDEwMDY0NA0KPiA+ID4gLS0tIGEvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2dwdS9hcm0sbWFsaS1iaWZyb3N0LnlhbWwN Cj4gPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncHUvYXJtLG1h bGktYmlmcm9zdC55YW1sDQo+ID4gPiBAQCAtMTcsNiArMTcsNyBAQCBwcm9wZXJ0aWVzOg0KPiA+ ID4gICAgICBpdGVtczoNCj4gPiA+ICAgICAgICAtIGVudW06DQo+ID4gPiAgICAgICAgICAgIC0g YW1sb2dpYyxtZXNvbi1nMTJhLW1hbGkNCj4gPiA+ICsgICAgICAgICAgLSBtZWRpYXRlayxtdDgx ODMtbWFsaQ0KPiA+ID4gICAgICAgICAgICAtIHJlYWx0ZWsscnRkMTYxOS1tYWxpDQo+ID4gPiAg ICAgICAgICAgIC0gcm9ja2NoaXAscHgzMC1tYWxpDQo+ID4gPiAgICAgICAgLSBjb25zdDogYXJt LG1hbGktYmlmcm9zdCAjIE1hbGkgQmlmcm9zdCBHUFUgbW9kZWwvcmV2aXNpb24gaXMgZnVsbHkg ZGlzY292ZXJhYmxlDQo+ID4gPiBAQCAtNjIsNiArNjMsMzAgQEAgYWxsT2Y6DQo+ID4gPiAgICAg ICAgICAgIG1pbkl0ZW1zOiAyDQo+ID4gPiAgICAgICAgcmVxdWlyZWQ6DQo+ID4gPiAgICAgICAg ICAtIHJlc2V0cw0KPiA+ID4gKyAgLSBpZjoNCj4gPiA+ICsgICAgICBwcm9wZXJ0aWVzOg0KPiA+ ID4gKyAgICAgICAgY29tcGF0aWJsZToNCj4gPiA+ICsgICAgICAgICAgY29udGFpbnM6DQo+ID4g PiArICAgICAgICAgICAgY29uc3Q6IG1lZGlhdGVrLG10ODE4My1tYWxpDQo+ID4gPiArICAgIHRo ZW46DQo+ID4gPiArICAgICAgcHJvcGVydGllczoNCj4gPiA+ICsgICAgICAgIHNyYW0tc3VwcGx5 OiB0cnVlDQo+ID4gPiArICAgICAgICBwb3dlci1kb21haW5zOg0KPiA+ID4gKyAgICAgICAgICBk ZXNjcmlwdGlvbjoNCj4gPiA+ICsgICAgICAgICAgICBMaXN0IG9mIHBoYW5kbGUgYW5kIFBNIGRv bWFpbiBzcGVjaWZpZXIgYXMgZG9jdW1lbnRlZCBpbg0KPiA+ID4gKyAgICAgICAgICAgIERvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wb3dlci9wb3dlcl9kb21haW4udHh0DQo+ID4g PiArICAgICAgICAgIG1pbkl0ZW1zOiAzDQo+ID4gPiArICAgICAgICAgIG1heEl0ZW1zOiAzDQo+ ID4gPiArICAgICAgICBwb3dlci1kb21haW4tbmFtZXM6DQo+ID4gPiArICAgICAgICAgIGl0ZW1z Og0KPiA+ID4gKyAgICAgICAgICAgIC0gY29uc3Q6IGNvcmUwDQo+ID4gPiArICAgICAgICAgICAg LSBjb25zdDogY29yZTENCj4gPiA+ICsgICAgICAgICAgICAtIGNvbnN0OiAyZA0KPiA+DQo+ID4g QUZBSUssIHRoZXJlJ3Mgbm8gJzJkJyBibG9jayBpbiBiaWZyb3N0IEdQVXMuIEEgcG93ZXIgZG9t YWluIGZvciBlYWNoDQo+ID4gY29yZSBncm91cCBpcyBjb3JyZWN0IHRob3VnaC4NCj4gDQo+IEdv b2QgcXVlc3Rpb24uLi4gSG9wZWZ1bGx5IE5pY2svU0pATVRLIGNhbiBjb21tZW50LCB0aGUgbm9u LXVwc3RyZWFtIERUUyBoYXM6DQo+IGdwdTogbWFsaUAxMzA0MDAwMCB7DQo+IGNvbXBhdGlibGUg PSAibWVkaWF0ZWssbXQ4MTgzLW1hbGkiLCAiYXJtLG1hbGktYmlmcm9zdCI7DQo+IHBvd2VyLWRv bWFpbnMgPSA8JnNjcHN5cyBNVDgxODNfUE9XRVJfRE9NQUlOX01GR19DT1JFMD47DQo+IC4uLg0K PiB9DQo+IA0KPiBncHVfY29yZTE6IG1hbGlfZ3B1X2NvcmUxIHsNCj4gY29tcGF0aWJsZSA9ICJt ZWRpYXRlayxncHVfY29yZTEiOw0KPiBwb3dlci1kb21haW5zID0gPCZzY3BzeXMgTVQ4MTgzX1BP V0VSX0RPTUFJTl9NRkdfQ09SRTE+Ow0KPiB9Ow0KPiANCj4gZ3B1X2NvcmUyOiBtYWxpX2dwdV9j b3JlMiB7DQo+IGNvbXBhdGlibGUgPSAibWVkaWF0ZWssZ3B1X2NvcmUyIjsNCj4gcG93ZXItZG9t YWlucyA9IDwmc2Nwc3lzIE1UODE4M19QT1dFUl9ET01BSU5fTUZHXzJEPjsNCj4gfTsNCj4gDQo+ IFNvIEkgcGlja2VkIGNvcmUwL2NvcmUxLzJkIGFzIG5hbWVzLCBidXQgbG9va2luZyBhdCB0aGlz LCBpdCdzIGxpa2VseQ0KPiBjb3JlMiBpcyBtb3JlIGFwcHJvcHJpYXRlIChhbmQgTVQ4MTgzX1BP V0VSX0RPTUFJTl9NRkdfMkQgbWlnaHQganVzdA0KPiBiZSBhIGludGVybmFsL2xlZ2FjeSBuYW1l LCBpZiB0aGVyZSBpcyBubyByZWFsIDJkIGRvbWFpbikuDQo+IA0KPiBUaGFua3MuDQo+IA0KPiA+ IFJvYg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FB6C3F2D2 for ; Fri, 6 Mar 2020 02:34:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 268E8206D7 for ; Fri, 6 Mar 2020 02:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nLNjs1Bg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="t+WEOMVN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 268E8206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gL72MSjA1qAsLVO+JiiIATIf+XDFD/UWA5n75cCjl34=; b=nLNjs1BgGzOnPa XjQDiYa3FE42lToXXVrS4a7E4ugQ5egOmZsvOBObarwLL2xbR+C/+vQbtACh5cyr3OoSIseRg5dfV OY+DVaLrtn+h6dcBa+nIAPm4Ukbk1TAftFRxPUtPsu5MwUsY0sPOFfrFPSFg0ZKPhhLlvgYDO8ERH tkokobNp8Ph6sVcds1uRZVcMsMzODZ9VxM/2YSdwUCONiMGb5qSyviTdODdQWnlzKOgGSCMnf6xvq cTLCTVcDM4Zf4hLZI8mRVpz4ZDf4Yuy37i1fqcbftLBAlxSJMZCwup6Q/6SRNHI9qWynRt219EOgw PkcQu8m9yfie4NFdSCpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jA2or-0004V0-A9; Fri, 06 Mar 2020 02:34:33 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jA2oj-0004O5-DQ; Fri, 06 Mar 2020 02:34:27 +0000 X-UUID: 3b37ddd7469c412185d0e0e173e61948-20200305 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lw7Z2hh6lxCttqw2IBWx1RQ1VaA6UHtHaJjaKiScxsU=; b=t+WEOMVNd7ZhhmTf2qEIHa8Y/IyHKOYig5O5oZb4Fk30Hb7d0QsXIXTRG+ZWyM32G1vE8JjGlnWwJ6uaGCjKTeqwRik5tDn4aavoimZgLLizcCDFWRWz9loSPpm02J4aomj3IapNoQ+cPaeLH6fRbGgxR9cTWWPg0SzGj0iXgns=; X-UUID: 3b37ddd7469c412185d0e0e173e61948-20200305 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 648841798; Thu, 05 Mar 2020 18:34:18 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Mar 2020 18:34:16 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Mar 2020 10:33:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Mar 2020 10:34:16 +0800 Message-ID: <1583462055.4947.6.camel@mtksdaap41> Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 From: Nick Fan To: Nicolas Boichat Date: Fri, 6 Mar 2020 10:34:15 +0800 In-Reply-To: References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200305_183425_460222_6FB7FADF X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Ulf Hansson , Tomeu Vizoso , Devicetree List , David Airlie , lkml , Liam Girdwood , dri-devel , Steven Price , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Sorry for my late reply. I have checked internally. The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D domain. If the naming too confusing, we can change this name to MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. Thanks Nick Fan On Wed, 2020-02-26 at 08:55 +0800, Nicolas Boichat wrote: > +Nick Fan +Sj Huang @ MTK > > On Wed, Feb 26, 2020 at 1:16 AM Rob Herring wrote: > > > > On Fri, Feb 07, 2020 at 01:26:21PM +0800, Nicolas Boichat wrote: > > > Define a compatible string for the Mali Bifrost GPU found in > > > Mediatek's MT8183 SoCs. > > > > > > Signed-off-by: Nicolas Boichat > > > Reviewed-by: Alyssa Rosenzweig > > > --- > > > > > > v4: > > > - Add power-domain-names description > > > (kept Alyssa's reviewed-by as the change is minor) > > > v3: > > > - No change > > > > > > .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > index 4ea6a8789699709..0d93b3981445977 100644 > > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > @@ -17,6 +17,7 @@ properties: > > > items: > > > - enum: > > > - amlogic,meson-g12a-mali > > > + - mediatek,mt8183-mali > > > - realtek,rtd1619-mali > > > - rockchip,px30-mali > > > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > > > @@ -62,6 +63,30 @@ allOf: > > > minItems: 2 > > > required: > > > - resets > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: mediatek,mt8183-mali > > > + then: > > > + properties: > > > + sram-supply: true > > > + power-domains: > > > + description: > > > + List of phandle and PM domain specifier as documented in > > > + Documentation/devicetree/bindings/power/power_domain.txt > > > + minItems: 3 > > > + maxItems: 3 > > > + power-domain-names: > > > + items: > > > + - const: core0 > > > + - const: core1 > > > + - const: 2d > > > > AFAIK, there's no '2d' block in bifrost GPUs. A power domain for each > > core group is correct though. > > Good question... Hopefully Nick/SJ@MTK can comment, the non-upstream DTS has: > gpu: mali@13040000 { > compatible = "mediatek,mt8183-mali", "arm,mali-bifrost"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE0>; > ... > } > > gpu_core1: mali_gpu_core1 { > compatible = "mediatek,gpu_core1"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE1>; > }; > > gpu_core2: mali_gpu_core2 { > compatible = "mediatek,gpu_core2"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_2D>; > }; > > So I picked core0/core1/2d as names, but looking at this, it's likely > core2 is more appropriate (and MT8183_POWER_DOMAIN_MFG_2D might just > be a internal/legacy name, if there is no real 2d domain). > > Thanks. > > > Rob _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F30C3F2D7 for ; Fri, 6 Mar 2020 02:34:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B67E20870 for ; Fri, 6 Mar 2020 02:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LgYw5gBW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="t+WEOMVN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B67E20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KqI/cJsfnvlvPDYZiPPZ42ZlU9t7Z3r+RFJjL/F5pkQ=; b=LgYw5gBW95tdVe TEEKhqjO6BqmuQSEg7ZircbP4Q8oTiGizN606UnwGsb9hgtGngwPx9AplIn8ZVMACveqNwx59eLjQ fdGBqk72Wjf8VdT16MPjsEnXWfEcP6w0+2PWc82XzZBm9GFwtcQ9cUe4i1E2KGeC79MKhybTjYFZl HDTLMpqYjsjyxPJBOjokwKi/fjgfWU2Sn6ewVLrFT7avSS+upecOpy2PSxTB3dvqfiBeBNnMCe9bT 27KLtEjYMOM0O1ycxZG5oh9qVFkeO0jTuzGH1BK+puQyAh25IAJwgJaDyJ9/Xj88oZWq5A0cDYgh4 wPvQiGrha6RCbnpzMjnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jA2ol-0004Ot-Vi; Fri, 06 Mar 2020 02:34:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jA2oj-0004O5-DQ; Fri, 06 Mar 2020 02:34:27 +0000 X-UUID: 3b37ddd7469c412185d0e0e173e61948-20200305 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lw7Z2hh6lxCttqw2IBWx1RQ1VaA6UHtHaJjaKiScxsU=; b=t+WEOMVNd7ZhhmTf2qEIHa8Y/IyHKOYig5O5oZb4Fk30Hb7d0QsXIXTRG+ZWyM32G1vE8JjGlnWwJ6uaGCjKTeqwRik5tDn4aavoimZgLLizcCDFWRWz9loSPpm02J4aomj3IapNoQ+cPaeLH6fRbGgxR9cTWWPg0SzGj0iXgns=; X-UUID: 3b37ddd7469c412185d0e0e173e61948-20200305 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 648841798; Thu, 05 Mar 2020 18:34:18 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Mar 2020 18:34:16 -0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Mar 2020 10:33:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Mar 2020 10:34:16 +0800 Message-ID: <1583462055.4947.6.camel@mtksdaap41> Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 From: Nick Fan To: Nicolas Boichat Date: Fri, 6 Mar 2020 10:34:15 +0800 In-Reply-To: References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200305_183425_460222_6FB7FADF X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Rob Herring , Ulf Hansson , Tomeu Vizoso , Devicetree List , David Airlie , lkml , Liam Girdwood , dri-devel , Steven Price , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Daniel Vetter , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Sorry for my late reply. I have checked internally. The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D domain. If the naming too confusing, we can change this name to MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. Thanks Nick Fan On Wed, 2020-02-26 at 08:55 +0800, Nicolas Boichat wrote: > +Nick Fan +Sj Huang @ MTK > > On Wed, Feb 26, 2020 at 1:16 AM Rob Herring wrote: > > > > On Fri, Feb 07, 2020 at 01:26:21PM +0800, Nicolas Boichat wrote: > > > Define a compatible string for the Mali Bifrost GPU found in > > > Mediatek's MT8183 SoCs. > > > > > > Signed-off-by: Nicolas Boichat > > > Reviewed-by: Alyssa Rosenzweig > > > --- > > > > > > v4: > > > - Add power-domain-names description > > > (kept Alyssa's reviewed-by as the change is minor) > > > v3: > > > - No change > > > > > > .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > index 4ea6a8789699709..0d93b3981445977 100644 > > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > @@ -17,6 +17,7 @@ properties: > > > items: > > > - enum: > > > - amlogic,meson-g12a-mali > > > + - mediatek,mt8183-mali > > > - realtek,rtd1619-mali > > > - rockchip,px30-mali > > > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > > > @@ -62,6 +63,30 @@ allOf: > > > minItems: 2 > > > required: > > > - resets > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: mediatek,mt8183-mali > > > + then: > > > + properties: > > > + sram-supply: true > > > + power-domains: > > > + description: > > > + List of phandle and PM domain specifier as documented in > > > + Documentation/devicetree/bindings/power/power_domain.txt > > > + minItems: 3 > > > + maxItems: 3 > > > + power-domain-names: > > > + items: > > > + - const: core0 > > > + - const: core1 > > > + - const: 2d > > > > AFAIK, there's no '2d' block in bifrost GPUs. A power domain for each > > core group is correct though. > > Good question... Hopefully Nick/SJ@MTK can comment, the non-upstream DTS has: > gpu: mali@13040000 { > compatible = "mediatek,mt8183-mali", "arm,mali-bifrost"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE0>; > ... > } > > gpu_core1: mali_gpu_core1 { > compatible = "mediatek,gpu_core1"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE1>; > }; > > gpu_core2: mali_gpu_core2 { > compatible = "mediatek,gpu_core2"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_2D>; > }; > > So I picked core0/core1/2d as names, but looking at this, it's likely > core2 is more appropriate (and MT8183_POWER_DOMAIN_MFG_2D might just > be a internal/legacy name, if there is no real 2d domain). > > Thanks. > > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87DBEC10F00 for ; Fri, 6 Mar 2020 08:03:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54C932073D for ; Fri, 6 Mar 2020 08:03:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="e6ayxYvJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54C932073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DC7D6EC6B; Fri, 6 Mar 2020 08:03:02 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id 180856EC50 for ; Fri, 6 Mar 2020 02:34:20 +0000 (UTC) X-UUID: 0bcd69818ec44aa19b87aa0671e71ffa-20200306 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=lw7Z2hh6lxCttqw2IBWx1RQ1VaA6UHtHaJjaKiScxsU=; b=e6ayxYvJPghsOeTmMKrxd+rDVv0LvxracPf2u1WBaq49Z7bf7awGJRY7Z9RXTt8/QyLyOp6nBUPB/iuIuHDkxt80A9kyPZ9ZMmjB8bJs6tJlqhBxcfDfOxmyxMltr6TCrFy6XOwb04o6zTxdOMyGNUjxdVoXWcum5c0B1+qgdZg=; X-UUID: 0bcd69818ec44aa19b87aa0671e71ffa-20200306 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1834358050; Fri, 06 Mar 2020 10:34:16 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 6 Mar 2020 10:33:05 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 6 Mar 2020 10:34:16 +0800 Message-ID: <1583462055.4947.6.camel@mtksdaap41> Subject: Re: [PATCH v4 1/7] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 From: Nick Fan To: Nicolas Boichat Date: Fri, 6 Mar 2020 10:34:15 +0800 In-Reply-To: References: <20200207052627.130118-1-drinkcat@chromium.org> <20200207052627.130118-2-drinkcat@chromium.org> <20200225171613.GA7063@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Fri, 06 Mar 2020 08:03:01 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ulf Hansson , Tomeu Vizoso , Devicetree List , David Airlie , lkml , Liam Girdwood , dri-devel , Steven Price , Sj Huang , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Alyssa Rosenzweig , Hsin-Yi Wang , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sorry for my late reply. I have checked internally. The MT8183_POWER_DOMAIN_MFG_2D is just a legacy name, not really 2D domain. If the naming too confusing, we can change this name to MT8183_POWER_DOMAIN_MFG_CORE2 for consistency. Thanks Nick Fan On Wed, 2020-02-26 at 08:55 +0800, Nicolas Boichat wrote: > +Nick Fan +Sj Huang @ MTK > > On Wed, Feb 26, 2020 at 1:16 AM Rob Herring wrote: > > > > On Fri, Feb 07, 2020 at 01:26:21PM +0800, Nicolas Boichat wrote: > > > Define a compatible string for the Mali Bifrost GPU found in > > > Mediatek's MT8183 SoCs. > > > > > > Signed-off-by: Nicolas Boichat > > > Reviewed-by: Alyssa Rosenzweig > > > --- > > > > > > v4: > > > - Add power-domain-names description > > > (kept Alyssa's reviewed-by as the change is minor) > > > v3: > > > - No change > > > > > > .../bindings/gpu/arm,mali-bifrost.yaml | 25 +++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > index 4ea6a8789699709..0d93b3981445977 100644 > > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > @@ -17,6 +17,7 @@ properties: > > > items: > > > - enum: > > > - amlogic,meson-g12a-mali > > > + - mediatek,mt8183-mali > > > - realtek,rtd1619-mali > > > - rockchip,px30-mali > > > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > > > @@ -62,6 +63,30 @@ allOf: > > > minItems: 2 > > > required: > > > - resets > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: mediatek,mt8183-mali > > > + then: > > > + properties: > > > + sram-supply: true > > > + power-domains: > > > + description: > > > + List of phandle and PM domain specifier as documented in > > > + Documentation/devicetree/bindings/power/power_domain.txt > > > + minItems: 3 > > > + maxItems: 3 > > > + power-domain-names: > > > + items: > > > + - const: core0 > > > + - const: core1 > > > + - const: 2d > > > > AFAIK, there's no '2d' block in bifrost GPUs. A power domain for each > > core group is correct though. > > Good question... Hopefully Nick/SJ@MTK can comment, the non-upstream DTS has: > gpu: mali@13040000 { > compatible = "mediatek,mt8183-mali", "arm,mali-bifrost"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE0>; > ... > } > > gpu_core1: mali_gpu_core1 { > compatible = "mediatek,gpu_core1"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_CORE1>; > }; > > gpu_core2: mali_gpu_core2 { > compatible = "mediatek,gpu_core2"; > power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_2D>; > }; > > So I picked core0/core1/2d as names, but looking at this, it's likely > core2 is more appropriate (and MT8183_POWER_DOMAIN_MFG_2D might just > be a internal/legacy name, if there is no real 2d domain). > > Thanks. > > > Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel