From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5DFC10F27 for ; Tue, 10 Mar 2020 15:35:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFF5220578 for ; Tue, 10 Mar 2020 15:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="l4t58QwN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbgCJPfP (ORCPT ); Tue, 10 Mar 2020 11:35:15 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:56046 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbgCJPfP (ORCPT ); Tue, 10 Mar 2020 11:35:15 -0400 Received: by mail-pj1-f66.google.com with SMTP id a18so557269pjs.5 for ; Tue, 10 Mar 2020 08:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=EM9VJ6nxTtUBRreIKmvsLUlLVBtKCkiQDGFe+a+hzvQ=; b=l4t58QwNZM+PjwGIqw0ITjX4Z6H77YQ+VFKzyxV+D/xtxoSmLER+OXRcTrHjS7zyPB GfGvCeRKiV6h3kIxbG8dYgSaSZoujQNoMLMcUU1cMHNeUwEqzY0wiRvOiteaHGWaUVxo qugmyQQbTFZx+qFz0I1kMFVE1oGBAmGfa2tAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=EM9VJ6nxTtUBRreIKmvsLUlLVBtKCkiQDGFe+a+hzvQ=; b=ckqiZmwmlCx3sMVtFtHzoGEQppWoLVgtsqWS0DOPGha3GyK3e4FS0EwN8lCO7YhH7f lepN7WtgQSaoX5JbUYxzEmi/tPhcLJvtDxAmA3kDSKILQm3BYpIFMpfJ6Q1Y0G8Izv2V th2iDbARAAPXWIqKDXhdS8ZGiFag1k7Duo8eDDCSyGb4EfRHSMHEHQdNm6GeqJ5Nbfni 6EhLzF/0oLJ8OuwYEHUFa3Ea4wc+oSIJUqmG57K0EDOoxdZtAjX8wg/FUxuZAQEozWZK WEiSjNuyLI+lyUM4x3MExEsEjtdIszgt2xzSWo4IbUhanqAO9y1DMbn3SM9jJObs7eAv vT+w== X-Gm-Message-State: ANhLgQ3hpGHSlq9YD0CGakQOlMlWbngL0fFtFbNdoACL56zDinuUk4Tw UKc9CZFAinUkGwUsleMoIKk9sQ== X-Google-Smtp-Source: ADFU+vsAkBrbFp7fTBc0n/vYH++HL6rDrVZ3ftxqofpmllV0r6lddj1nIS0ZwK2dMh8/hlaU514BMw== X-Received: by 2002:a17:902:8bc7:: with SMTP id r7mr21490943plo.12.1583854513164; Tue, 10 Mar 2020 08:35:13 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id c4sm1650pfc.88.2020.03.10.08.35.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 08:35:12 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200310094159.GG1987@ninjato> References: <20200204193152.124980-1-swboyd@chromium.org> <20200204193152.124980-2-swboyd@chromium.org> <20200310094159.GG1987@ninjato> Subject: Re: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, Girish Mahadevan , Dilip Kota , Alok Chauhan , Douglas Anderson To: Wolfram Sang Date: Tue, 10 Mar 2020 08:35:11 -0700 Message-ID: <158385451115.149997.17354220554214087646@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Wolfram Sang (2020-03-10 02:42:00) > On Tue, Feb 04, 2020 at 11:31:50AM -0800, Stephen Boyd wrote: > > We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables > > should take care of this for us. Just use 0 instead so that we use the > > flags from the firmware. Also, remove specify dev_name() for the irq > > name so that we can get better information in /proc/interrupts about > > which device is generating interrupts. > >=20 > > Cc: Girish Mahadevan > > Cc: Dilip Kota > > Cc: Alok Chauhan > > Cc: Douglas Anderson > > Signed-off-by: Stephen Boyd >=20 > All patches look good, but this one doesn't build because dev is defined > in the next patch only. I also can't apply patch 2 before 1, so please > rebase and resend. Ok.