All of lore.kernel.org
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: ehabkost@redhat.com, marcel.apfelbaum@gmail.com,
	pbonzini@redhat.com, rth@twiddle.net, mst@redhat.com,
	imammedo@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [PATCH v6 04/13] hw/i386: Remove unnecessary initialization in x86_cpu_new
Date: Tue, 10 Mar 2020 21:33:44 -0500	[thread overview]
Message-ID: <158389402482.22020.17707923191340692971.stgit@naples-babu.amd.com> (raw)
In-Reply-To: <158389385028.22020.7608244627303132902.stgit@naples-babu.amd.com>

The function pc_cpu_pre_plug takes care of initialization of CPUX86State.
So, remove the initialization here.

Suggested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/i386/x86.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/i386/x86.c b/hw/i386/x86.c
index 03b8962c98..79badcc4ec 100644
--- a/hw/i386/x86.c
+++ b/hw/i386/x86.c
@@ -103,13 +103,9 @@ void x86_cpu_new(X86MachineState *x86ms, int64_t apic_id, Error **errp)
 {
     Object *cpu = NULL;
     Error *local_err = NULL;
-    CPUX86State *env = NULL;
 
     cpu = object_new(MACHINE(x86ms)->cpu_type);
 
-    env = &X86_CPU(cpu)->env;
-    env->nr_dies = x86ms->smp_dies;
-
     object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
     object_property_set_bool(cpu, true, "realized", &local_err);
 



  parent reply	other threads:[~2020-03-11  2:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  2:33 [PATCH v6 00/13] APIC ID fixes for AMD EPYC CPU model Babu Moger
2020-03-11  2:33 ` [PATCH v6 01/13] hw/i386: Introduce X86CPUTopoInfo to contain topology info Babu Moger
2020-03-11 11:39   ` Igor Mammedov
2020-03-11 14:02     ` Babu Moger
2020-03-11  2:33 ` [PATCH v6 02/13] hw/i386: Consolidate topology functions Babu Moger
2020-03-11  2:33 ` [PATCH v6 03/13] machine: Add SMP Sockets in CpuTopology Babu Moger
2020-03-11  2:33 ` Babu Moger [this message]
2020-03-11  2:33 ` [PATCH v6 05/13] hw/i386: Update structures to save the number of nodes per package Babu Moger
2020-03-11  2:33 ` [PATCH v6 06/13] hw/i386: Rename apicid_from_topo_ids to x86_apicid_from_topo_ids Babu Moger
2020-03-11 11:44   ` Igor Mammedov
2020-03-11  2:34 ` [PATCH v6 07/13] hw/386: Add EPYC mode topology decoding functions Babu Moger
2020-03-11  2:34 ` [PATCH v6 08/13] target/i386: Cleanup and use the EPYC mode topology functions Babu Moger
2020-03-11 11:49   ` Igor Mammedov
2020-03-11  2:34 ` [PATCH v6 09/13] hw/i386: Introduce apicid functions inside X86MachineState Babu Moger
2020-03-11  2:34 ` [PATCH v6 10/13] i386: Check for apic id encoding Babu Moger
2020-03-11 12:17   ` Igor Mammedov
2020-03-11 14:50     ` Babu Moger
2020-03-11  2:34 ` [PATCH v6 11/13] target/i386: Enable new apic id encoding for EPYC based cpus models Babu Moger
2020-03-11 12:18   ` Igor Mammedov
2020-03-11  2:34 ` [PATCH v6 12/13] hw/i386: Move arch_id decode inside x86_cpus_init Babu Moger
2020-03-11 12:29   ` Igor Mammedov
2020-03-11 14:52     ` Babu Moger
2020-03-11  2:34 ` [PATCH v6 13/13] i386: Fix pkg_id offset for EPYC cpu models Babu Moger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158389402482.22020.17707923191340692971.stgit@naples-babu.amd.com \
    --to=babu.moger@amd.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.