From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7718FC1975A for ; Thu, 12 Mar 2020 08:58:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56B2F20578 for ; Thu, 12 Mar 2020 08:58:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iOzxdYpp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbgCLI6S (ORCPT ); Thu, 12 Mar 2020 04:58:18 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:31735 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725978AbgCLI6R (ORCPT ); Thu, 12 Mar 2020 04:58:17 -0400 X-UUID: 7cbfa43d3c244faf9edc17ff0fa57006-20200312 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=3TDN1j10xZCmKTt4/HmcFKsBFN2EXb3TUfii04A/U8I=; b=iOzxdYppsJNm+1ewnLgQ2d8sdb7jq3GrPSchuyFSJNsLrWOi5Upv12r4SzLG8jfEhjBTop/YwNCPRaCIK1F9VSqcD9QwIoh3iYVKhpbu8rcDUEDdcmPfzRlDPc9bfqaxtUDK6u4aghGTdSU/SuM+gXV0ya1uyndzEJ/rWsR7Ric=; X-UUID: 7cbfa43d3c244faf9edc17ff0fa57006-20200312 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1079829579; Thu, 12 Mar 2020 16:58:11 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Mar 2020 16:56:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Mar 2020 16:58:06 +0800 Message-ID: <1584003477.6269.8.camel@mhfsdcap03> Subject: Re: [PATCH v10 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC From: Ran Bi To: Lee Jones CC: Hsin-Hsiung Wang , Rob Herring , Alexandre Belloni , Matthias Brugger , Mark Rutland , Sean Wang , "Sebastian Reichel" , Eddie Huang , Alessandro Zummo , Frank Wunderlich , Thomas Gleixner , "Richard Fontana" , Josef Friedl , , , , , , , Nicolas Boichat , Date: Thu, 12 Mar 2020 16:57:57 +0800 In-Reply-To: <20200312074407.GA3142@dell> References: <1583918223-22506-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1583918223-22506-5-git-send-email-hsin-hsiung.wang@mediatek.com> <20200312074407.GA3142@dell> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 41489C93ED8253A92B734623EA5AC68DE0AA3C817D3EF1171405B84CD846F7CC2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIwLTAzLTEyIGF0IDA3OjQ0ICswMDAwLCBMZWUgSm9uZXMgd3JvdGU6DQo+IE9u IFdlZCwgMTEgTWFyIDIwMjAsIEhzaW4tSHNpdW5nIFdhbmcgd3JvdGU6DQo+IA0KPiA+IEZyb206 IFJhbiBCaSA8cmFuLmJpQG1lZGlhdGVrLmNvbT4NCj4gPiANCj4gPiBUaGlzIGFkZCBzdXBwb3J0 IGZvciB0aGUgTWVkaWFUZWsgTVQ2MzU4IFJUQy4gRHJpdmVyIHVzaW5nDQo+ID4gY29tcGF0aWJs ZSBkYXRhIHRvIHN0b3JlIGRpZmZlcmVudCBSVENfV1JUR1IgYWRkcmVzcyBvZmZzZXQuDQo+ID4g VGhpcyByZXBsYWNlIFJUQ19XUlRHUiB0byBSVENfV1JUR1JfTVQ2MzIzIGluIG10NjMyMy1wb3dl cm9mZg0KPiA+IGRyaXZlciB3aGljaCBvbmx5IG5lZWRlZCBieSBhcm12NyBDUFUgd2l0aG91dCBB VEYuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogUmFuIEJpIDxyYW4uYmlAbWVkaWF0ZWsuY29t Pg0KPiA+IFNpZ25lZC1vZmYtYnk6IEhzaW4tSHNpdW5nIFdhbmcgPGhzaW4taHNpdW5nLndhbmdA bWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3Bvd2VyL3Jlc2V0L210NjMyMy1w b3dlcm9mZi5jIHwgIDIgKy0NCj4gPiAgZHJpdmVycy9ydGMvcnRjLW10NjM5Ny5jICAgICAgICAg ICAgICB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tDQo+ID4gIGluY2x1ZGUv bGludXgvbWZkL210NjM5Ny9ydGMuaCAgICAgICAgfCAgOSArKysrKysrKy0NCj4gPiAgMyBmaWxl cyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4gPiANCg0KPC4u Lj4NCg0KPiA+ICANCj4gPiAgI2RlZmluZSBSVENfSVJRX1NUQSAgICAgICAgICAgIDB4MDAwMg0K PiA+ICAjZGVmaW5lIFJUQ19JUlFfU1RBX0FMICAgICAgICAgQklUKDApDQo+ID4gQEAgLTY1LDYg KzY3LDEwIEBADQo+ID4gICNkZWZpbmUgTVRLX1JUQ19QT0xMX0RFTEFZX1VTICAxMA0KPiA+ICAj ZGVmaW5lIE1US19SVENfUE9MTF9USU1FT1VUICAgKGppZmZpZXNfdG9fdXNlY3MoSFopKQ0KPiA+ ICANCj4gPiArc3RydWN0IG10a19ydGNfZGF0YSB7DQo+ID4gKwl1MzIJCQl3cnRncjsNCj4gPiAr fTsNCj4gDQo+IERvIHlvdSBleHBlY3QgdG8gYWRkIG1vcmUgcHJvcGVydGllcyB0byB0aGlzIHN0 cnVjdD8NCj4gDQo+IElmIG5vdCwgaXQgc2VlbXMgYSBiaXQgb3ZlcmtpbGwuDQo+IA0KDQpZZXMs IHdlIHdvdWxkIGFkZCBtb3JlIHByb3BlcnRpZXMgaGVyZSBpbiBmdXR1cmUgcGF0Y2hlcy4NCg0K PiA+ICBzdHJ1Y3QgbXQ2Mzk3X3J0YyB7DQo+ID4gIAlzdHJ1Y3QgZGV2aWNlICAgICAgICAgICAq ZGV2Ow0KPiA+ICAJc3RydWN0IHJ0Y19kZXZpY2UgICAgICAgKnJ0Y19kZXY7DQo+ID4gQEAgLTc0 LDYgKzgwLDcgQEAgc3RydWN0IG10NjM5N19ydGMgew0KPiA+ICAJc3RydWN0IHJlZ21hcCAgICAg ICAgICAgKnJlZ21hcDsNCj4gPiAgCWludCAgICAgICAgICAgICAgICAgICAgIGlycTsNCj4gPiAg CXUzMiAgICAgICAgICAgICAgICAgICAgIGFkZHJfYmFzZTsNCj4gPiArCWNvbnN0IHN0cnVjdCBt dGtfcnRjX2RhdGEgKmRhdGE7DQo+IA0KPiAnZGF0YScgaXMgYSB0ZXJyaWJsZSB2YXJpYWJsZSBu YW1lLg0KPiANCj4gV2h5IGRvIHlvdSBuZWVkIHRvIHN0b3JlIHRoaXM/DQo+IA0KPiBJdCdzIG9u ZSB2YXJpYWJsZSB3aGljaCBpcyB1c2VkIG9uY2UgQUZBSUNULg0KPiANCg0KSSB3b3VsZCByZW5h bWUgJ2RhdGEnIHRvICdjb25maWcnLg0KDQpUaGlzIHN0cnVjdCB3aWxsIGJlIGV4dGVuZGVkIGlu IGZ1dHVyZSBwYXRjaGVzIHRvIGFjaGlldmUgbW9yZSBQTUlDIGNoaXANCmNvbXBhdGliaWxpdHku DQoNCj4gPiAgfTsNCj4gPiAgDQo+ID4gICNlbmRpZiAvKiBfTElOVVhfTUZEX01UNjM5N19SVENf SF8gKi8NCj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEAE7C1975A for ; Thu, 12 Mar 2020 09:09:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78E1220716 for ; Thu, 12 Mar 2020 09:09:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="avM3tFoF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="bCiMW4GD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78E1220716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/y3CeYQg39xQT37xkzdJ1aebttF1QOZv+O/6/MdWpU=; b=avM3tFoF72XG01 djT+6IfSiA9zYdxKHuV4WEdiN/Ezz8fDGswQM43Y9HGdpBcl3gRYldjJBggHn6iXwF4R0zIFIw6lm Ec3EAP+z5aop/L8+f1YRFsbuz7ko7pMTndn74vIUFQzJubtOKnss9GxUJf2Cyt6UJ1D9FdwnhIxXR ru3eGmJLPPTWaNPG3D7uge8S/5iU83t1vR531pd29BcNKptDTNcNkObpduLQFsNq9cR+VnIRPcBEJ W7Z0qQJkmbV6x++kYzaLtFTyBVUT2EHxK7PNRrJZsXut5p1AvSjvNXnMHwtwuwuyq2A1VHZXFvWCc t+Vk3KAw9vbOU1Ij0RYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCJq4-0003sZ-31; Thu, 12 Mar 2020 09:09:12 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCJpS-0003IJ-5i; Thu, 12 Mar 2020 09:08:35 +0000 X-UUID: d90b8380b1e94cfa8b001dbac2340833-20200312 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=3TDN1j10xZCmKTt4/HmcFKsBFN2EXb3TUfii04A/U8I=; b=bCiMW4GDIepzOD3X/35p7AkrDB6cZjG2XF9ZHKl6Ue/a56QUqX0qVhUdlPk+CB2MQB355PMCkXr1eamGony6qPTV6QJZUcRuAKs21wsybRmZZJl+EPVK8lrE/Vs6AF/Xh5Q27iUiyVgJ89UXr9AZA4R7yatEKyxQy7bBTsLCoVg=; X-UUID: d90b8380b1e94cfa8b001dbac2340833-20200312 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 218938399; Thu, 12 Mar 2020 01:08:20 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Mar 2020 01:58:17 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Mar 2020 16:56:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Mar 2020 16:58:06 +0800 Message-ID: <1584003477.6269.8.camel@mhfsdcap03> Subject: Re: [PATCH v10 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC From: Ran Bi To: Lee Jones Date: Thu, 12 Mar 2020 16:57:57 +0800 In-Reply-To: <20200312074407.GA3142@dell> References: <1583918223-22506-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1583918223-22506-5-git-send-email-hsin-hsiung.wang@mediatek.com> <20200312074407.GA3142@dell> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 41489C93ED8253A92B734623EA5AC68DE0AA3C817D3EF1171405B84CD846F7CC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_020834_233590_154281AD X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , Alexandre Belloni , Nicolas Boichat , srv_heupstream@mediatek.com, Frank Wunderlich , Josef Friedl , linux-pm@vger.kernel.org, Sean Wang , Sebastian Reichel , linux-kernel@vger.kernel.org, Richard Fontana , devicetree@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , Hsin-Hsiung Wang , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2020-03-12 at 07:44 +0000, Lee Jones wrote: > On Wed, 11 Mar 2020, Hsin-Hsiung Wang wrote: > > > From: Ran Bi > > > > This add support for the MediaTek MT6358 RTC. Driver using > > compatible data to store different RTC_WRTGR address offset. > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff > > driver which only needed by armv7 CPU without ATF. > > > > Signed-off-by: Ran Bi > > Signed-off-by: Hsin-Hsiung Wang > > --- > > drivers/power/reset/mt6323-poweroff.c | 2 +- > > drivers/rtc/rtc-mt6397.c | 32 ++++++++++++++++++++++++-------- > > include/linux/mfd/mt6397/rtc.h | 9 ++++++++- > > 3 files changed, 33 insertions(+), 10 deletions(-) > > <...> > > > > #define RTC_IRQ_STA 0x0002 > > #define RTC_IRQ_STA_AL BIT(0) > > @@ -65,6 +67,10 @@ > > #define MTK_RTC_POLL_DELAY_US 10 > > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ)) > > > > +struct mtk_rtc_data { > > + u32 wrtgr; > > +}; > > Do you expect to add more properties to this struct? > > If not, it seems a bit overkill. > Yes, we would add more properties here in future patches. > > struct mt6397_rtc { > > struct device *dev; > > struct rtc_device *rtc_dev; > > @@ -74,6 +80,7 @@ struct mt6397_rtc { > > struct regmap *regmap; > > int irq; > > u32 addr_base; > > + const struct mtk_rtc_data *data; > > 'data' is a terrible variable name. > > Why do you need to store this? > > It's one variable which is used once AFAICT. > I would rename 'data' to 'config'. This struct will be extended in future patches to achieve more PMIC chip compatibility. > > }; > > > > #endif /* _LINUX_MFD_MT6397_RTC_H_ */ > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E809C2BB1D for ; Thu, 12 Mar 2020 09:08:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0127C20716 for ; Thu, 12 Mar 2020 09:08:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gkGbOLrm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="bCiMW4GD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0127C20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FYT7Xyot+gmcImOkQ2Wy6fk4mp9/L5fUQQ6nfxcOb4M=; b=gkGbOLrm/EfpiS t5e9XbA5bSEQ7kxVTxd4Oihb8HHsw/5VGisPxMcbvaYvopxMENf8COsOZf7jvnxxzotwgw5TOdBQk AR+gfsILf7BmL2REQJXjplwVrL6/b9BM1VycRo+MiJNqJxx9saYYvRvNgHfnGQIDjkoITneJPJZDC XhubNSAojM8b+2uFy71hTrvGy3rPLR3L9Q7QVQ7ZoHeO0gs7h2Bt1RtXanRlYUONHkW7/VVb9yAOM gyoSjxW8nU5N3eoQYvVn3jR+BPCYoGRxHKicJ8N1SjREL0w7+iG6quSdX87eD4+/vtErhR92Yol5z zK3f5rHNmxrEYYJsBkrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCJpk-0003YA-Ee; Thu, 12 Mar 2020 09:08:52 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCJpS-0003IJ-5i; Thu, 12 Mar 2020 09:08:35 +0000 X-UUID: d90b8380b1e94cfa8b001dbac2340833-20200312 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=3TDN1j10xZCmKTt4/HmcFKsBFN2EXb3TUfii04A/U8I=; b=bCiMW4GDIepzOD3X/35p7AkrDB6cZjG2XF9ZHKl6Ue/a56QUqX0qVhUdlPk+CB2MQB355PMCkXr1eamGony6qPTV6QJZUcRuAKs21wsybRmZZJl+EPVK8lrE/Vs6AF/Xh5Q27iUiyVgJ89UXr9AZA4R7yatEKyxQy7bBTsLCoVg=; X-UUID: d90b8380b1e94cfa8b001dbac2340833-20200312 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 218938399; Thu, 12 Mar 2020 01:08:20 -0800 Received: from MTKMBS01N2.mediatek.inc (172.21.101.79) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Mar 2020 01:58:17 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Mar 2020 16:56:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Mar 2020 16:58:06 +0800 Message-ID: <1584003477.6269.8.camel@mhfsdcap03> Subject: Re: [PATCH v10 4/5] rtc: mt6397: Add support for the MediaTek MT6358 RTC From: Ran Bi To: Lee Jones Date: Thu, 12 Mar 2020 16:57:57 +0800 In-Reply-To: <20200312074407.GA3142@dell> References: <1583918223-22506-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1583918223-22506-5-git-send-email-hsin-hsiung.wang@mediatek.com> <20200312074407.GA3142@dell> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 41489C93ED8253A92B734623EA5AC68DE0AA3C817D3EF1171405B84CD846F7CC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200312_020834_233590_154281AD X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , Alexandre Belloni , Nicolas Boichat , srv_heupstream@mediatek.com, Frank Wunderlich , Josef Friedl , linux-pm@vger.kernel.org, Sean Wang , Sebastian Reichel , linux-kernel@vger.kernel.org, Richard Fontana , devicetree@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , Hsin-Hsiung Wang , linux-rtc@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-03-12 at 07:44 +0000, Lee Jones wrote: > On Wed, 11 Mar 2020, Hsin-Hsiung Wang wrote: > > > From: Ran Bi > > > > This add support for the MediaTek MT6358 RTC. Driver using > > compatible data to store different RTC_WRTGR address offset. > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff > > driver which only needed by armv7 CPU without ATF. > > > > Signed-off-by: Ran Bi > > Signed-off-by: Hsin-Hsiung Wang > > --- > > drivers/power/reset/mt6323-poweroff.c | 2 +- > > drivers/rtc/rtc-mt6397.c | 32 ++++++++++++++++++++++++-------- > > include/linux/mfd/mt6397/rtc.h | 9 ++++++++- > > 3 files changed, 33 insertions(+), 10 deletions(-) > > <...> > > > > #define RTC_IRQ_STA 0x0002 > > #define RTC_IRQ_STA_AL BIT(0) > > @@ -65,6 +67,10 @@ > > #define MTK_RTC_POLL_DELAY_US 10 > > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ)) > > > > +struct mtk_rtc_data { > > + u32 wrtgr; > > +}; > > Do you expect to add more properties to this struct? > > If not, it seems a bit overkill. > Yes, we would add more properties here in future patches. > > struct mt6397_rtc { > > struct device *dev; > > struct rtc_device *rtc_dev; > > @@ -74,6 +80,7 @@ struct mt6397_rtc { > > struct regmap *regmap; > > int irq; > > u32 addr_base; > > + const struct mtk_rtc_data *data; > > 'data' is a terrible variable name. > > Why do you need to store this? > > It's one variable which is used once AFAICT. > I would rename 'data' to 'config'. This struct will be extended in future patches to achieve more PMIC chip compatibility. > > }; > > > > #endif /* _LINUX_MFD_MT6397_RTC_H_ */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel