All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip: locking/core] usb: gadget: Use completion interface instead of open coding it
Date: Sat, 21 Mar 2020 15:53:52 -0000	[thread overview]
Message-ID: <158480603223.28353.16829608560057265287.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200321113241.043380271@linutronix.de>

The following commit has been merged into the locking/core branch of tip:

Commit-ID:     c1d51dd505577b189bf33867a9c20015ca7efb46
Gitweb:        https://git.kernel.org/tip/c1d51dd505577b189bf33867a9c20015ca7efb46
Author:        Thomas Gleixner <tglx@linutronix.de>
AuthorDate:    Sat, 21 Mar 2020 12:25:47 +01:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Sat, 21 Mar 2020 16:00:20 +01:00

usb: gadget: Use completion interface instead of open coding it

ep_io() uses a completion on stack and open codes the waiting with:

  wait_event_interruptible (done.wait, done.done);
and
  wait_event (done.wait, done.done);

This waits in non-exclusive mode for complete(), but there is no reason to
do so because the completion can only be waited for by the task itself and
complete() wakes exactly one exlusive waiter.

Replace the open coded implementation with the corresponding
wait_for_completion*() functions.

No functional change.

Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lkml.kernel.org/r/20200321113241.043380271@linutronix.de
---
 drivers/usb/gadget/legacy/inode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
index b47938d..4c3aff9 100644
--- a/drivers/usb/gadget/legacy/inode.c
+++ b/drivers/usb/gadget/legacy/inode.c
@@ -344,7 +344,7 @@ ep_io (struct ep_data *epdata, void *buf, unsigned len)
 	spin_unlock_irq (&epdata->dev->lock);
 
 	if (likely (value == 0)) {
-		value = wait_event_interruptible (done.wait, done.done);
+		value = wait_for_completion_interruptible(&done);
 		if (value != 0) {
 			spin_lock_irq (&epdata->dev->lock);
 			if (likely (epdata->ep != NULL)) {
@@ -353,7 +353,7 @@ ep_io (struct ep_data *epdata, void *buf, unsigned len)
 				usb_ep_dequeue (epdata->ep, epdata->req);
 				spin_unlock_irq (&epdata->dev->lock);
 
-				wait_event (done.wait, done.done);
+				wait_for_completion(&done);
 				if (epdata->status == -ECONNRESET)
 					epdata->status = -EINTR;
 			} else {

  reply	other threads:[~2020-03-21 15:54 UTC|newest]

Thread overview: 195+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21 11:25 [patch V3 00/20] Lock ordering documentation and annotation for lockdep Thomas Gleixner
2020-03-21 11:25 ` Thomas Gleixner
2020-03-21 11:25 ` Thomas Gleixner
2020-03-21 11:25 ` Thomas Gleixner
2020-03-21 11:25 ` [patch V3 01/20] PCI/switchtec: Fix init_completion race condition with poll_wait() Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25 ` [patch V3 02/20] pci/switchtec: Replace completion wait queue usage for poll Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 11:25 ` [patch V3 03/20] usb: gadget: Use completion interface instead of open coding it Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` tip-bot2 for Thomas Gleixner [this message]
2020-03-25  8:37   ` Felipe Balbi
2020-03-25  8:37     ` Felipe Balbi
2020-03-25  8:37     ` Felipe Balbi
2020-03-25  8:37     ` Felipe Balbi
2020-03-27 12:14     ` Sebastian Siewior
2020-03-27 12:14       ` Sebastian Siewior
2020-03-27 12:14       ` Sebastian Siewior
2020-03-27 12:14       ` Sebastian Siewior
2020-03-21 11:25 ` [patch V3 04/20] orinoco_usb: Use the regular completion interfaces Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Thomas Gleixner
2020-03-22 14:42   ` [patch V3 04/20] " Kalle Valo
2020-03-22 14:42     ` Kalle Valo
2020-03-22 14:42     ` Kalle Valo
2020-03-21 11:25 ` [patch V3 05/20] acpi: Remove header dependency Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 12:23   ` Andy Shevchenko
2020-03-21 12:23     ` Andy Shevchenko
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-03-22  7:02   ` [patch V3 05/20] " Rafael J. Wysocki
2020-03-22  7:02     ` Rafael J. Wysocki
2020-03-21 11:25 ` [patch V3 06/20] nds32: Remove mm.h from asm/uaccess.h Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 11:25 ` [patch V3 07/20] csky: " Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 11:25 ` [patch V3 08/20] hexagon: " Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-23 21:46   ` [patch V3 08/20] " Brian Cain
2020-03-23 21:46     ` Brian Cain
2020-03-23 21:46     ` Brian Cain
2020-03-23 21:46     ` Brian Cain
2020-03-21 11:25 ` [patch V3 09/20] ia64: " Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 11:25 ` [patch V3 10/20] microblaze: " Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 11:25 ` [patch V3 11/20] rcuwait: Add @state argument to rcuwait_wait_event() Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra (Intel)
2020-03-21 11:25 ` [patch V3 12/20] powerpc/ps3: Convert half completion to rcuwait Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 13:22   ` Thomas Gleixner
2020-03-21 13:22     ` Thomas Gleixner
2020-03-21 13:22     ` Thomas Gleixner
2020-03-21 13:22     ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra (Intel)
2020-03-27 19:14   ` [patch V3 12/20] " Geoff Levand
2020-03-27 19:14     ` Geoff Levand
2020-03-27 19:14     ` Geoff Levand
2020-03-27 19:14     ` Geoff Levand
2020-03-21 11:25 ` [patch V3 13/20] Documentation: Add lock ordering and nesting documentation Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Thomas Gleixner
2020-03-23  2:55   ` [patch V3 13/20] " Paul E. McKenney
2020-03-23  2:55     ` Paul E. McKenney
2020-03-23  2:55     ` Paul E. McKenney
2020-03-23  2:55     ` Paul E. McKenney
2020-03-23  2:55     ` Paul E. McKenney
2020-03-24 23:13     ` Thomas Gleixner
2020-03-24 23:13       ` Thomas Gleixner
2020-03-24 23:13       ` Thomas Gleixner
2020-03-24 23:13       ` Thomas Gleixner
2020-03-24 23:13       ` Thomas Gleixner
2020-03-25  0:28       ` Paul E. McKenney
2020-03-25  0:28         ` Paul E. McKenney
2020-03-25  0:28         ` Paul E. McKenney
2020-03-25  0:28         ` Paul E. McKenney
2020-03-25  0:28         ` Paul E. McKenney
2020-03-25 12:27         ` Documentation/locking/locktypes: Further clarifications and wordsmithing Thomas Gleixner
2020-03-25 12:27           ` Thomas Gleixner
2020-03-25 12:27           ` Thomas Gleixner
2020-03-25 12:27           ` Thomas Gleixner
2020-03-25 12:27           ` Thomas Gleixner
2020-03-25 16:02           ` Sebastian Siewior
2020-03-25 16:02             ` Sebastian Siewior
2020-03-25 16:02             ` Sebastian Siewior
2020-03-25 16:02             ` Sebastian Siewior
2020-03-25 16:02             ` Sebastian Siewior
2020-03-25 16:39             ` Paul E. McKenney
2020-03-25 16:39               ` Paul E. McKenney
2020-03-25 16:39               ` Paul E. McKenney
2020-03-25 16:39               ` Paul E. McKenney
2020-03-25 16:54               ` Sebastian Siewior
2020-03-25 16:54                 ` Sebastian Siewior
2020-03-25 16:54                 ` Sebastian Siewior
2020-03-25 16:54                 ` Sebastian Siewior
2020-03-25 16:58           ` [PATCH v2] Documentation/locking/locktypes: minor copy editor fixes Randy Dunlap
2020-03-25 16:58             ` Randy Dunlap
2020-03-25 16:58             ` Randy Dunlap
2020-03-25 16:58             ` Randy Dunlap
2020-03-26  2:40             ` Paul E. McKenney
2020-03-26  2:40               ` Paul E. McKenney
2020-03-26  2:40               ` Paul E. McKenney
2020-03-26  2:40               ` Paul E. McKenney
2020-03-26  2:40               ` Paul E. McKenney
2020-03-28 11:52             ` [tip: locking/core] Documentation/locking/locktypes: Minor " tip-bot2 for Randy Dunlap
2020-03-28 11:52           ` [tip: locking/core] Documentation/locking/locktypes: Further clarifications and wordsmithing tip-bot2 for Thomas Gleixner
2020-03-21 11:25 ` [patch V3 14/20] timekeeping: Split jiffies seqlock Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Thomas Gleixner
2020-03-21 11:25 ` [patch V3 15/20] sched/swait: Prepare usage in completions Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 11:25   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Thomas Gleixner
2020-03-21 11:26 ` [patch V3 16/20] completion: Use simple wait queues Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Thomas Gleixner
2020-03-23 15:20   ` [PATCH] completion: Use lockdep_assert_RT_in_threaded_ctx() in complete_all() Sebastian Siewior
2020-03-23 15:20     ` Sebastian Siewior
2020-03-23 15:20     ` Sebastian Siewior
2020-03-23 15:20     ` Sebastian Siewior
2020-03-23 17:50     ` [tip: locking/core] " tip-bot2 for Sebastian Siewior
2020-03-21 11:26 ` [patch V3 17/20] lockdep: Introduce wait-type checks Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-03-21 11:26 ` [patch V3 18/20] lockdep: Add hrtimer context tracing bits Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 16:46     ` Frederic Weisbecker
2020-03-21 11:26 ` [patch V3 19/20] lockdep: Annotate irq_work Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 16:40     ` Frederic Weisbecker
2020-03-21 18:12       ` Sebastian Andrzej Siewior
2020-03-22  2:33         ` Frederic Weisbecker
2020-03-22  2:39           ` Frederic Weisbecker
2020-03-22 12:27           ` Sebastian Andrzej Siewior
2020-03-21 11:26 ` [patch V3 20/20] lockdep: Add posixtimer context tracing bits Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 11:26   ` Thomas Gleixner
2020-03-21 15:53   ` [tip: locking/core] " tip-bot2 for Sebastian Andrzej Siewior
2020-03-21 17:19 ` [patch V3 00/20] Lock ordering documentation and annotation for lockdep Davidlohr Bueso
2020-03-21 17:19   ` Davidlohr Bueso
2020-03-21 17:19   ` Davidlohr Bueso
2020-03-21 17:19   ` Davidlohr Bueso
2020-03-21 17:45   ` Thomas Gleixner
2020-03-21 17:45     ` Thomas Gleixner
2020-03-21 17:45     ` Thomas Gleixner
2020-03-21 17:45     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158480603223.28353.16829608560057265287.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.