From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 558FBC4332B for ; Tue, 24 Mar 2020 08:54:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 22FBC2073C for ; Tue, 24 Mar 2020 08:54:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jjtxgFPj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727163AbgCXIy2 (ORCPT ); Tue, 24 Mar 2020 04:54:28 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:38165 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgCXIy1 (ORCPT ); Tue, 24 Mar 2020 04:54:27 -0400 Received: by mail-pj1-f66.google.com with SMTP id m15so1142226pje.3; Tue, 24 Mar 2020 01:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :user-agent:message-id:content-transfer-encoding; bh=AX6pvyW36VYxdhbcJ7NY2GZcvFUSsP1GTN2RViF8G7Y=; b=jjtxgFPjP0XI7X603OuXDyscIH0QbP4zjp0du6D/cgb/jHVPILKH3KGOL7nhVYDAdr BeDDacT5TQtN0HqK815WDe/FB9o5vbE340CtKRKkMT8jpjQ5ZSSlValk6hiQPTU20Inw cuxk9zVZbC+jila0X5uWNhaF3ar/mZ2/mfvu5YIdMIaYD1+fkpZcwfDyetbLMmqxddT4 WWa5uyYzCGDmU095ttk4ni+mvDiPvSDRnpGVdhckh+gLRFq7S8Hjj89OJGOBx7Kzqjom Sth9EoTAAyEjW1LLz9OQdPHUPde5yQmiqA+e2u5JVd/89s4YnnkK5dhWYYrLj9viO+wM HBNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:user-agent:message-id:content-transfer-encoding; bh=AX6pvyW36VYxdhbcJ7NY2GZcvFUSsP1GTN2RViF8G7Y=; b=ZLew4HMLBb9AxPZqJNvorTZOYwrLD+Kfjh0HcDsxK7965liKKR5KaXNQcwxWA8z+Es ZMsrOGJpbkySdkpGG+nupD9SOzBglpDq87CSBl9uBQd0ljVPuQV57KwAz8Dz8JBE1JM/ X/8AJrSQ5+ULLbxVhakik5GgJQyiqBmZDTJxnC5i3MkG68v9JJtHMzEqQn4sEVXnzH3M 24/f1RJqYP3uYnzDiQxHILRIPLhthWB38H6Xv+yF9jtxGWcneQcuXHkggTeU9VVfhwmj TXNP6JSMyW/ESpeFjvFAqdEpUPqgs5oxCZ2szbKQmr+QBbeGlXBX3jwIvZNccrjkEQ+K 6xxw== X-Gm-Message-State: ANhLgQ3PNZNBdBjKxO94vqQ8VWulCnQ6xrs/kc9VL14GVPG0p3wRXbwn O4oQjmGy1Gl3kUTyCC+cl/1eaE9H X-Google-Smtp-Source: ADFU+vvIuVTTxHyKgEzCyA/Lbfk93DlamjfOFopC5+FhsCBW5H4GMO1fhbhjH3uo8/3wJ9hE2sQS2Q== X-Received: by 2002:a17:902:8f8e:: with SMTP id z14mr26000685plo.195.1585040066562; Tue, 24 Mar 2020 01:54:26 -0700 (PDT) Received: from localhost (14-202-190-183.tpgi.com.au. [14.202.190.183]) by smtp.gmail.com with ESMTPSA id bx1sm1758873pjb.5.2020.03.24.01.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 01:54:26 -0700 (PDT) Date: Tue, 24 Mar 2020 18:54:20 +1000 From: Nicholas Piggin Subject: Re: [PATCH v11 5/8] powerpc/64: make buildable without CONFIG_COMPAT To: linuxppc-dev@lists.ozlabs.org, Michal Suchanek Cc: Arnaldo Carvalho de Melo , Alexander Shishkin , Allison Randal , Andy Shevchenko , Arnd Bergmann , Thiago Jung Bauermann , Benjamin Herrenschmidt , Sebastian Andrzej Siewior , Claudio Carvalho , Christophe Leroy , "David S. Miller" , "Eric W. Biederman" , Eric Richter , Greg Kroah-Hartman , Gustavo Luiz Duarte , Hari Bathini , Jordan Niethe , Jiri Olsa , Jonathan Cameron , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , Masahiro Yamada , Mauro Carvalho Chehab , Michael Neuling , Ingo Molnar , Michael Ellerman , Namhyung Kim , Nayna Jain , Paul Mackerras , Peter Zijlstra , Rob Herring , Thomas Gleixner , Valentin Schneider , Alexander Viro References: <20200225173541.1549955-1-npiggin@gmail.com> <4b7058eb0f5558fb7e2cee1b8f7cf99ebd03084e.1584620202.git.msuchanek@suse.de> In-Reply-To: <4b7058eb0f5558fb7e2cee1b8f7cf99ebd03084e.1584620202.git.msuchanek@suse.de> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1585039733.dm1rivvych.astroid@bobo.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Suchanek's on March 19, 2020 10:19 pm: > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c > index 4b0152108f61..a264989626fd 100644 > --- a/arch/powerpc/kernel/signal.c > +++ b/arch/powerpc/kernel/signal.c > @@ -247,7 +247,6 @@ static void do_signal(struct task_struct *tsk) > sigset_t *oldset =3D sigmask_to_save(); > struct ksignal ksig =3D { .sig =3D 0 }; > int ret; > - int is32 =3D is_32bit_task(); > =20 > BUG_ON(tsk !=3D current); > =20 > @@ -277,7 +276,7 @@ static void do_signal(struct task_struct *tsk) > =20 > rseq_signal_deliver(&ksig, tsk->thread.regs); > =20 > - if (is32) { > + if (is_32bit_task()) { > if (ksig.ka.sa.sa_flags & SA_SIGINFO) > ret =3D handle_rt_signal32(&ksig, oldset, tsk); > else Unnecessary? > diff --git a/arch/powerpc/kernel/syscall_64.c b/arch/powerpc/kernel/sysca= ll_64.c > index 87d95b455b83..2dcbfe38f5ac 100644 > --- a/arch/powerpc/kernel/syscall_64.c > +++ b/arch/powerpc/kernel/syscall_64.c > @@ -24,7 +24,6 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > long r6, long r7, long r8, > unsigned long r0, struct pt_regs *regs) > { > - unsigned long ti_flags; > syscall_fn f; > =20 > if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG)) > @@ -68,8 +67,7 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > =20 > local_irq_enable(); > =20 > - ti_flags =3D current_thread_info()->flags; > - if (unlikely(ti_flags & _TIF_SYSCALL_DOTRACE)) { > + if (unlikely(current_thread_info()->flags & _TIF_SYSCALL_DOTRACE)) { > /* > * We use the return value of do_syscall_trace_enter() as the > * syscall number. If the syscall was rejected for any reason > @@ -94,7 +92,7 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > /* May be faster to do array_index_nospec? */ > barrier_nospec(); > =20 > - if (unlikely(ti_flags & _TIF_32BIT)) { > + if (unlikely(is_32bit_task())) { Problem is, does this allow the load of ti_flags to be used for both tests, or does test_bit make it re-load? This could maybe be fixed by testing if(IS_ENABLED(CONFIG_COMPAT) && Other than these, the patches all look pretty good to me. Thanks, Nick = From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E733C4332B for ; Tue, 24 Mar 2020 08:56:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F1AB205ED for ; Tue, 24 Mar 2020 08:56:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jjtxgFPj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F1AB205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48mlV56QGwzDqlS for ; Tue, 24 Mar 2020 19:56:29 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::1042; helo=mail-pj1-x1042.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=jjtxgFPj; dkim-atps=neutral Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48mlRn2FBCzDqWg for ; Tue, 24 Mar 2020 19:54:28 +1100 (AEDT) Received: by mail-pj1-x1042.google.com with SMTP id g9so1149691pjp.0 for ; Tue, 24 Mar 2020 01:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :user-agent:message-id:content-transfer-encoding; bh=AX6pvyW36VYxdhbcJ7NY2GZcvFUSsP1GTN2RViF8G7Y=; b=jjtxgFPjP0XI7X603OuXDyscIH0QbP4zjp0du6D/cgb/jHVPILKH3KGOL7nhVYDAdr BeDDacT5TQtN0HqK815WDe/FB9o5vbE340CtKRKkMT8jpjQ5ZSSlValk6hiQPTU20Inw cuxk9zVZbC+jila0X5uWNhaF3ar/mZ2/mfvu5YIdMIaYD1+fkpZcwfDyetbLMmqxddT4 WWa5uyYzCGDmU095ttk4ni+mvDiPvSDRnpGVdhckh+gLRFq7S8Hjj89OJGOBx7Kzqjom Sth9EoTAAyEjW1LLz9OQdPHUPde5yQmiqA+e2u5JVd/89s4YnnkK5dhWYYrLj9viO+wM HBNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:user-agent:message-id:content-transfer-encoding; bh=AX6pvyW36VYxdhbcJ7NY2GZcvFUSsP1GTN2RViF8G7Y=; b=l0/ttn74fM47XssNsKqCiSjz7q+oi10NaZuYr20Dp8+F+8SnJG8A7W15YBJoBXKizo i8BXnQOhBklTMrsTf4VXEHHetXb4mwbovGW3rlVRPNUa0Ys4Z33xelBheX5XOXdlxTrE KMdcwAO5cEsZO8iCa3+CcvBGYWoBr3PCgw/LRi09Y78/9lYu+iGzqUujJGEVU/N5n9Ge ZijAyXXny9BhQR+/OIBPm2rR7iD0tgtU9AhcB0Hi/fBQlbdC+p4/rc42dRWHJSmOKHUz 0hvKEFDb8Q6jL0G9Urd2OVnbDfHvVJPhMbjT/TgjgVeNRqdkWRpeHM6860i2UuyHgjGw NGkw== X-Gm-Message-State: ANhLgQ2TaF1xlh3ZFbtP56z0NO6R5X3ppjX1l+l8L4PH8Qa1HvtRG3ZC 2c/HcahSBUV61vnPlIh12cJR24Al X-Google-Smtp-Source: ADFU+vvIuVTTxHyKgEzCyA/Lbfk93DlamjfOFopC5+FhsCBW5H4GMO1fhbhjH3uo8/3wJ9hE2sQS2Q== X-Received: by 2002:a17:902:8f8e:: with SMTP id z14mr26000685plo.195.1585040066562; Tue, 24 Mar 2020 01:54:26 -0700 (PDT) Received: from localhost (14-202-190-183.tpgi.com.au. [14.202.190.183]) by smtp.gmail.com with ESMTPSA id bx1sm1758873pjb.5.2020.03.24.01.54.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 01:54:26 -0700 (PDT) Date: Tue, 24 Mar 2020 18:54:20 +1000 From: Nicholas Piggin Subject: Re: [PATCH v11 5/8] powerpc/64: make buildable without CONFIG_COMPAT To: linuxppc-dev@lists.ozlabs.org, Michal Suchanek References: <20200225173541.1549955-1-npiggin@gmail.com> <4b7058eb0f5558fb7e2cee1b8f7cf99ebd03084e.1584620202.git.msuchanek@suse.de> In-Reply-To: <4b7058eb0f5558fb7e2cee1b8f7cf99ebd03084e.1584620202.git.msuchanek@suse.de> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1585039733.dm1rivvych.astroid@bobo.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Gustavo Luiz Duarte , Alexander Shishkin , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, Paul Mackerras , Jiri Olsa , Rob Herring , Michael Neuling , Eric Richter , Masahiro Yamada , Nayna Jain , Peter Zijlstra , Ingo Molnar , Hari Bathini , Jordan Niethe , Valentin Schneider , Arnd Bergmann , Arnaldo Carvalho de Melo , Alexander Viro , Jonathan Cameron , Namhyung Kim , Thomas Gleixner , Andy Shevchenko , Allison Randal , Greg Kroah-Hartman , Claudio Carvalho , Mauro Carvalho Chehab , "Eric W. Biederman" , linux-fsdevel@vger.kernel.org, "David S. Miller" , Thiago Jung Bauermann Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Michal Suchanek's on March 19, 2020 10:19 pm: > diff --git a/arch/powerpc/kernel/signal.c b/arch/powerpc/kernel/signal.c > index 4b0152108f61..a264989626fd 100644 > --- a/arch/powerpc/kernel/signal.c > +++ b/arch/powerpc/kernel/signal.c > @@ -247,7 +247,6 @@ static void do_signal(struct task_struct *tsk) > sigset_t *oldset =3D sigmask_to_save(); > struct ksignal ksig =3D { .sig =3D 0 }; > int ret; > - int is32 =3D is_32bit_task(); > =20 > BUG_ON(tsk !=3D current); > =20 > @@ -277,7 +276,7 @@ static void do_signal(struct task_struct *tsk) > =20 > rseq_signal_deliver(&ksig, tsk->thread.regs); > =20 > - if (is32) { > + if (is_32bit_task()) { > if (ksig.ka.sa.sa_flags & SA_SIGINFO) > ret =3D handle_rt_signal32(&ksig, oldset, tsk); > else Unnecessary? > diff --git a/arch/powerpc/kernel/syscall_64.c b/arch/powerpc/kernel/sysca= ll_64.c > index 87d95b455b83..2dcbfe38f5ac 100644 > --- a/arch/powerpc/kernel/syscall_64.c > +++ b/arch/powerpc/kernel/syscall_64.c > @@ -24,7 +24,6 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > long r6, long r7, long r8, > unsigned long r0, struct pt_regs *regs) > { > - unsigned long ti_flags; > syscall_fn f; > =20 > if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG)) > @@ -68,8 +67,7 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > =20 > local_irq_enable(); > =20 > - ti_flags =3D current_thread_info()->flags; > - if (unlikely(ti_flags & _TIF_SYSCALL_DOTRACE)) { > + if (unlikely(current_thread_info()->flags & _TIF_SYSCALL_DOTRACE)) { > /* > * We use the return value of do_syscall_trace_enter() as the > * syscall number. If the syscall was rejected for any reason > @@ -94,7 +92,7 @@ notrace long system_call_exception(long r3, long r4, lo= ng r5, > /* May be faster to do array_index_nospec? */ > barrier_nospec(); > =20 > - if (unlikely(ti_flags & _TIF_32BIT)) { > + if (unlikely(is_32bit_task())) { Problem is, does this allow the load of ti_flags to be used for both tests, or does test_bit make it re-load? This could maybe be fixed by testing if(IS_ENABLED(CONFIG_COMPAT) && Other than these, the patches all look pretty good to me. Thanks, Nick =