From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Daniel Vetter" <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_device managed resources (rev8)
Date: Wed, 25 Mar 2020 08:15:06 -0000 [thread overview]
Message-ID: <158512410645.29633.10405698895643620215@emeril.freedesktop.org> (raw)
In-Reply-To: <20200323144950.3018436-1-daniel.vetter@ffwll.ch>
== Series Details ==
Series: drm_device managed resources (rev8)
URL : https://patchwork.freedesktop.org/series/73633/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5c1fd37276a0 mm/sl[uo]b: export __kmalloc_track(_node)_caller
-:58: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 28 lines checked
0db382972a08 drm/i915: Don't clear drvdata in ->release
-:20: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0998d0631001 ("device-core: Ensure drvdata = NULL when no driver is bound")'
#20:
commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
-:45: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 9 lines checked
c5829952b42a drm: add managed resources tied to drm_device
-:72: WARNING:TYPO_SPELLING: 'unecessary' may be misspelled - perhaps 'unnecessary'?
#72:
v8: Remove unecessary {} around if else
-:74: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#74:
v9: Use kstrdup_const, which requires kfree_const and introducing a free_dr()
-:85: ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Neil Armstrong <narmstrong@baylibre.com'
#85:
Cc: Neil Armstrong <narmstrong@baylibre.com
-:148: CHECK:BRACES: braces {} should be used on all arms of this statement
#148: FILE: drivers/gpu/drm/drm_drv.c:837:
+ if (!dev->driver->release && !dev->managed.final_kfree) {
[...]
- }
[...]
-:153: WARNING:NEEDLESS_IF: kfree(NULL) is safe and this check is probably not required
#153: FILE: drivers/gpu/drm/drm_drv.c:841:
+ } else if (dev->managed.final_kfree)
+ kfree(dev->managed.final_kfree);
-:172: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#172:
new file mode 100644
-:247: ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#247: FILE: drivers/gpu/drm/drm_managed.c:71:
+static __always_inline struct drmres * alloc_dr(drmres_release_t release,
-:275: CHECK:SPACING: No space is necessary after a cast
#275: FILE: drivers/gpu/drm/drm_managed.c:99:
+ dr, dr->node.name, (unsigned long) dr->node.size);
-:287: CHECK:SPACING: No space is necessary after a cast
#287: FILE: drivers/gpu/drm/drm_managed.c:111:
+ dr, dr->node.name, (unsigned long) dr->node.size);
-:293: CHECK:SPACING: No space is necessary after a cast
#293: FILE: drivers/gpu/drm/drm_managed.c:117:
+ WARN_ON(dev < (struct drm_device *) container);
-:295: CHECK:SPACING: No space is necessary after a cast
#295: FILE: drivers/gpu/drm/drm_managed.c:119:
+ (struct drm_device *) (container + ksize(container)));
-:307: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#307: FILE: drivers/gpu/drm/drm_managed.c:131:
+ dr = alloc_dr(action, data ? sizeof(void*) : 0,
-:402: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'include/drm/drm_managed.h', please use '/*' instead
#402: FILE: include/drm/drm_managed.h:1:
+// SPDX-License-Identifier: GPL-2.0
-:402: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#402: FILE: include/drm/drm_managed.h:1:
+// SPDX-License-Identifier: GPL-2.0
-:455: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 3 errors, 7 warnings, 5 checks, 322 lines checked
e2a9e90fb1c7 drm: Set final_kfree in drm_dev_alloc
-:15: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0a6659bdc5e8 ("drm/bochs: new driver")'
#15:
commit 0a6659bdc5e8221da99eebb176fd9591435e38de
-:25: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b1df3a2b24a9 ("drm/virtio: add drm_driver.release callback.")'
#25:
commit b1df3a2b24a917f8853d43fe9683c0e360d2c33a
-:44: WARNING:BAD_SIGN_OFF: Duplicate signature
#44:
Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
-:45: WARNING:BAD_SIGN_OFF: Duplicate signature
#45:
Cc: xen-devel@lists.xenproject.org
-:87: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 2 errors, 3 warnings, 0 checks, 29 lines checked
533466d6d0ad drm/mipi_dbi: Use drmm_add_final_kfree in all drivers
-:189: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 111 lines checked
1a69dd93ff0a drm/udl: Use drmm_add_final_kfree
-:63: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 27 lines checked
3c1e123eb046 drm/qxl: Use drmm_add_final_kfree
-:47: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 22 lines checked
169c2c69d925 drm/i915: Use drmm_add_final_kfree
-:207: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 136 lines checked
fe66408e5fd3 drm/cirrus: Use drmm_add_final_kfree
-:28: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:31: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:75: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 3 warnings, 0 checks, 40 lines checked
ac75b8adf4be drm/v3d: Use drmm_add_final_kfree
-:122: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 95 lines checked
985789a21bf7 drm/tidss: Use drmm_add_final_kfree
-:41: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 22 lines checked
dd7421f43362 drm/mcde: Use drmm_add_final_kfree
-:39: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 21 lines checked
faca8d3cc32f drm/vgem: Use drmm_add_final_kfree
-:66: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 38 lines checked
9d3bf8891313 drm/vkms: Use drmm_add_final_kfree
-:87: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 61 lines checked
d41231272cba drm/repaper: Use drmm_add_final_kfree
-:49: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 27 lines checked
6c5bc69f860a drm/ingenic: Use drmm_add_final_kfree
-:44: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
195eacb42788 drm/gm12u320: Use drmm_add_final_kfree
-:40: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 21 lines checked
5d7cf79a8549 drm/<drivers>: Use drmm_add_final_kfree
-:77: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 42 lines checked
09c19285280f drm: Cleanups after drmm_add_final_kfree rollout
-:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 39 lines checked
430dc60ad84d drm: Handle dev->unique with drmm_
-:73: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#73: FILE: include/drm/drm_managed.h:27:
}
+char *drmm_kstrdup(struct drm_device *dev, const char *s, gfp_t gfp);
-:76: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 1 checks, 46 lines checked
5f3415797801 drm: Use drmm_ for drm_dev_init cleanup
-:33: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#33: FILE: drivers/gpu/drm/drm_drv.c:591:
+ * enabled. Slightly awkward, but can't really be helped. */
-:105: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 81 lines checked
4968ba2846b2 drm: manage drm_minor cleanup with drmm_
-:207: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 160 lines checked
20465db66178 drm: Manage drm_gem_init with drmm_
-:106: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 75 lines checked
d0a27fe712ed drm: Manage drm_vblank_cleanup with drmm_
-:150: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#150: FILE: include/drm/drm_managed.h:35:
}
+static inline void *drmm_kmalloc_array(struct drm_device *dev,
-:160: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#160: FILE: include/drm/drm_managed.h:45:
+}
+static inline void *drmm_kcalloc(struct drm_device *dev,
-:167: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 2 checks, 119 lines checked
4858cc4ba0e3 drm: Garbage collect drm_dev_fini
-:16: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:19: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:271: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 3 warnings, 0 checks, 175 lines checked
dff759c5a339 drm: Manage drm_mode_config_init with drmm_
-:164: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#164: FILE: drivers/gpu/drm/drm_mode_config.c:384:
+ * ^Iinitialization$
-:233: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 149 lines checked
2a1a6da02338 drm/bochs: Remove leftover drm_atomic_helper_shutdown
-:8: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 81da8c3b8d3d ("drm/bochs: add drm_driver.release callback.")'
#8:
commit 81da8c3b8d3df6f05b11300b7d17ccd1f3017fab
-:31: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 6 lines checked
1156334fc354 drm/bochs: Drop explicit drm_mode_config_cleanup
-:11: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#11:
This is made possible by a preceeding patch which added a drmm_
-:101: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 47 lines checked
6511b2aa6617 drm/cirrus: Drop explicit drm_mode_config_cleanup call
-:11: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#11:
This is made possible by a preceeding patch which added a drmm_
-:30: WARNING:BAD_SIGN_OFF: Duplicate signature
#30:
Cc: Sam Ravnborg <sam@ravnborg.org>
-:31: WARNING:BAD_SIGN_OFF: Duplicate signature
#31:
Cc: Thomas Zimmermann <tzimmermann@suse.de>
-:34: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:37: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:100: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 6 warnings, 0 checks, 58 lines checked
23dc60bf1d01 drm/cirrus: Fully embrace devm_
-:10: WARNING:TYPO_SPELLING: 'releated' may be misspelled - perhaps 'related'?
#10:
anymore to use devm_ for everything hw releated. Do it, and in the
-:23: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:26: WARNING:OBSOLETE: drivers/gpu/drm/cirrus/cirrus.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please.
-:122: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 4 warnings, 0 checks, 93 lines checked
e661300e8e74 drm/ingenic: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:60: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 29 lines checked
b284276ec6be drm/mcde: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:90: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 57 lines checked
90cc1dbe6df1 drm/mcde: More devm_drm_dev_init
-:61: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 37 lines checked
9d6ffea3634c drm/meson: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 17 lines checked
3031a702f3a4 drm/pl111: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:72: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 38 lines checked
5cb1ab78d0a3 drm/rcar-du: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:25: WARNING:BAD_SIGN_OFF: Duplicate signature
#25:
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-:55: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 3 warnings, 0 checks, 17 lines checked
ae8a792f81f0 drm/rockchip: Drop explicit drm_mode_config_cleanup call
-:12: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#12:
This is made possible by a preceeding patch which added a drmm_
-:88: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 42 lines checked
81c677e3c2de drm/stm: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:76: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 34 lines checked
ef6c48afeaad drm/shmob: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:25: WARNING:BAD_SIGN_OFF: Duplicate signature
#25:
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
-:65: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 3 warnings, 0 checks, 26 lines checked
2a6636367e37 drm/mtk: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 33 lines checked
c8348cd6090b drm/tidss: Drop explicit drm_mode_config_cleanup call
-:8: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#8:
This is made possible by a preceeding patch which added a drmm_
-:110: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 55 lines checked
2a991f3e5988 drm/gm12u320: More drmm_
-:81: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 50 lines checked
5d8729b98c80 drm/gm12u320: Use devm_drm_dev_init
-:89: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 65 lines checked
3dcc6ec7d1d2 drm/gm12u320: Use helpers for shutdown/suspend/resume
-:9: WARNING:TYPO_SPELLING: 'implemenation' may be misspelled - perhaps 'implementation'?
#9:
Also there's a race in the disconnect implemenation. First shut
-:85: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 56 lines checked
b7f4c804fea1 drm/gm12u320: Simplify upload work
-:160: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#160: FILE: drivers/gpu/drm/tiny/gm12u320.c:360:
+ ret = usb_bulk_msg(gm12u320->udev,
+ usb_sndbulkpipe(gm12u320->udev, DATA_SND_EPT),
-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#191: FILE: drivers/gpu/drm/tiny/gm12u320.c:378:
+ ret = usb_bulk_msg(gm12u320->udev,
+ usb_sndbulkpipe(gm12u320->udev, DATA_SND_EPT),
-:198: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#198: FILE: drivers/gpu/drm/tiny/gm12u320.c:385:
+ ret = usb_bulk_msg(gm12u320->udev,
+ usb_rcvbulkpipe(gm12u320->udev, DATA_RCV_EPT),
-:307: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 3 checks, 256 lines checked
5f5b2edee63a drm/repaper: Drop explicit drm_mode_config_cleanup call
-:11: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#11:
This is made possible by a preceeding patch which added a drmm_
-:65: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 30 lines checked
a83a298090f6 drm/mipi-dbi: Move drm_mode_config_init into mipi library
-:134: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 66 lines checked
34437aa99da1 drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call
-:12: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#12:
This is made possible by a preceeding patch which added a drmm_
-:30: WARNING:BAD_SIGN_OFF: Duplicate signature
#30:
Cc: Thomas Zimmermann <tzimmermann@suse.de>
-:37: WARNING:BAD_SIGN_OFF: Duplicate signature
#37:
Cc: Sam Ravnborg <sam@ravnborg.org>
-:170: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 4 warnings, 0 checks, 86 lines checked
ef6c6b9d2e19 drm/udl: Drop explicit drm_mode_config_cleanup call
-:14: WARNING:TYPO_SPELLING: 'preceeding' may be misspelled - perhaps 'preceding'?
#14:
This is made possible by a preceeding patch which added a drmm_
-:31: WARNING:BAD_SIGN_OFF: Duplicate signature
#31:
Cc: Thomas Zimmermann <tzimmermann@suse.de>
-:36: WARNING:BAD_SIGN_OFF: Duplicate signature
#36:
Cc: Sam Ravnborg <sam@ravnborg.org>
-:110: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 4 warnings, 0 checks, 55 lines checked
a8d9478f18b2 drm/udl: drop drm_driver.release hook
-:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 32 lines checked
baa4dcb0aee2 drm: Add docs for managed resources
-:337: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 230 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-25 8:15 UTC|newest]
Thread overview: 176+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 14:48 [PATCH 00/51] drm_device managed resources, v5 Daniel Vetter
2020-03-23 14:48 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 01/51] mm/sl[uo]b: export __kmalloc_track(_node)_caller Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-26 13:46 ` Daniel Vetter
2020-03-26 13:46 ` [Intel-gfx] " Daniel Vetter
2020-03-26 13:46 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 02/51] drm/i915: Don't clear drvdata in ->release Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-25 18:20 ` Jani Nikula
2020-03-25 18:20 ` Jani Nikula
2020-03-26 13:15 ` Jani Nikula
2020-03-26 13:15 ` Jani Nikula
2020-03-23 14:49 ` [PATCH 03/51] drm: add managed resources tied to drm_device Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 18:36 ` Sam Ravnborg
2020-03-23 18:36 ` [Intel-gfx] " Sam Ravnborg
2020-03-24 12:45 ` [PATCH] " Daniel Vetter
2020-03-24 12:45 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 04/51] drm: Set final_kfree in drm_dev_alloc Daniel Vetter
2020-03-23 14:49 ` [Xen-devel] " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 05/51] drm/mipi_dbi: Use drmm_add_final_kfree in all drivers Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 06/51] drm/udl: Use drmm_add_final_kfree Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 07/51] drm/qxl: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 08/51] drm/i915: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-26 13:10 ` Jani Nikula
2020-03-26 13:10 ` [Intel-gfx] " Jani Nikula
2020-03-26 13:33 ` Daniel Vetter
2020-03-26 13:33 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 09/51] drm/cirrus: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 10/51] drm/v3d: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 11/51] drm/tidss: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 12/51] drm/mcde: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 13/51] drm/vgem: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 14/51] drm/vkms: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 15/51] drm/repaper: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 16/51] drm/ingenic: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 17/51] drm/gm12u320: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 18/51] drm/<drivers>: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 19/51] drm: Cleanups after drmm_add_final_kfree rollout Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-04-02 0:50 ` Laurent Pinchart
2020-04-02 0:50 ` [Intel-gfx] " Laurent Pinchart
2020-04-02 5:17 ` Daniel Vetter
2020-04-02 5:17 ` [Intel-gfx] " Daniel Vetter
2020-04-02 9:39 ` Laurent Pinchart
2020-04-02 9:39 ` [Intel-gfx] " Laurent Pinchart
2020-04-02 9:50 ` Daniel Vetter
2020-04-02 9:50 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 20/51] drm: Handle dev->unique with drmm_ Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 21/51] drm: Use drmm_ for drm_dev_init cleanup Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-24 21:20 ` Sam Ravnborg
2020-03-24 21:20 ` [Intel-gfx] " Sam Ravnborg
2020-03-23 14:49 ` [PATCH 22/51] drm: manage drm_minor cleanup with drmm_ Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-24 8:54 ` Thomas Zimmermann
2020-03-24 8:54 ` [Intel-gfx] " Thomas Zimmermann
2020-03-24 20:39 ` [PATCH] " Daniel Vetter
2020-03-24 20:39 ` [Intel-gfx] " Daniel Vetter
2020-03-24 21:42 ` Sam Ravnborg
2020-03-24 21:42 ` [Intel-gfx] " Sam Ravnborg
2020-03-25 9:09 ` Daniel Vetter
2020-03-25 9:09 ` [Intel-gfx] " Daniel Vetter
2020-03-24 21:36 ` [PATCH 22/51] " Sam Ravnborg
2020-03-24 21:36 ` [Intel-gfx] " Sam Ravnborg
2020-03-25 9:07 ` Daniel Vetter
2020-03-25 9:07 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 23/51] drm: Manage drm_gem_init " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 24/51] drm: Manage drm_vblank_cleanup " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 25/51] drm: Garbage collect drm_dev_fini Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 26/51] drm: Manage drm_mode_config_init with drmm_ Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 27/51] drm/bochs: Remove leftover drm_atomic_helper_shutdown Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 28/51] drm/bochs: Drop explicit drm_mode_config_cleanup Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 29/51] drm/cirrus: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 30/51] drm/cirrus: Fully embrace devm_ Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 31/51] drm/ingenic: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 32/51] drm/mcde: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 33/51] drm/mcde: More devm_drm_dev_init Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 34/51] drm/meson: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 35/51] drm/pl111: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 36/51] drm/rcar-du: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
[not found] ` <20200323144950.3018436-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2020-03-23 14:49 ` [PATCH 37/51] drm/rockchip: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 38/51] drm/stm: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 39/51] drm/shmob: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 14:49 ` [PATCH 40/51] drm/mtk: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 15:27 ` Chun-Kuang Hu
2020-03-23 15:27 ` [Intel-gfx] " Chun-Kuang Hu
2020-03-23 14:49 ` [PATCH 41/51] drm/tidss: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 42/51] drm/gm12u320: More drmm_ Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 43/51] drm/gm12u320: Use devm_drm_dev_init Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 44/51] drm/gm12u320: Use helpers for shutdown/suspend/resume Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 45/51] drm/gm12u320: Simplify upload work Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 46/51] drm/repaper: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 47/51] drm/mipi-dbi: Move drm_mode_config_init into mipi library Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 48/51] drm/mipi-dbi: Drop explicit drm_mode_config_cleanup call Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 49/51] drm/udl: " Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-24 8:56 ` Thomas Zimmermann
2020-03-24 8:56 ` [Intel-gfx] " Thomas Zimmermann
2020-03-23 14:49 ` [PATCH 50/51] drm/udl: drop drm_driver.release hook Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` [PATCH 51/51] drm: Add docs for managed resources Daniel Vetter
2020-03-23 14:49 ` [Intel-gfx] " Daniel Vetter
2020-03-23 14:49 ` Daniel Vetter
2020-03-23 17:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_device managed resources (rev5) Patchwork
2020-03-23 17:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-03-23 17:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-24 14:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_device managed resources (rev6) Patchwork
2020-03-24 14:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-03-24 14:28 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-24 22:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm_device managed resources (rev7) Patchwork
2020-03-24 22:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-03-24 23:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-25 2:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-25 8:15 ` Patchwork [this message]
2020-03-25 8:17 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm_device managed resources (rev8) Patchwork
2020-03-25 8:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-25 9:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-26 15:10 ` [PATCH 00/51] drm_device managed resources, v5 Daniel Vetter
2020-03-26 15:10 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158512410645.29633.10405698895643620215@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.