From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56062C43331 for ; Wed, 1 Apr 2020 02:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C1002078B for ; Wed, 1 Apr 2020 02:16:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jySO1Vft" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731625AbgDACQG (ORCPT ); Tue, 31 Mar 2020 22:16:06 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:36722 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1731427AbgDACQG (ORCPT ); Tue, 31 Mar 2020 22:16:06 -0400 X-UUID: 6749501c1f56470d871025ad78d58ae8-20200401 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=AVMXu0r+6z6IDu7t/jy3++IgcoN/EedNyjzmILOaaOM=; b=jySO1VftyI+JCu8nT4nnSfsW2nEJaszEKy8KiKELtSvTD3NbnH5XWKNBmJKAG0zdwAYECn/kMruS+BtYbBWPZx+usJpVeC2Z8JJ4UktjDMvRzaR3C7ZFSdRjHVkqJsXMlIA6P7bO+3jucbnhuRMibqphX7GQJDdcFl5golmY8YA=; X-UUID: 6749501c1f56470d871025ad78d58ae8-20200401 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1896337754; Wed, 01 Apr 2020 10:16:01 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Apr 2020 10:15:57 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 1 Apr 2020 10:15:54 +0800 Message-ID: <1585707361.28859.19.camel@mhfsdcap03> Subject: Re: [PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver From: Chunfeng Yun To: Chun-Kuang Hu CC: Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , Kishon Vijay Abraham I , , , , "CK Hu" Date: Wed, 1 Apr 2020 10:16:01 +0800 In-Reply-To: <20200331155728.18032-2-chunkuang.hu@kernel.org> References: <20200331155728.18032-1-chunkuang.hu@kernel.org> <20200331155728.18032-2-chunkuang.hu@kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIwLTAzLTMxIGF0IDIzOjU3ICswODAwLCBDaHVuLUt1YW5nIEh1IHdyb3RlOg0K PiBGcm9tOiBDSyBIdSA8Y2suaHVAbWVkaWF0ZWsuY29tPg0KPiANCj4gdHpfZGlzYWJsZWQgaXMg dXNlZCB0byBjb250cm9sIG10a19oZG1pIG91dHB1dCBzaWduYWwsIGJ1dCB0aGlzIHZhcmlhYmxl DQo+IGlzIHN0b3JlZCBpbiBtdGtfaGRtaV9waHkgYW5kIG10a19oZG1pX3BoeSBkb2VzIG5vdCB1 c2UgaXQuIFNvIG1vdmUNCj4gdHpfZGlzYWJsZWQgdG8gbXRrX2hkbWkgd2hlcmUgaXQncyB1c2Vk Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQ0sgSHUgPGNrLmh1QG1lZGlhdGVrLmNvbT4NCj4gU2ln bmVkLW9mZi1ieTogQ2h1bi1LdWFuZyBIdSA8Y2h1bmt1YW5nLmh1QGtlcm5lbC5vcmc+DQo+IC0t LQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pLmMgICAgICAgICAgIHwgMjIg KysrKysrKysrKysrKysrKy0tLQ0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1p X3BoeS5oICAgICAgIHwgIDEgLQ0KPiAgLi4uL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX210MjcwMV9o ZG1pX3BoeS5jICAgIHwgIDEgLQ0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCsp LCA1IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRp YXRlay9tdGtfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pLmMNCj4g aW5kZXggNWU0YTRkYmRhNDQzLi44Nzg0MzNjMDljOWIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRp YXRlay9tdGtfaGRtaS5jDQo+IEBAIC0xNDQsMTEgKzE0NCwxNiBAQCBzdHJ1Y3QgaGRtaV9hdWRp b19wYXJhbSB7DQo+ICAJc3RydWN0IGhkbWlfY29kZWNfcGFyYW1zIGNvZGVjX3BhcmFtczsNCj4g IH07DQo+ICANCj4gK3N0cnVjdCBtdGtfaGRtaV9jb25mIHsNCj4gKwlib29sIHR6X2Rpc2FibGVk Ow0KPiArfTsNCj4gKw0KPiAgc3RydWN0IG10a19oZG1pIHsNCj4gIAlzdHJ1Y3QgZHJtX2JyaWRn ZSBicmlkZ2U7DQo+ICAJc3RydWN0IGRybV9icmlkZ2UgKm5leHRfYnJpZGdlOw0KPiAgCXN0cnVj dCBkcm1fY29ubmVjdG9yIGNvbm47DQo+ICAJc3RydWN0IGRldmljZSAqZGV2Ow0KPiArCWNvbnN0 IHN0cnVjdCBtdGtfaGRtaV9jb25mICpjb25mOw0KPiAgCXN0cnVjdCBwaHkgKnBoeTsNCj4gIAlz dHJ1Y3QgZGV2aWNlICpjZWNfZGV2Ow0KPiAgCXN0cnVjdCBpMmNfYWRhcHRlciAqZGRjX2FkcHQ7 DQo+IEBAIC0yMzAsNyArMjM1LDYgQEAgc3RhdGljIHZvaWQgbXRrX2hkbWlfaHdfdmlkX2JsYWNr KHN0cnVjdCBtdGtfaGRtaSAqaGRtaSwgYm9vbCBibGFjaykNCj4gIHN0YXRpYyB2b2lkIG10a19o ZG1pX2h3X21ha2VfcmVnX3dyaXRhYmxlKHN0cnVjdCBtdGtfaGRtaSAqaGRtaSwgYm9vbCBlbmFi bGUpDQo+ICB7DQo+ICAJc3RydWN0IGFybV9zbWNjY19yZXMgcmVzOw0KPiAtCXN0cnVjdCBtdGtf aGRtaV9waHkgKmhkbWlfcGh5ID0gcGh5X2dldF9kcnZkYXRhKGhkbWktPnBoeSk7DQo+ICANCj4g IAkvKg0KPiAgCSAqIE1UODE3MyBIRE1JIGhhcmR3YXJlIGhhcyBhbiBvdXRwdXQgY29udHJvbCBi aXQgdG8gZW5hYmxlL2Rpc2FibGUgSERNSQ0KPiBAQCAtMjM4LDcgKzI0Miw3IEBAIHN0YXRpYyB2 b2lkIG10a19oZG1pX2h3X21ha2VfcmVnX3dyaXRhYmxlKHN0cnVjdCBtdGtfaGRtaSAqaGRtaSwg Ym9vbCBlbmFibGUpDQo+ICAJICogVGhlIEFSTSB0cnVzdGVkIGZpcm13YXJlIHByb3ZpZGVzIGFu IEFQSSBmb3IgdGhlIEhETUkgZHJpdmVyIHRvIHNldA0KPiAgCSAqIHRoaXMgY29udHJvbCBiaXQg dG8gZW5hYmxlIEhETUkgb3V0cHV0IGluIHN1cGVydmlzb3IgbW9kZS4NCj4gIAkgKi8NCj4gLQlp ZiAoaGRtaV9waHktPmNvbmYgJiYgaGRtaV9waHktPmNvbmYtPnR6X2Rpc2FibGVkKQ0KPiArCWlm IChoZG1pLT5jb25mLT50el9kaXNhYmxlZCkNCj4gIAkJcmVnbWFwX3VwZGF0ZV9iaXRzKGhkbWkt PnN5c19yZWdtYXAsDQo+ICAJCQkJICAgaGRtaS0+c3lzX29mZnNldCArIEhETUlfU1lTX0NGRzIw LA0KPiAgCQkJCSAgIDB4ODAwMDgwMDUsIGVuYWJsZSA/IDB4ODAwMDAwMDUgOiAweDgwMDApOw0K PiBAQCAtMTY4OCw2ICsxNjkyLDcgQEAgc3RhdGljIGludCBtdGtfZHJtX2hkbWlfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikNCj4gIAkJcmV0dXJuIC1FTk9NRU07DQo+ICANCj4g IAloZG1pLT5kZXYgPSBkZXY7DQo+ICsJaGRtaS0+Y29uZiA9IG9mX2RldmljZV9nZXRfbWF0Y2hf ZGF0YShkZXYpOw0KPiAgDQo+ICAJcmV0ID0gbXRrX2hkbWlfZHRfcGFyc2VfcGRhdGEoaGRtaSwg cGRldik7DQo+ICAJaWYgKHJldCkNCj4gQEAgLTE3NjUsOCArMTc3MCwxOSBAQCBzdGF0aWMgaW50 IG10a19oZG1pX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ICBzdGF0aWMgU0lNUExFX0RF Vl9QTV9PUFMobXRrX2hkbWlfcG1fb3BzLA0KPiAgCQkJIG10a19oZG1pX3N1c3BlbmQsIG10a19o ZG1pX3Jlc3VtZSk7DQo+ICANCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgbXRrX2hkbWlfY29uZiBt dGtfaGRtaV9jb25mX210MjcwMSA9IHsNCj4gKwkudHpfZGlzYWJsZWQgPSB0cnVlLA0KPiArfTsN Cj4gKw0KPiArc3RhdGljIGNvbnN0IHN0cnVjdCBtdGtfaGRtaV9jb25mIG10a19oZG1pX2NvbmZf bXQ4MTczOw0KPiArDQo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtdGtfZHJt X2hkbWlfb2ZfaWRzW10gPSB7DQo+IC0JeyAuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDgxNzMt aGRtaSIsIH0sDQo+ICsJeyAuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDI3MDEtaGRtaSIsDQo+ ICsJICAuZGF0YSA9ICZtdGtfaGRtaV9jb25mX210MjcwMSwNCj4gKwl9LA0KPiArCXsgLmNvbXBh dGlibGUgPSAibWVkaWF0ZWssbXQ4MTczLWhkbWkiLA0KPiArCSAgLmRhdGEgPSAmbXRrX2hkbWlf Y29uZl9tdDgxNzMsDQo+ICsJfSwNCj4gIAl7fQ0KPiAgfTsNCj4gIA0KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pX3BoeS5oIGIvZHJpdmVycy9ncHUvZHJt L21lZGlhdGVrL210a19oZG1pX3BoeS5oDQo+IGluZGV4IDJkOGIzMTgyNDcwZC4uZmMxYzJlZmQx MTI4IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2hkbWlfcGh5 LmgNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pX3BoeS5oDQo+IEBA IC0yMCw3ICsyMCw2IEBADQo+ICBzdHJ1Y3QgbXRrX2hkbWlfcGh5Ow0KPiAgDQo+ICBzdHJ1Y3Qg bXRrX2hkbWlfcGh5X2NvbmYgew0KPiAtCWJvb2wgdHpfZGlzYWJsZWQ7DQo+ICAJdW5zaWduZWQg bG9uZyBmbGFnczsNCj4gIAljb25zdCBzdHJ1Y3QgY2xrX29wcyAqaGRtaV9waHlfY2xrX29wczsN Cj4gIAl2b2lkICgqaGRtaV9waHlfZW5hYmxlX3RtZHMpKHN0cnVjdCBtdGtfaGRtaV9waHkgKmhk bWlfcGh5KTsNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfbXQy NzAxX2hkbWlfcGh5LmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX210MjcwMV9oZG1p X3BoeS5jDQo+IGluZGV4IGQzY2M0MDIyZTk4OC4uOTlmZTA1Y2QzNTk4IDEwMDY0NA0KPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX210MjcwMV9oZG1pX3BoeS5jDQo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfbXQyNzAxX2hkbWlfcGh5LmMNCj4gQEAgLTIz Nyw3ICsyMzcsNiBAQCBzdGF0aWMgdm9pZCBtdGtfaGRtaV9waHlfZGlzYWJsZV90bWRzKHN0cnVj dCBtdGtfaGRtaV9waHkgKmhkbWlfcGh5KQ0KPiAgfQ0KPiAgDQo+ICBzdHJ1Y3QgbXRrX2hkbWlf cGh5X2NvbmYgbXRrX2hkbWlfcGh5XzI3MDFfY29uZiA9IHsNCj4gLQkudHpfZGlzYWJsZWQgPSB0 cnVlLA0KPiAgCS5mbGFncyA9IENMS19TRVRfUkFURV9HQVRFLA0KPiAgCS5oZG1pX3BoeV9jbGtf b3BzID0gJm10a19oZG1pX3BoeV9wbGxfb3BzLA0KPiAgCS5oZG1pX3BoeV9lbmFibGVfdG1kcyA9 IG10a19oZG1pX3BoeV9lbmFibGVfdG1kcywNCg0KUmV2aWV3ZWQtYnk6IENodW5mZW5nIFl1biA8 Y2h1bmZlbmcueXVuQG1lZGlhdGVrLmNvbT4NCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC64BC2D0F1 for ; Wed, 1 Apr 2020 02:26:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF58F2071A for ; Wed, 1 Apr 2020 02:26:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MnLkaCFC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jySO1Vft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF58F2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gNGmZVEi5tBwBwwp9mCH0O+zbcx/3Caxn6xBaN9v9v4=; b=MnLkaCFCuxIXO5 vqhsRRmOWM79i89Ea8jurj/4hCRerg+WtkhoyIkmlyp4zakRJlttrNvwLCp6eh/0KGaviKkCA+HM2 UxNeBbVl6IFlxCgBmdL7n4dLQDY98FAdlesPsyMDmbkbXmdt+AFFh4OPSKK6LZOcvoStXzGkbv6of g3UP9M6cmRhH1khyhtoBUILKwDFWfZ0pvzU127pTLQ6F3jCOoE2ju0oQCnt5MvWQ4l5l9yA+jGIQ4 JmWX+XlU+vdMz+J/MKLWS7v5p7DI3WSum5aYqn1F9vh6DzDLT6uDR8eGSMKH4CGuYSRdO8Oq6cgbJ h0rhvj0BknorFthY2PrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJT4y-0001LI-Aw; Wed, 01 Apr 2020 02:26:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJT4v-0001JX-ET for linux-mediatek@lists.infradead.org; Wed, 01 Apr 2020 02:26:07 +0000 X-UUID: 1f8990530e5843c099831ca7edcf62c9-20200331 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=AVMXu0r+6z6IDu7t/jy3++IgcoN/EedNyjzmILOaaOM=; b=jySO1VftyI+JCu8nT4nnSfsW2nEJaszEKy8KiKELtSvTD3NbnH5XWKNBmJKAG0zdwAYECn/kMruS+BtYbBWPZx+usJpVeC2Z8JJ4UktjDMvRzaR3C7ZFSdRjHVkqJsXMlIA6P7bO+3jucbnhuRMibqphX7GQJDdcFl5golmY8YA=; X-UUID: 1f8990530e5843c099831ca7edcf62c9-20200331 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 136803057; Tue, 31 Mar 2020 18:25:58 -0800 Received: from mtkmbs05n1.mediatek.inc (172.21.101.15) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 31 Mar 2020 19:15:58 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Apr 2020 10:15:57 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 1 Apr 2020 10:15:54 +0800 Message-ID: <1585707361.28859.19.camel@mhfsdcap03> Subject: Re: [PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver From: Chunfeng Yun To: Chun-Kuang Hu Date: Wed, 1 Apr 2020 10:16:01 +0800 In-Reply-To: <20200331155728.18032-2-chunkuang.hu@kernel.org> References: <20200331155728.18032-1-chunkuang.hu@kernel.org> <20200331155728.18032-2-chunkuang.hu@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200331_192605_498114_BE4A3B52 X-CRM114-Status: GOOD ( 19.24 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , CK Hu , linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-03-31 at 23:57 +0800, Chun-Kuang Hu wrote: > From: CK Hu > > tz_disabled is used to control mtk_hdmi output signal, but this variable > is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move > tz_disabled to mtk_hdmi where it's used. > > Signed-off-by: CK Hu > Signed-off-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 22 ++++++++++++++++--- > drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 1 - > .../gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 1 - > 3 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 5e4a4dbda443..878433c09c9b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -144,11 +144,16 @@ struct hdmi_audio_param { > struct hdmi_codec_params codec_params; > }; > > +struct mtk_hdmi_conf { > + bool tz_disabled; > +}; > + > struct mtk_hdmi { > struct drm_bridge bridge; > struct drm_bridge *next_bridge; > struct drm_connector conn; > struct device *dev; > + const struct mtk_hdmi_conf *conf; > struct phy *phy; > struct device *cec_dev; > struct i2c_adapter *ddc_adpt; > @@ -230,7 +235,6 @@ static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black) > static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable) > { > struct arm_smccc_res res; > - struct mtk_hdmi_phy *hdmi_phy = phy_get_drvdata(hdmi->phy); > > /* > * MT8173 HDMI hardware has an output control bit to enable/disable HDMI > @@ -238,7 +242,7 @@ static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable) > * The ARM trusted firmware provides an API for the HDMI driver to set > * this control bit to enable HDMI output in supervisor mode. > */ > - if (hdmi_phy->conf && hdmi_phy->conf->tz_disabled) > + if (hdmi->conf->tz_disabled) > regmap_update_bits(hdmi->sys_regmap, > hdmi->sys_offset + HDMI_SYS_CFG20, > 0x80008005, enable ? 0x80000005 : 0x8000); > @@ -1688,6 +1692,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) > return -ENOMEM; > > hdmi->dev = dev; > + hdmi->conf = of_device_get_match_data(dev); > > ret = mtk_hdmi_dt_parse_pdata(hdmi, pdev); > if (ret) > @@ -1765,8 +1770,19 @@ static int mtk_hdmi_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, > mtk_hdmi_suspend, mtk_hdmi_resume); > > +static const struct mtk_hdmi_conf mtk_hdmi_conf_mt2701 = { > + .tz_disabled = true, > +}; > + > +static const struct mtk_hdmi_conf mtk_hdmi_conf_mt8173; > + > static const struct of_device_id mtk_drm_hdmi_of_ids[] = { > - { .compatible = "mediatek,mt8173-hdmi", }, > + { .compatible = "mediatek,mt2701-hdmi", > + .data = &mtk_hdmi_conf_mt2701, > + }, > + { .compatible = "mediatek,mt8173-hdmi", > + .data = &mtk_hdmi_conf_mt8173, > + }, > {} > }; > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h > index 2d8b3182470d..fc1c2efd1128 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h > @@ -20,7 +20,6 @@ > struct mtk_hdmi_phy; > > struct mtk_hdmi_phy_conf { > - bool tz_disabled; > unsigned long flags; > const struct clk_ops *hdmi_phy_clk_ops; > void (*hdmi_phy_enable_tmds)(struct mtk_hdmi_phy *hdmi_phy); > diff --git a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > index d3cc4022e988..99fe05cd3598 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > +++ b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > @@ -237,7 +237,6 @@ static void mtk_hdmi_phy_disable_tmds(struct mtk_hdmi_phy *hdmi_phy) > } > > struct mtk_hdmi_phy_conf mtk_hdmi_phy_2701_conf = { > - .tz_disabled = true, > .flags = CLK_SET_RATE_GATE, > .hdmi_phy_clk_ops = &mtk_hdmi_phy_pll_ops, > .hdmi_phy_enable_tmds = mtk_hdmi_phy_enable_tmds, Reviewed-by: Chunfeng Yun _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8963BC43331 for ; Wed, 1 Apr 2020 07:03:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A1B120719 for ; Wed, 1 Apr 2020 07:03:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="jySO1Vft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A1B120719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19F7A6E8E2; Wed, 1 Apr 2020 07:03:44 +0000 (UTC) X-Greylist: delayed 301 seconds by postgrey-1.36 at gabe; Wed, 01 Apr 2020 02:21:07 UTC Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E06F6E8C9 for ; Wed, 1 Apr 2020 02:21:07 +0000 (UTC) X-UUID: 6749501c1f56470d871025ad78d58ae8-20200401 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=AVMXu0r+6z6IDu7t/jy3++IgcoN/EedNyjzmILOaaOM=; b=jySO1VftyI+JCu8nT4nnSfsW2nEJaszEKy8KiKELtSvTD3NbnH5XWKNBmJKAG0zdwAYECn/kMruS+BtYbBWPZx+usJpVeC2Z8JJ4UktjDMvRzaR3C7ZFSdRjHVkqJsXMlIA6P7bO+3jucbnhuRMibqphX7GQJDdcFl5golmY8YA=; X-UUID: 6749501c1f56470d871025ad78d58ae8-20200401 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1896337754; Wed, 01 Apr 2020 10:16:01 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 1 Apr 2020 10:15:57 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 1 Apr 2020 10:15:54 +0800 Message-ID: <1585707361.28859.19.camel@mhfsdcap03> Subject: Re: [PATCH v3 1/4] drm/mediatek: Move tz_disabled from mtk_hdmi_phy to mtk_hdmi driver From: Chunfeng Yun To: Chun-Kuang Hu Date: Wed, 1 Apr 2020 10:16:01 +0800 In-Reply-To: <20200331155728.18032-2-chunkuang.hu@kernel.org> References: <20200331155728.18032-1-chunkuang.hu@kernel.org> <20200331155728.18032-2-chunkuang.hu@kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Wed, 01 Apr 2020 07:03:42 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , linux-mediatek@lists.infradead.org, Matthias Brugger Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 2020-03-31 at 23:57 +0800, Chun-Kuang Hu wrote: > From: CK Hu > > tz_disabled is used to control mtk_hdmi output signal, but this variable > is stored in mtk_hdmi_phy and mtk_hdmi_phy does not use it. So move > tz_disabled to mtk_hdmi where it's used. > > Signed-off-by: CK Hu > Signed-off-by: Chun-Kuang Hu > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 22 ++++++++++++++++--- > drivers/gpu/drm/mediatek/mtk_hdmi_phy.h | 1 - > .../gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 1 - > 3 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index 5e4a4dbda443..878433c09c9b 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -144,11 +144,16 @@ struct hdmi_audio_param { > struct hdmi_codec_params codec_params; > }; > > +struct mtk_hdmi_conf { > + bool tz_disabled; > +}; > + > struct mtk_hdmi { > struct drm_bridge bridge; > struct drm_bridge *next_bridge; > struct drm_connector conn; > struct device *dev; > + const struct mtk_hdmi_conf *conf; > struct phy *phy; > struct device *cec_dev; > struct i2c_adapter *ddc_adpt; > @@ -230,7 +235,6 @@ static void mtk_hdmi_hw_vid_black(struct mtk_hdmi *hdmi, bool black) > static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable) > { > struct arm_smccc_res res; > - struct mtk_hdmi_phy *hdmi_phy = phy_get_drvdata(hdmi->phy); > > /* > * MT8173 HDMI hardware has an output control bit to enable/disable HDMI > @@ -238,7 +242,7 @@ static void mtk_hdmi_hw_make_reg_writable(struct mtk_hdmi *hdmi, bool enable) > * The ARM trusted firmware provides an API for the HDMI driver to set > * this control bit to enable HDMI output in supervisor mode. > */ > - if (hdmi_phy->conf && hdmi_phy->conf->tz_disabled) > + if (hdmi->conf->tz_disabled) > regmap_update_bits(hdmi->sys_regmap, > hdmi->sys_offset + HDMI_SYS_CFG20, > 0x80008005, enable ? 0x80000005 : 0x8000); > @@ -1688,6 +1692,7 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) > return -ENOMEM; > > hdmi->dev = dev; > + hdmi->conf = of_device_get_match_data(dev); > > ret = mtk_hdmi_dt_parse_pdata(hdmi, pdev); > if (ret) > @@ -1765,8 +1770,19 @@ static int mtk_hdmi_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, > mtk_hdmi_suspend, mtk_hdmi_resume); > > +static const struct mtk_hdmi_conf mtk_hdmi_conf_mt2701 = { > + .tz_disabled = true, > +}; > + > +static const struct mtk_hdmi_conf mtk_hdmi_conf_mt8173; > + > static const struct of_device_id mtk_drm_hdmi_of_ids[] = { > - { .compatible = "mediatek,mt8173-hdmi", }, > + { .compatible = "mediatek,mt2701-hdmi", > + .data = &mtk_hdmi_conf_mt2701, > + }, > + { .compatible = "mediatek,mt8173-hdmi", > + .data = &mtk_hdmi_conf_mt8173, > + }, > {} > }; > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h > index 2d8b3182470d..fc1c2efd1128 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.h > @@ -20,7 +20,6 @@ > struct mtk_hdmi_phy; > > struct mtk_hdmi_phy_conf { > - bool tz_disabled; > unsigned long flags; > const struct clk_ops *hdmi_phy_clk_ops; > void (*hdmi_phy_enable_tmds)(struct mtk_hdmi_phy *hdmi_phy); > diff --git a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > index d3cc4022e988..99fe05cd3598 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > +++ b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > @@ -237,7 +237,6 @@ static void mtk_hdmi_phy_disable_tmds(struct mtk_hdmi_phy *hdmi_phy) > } > > struct mtk_hdmi_phy_conf mtk_hdmi_phy_2701_conf = { > - .tz_disabled = true, > .flags = CLK_SET_RATE_GATE, > .hdmi_phy_clk_ops = &mtk_hdmi_phy_pll_ops, > .hdmi_phy_enable_tmds = mtk_hdmi_phy_enable_tmds, Reviewed-by: Chunfeng Yun _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel