From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Guedes Date: Wed, 01 Apr 2020 14:51:15 -0700 Subject: [Intel-wired-lan] [PATCH 05/12] igc: Refactor igc_rar_set_index() In-Reply-To: <158568913295.84366.14895161973219728060@latran-mobl.amr.corp.intel.com> References: <20200318230102.36952-1-andre.guedes@intel.com> <20200318230102.36952-6-andre.guedes@intel.com> <158568913295.84366.14895161973219728060@latran-mobl.amr.corp.intel.com> Message-ID: <158577787597.2951.8454136796173006388@bnkannan-mobl.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Hi Jeff, > > > -/** > > > - * igc_rar_set_index - Sync RAL[index] and RAH[index] registers with MAC table > > > - * @adapter: address of board private structure > > > - * @index: Index of the RAR entry which need to be synced with MAC table > > > +/* Set MAC address filter in hardware. > > Small correction to be consistently. Please, keep /** line above method > > declaration line. > > Yes, I can fix that. I thought we utilized kernel-doc style comments only for > APIs, not local helper functions like this. > > @Jeff, what works better for your workflow, I send a v2 in-reply-to this patch > or I send a v2 of the whole patchset? Since the modifications are very trivial and only 3 patches from this series were actually updated, I sent the v2 patches in-reply-to. Hope that's fine. - Andre