From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE33C2BA19 for ; Mon, 6 Apr 2020 11:59:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88628206F5 for ; Mon, 6 Apr 2020 11:59:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88628206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emeril.freedesktop.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2069089C54; Mon, 6 Apr 2020 11:59:35 +0000 (UTC) Received: from emeril.freedesktop.org (emeril.freedesktop.org [131.252.210.167]) by gabe.freedesktop.org (Postfix) with ESMTP id 3307789C54; Mon, 6 Apr 2020 11:59:34 +0000 (UTC) Received: from emeril.freedesktop.org (localhost [127.0.0.1]) by emeril.freedesktop.org (Postfix) with ESMTP id 2CFA5A47EE; Mon, 6 Apr 2020 11:59:34 +0000 (UTC) MIME-Version: 1.0 From: Patchwork To: "Pankaj Bharadiya" Date: Mon, 06 Apr 2020 11:59:34 -0000 Message-ID: <158617437415.4193.7868464366667651303@emeril.freedesktop.org> X-Patchwork-Hint: ignore References: <20200406112800.23762-1-pankaj.laxminarayan.bharadiya@intel.com> In-Reply-To: <20200406112800.23762-1-pankaj.laxminarayan.bharadiya@intel.com> Subject: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkNIRUNLUEFUQ0g6IHdhcm5pbmcg?= =?utf-8?q?for_Prefer_drm=5FWARN*_over_WARN*?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: intel-gfx@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" == Series Details == Series: Prefer drm_WARN* over WARN* URL : https://patchwork.freedesktop.org/series/75543/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b3269120530 drm/i915/display/icl_dsi: Prefer drm_WARN_ON over WARN_ON ce36d1d4c808 drm/i915/display/atomic_plane: Prefer drm_WARN_ON over WARN_ON 9db54cf5c0c1 drm/i915/display/ddi: Prefer drm_WARN* over WARN* cbddf2425b98 drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON 0aae019835f6 drm/i915/display/display: Prefer drm_WARN_ON over WARN_ON -:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #18: + struct drm_i915_private *i915 = container_of(T, struct drm_i915_private, power_domains); total: 0 errors, 1 warnings, 0 checks, 71 lines checked 462c17ba380f drm/i915/display/dp: Prefer drm_WARN* over WARN* 3a60829da48b drm/i915/display/dpll_mgr: Prefer drm_WARN_ON over WARN_ON 9343391f6779 drm/i915/display/frontbuffer: Prefer drm_WARN_ON over WARN_ON 31d144a0fd99 drm/i915/display/global_state: Prefer drm_WARN* over WARN* e61a3429efb8 drm/i915/display/overlay: Prefer drm_WARN_ON over WARN_ON a17137b9ca74 drm/i915/display/sdvo: Prefer drm_WARN* over WARN* ccea1b50c254 drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON 63fc326a1fca drm/i915/display/vlv_dsi: Prefer drm_WARN_ON over WARN_ON a09caf119a41 drm/i915/gem: Prefer drm_WARN* over WARN* -:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #24: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1444: + if (drm_WARN_ONCE(&i915->drm, err, "Unexpected failure to bind target VMA!")) -:50: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!obj->userptr.mm" #50: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:238: + if (drm_WARN_ON(obj->base.dev, obj->userptr.mm == NULL)) total: 0 errors, 0 warnings, 2 checks, 25 lines checked d9387cef2125 drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON -:22: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects? #22: FILE: drivers/gpu/drm/i915/i915_drv.h:1650: +#define INTEL_DISPLAY_ENABLED(dev_priv) \ + (drm_WARN_ON(&dev_priv->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display) -:22: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'dev_priv' may be better as '(dev_priv)' to avoid precedence issues #22: FILE: drivers/gpu/drm/i915/i915_drv.h:1650: +#define INTEL_DISPLAY_ENABLED(dev_priv) \ + (drm_WARN_ON(&dev_priv->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display) -:23: WARNING:LONG_LINE: line over 100 characters #23: FILE: drivers/gpu/drm/i915/i915_drv.h:1651: + (drm_WARN_ON(&dev_priv->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display) total: 0 errors, 1 warnings, 2 checks, 9 lines checked 0af155c5b3f1 drm/i915/pmu: Prefer drm_WARN_ON over WARN_ON db552aba6881 drm/i915/pm: Prefer drm_WARN_ON over WARN_ON 4c4c2b16486b drm/i915/runtime_pm: Prefer drm_WARN* over WARN* -:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #17: + struct drm_i915_private *i915 = container_of(T, struct drm_i915_private, runtime_pm); total: 0 errors, 1 warnings, 0 checks, 89 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx