From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D05DC2BA80 for ; Tue, 7 Apr 2020 13:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB52E206F7 for ; Tue, 7 Apr 2020 13:41:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LDGiTVjx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728739AbgDGNlp (ORCPT ); Tue, 7 Apr 2020 09:41:45 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:7166 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728573AbgDGNlp (ORCPT ); Tue, 7 Apr 2020 09:41:45 -0400 X-UUID: dfbf9dd631bd4f5693f93839923541e8-20200407 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=I+Idz2kS2YO8DN7EbW71q3QgUKuFjlpxCMebxFehMZE=; b=LDGiTVjxygBOmbSSvdxYCQmSpHbtihQnuFr4bslpdD7ArdBogzLYkIttZ3NSi/58Tz1Q6OkAzKL7BJ2xOEvys7aDdbC8ByQCOmusz54qDgdMrDdSNWhHxujp+1Gmal2mHJj6b4ykSswtjnd9Z04ZriY15n4PU0hXs162IxGQoS0=; X-UUID: dfbf9dd631bd4f5693f93839923541e8-20200407 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1937740329; Tue, 07 Apr 2020 21:41:33 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Apr 2020 21:41:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Apr 2020 21:41:23 +0800 Message-ID: <1586266885.31587.1.camel@mtksdaap41> Subject: Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration From: Yingjoe Chen To: CC: , , , , , Date: Tue, 7 Apr 2020 21:41:25 +0800 In-Reply-To: <1586255632-27528-1-git-send-email-light.hsieh@mediatek.com> References: <1586255632-27528-1-git-send-email-light.hsieh@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org T24gVHVlLCAyMDIwLTA0LTA3IGF0IDE4OjMzICswODAwLCBsaWdodC5oc2llaEBtZWRpYXRlay5j b20gd3JvdGU6DQo+IEZyb206IExpZ2h0IEhzaWVoIDxsaWdodC5oc2llaEBtZWRpYXRlay5jb20+ DQo+IA0KPiBSZW1vdmUgc2hhZG93IGRlY2xhcmF0aW9uIG9mIHZhcmlhYmxlICdwdWxsdXAnIGlu IG10a19waW5jb25mX2dldCgpDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBMaWdodCBIc2llaCA8bGln aHQuaHNpZWhAbWVkaWF0ZWsuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvcGluY3RybC9tZWRpYXRl ay9waW5jdHJsLXBhcmlzLmMgfCAyIC0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMo LSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BpbmN0cmwvbWVkaWF0ZWsvcGluY3RybC1w YXJpcy5jIGIvZHJpdmVycy9waW5jdHJsL21lZGlhdGVrL3BpbmN0cmwtcGFyaXMuYw0KPiBpbmRl eCA4M2JmMjljLi44Zjc1MTE1IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL3BpbmN0cmwvbWVkaWF0 ZWsvcGluY3RybC1wYXJpcy5jDQo+ICsrKyBiL2RyaXZlcnMvcGluY3RybC9tZWRpYXRlay9waW5j dHJsLXBhcmlzLmMNCj4gQEAgLTE2NCw4ICsxNjQsNiBAQCBzdGF0aWMgaW50IG10a19waW5jb25m X2dldChzdHJ1Y3QgcGluY3RybF9kZXYgKnBjdGxkZXYsDQo+ICAJY2FzZSBNVEtfUElOX0NPTkZJ R19QVV9BRFY6DQo+ICAJY2FzZSBNVEtfUElOX0NPTkZJR19QRF9BRFY6DQo+ICAJCWlmIChody0+ c29jLT5hZHZfcHVsbF9nZXQpIHsNCj4gLQkJCWJvb2wgcHVsbHVwOw0KPiAtDQo+ICAJCQlwdWxs dXAgPSBwYXJhbSA9PSBNVEtfUElOX0NPTkZJR19QVV9BRFY7DQo+ICAJCQllcnIgPSBody0+c29j LT5hZHZfcHVsbF9nZXQoaHcsIGRlc2MsIHB1bGx1cCwgJnJldCk7DQo+ICAJCX0gZWxzZQ0KDQpI aSwgTGlnaHQsDQoNCldoYXQgaXMgdGhpcyBiYXNlZCBvbj8NClRoZSBjb2RlIGluIHY1LjYgZG9l c24ndCBsb29rcyBsaWtlIHRoaXMuDQoNCkpvZS5DDQoNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD66C2BA80 for ; Tue, 7 Apr 2020 13:41:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17619206F7 for ; Tue, 7 Apr 2020 13:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o8ojzyrp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="LDGiTVjx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17619206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XubjhrMevUfnS5RvH5AP4QmmeVyq62Zafd6fXXhPYhE=; b=o8ojzyrpBBYVbP S77o42AcAgSHNBP6751ig6W8ji6DNXzj7Q2fJHEpKj7bR79SUtfDWGSZv+OtIfhDZaIxjqbhA0ytT 5PrFUNUhBLvAuS1n5eLeRrOA07eUNs+5OZN45OxQsok0l0DD9Kmsh5dz8xaUN15O/NlDy/MG99mGT Q8Pv8Iimr8Ao/cmhUZ7f3wQY8u1cNLEQsyh9HRtr2eiZUiKFEeve63HbCrETZK/uaJ9CAt0Y3SH14 PvQukb1BZLBZTR2zUwqeaeZHWBMIMnfu2AOGyApZnQy4cEJzOYcrnZ1wXZ+l0JavclijXdpF7ssMn fTFENdWvKngz0jOYwHBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLoU8-0004KO-Ov; Tue, 07 Apr 2020 13:41:48 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jLoU6-0004JV-FX for linux-mediatek@lists.infradead.org; Tue, 07 Apr 2020 13:41:47 +0000 X-UUID: c148d9b8e0f643e6bda04281e73ae024-20200407 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=I+Idz2kS2YO8DN7EbW71q3QgUKuFjlpxCMebxFehMZE=; b=LDGiTVjxygBOmbSSvdxYCQmSpHbtihQnuFr4bslpdD7ArdBogzLYkIttZ3NSi/58Tz1Q6OkAzKL7BJ2xOEvys7aDdbC8ByQCOmusz54qDgdMrDdSNWhHxujp+1Gmal2mHJj6b4ykSswtjnd9Z04ZriY15n4PU0hXs162IxGQoS0=; X-UUID: c148d9b8e0f643e6bda04281e73ae024-20200407 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 328450135; Tue, 07 Apr 2020 05:42:08 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Apr 2020 06:41:36 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Apr 2020 21:41:22 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 7 Apr 2020 21:41:23 +0800 Message-ID: <1586266885.31587.1.camel@mtksdaap41> Subject: Re: [PATCH v1 1/1] pinctrl: mediatek: remove shadow variable declaration From: Yingjoe Chen To: Date: Tue, 7 Apr 2020 21:41:25 +0800 In-Reply-To: <1586255632-27528-1-git-send-email-light.hsieh@mediatek.com> References: <1586255632-27528-1-git-send-email-light.hsieh@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200407_064146_525863_11014B6B X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.walleij@linaro.org, sean.wang@kernel.org, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-04-07 at 18:33 +0800, light.hsieh@mediatek.com wrote: > From: Light Hsieh > > Remove shadow declaration of variable 'pullup' in mtk_pinconf_get() > > Signed-off-by: Light Hsieh > --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index 83bf29c..8f75115 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -164,8 +164,6 @@ static int mtk_pinconf_get(struct pinctrl_dev *pctldev, > case MTK_PIN_CONFIG_PU_ADV: > case MTK_PIN_CONFIG_PD_ADV: > if (hw->soc->adv_pull_get) { > - bool pullup; > - > pullup = param == MTK_PIN_CONFIG_PU_ADV; > err = hw->soc->adv_pull_get(hw, desc, pullup, &ret); > } else Hi, Light, What is this based on? The code in v5.6 doesn't looks like this. Joe.C _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek