From: xiangxia.m.yue@gmail.com
To: mattias.ronnblom@ericsson.com, david.marchand@redhat.com
Cc: dev@dpdk.org, Tonghao Zhang <xiangxia.m.yue@gmail.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2] eal: fix crash when the random init
Date: Wed, 15 Apr 2020 15:43:35 +0800 [thread overview]
Message-ID: <1586936615-35033-1-git-send-email-xiangxia.m.yue@gmail.com> (raw)
In-Reply-To: <586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com>
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
When rte_rand_init is invoked, and the kernel running dpdk does't
support *getentropy, at the same time, the cpu does't support rdseed,
then rte_rand_init invoked rte_get_timer_cycles which invoked
rte_get_hpet_cycles while *eal_hpet is not available.
To fix that, use rte_get_tsc_cycles instread of rte_get_timer_cycles.
Fixes: faf8fd252785 ("eal: improve entropy for initial PRNG seed")
Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR")
Cc: stable@dpdk.org
Reported-by: Ravi Kerur <rkerur@gmail.com>
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
v2:
* use rte_get_tsc_cycles instread of rte_get_timer_cycles
---
lib/librte_eal/common/rte_random.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_random.c b/lib/librte_eal/common/rte_random.c
index 57ec8fb2b3dd..b7a089ac4fe0 100644
--- a/lib/librte_eal/common/rte_random.c
+++ b/lib/librte_eal/common/rte_random.c
@@ -198,7 +198,7 @@ struct rte_rand_state *__rte_rand_get_state(void)
return (uint64_t)rdseed_low | ((uint64_t)rdseed_high << 32);
#endif
/* second fallback: seed using rdtsc */
- return rte_get_timer_cycles();
+ return rte_get_tsc_cycles();
}
RTE_INIT(rte_rand_init)
--
1.8.3.1
next parent reply other threads:[~2020-04-16 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com>
2020-04-15 7:43 ` xiangxia.m.yue [this message]
2020-04-16 16:12 ` [dpdk-dev] [PATCH v2] eal: fix crash when the random init Mattias Rönnblom
2020-04-15 17:41 ` [dpdk-dev] [PATCH v3] " xiangxia.m.yue
2020-04-21 16:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1586936615-35033-1-git-send-email-xiangxia.m.yue@gmail.com \
--to=xiangxia.m.yue@gmail.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.