From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36D54C55185 for ; Wed, 22 Apr 2020 20:52:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07470214AF for ; Wed, 22 Apr 2020 20:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587588767; bh=Ip45XjNU3RfaDdS8GuN5nOdWgVjIUF1z7tcIGoDtEkI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=dOxl+4p0M51FmZPPFHg9ux5tGvuYdpxeP5wirbCBMfXKoNcLAfIK/uKMF1xzDcZZL 9aWbezLvakPuqTiZizKGQKrBOFZ6iw+9HShHmmiWKf2lt/hS2E1G8DEbyXM35zZjFp E5vWXQ79p0OC3T+4LSwgRtcjDbr8I3qIO8+OHpq4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726117AbgDVUwq (ORCPT ); Wed, 22 Apr 2020 16:52:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:50558 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgDVUwq (ORCPT ); Wed, 22 Apr 2020 16:52:46 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C637920857; Wed, 22 Apr 2020 20:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587588765; bh=Ip45XjNU3RfaDdS8GuN5nOdWgVjIUF1z7tcIGoDtEkI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=a2ofJsV+3c30LI/TqgmPbHk3GA/NjMJEhkk+06ZoNpF4jh14gNBBYW82NSJShgwQ3 HEbAUcdqQ8QbFJZKcDSax3rybD6T4m/T35TlNYigGsqFmJqm1a8+xTgrlNgsVuMBvK NNQSHQZ+OCCxlYYi7sEsKemN+ZMz8QTzgYTQETss= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <60402718-f36c-cab3-2766-9ae180dd7504@linux.intel.com> References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-13-pierre-louis.bossart@linux.intel.com> <158754793532.132238.9824423478783177623@swboyd.mtv.corp.google.com> <60402718-f36c-cab3-2766-9ae180dd7504@linux.intel.com> Subject: Re: [RFC PATCH 12/16] clk: hifiberry-dacpro: add ACPI support From: Stephen Boyd Cc: Rob Herring , linux-gpio@vger.kernel.org, tiwai@suse.de, Linus Walleij , Daniel Matuschek , Hui Wang , Matthias Reichl , broonie@kernel.org, Bartosz Golaszewski , Andy Shevchenko , Michael Turquette , linux-clk@vger.kernel.org To: Pierre-Louis Bossart , alsa-devel@alsa-project.org Date: Wed, 22 Apr 2020 13:52:44 -0700 Message-ID: <158758876497.163502.13202465070681172627@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Quoting Pierre-Louis Bossart (2020-04-22 02:54:38) >=20 >=20 > On 4/22/20 4:32 AM, Stephen Boyd wrote: > > Quoting Pierre-Louis Bossart (2020-04-09 12:58:37) > >> On ACPI platforms the of_ functions are irrelevant, conditionally > >> compile them out and add devm_clk_hw_register_clkdev() call instead. > >> > >> Signed-off-by: Pierre-Louis Bossart > >> --- > >> drivers/clk/clk-hifiberry-dacpro.c | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/drivers/clk/clk-hifiberry-dacpro.c b/drivers/clk/clk-hifi= berry-dacpro.c > >> index bf0616c959da..d01a90fed51b 100644 > >> --- a/drivers/clk/clk-hifiberry-dacpro.c > >> +++ b/drivers/clk/clk-hifiberry-dacpro.c > >> @@ -114,15 +114,22 @@ static int clk_hifiberry_dacpro_probe(struct pla= tform_device *pdev) > >> return ret; > >> } > >> =20 > >> +#ifndef CONFIG_ACPI > >=20 > > Use if (!IS_ENABLED(CONFIG_ACPI)) instead? >=20 > git grep CONFIG_ACPI shows most of the kernel code uses #if(n)def=20 > CONFIG_ACPI. It's equivalent, it's a boolean. It's not equivalent. It is a pre-processor directive vs. an if statement that evaluates to 0 or 1 and lets the compiler see both sides of the code to check types. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5183EC54FCB for ; Wed, 22 Apr 2020 20:53:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D95821473 for ; Wed, 22 Apr 2020 20:53:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="fgbN9CqZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="a2ofJsV+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D95821473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B4838169B; Wed, 22 Apr 2020 22:52:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B4838169B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587588828; bh=Ip45XjNU3RfaDdS8GuN5nOdWgVjIUF1z7tcIGoDtEkI=; h=In-Reply-To:References:Subject:From:To:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fgbN9CqZ5oLCs28/rSNE6TO9f33StsHdolMid96PH3S5asz3Zlj3PolTrm8odCc7d Z0rfVcTNfnQIYNYxLOBFYyUart/2xDdzprlwpTHz8Es3aKO/4VxjqKZjjgQgPHC7LD Kxd4jMIzd/iUtE0zwox1JUrs9BJH/kn/tq2hIomo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3770CF80142; Wed, 22 Apr 2020 22:52:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1DE96F800FF; Wed, 22 Apr 2020 22:52:54 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12BFCF800FF for ; Wed, 22 Apr 2020 22:52:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12BFCF800FF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="a2ofJsV+" Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C637920857; Wed, 22 Apr 2020 20:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587588765; bh=Ip45XjNU3RfaDdS8GuN5nOdWgVjIUF1z7tcIGoDtEkI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=a2ofJsV+3c30LI/TqgmPbHk3GA/NjMJEhkk+06ZoNpF4jh14gNBBYW82NSJShgwQ3 HEbAUcdqQ8QbFJZKcDSax3rybD6T4m/T35TlNYigGsqFmJqm1a8+xTgrlNgsVuMBvK NNQSHQZ+OCCxlYYi7sEsKemN+ZMz8QTzgYTQETss= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <60402718-f36c-cab3-2766-9ae180dd7504@linux.intel.com> References: <20200409195841.18901-1-pierre-louis.bossart@linux.intel.com> <20200409195841.18901-13-pierre-louis.bossart@linux.intel.com> <158754793532.132238.9824423478783177623@swboyd.mtv.corp.google.com> <60402718-f36c-cab3-2766-9ae180dd7504@linux.intel.com> Subject: Re: [RFC PATCH 12/16] clk: hifiberry-dacpro: add ACPI support From: Stephen Boyd To: Pierre-Louis Bossart , alsa-devel@alsa-project.org Date: Wed, 22 Apr 2020 13:52:44 -0700 Message-ID: <158758876497.163502.13202465070681172627@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Cc: Matthias Reichl , tiwai@suse.de, Linus Walleij , Daniel Matuschek , linux-clk@vger.kernel.org, Hui Wang , linux-gpio@vger.kernel.org, Rob Herring , broonie@kernel.org, Bartosz Golaszewski , Andy Shevchenko , Michael Turquette X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Quoting Pierre-Louis Bossart (2020-04-22 02:54:38) >=20 >=20 > On 4/22/20 4:32 AM, Stephen Boyd wrote: > > Quoting Pierre-Louis Bossart (2020-04-09 12:58:37) > >> On ACPI platforms the of_ functions are irrelevant, conditionally > >> compile them out and add devm_clk_hw_register_clkdev() call instead. > >> > >> Signed-off-by: Pierre-Louis Bossart > >> --- > >> drivers/clk/clk-hifiberry-dacpro.c | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/drivers/clk/clk-hifiberry-dacpro.c b/drivers/clk/clk-hifi= berry-dacpro.c > >> index bf0616c959da..d01a90fed51b 100644 > >> --- a/drivers/clk/clk-hifiberry-dacpro.c > >> +++ b/drivers/clk/clk-hifiberry-dacpro.c > >> @@ -114,15 +114,22 @@ static int clk_hifiberry_dacpro_probe(struct pla= tform_device *pdev) > >> return ret; > >> } > >> =20 > >> +#ifndef CONFIG_ACPI > >=20 > > Use if (!IS_ENABLED(CONFIG_ACPI)) instead? >=20 > git grep CONFIG_ACPI shows most of the kernel code uses #if(n)def=20 > CONFIG_ACPI. It's equivalent, it's a boolean. It's not equivalent. It is a pre-processor directive vs. an if statement that evaluates to 0 or 1 and lets the compiler see both sides of the code to check types.