* [PATCH -next] bpf: Make bpf_link_fops static
@ 2020-04-23 2:32 Zou Wei
2020-04-23 4:32 ` Andrii Nakryiko
2020-04-25 0:44 ` Alexei Starovoitov
0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-23 2:32 UTC (permalink / raw)
To: ast, daniel, kafai, songliubraving, yhs, andriin, john.fastabend,
kpsingh
Cc: netdev, bpf, linux-kernel, Zou Wei
Fix the following sparse warning:
kernel/bpf/syscall.c:2289:30: warning: symbol 'bpf_link_fops' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
kernel/bpf/syscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 8608d6e..fcb80e1 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -2286,7 +2286,7 @@ static void bpf_link_show_fdinfo(struct seq_file *m, struct file *filp)
}
#endif
-const struct file_operations bpf_link_fops = {
+static const struct file_operations bpf_link_fops = {
#ifdef CONFIG_PROC_FS
.show_fdinfo = bpf_link_show_fdinfo,
#endif
--
2.6.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] bpf: Make bpf_link_fops static
2020-04-23 2:32 [PATCH -next] bpf: Make bpf_link_fops static Zou Wei
@ 2020-04-23 4:32 ` Andrii Nakryiko
2020-04-25 0:44 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Andrii Nakryiko @ 2020-04-23 4:32 UTC (permalink / raw)
To: Zou Wei
Cc: Alexei Starovoitov, Daniel Borkmann, Martin Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, john fastabend, KP Singh,
Networking, bpf, open list
On Wed, Apr 22, 2020 at 7:27 PM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> kernel/bpf/syscall.c:2289:30: warning: symbol 'bpf_link_fops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
Thanks!
Acked-by: Andrii Nakryiko <andriin@fb.com>
> kernel/bpf/syscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index 8608d6e..fcb80e1 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -2286,7 +2286,7 @@ static void bpf_link_show_fdinfo(struct seq_file *m, struct file *filp)
> }
> #endif
>
> -const struct file_operations bpf_link_fops = {
> +static const struct file_operations bpf_link_fops = {
> #ifdef CONFIG_PROC_FS
> .show_fdinfo = bpf_link_show_fdinfo,
> #endif
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] bpf: Make bpf_link_fops static
2020-04-23 2:32 [PATCH -next] bpf: Make bpf_link_fops static Zou Wei
2020-04-23 4:32 ` Andrii Nakryiko
@ 2020-04-25 0:44 ` Alexei Starovoitov
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2020-04-25 0:44 UTC (permalink / raw)
To: Zou Wei
Cc: Alexei Starovoitov, Daniel Borkmann, Martin KaFai Lau, Song Liu,
Yonghong Song, Andrii Nakryiko, John Fastabend, KP Singh,
Network Development, bpf, LKML
On Wed, Apr 22, 2020 at 7:26 PM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix the following sparse warning:
>
> kernel/bpf/syscall.c:2289:30: warning: symbol 'bpf_link_fops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Applied to bpf tree. Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-25 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 2:32 [PATCH -next] bpf: Make bpf_link_fops static Zou Wei
2020-04-23 4:32 ` Andrii Nakryiko
2020-04-25 0:44 ` Alexei Starovoitov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.