All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Nusov <alexander.nusov@nfvexpress.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v3 for-4.8] tools/configure: fix pkg-config install path for FreeBSD
Date: Sat, 19 Nov 2016 15:59:08 +0300	[thread overview]
Message-ID: <1587cab42a6.f75e2fd579491.1675224345098892689@nfvexpress.com> (raw)
In-Reply-To: <20161026120215.GJ30231@citrix.com>


[-- Attachment #1.1: Type: text/plain, Size: 1712 bytes --]

Hello,



I've reinstalled xen from ports on FreeBSD-11.0

and it seems xenlight.pc is not being installed to /usr/local/libdata/pkgconfig/ directory.



root@controller:/usr/ports/devel/libvirt # find /usr/ -type f -name xenlight.pc
/usr/local/share/pkgconfig/xenlight.pc
root@controller:/usr/ports/devel/libvirt #

Name  : xen
Version : 4.7.0_2

Name  : xen-tools
Version : 4.7.0_4

could you apply this fix for FreeBSD ports tree please?

original issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213744


--

Thanks,

Alex




---- On Wed, 26 Oct 2016 15:02:15 +0300Wei Liu &lt;wei.liu2@citrix.com&gt; wrote ----




On Tue, Oct 25, 2016 at 02:26:55PM +0100, Wei Liu wrote: 

&gt; On Tue, Oct 25, 2016 at 11:53:28AM +0200, Roger Pau Monne wrote: 

&gt; &gt; pkg-config from FreeBSD ports doesn't have ${prefix}/share/pkgconfig in the 

&gt; &gt; default search path, fix this by having a PKG_INSTALLDIR variable that can 

&gt; &gt; be changed on a per-OS basis. 

&gt; &gt; 

&gt; &gt; It would be best to use PKG_INSTALLDIR as defined by the pkg.m4 macro, but 

&gt; &gt; sadly this also reports a wrong value on FreeBSD (${libdir}/pkgconfig, which 

&gt; &gt; expands to /usr/local/lib/pkgconfig by default, and is also _not_ part of 

&gt; &gt; the default pkg-config search path). 

&gt; &gt; 

&gt; &gt; This patch should not change the behavior for Linux installs. 

&gt; &gt; 

&gt; &gt; Signed-off-by: Roger Pau Monné &lt;roger.pau@citrix.com&gt; 

&gt; &gt; Reported-by: Alexander Nusov &lt;alexander.nusov@nfvexpress.com&gt; 

&gt; 

&gt; Acked-by: Wei Liu &lt;wei.liu2@citrix.com&gt; 

 

Applied. 







[-- Attachment #1.2: Type: text/html, Size: 3039 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-11-19 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  9:53 [PATCH v3 for-4.8] tools/configure: fix pkg-config install path for FreeBSD Roger Pau Monne
2016-10-25 13:26 ` Wei Liu
2016-10-26 12:02   ` Wei Liu
2016-11-19 12:59     ` Alexander Nusov [this message]
2016-11-29  9:14       ` Wei Liu
2016-12-02 16:16       ` Roger Pau Monne
2016-12-02 22:21         ` Alexander Nusov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1587cab42a6.f75e2fd579491.1675224345098892689@nfvexpress.com \
    --to=alexander.nusov@nfvexpress.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.