From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745ABC83003 for ; Wed, 29 Apr 2020 06:46:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 50DB9206D6 for ; Wed, 29 Apr 2020 06:46:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbgD2Gqj convert rfc822-to-8bit (ORCPT ); Wed, 29 Apr 2020 02:46:39 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:58235 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726355AbgD2Gqj (ORCPT ); Wed, 29 Apr 2020 02:46:39 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21054240-1500050 for multiple; Wed, 29 Apr 2020 07:45:58 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <20200429030051.920203-1-natechancellor@gmail.com> References: <20200429030051.920203-1-natechancellor@gmail.com> Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor To: Jani Nikula , Joonas Lahtinen , Nathan Chancellor , Rodrigo Vivi Subject: Re: [PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show From: Chris Wilson Message-ID: <158814275688.18349.12896739005148519908@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Wed, 29 Apr 2020 07:45:56 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Nathan Chancellor (2020-04-29 04:00:52) > When building with clang + -Wuninitialized: > > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable > 'rpcurupei' is uninitialized when used here [-Wuninitialized] > rpcurupei, > ^~~~~~~~~ > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:304:16: note: initialize the > variable 'rpcurupei' to silence this warning > u32 rpcurupei, rpcurup, rpprevup; > ^ > = 0 > 1 warning generated. > > rpupei is assigned twice; based on the second argument to > intel_uncore_read, it seems this one should have been assigned to > rpcurupei. > > Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies") > Link: https://github.com/ClangBuiltLinux/linux/issues/1016 > Signed-off-by: Nathan Chancellor Thanks. Reviewed-by: Chris Wilson -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0620C83003 for ; Wed, 29 Apr 2020 06:46:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 898D320757 for ; Wed, 29 Apr 2020 06:46:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 898D320757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ECCCC6E3A4; Wed, 29 Apr 2020 06:46:43 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CA526E3A4; Wed, 29 Apr 2020 06:46:42 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21054240-1500050 for multiple; Wed, 29 Apr 2020 07:45:58 +0100 MIME-Version: 1.0 In-Reply-To: <20200429030051.920203-1-natechancellor@gmail.com> References: <20200429030051.920203-1-natechancellor@gmail.com> To: Jani Nikula , Joonas Lahtinen , Nathan Chancellor , Rodrigo Vivi Subject: Re: [PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show From: Chris Wilson Message-ID: <158814275688.18349.12896739005148519908@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Wed, 29 Apr 2020 07:45:56 +0100 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Chancellor , clang-built-linux@googlegroups.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Nathan Chancellor (2020-04-29 04:00:52) > When building with clang + -Wuninitialized: > > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable > 'rpcurupei' is uninitialized when used here [-Wuninitialized] > rpcurupei, > ^~~~~~~~~ > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:304:16: note: initialize the > variable 'rpcurupei' to silence this warning > u32 rpcurupei, rpcurup, rpprevup; > ^ > = 0 > 1 warning generated. > > rpupei is assigned twice; based on the second argument to > intel_uncore_read, it seems this one should have been assigned to > rpcurupei. > > Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies") > Link: https://github.com/ClangBuiltLinux/linux/issues/1016 > Signed-off-by: Nathan Chancellor Thanks. Reviewed-by: Chris Wilson -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FE8C83007 for ; Wed, 29 Apr 2020 06:46:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D89E206D6 for ; Wed, 29 Apr 2020 06:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D89E206D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BDB16EC6A; Wed, 29 Apr 2020 06:46:45 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0CA526E3A4; Wed, 29 Apr 2020 06:46:42 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21054240-1500050 for multiple; Wed, 29 Apr 2020 07:45:58 +0100 MIME-Version: 1.0 In-Reply-To: <20200429030051.920203-1-natechancellor@gmail.com> References: <20200429030051.920203-1-natechancellor@gmail.com> To: Jani Nikula , Joonas Lahtinen , Nathan Chancellor , Rodrigo Vivi From: Chris Wilson Message-ID: <158814275688.18349.12896739005148519908@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Wed, 29 Apr 2020 07:45:56 +0100 Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Chancellor , clang-built-linux@googlegroups.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Nathan Chancellor (2020-04-29 04:00:52) > When building with clang + -Wuninitialized: > > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable > 'rpcurupei' is uninitialized when used here [-Wuninitialized] > rpcurupei, > ^~~~~~~~~ > drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:304:16: note: initialize the > variable 'rpcurupei' to silence this warning > u32 rpcurupei, rpcurup, rpprevup; > ^ > = 0 > 1 warning generated. > > rpupei is assigned twice; based on the second argument to > intel_uncore_read, it seems this one should have been assigned to > rpcurupei. > > Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies") > Link: https://github.com/ClangBuiltLinux/linux/issues/1016 > Signed-off-by: Nathan Chancellor Thanks. Reviewed-by: Chris Wilson -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx