From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34E2AC83009 for ; Thu, 30 Apr 2020 08:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15F2620838 for ; Thu, 30 Apr 2020 08:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UqYKJj7S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbgD3Ifb (ORCPT ); Thu, 30 Apr 2020 04:35:31 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:5516 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726420AbgD3Ifa (ORCPT ); Thu, 30 Apr 2020 04:35:30 -0400 X-UUID: 4b8be2f59f134203bb0a36f0d29d385e-20200430 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=BJN1G2vRhoJNm8shc3cGM0UiBE2w5KQJhfntwPFsV7Y=; b=UqYKJj7S0jitWVlmvMmXxXq6PkpznZPra5UVpDvoHLKE1L1Rj41f65pCwITOGBca9aVJqP2z5pR5/6tntGP49t0+yUZTABM3TIj7ffp8c89KFAR24gucIKveOyH+U5qUjWHUc8s4dJ/jNApBUOVnwZyfBLVQPgG5/4a/cQKVcBA=; X-UUID: 4b8be2f59f134203bb0a36f0d29d385e-20200430 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 731418237; Thu, 30 Apr 2020 16:35:27 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 16:35:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Apr 2020 16:35:26 +0800 Message-ID: <1588235725.3197.3.camel@mtkswgap22> Subject: RE: [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() From: Stanley Chu To: Avri Altman CC: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "alim.akhtar@samsung.com" , "jejb@linux.ibm.com" , "asutoshd@codeaurora.org" , "bvanassche@acm.org" , "andy.teng@mediatek.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Date: Thu, 30 Apr 2020 16:35:25 +0800 In-Reply-To: References: <20200429135610.23750-1-stanley.chu@mediatek.com> <20200429135610.23750-3-stanley.chu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org SGkgQXZyaSwNCg0KT24gVGh1LCAyMDIwLTA0LTMwIGF0IDA3OjU2ICswMDAwLCBBdnJpIEFsdG1h biB3cm90ZToNCj4gPiANCj4gPiBGb3IgcHJlcGFyYXRpb24gb2YgTFUgRGVkaWNhdGVkIGJ1ZmZl ciBtb2RlIHN1cHBvcnQgb24gV3JpdGVCb29zdGVyDQo+ID4gZmVhdHVyZSwgImluZGV4IiBwYXJh bWV0ZXIgc2hhbGwgYmUgYWRkZWQgYW5kIGFsbG93ZWQgdG8gYmUgc3BlY2lmaWVkDQo+ID4gYnkg Y2FsbGVycy4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBTdGFubGV5IENodSA8c3RhbmxleS5j aHVAbWVkaWF0ZWsuY29tPg0KPiA+IFJldmlld2VkLWJ5OiBCZWFuIEh1byA8YmVhbmh1b0BtaWNy b24uY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL3Njc2kvdWZzL3Vmcy1zeXNmcy5jIHwgIDIg Ky0NCj4gPiAgZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2QuYyAgICB8IDI4ICsrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0NCj4gPiAgZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2QuaCAgICB8ICAyICst DQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0p DQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc2NzaS91ZnMvdWZzLXN5c2ZzLmMgYi9k cml2ZXJzL3Njc2kvdWZzL3Vmcy1zeXNmcy5jDQo+ID4gaW5kZXggOTM0ODQ0MDhiYzQwLi5iODZi NmE0MGQ3ZTYgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9zY3NpL3Vmcy91ZnMtc3lzZnMuYw0K PiA+ICsrKyBiL2RyaXZlcnMvc2NzaS91ZnMvdWZzLXN5c2ZzLmMNCj4gPiBAQCAtNjMxLDcgKzYz MSw3IEBAIHN0YXRpYyBzc2l6ZV90IF9uYW1lIyNfc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYsDQo+ ID4gXA0KPiA+ICAgICAgICAgc3RydWN0IHVmc19oYmEgKmhiYSA9IGRldl9nZXRfZHJ2ZGF0YShk ZXYpOyAgICAgICAgICAgICAgICAgICAgIFwNCj4gPiAgICAgICAgIHBtX3J1bnRpbWVfZ2V0X3N5 bmMoaGJhLT5kZXYpOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+ID4gICAg ICAgICByZXQgPSB1ZnNoY2RfcXVlcnlfZmxhZyhoYmEsIFVQSVVfUVVFUllfT1BDT0RFX1JFQURf RkxBRywgICAgICAgXA0KPiA+IC0gICAgICAgICAgICAgICBRVUVSWV9GTEFHX0lETiMjX3VuYW1l LCAmZmxhZyk7ICAgICAgICAgICAgICAgICAgICAgICAgIFwNCj4gPiArICAgICAgICAgICAgICAg UVVFUllfRkxBR19JRE4jI191bmFtZSwgMCwgJmZsYWcpOyAgICAgICAgICAgICAgICAgICAgICBc DQo+IFRoZSBzeXNmcyBlbnRyaWVzIGZvciBmbGFncyBuZWVkcyB0byBnZXQgYW4gX2luZGV4IGFy Z3VtZW50IG5vdw0KDQpTdXJlLCBJIHdpbGwgZml4IHRoaXMgaW4gbmV4dCB2ZXJzaW9uLg0KDQpU aGFua3MsDQpTdGFubGV5IENodQ0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E65C8300A for ; Thu, 30 Apr 2020 08:41:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8692214D8 for ; Thu, 30 Apr 2020 08:41:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K1ZDiQVN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UqYKJj7S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8692214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VsSTK7LSVmFfni/1x6zOROBttG6ttRiMocaU/3fFX/4=; b=K1ZDiQVNFI3Z2M VajxtN5GJ/rVChtadihPitAWmSifYAO5sjz0Gp3BStxIl98Gyqj/uUTN13tls+VuYAqg3swm5Qv6M AWWCzbZyCMi263yzeHMi2/ooT9Ud5Ce9ihpNLsWcuwt1WGa68RGTNf+gB+mZCyk2HkjFsyciTNI2q XqwCazSrTtUfdXvedn9TSaHgxpV309E1fs6m93x6p/ZHw3qsDj/4uwCM3Ihr8UVz8hEC8QkSnP4Cz 5IPsIl+Rq1R8TfIsUE7tEN/D87cSkEbwcBBmkG197S9YGWHee4f49DxYJKVL2lnJ7LJJvTXlZ/pZB Cta9U8PiSxh+a78Tzi4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU4lL-0002KF-NP; Thu, 30 Apr 2020 08:41:43 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU4lB-0002Bi-8X; Thu, 30 Apr 2020 08:41:34 +0000 X-UUID: 9be725c7c28e44188be80d8205102d36-20200430 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=BJN1G2vRhoJNm8shc3cGM0UiBE2w5KQJhfntwPFsV7Y=; b=UqYKJj7S0jitWVlmvMmXxXq6PkpznZPra5UVpDvoHLKE1L1Rj41f65pCwITOGBca9aVJqP2z5pR5/6tntGP49t0+yUZTABM3TIj7ffp8c89KFAR24gucIKveOyH+U5qUjWHUc8s4dJ/jNApBUOVnwZyfBLVQPgG5/4a/cQKVcBA=; X-UUID: 9be725c7c28e44188be80d8205102d36-20200430 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 250260998; Thu, 30 Apr 2020 00:41:16 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 01:35:25 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 16:35:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Apr 2020 16:35:26 +0800 Message-ID: <1588235725.3197.3.camel@mtkswgap22> Subject: RE: [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() From: Stanley Chu To: Avri Altman Date: Thu, 30 Apr 2020 16:35:25 +0800 In-Reply-To: References: <20200429135610.23750-1-stanley.chu@mediatek.com> <20200429135610.23750-3-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_014133_309842_FA80129C X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "bvanassche@acm.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "linux-scsi@vger.kernel.org" , "matthias.bgg@gmail.com" , "beanhuo@micron.com" , "linux-arm-kernel@lists.infradead.org" , "asutoshd@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Avri, On Thu, 2020-04-30 at 07:56 +0000, Avri Altman wrote: > > > > For preparation of LU Dedicated buffer mode support on WriteBooster > > feature, "index" parameter shall be added and allowed to be specified > > by callers. > > > > Signed-off-by: Stanley Chu > > Reviewed-by: Bean Huo > > --- > > drivers/scsi/ufs/ufs-sysfs.c | 2 +- > > drivers/scsi/ufs/ufshcd.c | 28 +++++++++++++++------------- > > drivers/scsi/ufs/ufshcd.h | 2 +- > > 3 files changed, 17 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > > index 93484408bc40..b86b6a40d7e6 100644 > > --- a/drivers/scsi/ufs/ufs-sysfs.c > > +++ b/drivers/scsi/ufs/ufs-sysfs.c > > @@ -631,7 +631,7 @@ static ssize_t _name##_show(struct device *dev, > > \ > > struct ufs_hba *hba = dev_get_drvdata(dev); \ > > pm_runtime_get_sync(hba->dev); \ > > ret = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_READ_FLAG, \ > > - QUERY_FLAG_IDN##_uname, &flag); \ > > + QUERY_FLAG_IDN##_uname, 0, &flag); \ > The sysfs entries for flags needs to get an _index argument now Sure, I will fix this in next version. Thanks, Stanley Chu _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6886BC8300A for ; Thu, 30 Apr 2020 08:41:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21EE92173E for ; Thu, 30 Apr 2020 08:41:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bI2AdmcY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="UqYKJj7S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21EE92173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0uxYotZ+G3p2Uji7lxhMsAtGTvqEUw9m2+YKUMW8nL4=; b=bI2AdmcYAmo01s Ft7hPMXEJAiR/EL+ZryDjQphqcPWfU1S8FW8cPFxVkqmGzZSQKfFXTWCTcegedCdMDqXcEP6PlFub ByJmC7hAG7We8SRzkDJR9C0VsnQn/Sj96ZcwUjvXQoG9uHTm+tW7vxRkJkRFGPIVD1a2eTAvEjPfn 2IAzrxq36VmMWR/AhE4z+MydQov7Rzfevxg5UAGAnr8PWXzsqjFJpST9dGj5VbN7JesZUH2j3446W /+K/n/ArycOUWut8+e1gdngXSBVtgg1nyrDrgkFcn8f4/F26ZEdQr9oIXu0kYu+FMk1GHIY3aFFo+ jkiMrOUcG1ApfHUcofIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU4lE-0002Cs-GN; Thu, 30 Apr 2020 08:41:36 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jU4lB-0002Bi-8X; Thu, 30 Apr 2020 08:41:34 +0000 X-UUID: 9be725c7c28e44188be80d8205102d36-20200430 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=BJN1G2vRhoJNm8shc3cGM0UiBE2w5KQJhfntwPFsV7Y=; b=UqYKJj7S0jitWVlmvMmXxXq6PkpznZPra5UVpDvoHLKE1L1Rj41f65pCwITOGBca9aVJqP2z5pR5/6tntGP49t0+yUZTABM3TIj7ffp8c89KFAR24gucIKveOyH+U5qUjWHUc8s4dJ/jNApBUOVnwZyfBLVQPgG5/4a/cQKVcBA=; X-UUID: 9be725c7c28e44188be80d8205102d36-20200430 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 250260998; Thu, 30 Apr 2020 00:41:16 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 01:35:25 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 30 Apr 2020 16:35:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 30 Apr 2020 16:35:26 +0800 Message-ID: <1588235725.3197.3.camel@mtkswgap22> Subject: RE: [PATCH v2 2/5] scsi: ufs: add "index" in parameter list of ufshcd_query_flag() From: Stanley Chu To: Avri Altman Date: Thu, 30 Apr 2020 16:35:25 +0800 In-Reply-To: References: <20200429135610.23750-1-stanley.chu@mediatek.com> <20200429135610.23750-3-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200430_014133_309842_FA80129C X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "bvanassche@acm.org" , "martin.petersen@oracle.com" , "andy.teng@mediatek.com" , "jejb@linux.ibm.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "linux-kernel@vger.kernel.org" , "cang@codeaurora.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "linux-scsi@vger.kernel.org" , "matthias.bgg@gmail.com" , "beanhuo@micron.com" , "linux-arm-kernel@lists.infradead.org" , "asutoshd@codeaurora.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Avri, On Thu, 2020-04-30 at 07:56 +0000, Avri Altman wrote: > > > > For preparation of LU Dedicated buffer mode support on WriteBooster > > feature, "index" parameter shall be added and allowed to be specified > > by callers. > > > > Signed-off-by: Stanley Chu > > Reviewed-by: Bean Huo > > --- > > drivers/scsi/ufs/ufs-sysfs.c | 2 +- > > drivers/scsi/ufs/ufshcd.c | 28 +++++++++++++++------------- > > drivers/scsi/ufs/ufshcd.h | 2 +- > > 3 files changed, 17 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/scsi/ufs/ufs-sysfs.c b/drivers/scsi/ufs/ufs-sysfs.c > > index 93484408bc40..b86b6a40d7e6 100644 > > --- a/drivers/scsi/ufs/ufs-sysfs.c > > +++ b/drivers/scsi/ufs/ufs-sysfs.c > > @@ -631,7 +631,7 @@ static ssize_t _name##_show(struct device *dev, > > \ > > struct ufs_hba *hba = dev_get_drvdata(dev); \ > > pm_runtime_get_sync(hba->dev); \ > > ret = ufshcd_query_flag(hba, UPIU_QUERY_OPCODE_READ_FLAG, \ > > - QUERY_FLAG_IDN##_uname, &flag); \ > > + QUERY_FLAG_IDN##_uname, 0, &flag); \ > The sysfs entries for flags needs to get an _index argument now Sure, I will fix this in next version. Thanks, Stanley Chu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel