From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 9/9] drm/i915/gen12: Flush LLC
Date: Sun, 03 May 2020 22:36:51 +0100 [thread overview]
Message-ID: <158854181199.15829.41874323192593310@build.alporthouse.com> (raw)
In-Reply-To: <20200430154735.22434-9-mika.kuoppala@linux.intel.com>
Quoting Mika Kuoppala (2020-04-30 16:47:35)
> Request boundary is a global observation point for
> all operations. Thus flush the LLC too.
>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
This one always concerned me for being unbounded in cost: flush all the
LLC lines that might be framebuffer.
We don't mix scanout and LLC, so we've never felt concerned to enable
this flush. [It's definitely not gen12+!]
I would not enable this bit without good cause and verification it
doesn't cost anything for normal render paths.
Still we need to record this bit. For example, I might
suggest it is coupled into the flush-display path directly.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-03 21:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 15:47 [Intel-gfx] [PATCH 1/9] Revert "drm/i915/tgl: Include ro parts of l3 to invalidate" Mika Kuoppala
2020-04-30 15:47 ` [Intel-gfx] [PATCH 2/9] drm/i915/gen12: Fix HDC pipeline flush Mika Kuoppala
2020-05-03 18:24 ` Chris Wilson
2020-05-03 21:20 ` Chris Wilson
2020-05-05 21:02 ` D Scott Phillips
2020-04-30 15:47 ` [Intel-gfx] [PATCH 3/9] drm/i915/gen12: Add L3 fabric flush Mika Kuoppala
2020-05-03 21:22 ` Chris Wilson
2020-04-30 15:47 ` [Intel-gfx] [PATCH 4/9] drm/i915/gen12: Flush L3 Mika Kuoppala
2020-05-03 21:25 ` Chris Wilson
2020-05-05 8:45 ` Mika Kuoppala
2020-04-30 15:47 ` [Intel-gfx] [PATCH 5/9] drm/i915/gen12: Flush AMFS Mika Kuoppala
2020-05-03 21:26 ` Chris Wilson
2020-04-30 15:47 ` [Intel-gfx] [PATCH 6/9] drm/i915/gen12: Invalidate indirect state pointers Mika Kuoppala
2020-05-03 21:29 ` Chris Wilson
2020-05-05 20:53 ` D Scott Phillips
2020-04-30 15:47 ` [Intel-gfx] [PATCH 7/9] drm/i915/gen12: Wait on previous flush on invalidate Mika Kuoppala
2020-05-03 21:31 ` Chris Wilson
2020-04-30 15:47 ` [Intel-gfx] [PATCH 8/9] drm/i915/gen12: Invalidate media state Mika Kuoppala
2020-05-03 21:32 ` Chris Wilson
2020-04-30 15:47 ` [Intel-gfx] [PATCH 9/9] drm/i915/gen12: Flush LLC Mika Kuoppala
2020-05-03 21:36 ` Chris Wilson [this message]
2020-04-30 16:01 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] Revert "drm/i915/tgl: Include ro parts of l3 to invalidate" Patchwork
2020-04-30 16:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-30 16:30 ` Chris Wilson
2020-04-30 23:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-03 21:18 ` [Intel-gfx] [PATCH 1/9] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158854181199.15829.41874323192593310@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.