From: Patchwork <patchwork@emeril.freedesktop.org>
To: "Pankaj Bharadiya" <pankaj.laxminarayan.bharadiya@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prefer drm_WARN* over WARN* (rev3)
Date: Mon, 04 May 2020 20:57:01 -0000 [thread overview]
Message-ID: <158862582134.5817.18283742331274326360@emeril.freedesktop.org> (raw)
In-Reply-To: <20200504181600.18503-1-pankaj.laxminarayan.bharadiya@intel.com>
== Series Details ==
Series: Prefer drm_WARN* over WARN* (rev3)
URL : https://patchwork.freedesktop.org/series/75543/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e13909e4cad6 drm/i915/display/display_power: Prefer drm_WARN_ON over WARN_ON
-:19: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#19:
+ struct drm_i915_private *i915 = container_of(T, struct drm_i915_private, power_domains);
total: 0 errors, 1 warnings, 0 checks, 71 lines checked
1007d6a2e1d7 drm/i915/display/dp: Prefer drm_WARN* over WARN*
6f400e74f722 drm/i915/display/sdvo: Prefer drm_WARN* over WARN*
700fd559057c drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON
f41a15c05f60 drm/i915/gem: Prefer drm_WARN* over WARN*
-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1630:
+ if (drm_WARN_ONCE(&i915->drm, err,
"Unexpected failure to bind target VMA!"))
-:50: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!obj->userptr.mm"
#50: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:238:
+ if (drm_WARN_ON(obj->base.dev, obj->userptr.mm == NULL))
total: 0 errors, 0 warnings, 2 checks, 25 lines checked
57cd2a85fcd4 drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#25: FILE: drivers/gpu/drm/i915/i915_drv.h:1652:
+#define INTEL_DISPLAY_ENABLED(dev_priv) \
+ (drm_WARN_ON(&(dev_priv)->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display)
-:26: WARNING:LONG_LINE: line over 100 characters
#26: FILE: drivers/gpu/drm/i915/i915_drv.h:1653:
+ (drm_WARN_ON(&(dev_priv)->drm, !HAS_DISPLAY(dev_priv)), !i915_modparams.disable_display)
total: 0 errors, 1 warnings, 1 checks, 9 lines checked
adfccabbfb60 drm/i915/pmu: Prefer drm_WARN_ON over WARN_ON
fd2a05cb030c drm/i915/pm: Prefer drm_WARN_ON over WARN_ON
5f984d13c80e drm/i915/runtime_pm: Prefer drm_WARN* over WARN*
-:17: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
+ struct drm_i915_private *i915 = container_of(T, struct drm_i915_private, runtime_pm);
total: 0 errors, 1 warnings, 0 checks, 89 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-04 20:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 18:15 [PATCH v2 0/9] Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 1/9] drm/i915/display/display_power: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 2/9] drm/i915/display/dp: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 3/9] drm/i915/display/sdvo: " Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-08 6:48 ` Jani Nikula
2020-05-08 6:48 ` [Intel-gfx] " Jani Nikula
2020-05-08 7:23 ` Laxminarayan Bharadiya, Pankaj
2020-05-08 7:23 ` [Intel-gfx] " Laxminarayan Bharadiya, Pankaj
2020-05-19 13:41 ` Jani Nikula
2020-05-19 13:41 ` [Intel-gfx] " Jani Nikula
2020-05-19 14:03 ` Laxminarayan Bharadiya, Pankaj
2020-05-19 14:03 ` [Intel-gfx] " Laxminarayan Bharadiya, Pankaj
2020-05-04 18:15 ` [PATCH v2 4/9] drm/i915/display/tc: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 5/9] drm/i915/gem: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 6/9] drm/i915/i915_drv: Prefer drm_WARN_ON over WARN_ON Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 7/9] drm/i915/pmu: " Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:15 ` [PATCH v2 8/9] drm/i915/pm: " Pankaj Bharadiya
2020-05-04 18:15 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 18:16 ` [PATCH v2 9/9] drm/i915/runtime_pm: Prefer drm_WARN* over WARN* Pankaj Bharadiya
2020-05-04 18:16 ` [Intel-gfx] " Pankaj Bharadiya
2020-05-04 20:57 ` Patchwork [this message]
2020-05-04 21:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Prefer drm_WARN* over WARN* (rev3) Patchwork
2020-05-05 11:57 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158862582134.5817.18283742331274326360@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.