* [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT
@ 2020-05-06 3:25 ` Samuel Zou
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Zou @ 2020-05-06 3:25 UTC (permalink / raw)
To: agross, bjorn.andersson, vkoul, sanyog.r.kale, pierre-louis.bossart
Cc: linux-arm-msm, alsa-devel, linux-kernel, Samuel Zou
Fixes coccicheck error:
drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
drivers/soundwire/qcom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index e08a17c..a2a35f7 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -814,7 +814,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, ctrl->irq, NULL,
qcom_swrm_irq_handler,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING |
+ IRQF_ONESHOT,
"soundwire", ctrl);
if (ret) {
dev_err(dev, "Failed to request soundwire irq\n");
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT
@ 2020-05-06 3:25 ` Samuel Zou
0 siblings, 0 replies; 4+ messages in thread
From: Samuel Zou @ 2020-05-06 3:25 UTC (permalink / raw)
To: agross, bjorn.andersson, vkoul, sanyog.r.kale, pierre-louis.bossart
Cc: linux-arm-msm, alsa-devel, linux-kernel, Samuel Zou
Fixes coccicheck error:
drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
no primary handler requested without IRQF_ONESHOT
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Samuel Zou <zou_wei@huawei.com>
---
drivers/soundwire/qcom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index e08a17c..a2a35f7 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -814,7 +814,8 @@ static int qcom_swrm_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, ctrl->irq, NULL,
qcom_swrm_irq_handler,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING |
+ IRQF_ONESHOT,
"soundwire", ctrl);
if (ret) {
dev_err(dev, "Failed to request soundwire irq\n");
--
2.6.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT
2020-05-06 3:25 ` Samuel Zou
@ 2020-05-11 6:15 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-05-11 6:15 UTC (permalink / raw)
To: Samuel Zou
Cc: agross, bjorn.andersson, sanyog.r.kale, pierre-louis.bossart,
linux-arm-msm, alsa-devel, linux-kernel
On 06-05-20, 11:25, Samuel Zou wrote:
> Fixes coccicheck error:
>
> drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT
@ 2020-05-11 6:15 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-05-11 6:15 UTC (permalink / raw)
To: Samuel Zou
Cc: alsa-devel, linux-arm-msm, pierre-louis.bossart, bjorn.andersson,
agross, sanyog.r.kale, linux-kernel
On 06-05-20, 11:25, Samuel Zou wrote:
> Fixes coccicheck error:
>
> drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with
> no primary handler requested without IRQF_ONESHOT
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-11 6:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 3:25 [PATCH -next] soundwire: qcom: Use IRQF_ONESHOT Samuel Zou
2020-05-06 3:25 ` Samuel Zou
2020-05-11 6:15 ` Vinod Koul
2020-05-11 6:15 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.