From: Venkateswara Naralasetty <vnaralas@codeaurora.org> To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Venkateswara Naralasetty <vnaralas@codeaurora.org>, Markus Theil <markus.theil@tu-ilmenau.de> Subject: [PATCHv3] ath10k : Fix channel survey dump Date: Thu, 7 May 2020 08:00:34 +0530 [thread overview] Message-ID: <1588818634-10624-1-git-send-email-vnaralas@codeaurora.org> (raw) Channel active/busy time are showing incorrect(less than previous or sometimes zero) for successive survey dump command. example: Survey data from wlan0 frequency: 5180 MHz [in use] channel active time: 54995 ms channel busy time: 432 ms channel receive time: 0 ms channel transmit time: 59 ms Survey data from wlan0 frequency: 5180 MHz [in use] channel active time: 32592 ms channel busy time: 254 ms channel receive time: 0 ms channel transmit time: 0 ms This patch fix this issue by assigning 'wmi_bss_survey_req_type' as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in FW and send survey data to driver upon the driver request. Wrap around is taken care by FW. hardware used : QCA9984 firmware ver : ver 10.4-3.5.3-00057 hardware used : QCA988X firmware ver : 10.2.4-1.0-00047 Tested-by: Markus Theil <markus.theil@tu-ilmenau.de> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org> --- v3: * Rebased on TOT and added Tested-by drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index a1147cc..9330b52 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -7275,7 +7275,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar, struct ieee80211_channel *channel) { int ret; - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR; + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ; lockdep_assert_held(&ar->conf_mutex); -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Venkateswara Naralasetty <vnaralas@codeaurora.org> To: ath10k@lists.infradead.org Cc: Venkateswara Naralasetty <vnaralas@codeaurora.org>, linux-wireless@vger.kernel.org, Markus Theil <markus.theil@tu-ilmenau.de> Subject: [PATCHv3] ath10k : Fix channel survey dump Date: Thu, 7 May 2020 08:00:34 +0530 [thread overview] Message-ID: <1588818634-10624-1-git-send-email-vnaralas@codeaurora.org> (raw) Channel active/busy time are showing incorrect(less than previous or sometimes zero) for successive survey dump command. example: Survey data from wlan0 frequency: 5180 MHz [in use] channel active time: 54995 ms channel busy time: 432 ms channel receive time: 0 ms channel transmit time: 59 ms Survey data from wlan0 frequency: 5180 MHz [in use] channel active time: 32592 ms channel busy time: 254 ms channel receive time: 0 ms channel transmit time: 0 ms This patch fix this issue by assigning 'wmi_bss_survey_req_type' as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in FW and send survey data to driver upon the driver request. Wrap around is taken care by FW. hardware used : QCA9984 firmware ver : ver 10.4-3.5.3-00057 hardware used : QCA988X firmware ver : 10.2.4-1.0-00047 Tested-by: Markus Theil <markus.theil@tu-ilmenau.de> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org> --- v3: * Rebased on TOT and added Tested-by drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index a1147cc..9330b52 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -7275,7 +7275,7 @@ ath10k_mac_update_bss_chan_survey(struct ath10k *ar, struct ieee80211_channel *channel) { int ret; - enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR; + enum wmi_bss_survey_req_type type = WMI_BSS_SURVEY_REQ_TYPE_READ; lockdep_assert_held(&ar->conf_mutex); -- 2.7.4 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next reply other threads:[~2020-05-07 2:30 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-07 2:30 Venkateswara Naralasetty [this message] 2020-05-07 2:30 ` [PATCHv3] ath10k : Fix channel survey dump Venkateswara Naralasetty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1588818634-10624-1-git-send-email-vnaralas@codeaurora.org \ --to=vnaralas@codeaurora.org \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ --cc=markus.theil@tu-ilmenau.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.