From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D29C35280 for ; Fri, 8 May 2020 03:09:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2B1F208CA for ; Fri, 8 May 2020 03:09:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="qJWvXya2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbgEHDJh (ORCPT ); Thu, 7 May 2020 23:09:37 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:15034 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726612AbgEHDJh (ORCPT ); Thu, 7 May 2020 23:09:37 -0400 X-UUID: 0df33dff915f48cbb6729b023096ccb6-20200508 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zxrf2kTs3eDrMnUH9GHDlgcEj1tiqeJAGC48w/+m1fQ=; b=qJWvXya2sWPurEsqfzvmTYGBlllW26e7WkNmuCUxqPnLV9X1UmbXewnv5H3zyvp6gDEQPfoM+i6yAUlVwlZ83VZJQ4JNXCKzlArkPdIc2183bvpf1y/hOrSPEWi6gL7s4ZE6HFOgXUytHLoeFDfk+265npiFPj9FL4rHtrAuG1Y=; X-UUID: 0df33dff915f48cbb6729b023096ccb6-20200508 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 800839089; Fri, 08 May 2020 11:09:17 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 May 2020 11:09:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 May 2020 11:09:15 +0800 Message-ID: <1588907288.8804.188.camel@mhfsdcap03> Subject: Re: [V5, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Tomasz Figa CC: Sakari Ailus , Linus Walleij , Bartosz Golaszewski , Mauro Carvalho Chehab , Andy Shevchenko , Rob Herring , Mark Rutland , Nicolas Boichat , Matthias Brugger , "Cao Bing Bu" , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , "Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?=" Date: Fri, 8 May 2020 11:08:08 +0800 In-Reply-To: References: <20200502161727.30463-1-dongchun.zhu@mediatek.com> <20200502161727.30463-3-dongchun.zhu@mediatek.com> <20200506151352.GZ9190@paasikivi.fi.intel.com> <1588855524.8804.168.camel@mhfsdcap03> <20200507131220.GC9190@paasikivi.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BDE6ECBE2824A449FE8336CA19D39D8390089DCD152D8C6D3556D62553DB6B162000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgU2FrYXJpLCBUb21hc3osDQoNClRoYW5rcyBmb3IgdGhlIHJldmlldy4NCg0KT24gVGh1LCAy MDIwLTA1LTA3IGF0IDE1OjQ2ICswMjAwLCBUb21hc3ogRmlnYSB3cm90ZToNCj4gSGkgU2FrYXJp LCBEb25nY2h1biwNCj4gDQo+IE9uIFRodSwgTWF5IDcsIDIwMjAgYXQgMzoxMiBQTSBTYWthcmkg QWlsdXMNCj4gPHNha2FyaS5haWx1c0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOg0KPiA+DQo+ID4g SEkgRG9uZ2NodW4sDQo+ID4NCj4gPiBPbiBUaHUsIE1heSAwNywgMjAyMCBhdCAwODo0NToyNFBN ICswODAwLCBEb25nY2h1biBaaHUgd3JvdGU6DQo+ID4gPiBIaSBTYWthcmksDQo+ID4gPg0KPiA+ ID4gVGhhbmtzIGZvciB0aGUgcmV2aWV3Lg0KPiA+ID4NCj4gPiA+IE9uIFdlZCwgMjAyMC0wNS0w NiBhdCAxODoxMyArMDMwMCwgU2FrYXJpIEFpbHVzIHdyb3RlOg0KPiA+ID4gPiBIaSBEb25nY2h1 biwNCj4gPiA+ID4NCj4gPiA+ID4gT24gU3VuLCBNYXkgMDMsIDIwMjAgYXQgMTI6MTc6MjdBTSAr MDgwMCwgRG9uZ2NodW4gWmh1IHdyb3RlOg0KPiA+ID4gPiA+IEFkZCBhIFY0TDIgc3ViLWRldmlj ZSBkcml2ZXIgZm9yIERXOTc2OCB2b2ljZSBjb2lsIG1vdG9yLCBwcm92aWRpbmcNCj4gPiA+ID4g PiBjb250cm9sIHRvIHNldCB0aGUgZGVzaXJlZCBmb2N1cyB2aWEgSUlDIHNlcmlhbCBpbnRlcmZh Y2UuDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEb25nY2h1biBaaHUgPGRv bmdjaHVuLnpodUBtZWRpYXRlay5jb20+DQo+ID4gPiA+ID4gLS0tDQo+ID4gPiA+ID4gIE1BSU5U QUlORVJTICAgICAgICAgICAgICAgIHwgICAxICsNCj4gPiA+ID4gPiAgZHJpdmVycy9tZWRpYS9p MmMvS2NvbmZpZyAgfCAgMTEgKysNCj4gPiA+ID4gPiAgZHJpdmVycy9tZWRpYS9pMmMvTWFrZWZp bGUgfCAgIDEgKw0KPiA+ID4gPiA+ICBkcml2ZXJzL21lZGlhL2kyYy9kdzk3NjguYyB8IDQ0MCAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiA+ID4gPiAg NCBmaWxlcyBjaGFuZ2VkLCA0NTMgaW5zZXJ0aW9ucygrKQ0KPiA+ID4gPiA+ICBjcmVhdGUgbW9k ZSAxMDA2NDQgZHJpdmVycy9tZWRpYS9pMmMvZHc5NzY4LmMNCj4gPiA+ID4gPg0KPiA+ID4gPiA+ IGRpZmYgLS1naXQgYS9NQUlOVEFJTkVSUyBiL01BSU5UQUlORVJTDQo+ID4gPiA+ID4gaW5kZXgg OGQ3MmM0MS4uYzkyZGM5OSAxMDA2NDQNCj4gPiA+ID4gPiAtLS0gYS9NQUlOVEFJTkVSUw0KPiA+ ID4gPiA+ICsrKyBiL01BSU5UQUlORVJTDQo+ID4gPiA+ID4gQEAgLTUxNTcsNiArNTE1Nyw3IEBA IEw6ICBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcNCj4gPiA+ID4gPiAgUzogICAgICAgTWFp bnRhaW5lZA0KPiA+ID4gPiA+ICBUOiAgICAgICBnaXQgZ2l0Oi8vbGludXh0di5vcmcvbWVkaWFf dHJlZS5naXQNCj4gPiA+ID4gPiAgRjogICAgICAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL21lZGlhL2kyYy9kb25nd29vbixkdzk3NjgueWFtbA0KPiA+ID4gPiA+ICtGOiAgICAg ICBkcml2ZXJzL21lZGlhL2kyYy9kdzk3NjguYw0KPiA+ID4gPiA+DQo+ID4gPiA+ID4gIERPTkdX T09OIERXOTgwNyBMRU5TIFZPSUNFIENPSUwgRFJJVkVSDQo+ID4gPiA+ID4gIE06ICAgICAgIFNh a2FyaSBBaWx1cyA8c2FrYXJpLmFpbHVzQGxpbnV4LmludGVsLmNvbT4NCj4gPiA+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9pMmMvS2NvbmZpZyBiL2RyaXZlcnMvbWVkaWEvaTJjL0tj b25maWcNCj4gPiA+ID4gPiBpbmRleCAxMjVkNTk2Li42YTNmOWRhIDEwMDY0NA0KPiA+ID4gPiA+ IC0tLSBhL2RyaXZlcnMvbWVkaWEvaTJjL0tjb25maWcNCj4gPiA+ID4gPiArKysgYi9kcml2ZXJz L21lZGlhL2kyYy9LY29uZmlnDQo+ID4gPiA+ID4gQEAgLTEwNDAsNiArMTA0MCwxNyBAQCBjb25m aWcgVklERU9fRFc5NzE0DQo+ID4gPiA+ID4gICAgIGNhcGFiaWxpdHkuIFRoaXMgaXMgZGVzaWdu ZWQgZm9yIGxpbmVhciBjb250cm9sIG9mDQo+ID4gPiA+ID4gICAgIHZvaWNlIGNvaWwgbW90b3Jz LCBjb250cm9sbGVkIHZpYSBJMkMgc2VyaWFsIGludGVyZmFjZS4NCj4gPiA+ID4gPg0KPiA+ID4g PiA+ICtjb25maWcgVklERU9fRFc5NzY4DQo+ID4gPiA+ID4gKyB0cmlzdGF0ZSAiRFc5NzY4IGxl bnMgdm9pY2UgY29pbCBzdXBwb3J0Ig0KPiA+ID4gPiA+ICsgZGVwZW5kcyBvbiBJMkMgJiYgVklE RU9fVjRMMiAmJiBNRURJQV9DT05UUk9MTEVSDQo+ID4gPiA+ID4gKyBkZXBlbmRzIG9uIFZJREVP X1Y0TDJfU1VCREVWX0FQSQ0KPiA+ID4gPg0KPiA+ID4gPiBQbGVhc2UgY2hlY2sgaG93IHRoaXMg d29ya3MgaW4gdGhlIG1lZGlhIHRyZWUgbWFzdGVyIGJyYW5jaCBub3cgLS0tIGl0J3MNCj4gPiA+ ID4gbGFyZ2VseSBzZWxlY3QgYmFzZWQuDQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gVGhlIGFjdHVh dG9yIGRyaXZlciB1c2VzIHNvbWUgc3RydWN0dXJlcyB0aGF0IHJlcXVpcmUgdGhlDQo+ID4gPiBW SURFT19WNEwyX1NVQkRFVl9BUEkgY29kZSwgc28gaGVyZSB3ZSBhZGQgVklERU9fVjRMMl9TVUJE RVZfQVBJDQo+ID4gPiBkZXBlbmRlbmN5IHRvIGF2b2lkIHBvc3NpYmxlIGJ1aWxkIGVycm9yIHdo ZW4gaXQncyBub3QgZW5hYmxlZC4NCj4gPg0KPiA+IFBsZWFzZSBtYWtlIHN1cmUgdGhpcyB3b3Jr cyB3aXRoIGN1cnJlbnQgbWVkaWEgdHJlZSBtYXN0ZXIuIFJpZ2h0IG5vdyBpdA0KPiA+IGRvZXMg bm90Lg0KPiA+DQo+IA0KPiBEb25nY2h1biwgYXMgU2FrYXJpIHNhaWQsIHBsZWFzZSBtYWtlIHN1 cmUgdG8gYmFzZSB0aGUgcGF0Y2hlcyBvbiB0aGUNCj4gbWFzdGVyIGJyYW5jaCBvZiB0aGUgbWVk aWEgdHJlZS4NCj4gKGh0dHBzOi8vZ2l0LmxpbnV4dHYub3JnL21lZGlhX3RyZWUuZ2l0LykuIFRo ZSBhcHByb2FjaCBmb3IgS2NvbmZpZw0KPiBkZXBlbmRlbmN5IHNlbGVjdGlvbiB0aGVyZSBzZWVt cyB0byBoYXZlIGNoYW5nZWQgcmVjZW50bHkuDQo+IA0KDQpJIHNlYXJjaGVkIHRoZSBwYXRjaGVz IG9uIHRoZSBtZWRpYSB0cmVlIG1hc3RlciBicmFuY2guDQpJdCBzZWVtcyB0aGF0IHdlIG5lZWQg dG8gcmVtb3ZlIHRoZSBWSURFT19WNEwyX1NVQkRFVl9BUEkgZGVwZW5kZW5jeSBpbg0KS2NvbmZp ZywgYW5kIGFkZCAjaWZkZWYgQ09ORklHX1ZJREVPX1Y0TDJfU1VCREVWX0FQSSB0byBpbmNsdWRl DQp2NGwyLXN1YmRldiBjb2RlLg0KVGhlIGNoYW5nZSBtYWlubHkgaXMgdG8gbWFrZSBidWlsZCBw YXNzLCBhbmQgZG9uJ3QgcmV0dXJuIEVOT1RUWSBpZg0KU1VCREVWX0FQSSBpcyBub3Qgc2V0Lg0K QW0gSSByaWdodD8NCg0KPiA+ID4NCj4gPiA+ID4gSW4gZ2VuZXJhbCB0aGUgcGF0Y2ggc2VlbXMg ZmluZSB0byBtZSwgYnV0IHBsZWFzZSBzZWUgdGhlIG90aGVyIGNvbW1lbnRzDQo+ID4gPiA+IGJl bG93LCB0b28uDQo+ID4gPiA+DQo+ID4gPiA+ID4gKyBkZXBlbmRzIG9uIFBNDQo+ID4gPiA+ID4g KyBoZWxwDQo+ID4gPiA+ID4gKyAgIFRoaXMgaXMgYSBkcml2ZXIgZm9yIHRoZSBEVzk3NjggY2Ft ZXJhIGxlbnMgdm9pY2UgY29pbC4NCj4gPiA+ID4gPiArICAgRFc5NzY4IGlzIGEgMTAgYml0IERB QyB3aXRoIDEwMG1BIG91dHB1dCBjdXJyZW50IHNpbmsNCj4gPiA+ID4gPiArICAgY2FwYWJpbGl0 eS4gVGhpcyBpcyBkZXNpZ25lZCBmb3IgbGluZWFyIGNvbnRyb2wgb2YNCj4gPiA+ID4gPiArICAg dm9pY2UgY29pbCBtb3RvcnMsIGNvbnRyb2xsZWQgdmlhIEkyQyBzZXJpYWwgaW50ZXJmYWNlLg0K PiA+ID4gPiA+ICsNCj4gPiA+ID4gPiAgY29uZmlnIFZJREVPX0RXOTgwN19WQ00NCj4gPiA+ID4g PiAgIHRyaXN0YXRlICJEVzk4MDcgbGVucyB2b2ljZSBjb2lsIHN1cHBvcnQiDQo+ID4gPiA+ID4g ICBkZXBlbmRzIG9uIEkyQyAmJiBWSURFT19WNEwyICYmIE1FRElBX0NPTlRST0xMRVINCj4gPiA+ ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9pMmMvTWFrZWZpbGUgYi9kcml2ZXJzL21l ZGlhL2kyYy9NYWtlZmlsZQ0KPiA+ID4gPiA+IGluZGV4IDc3YmY3ZDAuLjQwNTc0NzYgMTAwNjQ0 DQo+ID4gPiA+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9pMmMvTWFrZWZpbGUNCj4gPiA+ID4gPiAr KysgYi9kcml2ZXJzL21lZGlhL2kyYy9NYWtlZmlsZQ0KPiA+ID4gPiA+IEBAIC0yNCw2ICsyNCw3 IEBAIG9iai0kKENPTkZJR19WSURFT19TQUE2NzUySFMpICs9IHNhYTY3NTJocy5vDQo+ID4gPiA+ ID4gIG9iai0kKENPTkZJR19WSURFT19BRDU4MjApICArPSBhZDU4MjAubw0KPiA+ID4gPiA+ICBv YmotJChDT05GSUdfVklERU9fQUs3Mzc1KSAgKz0gYWs3Mzc1Lm8NCj4gPiA+ID4gPiAgb2JqLSQo Q09ORklHX1ZJREVPX0RXOTcxNCkgICs9IGR3OTcxNC5vDQo+ID4gPiA+ID4gK29iai0kKENPTkZJ R19WSURFT19EVzk3NjgpICArPSBkdzk3Njgubw0KPiA+ID4gPiA+ICBvYmotJChDT05GSUdfVklE RU9fRFc5ODA3X1ZDTSkgICs9IGR3OTgwNy12Y20ubw0KPiA+ID4gPiA+ICBvYmotJChDT05GSUdf VklERU9fQURWNzE3MCkgKz0gYWR2NzE3MC5vDQo+ID4gPiA+ID4gIG9iai0kKENPTkZJR19WSURF T19BRFY3MTc1KSArPSBhZHY3MTc1Lm8NCj4gPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9t ZWRpYS9pMmMvZHc5NzY4LmMgYi9kcml2ZXJzL21lZGlhL2kyYy9kdzk3NjguYw0KPiA+ID4gPiA+ IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4gPiA+ID4gaW5kZXggMDAwMDAwMC4uZGQ2ODUzNA0K PiA+ID4gPiA+IC0tLSAvZGV2L251bGwNCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL21lZGlhL2ky Yy9kdzk3NjguYw0KPiA+ID4gPiA+IEBAIC0wLDAgKzEsNDQwIEBADQo+ID4gPiA+ID4gKy8vIFNQ RFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4wDQo+ID4gPiA+ID4gKy8vIENvcHlyaWdodCAo YykgMjAyMCBNZWRpYVRlayBJbmMuDQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsjaW5jbHVkZSA8 bGludXgvZGVsYXkuaD4NCj4gPiA+ID4gPiArI2luY2x1ZGUgPGxpbnV4L2kyYy5oPg0KPiA+ID4g PiA+ICsjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+DQo+ID4gPiA+ID4gKyNpbmNsdWRlIDxsaW51 eC9wbV9ydW50aW1lLmg+DQo+ID4gPiA+ID4gKyNpbmNsdWRlIDxsaW51eC9yZWd1bGF0b3IvY29u c3VtZXIuaD4NCj4gPiA+ID4gPiArI2luY2x1ZGUgPG1lZGlhL3Y0bDItYXN5bmMuaD4NCj4gPiA+ ID4gPiArI2luY2x1ZGUgPG1lZGlhL3Y0bDItY3RybHMuaD4NCj4gPiA+ID4gPiArI2luY2x1ZGUg PG1lZGlhL3Y0bDItZGV2aWNlLmg+DQo+ID4gPiA+ID4gKyNpbmNsdWRlIDxtZWRpYS92NGwyLXN1 YmRldi5oPg0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArI2RlZmluZSBEVzk3NjhfTkFNRSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJkdzk3NjgiDQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5 NzY4X01BWF9GT0NVU19QT1MgICAgICAgICAgICAgICAgICAgICAoMTAyNCAtIDEpDQo+ID4gPiA+ ID4gKy8qDQo+ID4gPiA+ID4gKyAqIFRoaXMgc2V0cyB0aGUgbWluaW11bSBncmFudWxhcml0eSBm b3IgdGhlIGZvY3VzIHBvc2l0aW9ucy4NCj4gPiA+ID4gPiArICogQSB2YWx1ZSBvZiAxIGdpdmVz IG1heGltdW0gYWNjdXJhY3kgZm9yIGEgZGVzaXJlZCBmb2N1cyBwb3NpdGlvbg0KPiA+ID4gPiA+ ICsgKi8NCj4gPiA+ID4gPiArI2RlZmluZSBEVzk3NjhfRk9DVVNfU1RFUFMgICAgICAgICAgICAg ICAgICAgICAgIDENCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKy8qDQo+ID4gPiA+ID4gKyAqIFJp bmcgY29udHJvbCBhbmQgUG93ZXIgY29udHJvbCByZWdpc3Rlcg0KPiA+ID4gPiA+ICsgKiBCaXRb MV0gUklOR19FTg0KPiA+ID4gPiA+ICsgKiAwOiBEaXJlY3QgbW9kZQ0KPiA+ID4gPiA+ICsgKiAx OiBBQUMgbW9kZSAocmluZ2luZyBjb250cm9sIG1vZGUpDQo+ID4gPiA+ID4gKyAqIEJpdFswXSBQ RA0KPiA+ID4gPiA+ICsgKiAwOiBOb3JtYWwgb3BlcmF0aW9uIG1vZGUNCj4gPiA+ID4gPiArICog MTogUG93ZXIgZG93biBtb2RlDQo+ID4gPiA+ID4gKyAqIERXOTc2OCByZXF1aXJlcyB3YWl0aW5n IHRpbWUgb2YgVG9wciBhZnRlciBQRCByZXNldCB0YWtlcyBwbGFjZS4NCj4gPiA+ID4gPiArICov DQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5NzY4X1JJTkdfUERfQ09OVFJPTF9SRUcgICAgICAgICAg ICAgICAweDAyDQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5NzY4X1BEX01PREVfT0ZGICAgICAgICAg ICAgICAgICAgICAgICAweDAwDQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5NzY4X1BEX01PREVfRU4g ICAgICAgICAgICAgICAgICAgICAgICBCSVQoMCkNCj4gPiA+ID4gPiArI2RlZmluZSBEVzk3Njhf QUFDX01PREVfRU4gICAgICAgICAgICAgICAgICAgICAgIEJJVCgxKQ0KPiA+ID4gPiA+ICsNCj4g PiA+ID4gPiArLyoNCj4gPiA+ID4gPiArICogRFc5NzY4IHNlcGFyYXRlcyB0d28gcmVnaXN0ZXJz IHRvIGNvbnRyb2wgdGhlIFZDTSBwb3NpdGlvbi4NCj4gPiA+ID4gPiArICogT25lIGZvciBNU0Ig dmFsdWUsIGFub3RoZXIgaXMgTFNCIHZhbHVlLg0KPiA+ID4gPiA+ICsgKiBEQUNfTVNCOiBEWzk6 OF0gKEFERDogMHgwMykNCj4gPiA+ID4gPiArICogREFDX0xTQjogRFs3OjBdIChBREQ6IDB4MDQp DQo+ID4gPiA+ID4gKyAqIERbOTowXSBEQUMgZGF0YSBpbnB1dDogcG9zaXRpdmUgb3V0cHV0IGN1 cnJlbnQgPSBEWzk6MF0gLyAxMDIzICogMTAwW21BXQ0KPiA+ID4gPiA+ICsgKi8NCj4gPiA+ID4g PiArI2RlZmluZSBEVzk3NjhfTVNCX0FERFIgICAgICAgICAgICAgICAgICAgICAgICAgIDB4MDMN Cj4gPiA+ID4gPiArI2RlZmluZSBEVzk3NjhfTFNCX0FERFIgICAgICAgICAgICAgICAgICAgICAg ICAgIDB4MDQNCj4gPiA+ID4gPiArI2RlZmluZSBEVzk3NjhfU1RBVFVTX0FERFIgICAgICAgICAg ICAgICAgICAgICAgIDB4MDUNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKy8qDQo+ID4gPiA+ID4g KyAqIEFBQyBtb2RlIGNvbnRyb2wgJiBwcmVzY2FsZSByZWdpc3Rlcg0KPiA+ID4gPiA+ICsgKiBC aXRbNzo1XSBOYW1lbHkgQUNbMjowXSwgZGVjaWRlIHRoZSBWQ00gbW9kZSBhbmQgb3BlcmF0aW9u IHRpbWUuDQo+ID4gPiA+ID4gKyAqIDAwMCBEaXJlY3QoZGVmYXVsdCkNCj4gPiA+ID4gPiArICog MDAxIEFBQzIgMC40OHhUdmliDQo+ID4gPiA+ID4gKyAqIDAxMCBBQUMzIDAuNzB4VHZpYg0KPiA+ ID4gPiA+ICsgKiAwMTEgQUFDNCAwLjc1eFR2aWINCj4gPiA+ID4gPiArICogMTAwIFJlc2VydmVk DQo+ID4gPiA+ID4gKyAqIDEwMSBBQUM4IDEuMTN4VHZpYg0KPiA+ID4gPiA+ICsgKiAxMTAgUmVz ZXJ2ZWQNCj4gPiA+ID4gPiArICogMTExIFJlc2VydmVkDQo+ID4gPiA+ID4gKyAqIEJpdFsyOjBd IE5hbWVseSBQUkVTQ1syOjBdLCBzZXQgdGhlIGludGVybmFsIGNsb2NrIGRpdmlkaW5nIHJhdGUg YXMgZm9sbG93Lg0KPiA+ID4gPiA+ICsgKiAwMDAgMg0KPiA+ID4gPiA+ICsgKiAwMDEgMShkZWZh dWx0KQ0KPiA+ID4gPiA+ICsgKiAwMTAgMS8yDQo+ID4gPiA+ID4gKyAqIDAxMSAxLzQNCj4gPiA+ ID4gPiArICogMTAwIDgNCj4gPiA+ID4gPiArICogMTAxIDQNCj4gPiA+ID4gPiArICogMTEwIFJl c2VydmVkDQo+ID4gPiA+ID4gKyAqIDExMSBSZXNlcnZlZA0KPiA+ID4gPiA+ICsgKi8NCj4gPiA+ ID4gPiArI2RlZmluZSBEVzk3NjhfQUFDX1BSRVNDX1JFRyAgICAgICAgICAgICAgICAgICAgIDB4 MDYNCj4gPiA+ID4gPiArI2RlZmluZSBEVzk3NjhfQUFDM19TRUxFQ1RfRElWSURJTkdfUkFURV8x ICAgICAgIDB4NDENCj4gPiA+ID4NCj4gPiA+ID4gSSBndWVzcyB3ZSBjYW4gc3RhcnQgd2l0aCB0 aGVzZSB2YWx1ZXMuIEJ1dCBJIGNhbid0IHRoaW5rIG9mIGFub3RoZXIgb3B0aW9uDQo+ID4gPiA+ IHRoYW4gcHV0dGluZyB0aGVtIGludG8gRFQgaWYgdGhlcmUgYXJlIGRpZmZlcmVuY2VzIGJldHdl ZW4gd2hhdCBoYXJkd2FyZQ0KPiA+ID4gPiBwbGF0Zm9ybXMgcmVxdWlyZS4NCj4gPiA+ID4NCj4g PiA+DQo+ID4gPiBMZXQncyBoYXZlIGEgZGlzY3Vzc2lvbiBhYm91dCB0aGlzLg0KPiA+ID4gTm93 IHRoZXNlIG5vbi1kZWZhdWx0IHJlZ2lzdGVyIHNldHRpbmdzIHJlcHJlc2VudCBvbmUgQUFDIG9w ZXJhdGlvbg0KPiA+ID4gbW9kZSwgdGhpcyBpcyBvbmUgb3B0aW9uIGFuZCB3b3JrcyBmb3IgYSBn aXZlbiBsZW5zIG9yIGEgbW9kdWxlLg0KPiA+ID4gSWYgc29tZXRpbWUgaW4gdGhlIGZ1dHVyZSBo YXJkd2FyZSBwbGF0Zm9ybXMgcmVxdWlyZSBhbm90aGVyIGRpZmZlcmVudA0KPiA+ID4gc2V0dGlu Z3MsIHRoZW4gRFQgcHJvcGVydGllcyBtYXkgbmVlZCB0byBiZSBjcmVhdGVkLg0KPiA+DQo+ID4g SWYgdGhlc2UgdmFsdWVzIGluZGVlZCBhcmUgc3BlY2lmaWMgdG8gYSBnaXZlbiBsZW5zIChhbmQg cHJlc3VtYWJseSBhbHNvIGENCj4gPiBzcHJpbmcpLCB0aGVuIEknZCBwdXQgdGhlbSB0byBEVCBy aWdodCBub3cgLS0tIHdlIGRvbid0IGhhdmUgZHJpdmVycyBmb3INCj4gPiB0aGVzZSBjb21wb25l bnRzIHRoZSBkcml2ZXJzIG9mIHdoaWNoIGNvdWxkIGhvbGQgdGhpcyBpbmZvcm1hdGlvbiwgbm9y IGl0DQo+ID4gbWFrZXMgc2Vuc2UgdG8gYWRkIHRoZW0ganVzdCBmb3IgdGhhdC4NCj4gPg0KPiAN Cj4gSSB0ZW5kIHRvIHN0YXkgb24gdGhlIGNvbnNlcnZhdGl2ZSBzaWRlIGFuZCBvbmx5IGFkZCBE VCBwcm9wZXJ0aWVzDQo+IG9uY2UgdGhlcmUgaXMgcmVhbGx5IGEgbmVlZCB0byBkbyBzby4gUmln aHQgbm93IHdlIGhhdmVuJ3Qgc2VlbiBhbnkNCj4gc3lzdGVtIHdoaWNoIHdvdWxkIHVzZSBkaWZm ZXJlbnQgdmFsdWVzIG9mIHRoZXNlIHBhcmFtZXRlcnMuDQo+IA0KPiBCZXN0IHJlZ2FyZHMsDQo+ IFRvbWFzeg0KPiANCj4gPiA+DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsvKg0KPiA+ID4gPiA+ ICsgKiBWQ00gcGVyaW9kIG9mIHZpYnJhdGlvbiByZWdpc3Rlcg0KPiA+ID4gPiA+ICsgKiBCaXRb NTowXSBEZWZpbmVkIGFzIFZDTSByaXNpbmcgcGVyaW9kaWMgdGltZSAoVHZpYikgdG9nZXRoZXIg d2l0aCBQUkVTQ1syOjBdDQo+ID4gPiA+ID4gKyAqIFR2aWIgPSAoNi4zbXMgKyBBQUNUWzU6MF0g KiAwLjFtcykgKiBEaXZpZGluZyBSYXRlDQo+ID4gPiA+ID4gKyAqIERpdmlkaW5nIFJhdGUgaXMg dGhlIGludGVybmFsIGNsb2NrIGRpdmlkaW5nIHJhdGUgdGhhdCBpcyBkZWZpbmVkIGF0DQo+ID4g PiA+ID4gKyAqIFBSRVNDQUxFIHJlZ2lzdGVyIChBREQ6IDB4MDYpDQo+ID4gPiA+ID4gKyAqLw0K PiA+ID4gPiA+ICsjZGVmaW5lIERXOTc2OF9BQUNfVElNRV9SRUcgICAgICAgICAgICAgICAgICAg ICAgMHgwNw0KPiA+ID4gPiA+ICsjZGVmaW5lIERXOTc2OF9BQUNUX0NOVCAgICAgICAgICAgICAg ICAgICAgICAgICAgMHgzOQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArLyoNCj4gPiA+ID4gPiAr ICogRFc5NzY4IHJlcXVpcmVzIHdhaXRpbmcgdGltZSAoZGVsYXkgdGltZSkgb2YgdF9PUFIgYWZ0 ZXIgcG93ZXItdXAsDQo+ID4gPiA+ID4gKyAqIG9yIGluIHRoZSBjYXNlIG9mIFBEIHJlc2V0IHRh a2luZyBwbGFjZS4NCj4gPiA+ID4gPiArICovDQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5NzY4X1Rf T1BSX1VTICAgICAgICAgICAgICAgICAgICAgICAgICAxMDAwDQo+ID4gPiA+ID4gKw0KPiA+ID4g PiA+ICsvKg0KPiA+ID4gPiA+ICsgKiBUaGlzIGFjdHMgYXMgdGhlIG1pbmltdW0gZ3JhbnVsYXJp dHkgb2YgbGVucyBtb3ZlbWVudC4NCj4gPiA+ID4gPiArICogS2VlcCB0aGlzIHZhbHVlIHBvd2Vy IG9mIDIsIHNvIHRoZSBjb250cm9sIHN0ZXBzIGNhbiBiZQ0KPiA+ID4gPiA+ICsgKiB1bmlmb3Jt bHkgYWRqdXN0ZWQgZm9yIGdyYWR1YWwgbGVucyBtb3ZlbWVudCwgd2l0aCBkZXNpcmVkDQo+ID4g PiA+ID4gKyAqIG51bWJlciBvZiBjb250cm9sIHN0ZXBzLg0KPiA+ID4gPiA+ICsgKi8NCj4gPiA+ ID4gPiArI2RlZmluZSBEVzk3NjhfTU9WRV9TVEVQUyAgICAgICAgICAgICAgICAgICAgICAgIDE2 DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsvKg0KPiA+ID4gPiA+ICsgKiBEVzk3NjhfQUFDX1BS RVNDX1JFRyAmIERXOTc2OF9BQUNfVElNRV9SRUcgZGV0ZXJtaW5lIFZDTSBvcGVyYXRpb24gdGlt ZS4NCj4gPiA+ID4gPiArICogSWYgRFc5NzY4X0FBQ19QUkVTQ19SRUcgaXMgMHg0MSwgYW5kIERX OTc2OF9BQUNfVElNRV9SRUcgaXMgMHgzOSwgVkNNIG1vZGUNCj4gPiA+ID4gPiArICogd291bGQg YmUgQUFDMywgT3BlcmF0aW9uIFRpbWUgd291bGQgYmUgMC43MHhUdmliLCB0aGF0IGlzIDguNDBt cy4NCj4gPiA+ID4gPiArICovDQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5NzY4X01PVkVfREVMQVlf VVMgICAgICAgICAgICAgICAgICAgICA4NDAwDQo+ID4gPiA+ID4gKyNkZWZpbmUgRFc5NzY4X1NU QUJMRV9USU1FX1VTICAgICAgICAgICAgICAgICAgICAyMDAwMA0KPiA+ID4gPiA+ICsNCj4gPiA+ ID4gPiArc3RhdGljIGNvbnN0IGNoYXIgKiBjb25zdCBkdzk3Njhfc3VwcGx5X25hbWVzW10gPSB7 DQo+ID4gPiA+ID4gKyAidmluIiwgIC8qIEkyQyBJL08gaW50ZXJmYWNlIHBvd2VyICovDQo+ID4g PiA+ID4gKyAidmRkIiwgIC8qIFZDTSBwb3dlciAqLw0KPiA+ID4gPiA+ICt9Ow0KPiA+ID4gPiA+ ICsNCj4gPiA+ID4gPiArLyogZHc5NzY4IGRldmljZSBzdHJ1Y3R1cmUgKi8NCj4gPiA+ID4gPiAr c3RydWN0IGR3OTc2OCB7DQo+ID4gPiA+ID4gKyBzdHJ1Y3QgcmVndWxhdG9yX2J1bGtfZGF0YSBz dXBwbGllc1tBUlJBWV9TSVpFKGR3OTc2OF9zdXBwbHlfbmFtZXMpXTsNCj4gPiA+ID4gPiArIHN0 cnVjdCB2NGwyX2N0cmxfaGFuZGxlciBjdHJsczsNCj4gPiA+ID4gPiArIHN0cnVjdCB2NGwyX2N0 cmwgKmZvY3VzOw0KPiA+ID4gPiA+ICsgc3RydWN0IHY0bDJfc3ViZGV2IHNkOw0KPiA+ID4gPiA+ ICt9Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3RhdGljIGlubGluZSBzdHJ1Y3QgZHc5NzY4 ICp0b19kdzk3Njgoc3RydWN0IHY0bDJfY3RybCAqY3RybCkNCj4gPiA+ID4gPiArew0KPiA+ID4g PiA+ICsgcmV0dXJuIGNvbnRhaW5lcl9vZihjdHJsLT5oYW5kbGVyLCBzdHJ1Y3QgZHc5NzY4LCBj dHJscyk7DQo+ID4gPiA+ID4gK30NCj4gPiA+ID4NCj4gPiA+ID4gVGhpcyBpcyB1c2VkIGluIGEg c2luZ2xlIHBsYWNlLiBJJ2QganVzdCB1c2UgY29udGFpbmVyX29mKCkgZGlyZWN0bHkgdGhlcmUu DQo+ID4gPiA+DQo+ID4gPg0KPiA+ID4gVGhhbmtzIGZvciB0aGUgcmVtaW5kZXIuDQo+ID4gPiBG aXhlZCBpbiBuZXh0IHJlbGVhc2UuDQo+ID4gPg0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3Rh dGljIGlubGluZSBzdHJ1Y3QgZHc5NzY4ICpzZF90b19kdzk3Njgoc3RydWN0IHY0bDJfc3ViZGV2 ICpzdWJkZXYpDQo+ID4gPiA+ID4gK3sNCj4gPiA+ID4gPiArIHJldHVybiBjb250YWluZXJfb2Yo c3ViZGV2LCBzdHJ1Y3QgZHc5NzY4LCBzZCk7DQo+ID4gPiA+ID4gK30NCj4gPiA+ID4gPiArDQo+ ID4gPiA+ID4gK3N0cnVjdCByZWd2YWxfbGlzdCB7DQo+ID4gPiA+ID4gKyB1OCByZWdfbnVtOw0K PiA+ID4gPiA+ICsgdTggdmFsdWU7DQo+ID4gPiA+ID4gK307DQo+ID4gPiA+ID4gKw0KPiA+ID4g PiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ3ZhbF9saXN0IGR3OTc2OF9pbml0X3JlZ3NbXSA9 IHsNCj4gPiA+ID4gPiArIHtEVzk3NjhfUklOR19QRF9DT05UUk9MX1JFRywgRFc5NzY4X0FBQ19N T0RFX0VOfSwNCj4gPiA+ID4gPiArIHtEVzk3NjhfQUFDX1BSRVNDX1JFRywgRFc5NzY4X0FBQzNf U0VMRUNUX0RJVklESU5HX1JBVEVfMX0sDQo+ID4gPiA+ID4gKyB7RFc5NzY4X0FBQ19USU1FX1JF RywgRFc5NzY4X0FBQ1RfQ05UfSwNCj4gPiA+ID4gPiArfTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ ID4gK3N0YXRpYyBpbnQgZHc5NzY4X3dyaXRlX2FycmF5KHN0cnVjdCBkdzk3NjggKmR3OTc2OCwN Cj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgcmVndmFsX2xp c3QgKnZhbHMsIHNpemVfdCBsZW4pDQo+ID4gPiA+ID4gK3sNCj4gPiA+ID4gPiArIHN0cnVjdCBp MmNfY2xpZW50ICpjbGllbnQgPSB2NGwyX2dldF9zdWJkZXZkYXRhKCZkdzk3NjgtPnNkKTsNCj4g PiA+ID4gPiArIHVuc2lnbmVkIGludCBpOw0KPiA+ID4gPiA+ICsgaW50IHJldDsNCj4gPiA+ID4g PiArDQo+ID4gPiA+ID4gKyBmb3IgKGkgPSAwOyBpIDwgbGVuOyBpKyspIHsNCj4gPiA+ID4gPiAr ICAgICAgICAgcmV0ID0gaTJjX3NtYnVzX3dyaXRlX2J5dGVfZGF0YShjbGllbnQsIHZhbHNbaV0u cmVnX251bSwNCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB2YWxzW2ldLnZhbHVlKTsNCj4gPiA+ID4gPiArICAgICAgICAgaWYgKHJldCA8IDApDQo+ ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsNCj4gPiA+ID4gPiArIH0NCj4g PiA+ID4gPiArIHJldHVybiAwOw0KPiA+ID4gPiA+ICt9DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ ICtzdGF0aWMgaW50IGR3OTc2OF9zZXRfZGFjKHN0cnVjdCBkdzk3NjggKmR3OTc2OCwgdTE2IHZh bCkNCj4gPiA+ID4gPiArew0KPiA+ID4gPiA+ICsgc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCA9 IHY0bDJfZ2V0X3N1YmRldmRhdGEoJmR3OTc2OC0+c2QpOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4g PiArIC8qIFdyaXRlIFZDTSBwb3NpdGlvbiB0byByZWdpc3RlcnMgKi8NCj4gPiA+ID4gPiArIHJl dHVybiBpMmNfc21idXNfd3JpdGVfd29yZF9zd2FwcGVkKGNsaWVudCwgRFc5NzY4X01TQl9BRERS LCB2YWwpOw0KPiA+ID4gPiA+ICt9DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICtzdGF0aWMgaW50 IGR3OTc2OF9pbml0KHN0cnVjdCBkdzk3NjggKmR3OTc2OCkNCj4gPiA+ID4gPiArew0KPiA+ID4g PiA+ICsgc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCA9IHY0bDJfZ2V0X3N1YmRldmRhdGEoJmR3 OTc2OC0+c2QpOw0KPiA+ID4gPiA+ICsgaW50IHJldCwgdmFsOw0KPiA+ID4gPiA+ICsNCj4gPiA+ ID4gPiArIC8qIFJlc2V0IERXOTc2OF9SSU5HX1BEX0NPTlRST0xfUkVHIHRvIGRlZmF1bHQgc3Rh dHVzIDB4MDAgKi8NCj4gPiA+ID4gPiArIHJldCA9IGkyY19zbWJ1c193cml0ZV9ieXRlX2RhdGEo Y2xpZW50LCBEVzk3NjhfUklOR19QRF9DT05UUk9MX1JFRywNCj4gPiA+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgRFc5NzY4X1BEX01PREVfT0ZGKTsNCj4gPiA+ID4gPiAr IGlmIChyZXQgPCAwKQ0KPiA+ID4gPiA+ICsgICAgICAgICByZXR1cm4gcmV0Ow0KPiA+ID4gPiA+ ICsNCj4gPiA+ID4gPiArIC8qDQo+ID4gPiA+ID4gKyAgKiBEVzk3NjkgcmVxdWlyZXMgd2FpdGlu ZyBkZWxheSB0aW1lIG9mIHRfT1BSDQo+ID4gPiA+ID4gKyAgKiBhZnRlciBQRCByZXNldCB0YWtl cyBwbGFjZS4NCj4gPiA+ID4gPiArICAqLw0KPiA+ID4gPiA+ICsgdXNsZWVwX3JhbmdlKERXOTc2 OF9UX09QUl9VUywgRFc5NzY4X1RfT1BSX1VTICsgMTAwKTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ ID4gKyByZXQgPSBkdzk3Njhfd3JpdGVfYXJyYXkoZHc5NzY4LCBkdzk3NjhfaW5pdF9yZWdzLA0K PiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIEFSUkFZX1NJWkUoZHc5NzY4X2lu aXRfcmVncykpOw0KPiA+ID4gPiA+ICsgaWYgKHJldCkNCj4gPiA+ID4gPiArICAgICAgICAgcmV0 dXJuIHJldDsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyBmb3IgKHZhbCA9IGR3OTc2OC0+Zm9j dXMtPnZhbCAlIERXOTc2OF9NT1ZFX1NURVBTOw0KPiA+ID4gPiA+ICsgICAgICB2YWwgPD0gZHc5 NzY4LT5mb2N1cy0+dmFsOw0KPiA+ID4gPiA+ICsgICAgICB2YWwgKz0gRFc5NzY4X01PVkVfU1RF UFMpIHsNCj4gPiA+ID4gPiArICAgICAgICAgcmV0ID0gZHc5NzY4X3NldF9kYWMoZHc5NzY4LCB2 YWwpOw0KPiA+ID4gPiA+ICsgICAgICAgICBpZiAocmV0KSB7DQo+ID4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgZGV2X2VycigmY2xpZW50LT5kZXYsICIlcyBJMkMgZmFpbHVyZTogJWQiLA0KPiA+ ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgX19mdW5jX18sIHJldCk7DQo+ID4gPiA+ ID4gKyAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsNCj4gPiA+ID4gPiArICAgICAgICAgfQ0K PiA+ID4gPiA+ICsgICAgICAgICB1c2xlZXBfcmFuZ2UoRFc5NzY4X01PVkVfREVMQVlfVVMsDQo+ ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICBEVzk3NjhfTU9WRV9ERUxBWV9VUyArIDEw MDApOw0KPiA+ID4gPiA+ICsgfQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJldHVybiAwOw0K PiA+ID4gPiA+ICt9DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICtzdGF0aWMgaW50IGR3OTc2OF9y ZWxlYXNlKHN0cnVjdCBkdzk3NjggKmR3OTc2OCkNCj4gPiA+ID4gPiArew0KPiA+ID4gPiA+ICsg c3RydWN0IGkyY19jbGllbnQgKmNsaWVudCA9IHY0bDJfZ2V0X3N1YmRldmRhdGEoJmR3OTc2OC0+ c2QpOw0KPiA+ID4gPiA+ICsgaW50IHJldCwgdmFsOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiAr IHZhbCA9IHJvdW5kX2Rvd24oZHc5NzY4LT5mb2N1cy0+dmFsLCBEVzk3NjhfTU9WRV9TVEVQUyk7 DQo+ID4gPiA+ID4gKyBmb3IgKCA7IHZhbCA+PSAwOyB2YWwgLT0gRFc5NzY4X01PVkVfU1RFUFMp IHsNCj4gPiA+ID4gPiArICAgICAgICAgcmV0ID0gZHc5NzY4X3NldF9kYWMoZHc5NzY4LCB2YWwp Ow0KPiA+ID4gPiA+ICsgICAgICAgICBpZiAocmV0KSB7DQo+ID4gPiA+ID4gKyAgICAgICAgICAg ICAgICAgZGV2X2VycigmY2xpZW50LT5kZXYsICJJMkMgd3JpdGUgZmFpbDogJWQiLCByZXQpOw0K PiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7DQo+ID4gPiA+ID4gKyAgICAg ICAgIH0NCj4gPiA+ID4gPiArICAgICAgICAgdXNsZWVwX3JhbmdlKERXOTc2OF9NT1ZFX0RFTEFZ X1VTLCBEVzk3NjhfTU9WRV9ERUxBWV9VUyArIDEwMDApOw0KPiA+ID4gPiA+ICsgfQ0KPiA+ID4g PiA+ICsNCj4gPiA+ID4gPiArIC8qDQo+ID4gPiA+ID4gKyAgKiBXYWl0IGZvciB0aGUgbW90b3Ig dG8gc3RhYmlsaXplIGFmdGVyIHRoZSBsYXN0IG1vdmVtZW50DQo+ID4gPiA+ID4gKyAgKiB0byBw cmV2ZW50IHRoZSBtb3RvciBmcm9tIHNoYWtpbmcuDQo+ID4gPiA+ID4gKyAgKi8NCj4gPiA+ID4g PiArIHVzbGVlcF9yYW5nZShEVzk3NjhfU1RBQkxFX1RJTUVfVVMgLSBEVzk3NjhfTU9WRV9ERUxB WV9VUywNCj4gPiA+ID4gPiArICAgICAgICAgICAgICBEVzk3NjhfU1RBQkxFX1RJTUVfVVMgLSBE Vzk3NjhfTU9WRV9ERUxBWV9VUyArIDEwMDApOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJl dCA9IGkyY19zbWJ1c193cml0ZV9ieXRlX2RhdGEoY2xpZW50LCBEVzk3NjhfUklOR19QRF9DT05U Uk9MX1JFRywNCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRFc5 NzY4X1BEX01PREVfRU4pOw0KPiA+ID4gPiA+ICsgaWYgKHJldCA8IDApDQo+ID4gPiA+ID4gKyAg ICAgICAgIHJldHVybiByZXQ7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgLyoNCj4gPiA+ID4g PiArICAqIERXOTc2OSByZXF1aXJlcyB3YWl0aW5nIGRlbGF5IHRpbWUgb2YgdF9PUFINCj4gPiA+ ID4gPiArICAqIGFmdGVyIFBEIHJlc2V0IHRha2VzIHBsYWNlLg0KPiA+ID4gPiA+ICsgICovDQo+ ID4gPiA+ID4gKyB1c2xlZXBfcmFuZ2UoRFc5NzY4X1RfT1BSX1VTLCBEVzk3NjhfVF9PUFJfVVMg KyAxMDApOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJldHVybiAwOw0KPiA+ID4gPiA+ICt9 DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICtzdGF0aWMgaW50IF9fbWF5YmVfdW51c2VkIGR3OTc2 OF9ydW50aW1lX3N1c3BlbmQoc3RydWN0IGRldmljZSAqZGV2KQ0KPiA+ID4gPiA+ICt7DQo+ID4g PiA+ID4gKyBzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50ID0gdG9faTJjX2NsaWVudChkZXYpOw0K PiA+ID4gPiA+ICsgc3RydWN0IHY0bDJfc3ViZGV2ICpzZCA9IGkyY19nZXRfY2xpZW50ZGF0YShj bGllbnQpOw0KPiA+ID4gPiA+ICsgc3RydWN0IGR3OTc2OCAqZHc5NzY4ID0gc2RfdG9fZHc5NzY4 KHNkKTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyBkdzk3NjhfcmVsZWFzZShkdzk3NjgpOw0K PiA+ID4gPiA+ICsgcmVndWxhdG9yX2J1bGtfZGlzYWJsZShBUlJBWV9TSVpFKGR3OTc2OF9zdXBw bHlfbmFtZXMpLA0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICBkdzk3NjgtPnN1 cHBsaWVzKTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyByZXR1cm4gMDsNCj4gPiA+ID4gPiAr fQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3RhdGljIGludCBfX21heWJlX3VudXNlZCBkdzk3 NjhfcnVudGltZV9yZXN1bWUoc3RydWN0IGRldmljZSAqZGV2KQ0KPiA+ID4gPiA+ICt7DQo+ID4g PiA+ID4gKyBzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50ID0gdG9faTJjX2NsaWVudChkZXYpOw0K PiA+ID4gPiA+ICsgc3RydWN0IHY0bDJfc3ViZGV2ICpzZCA9IGkyY19nZXRfY2xpZW50ZGF0YShj bGllbnQpOw0KPiA+ID4gPiA+ICsgc3RydWN0IGR3OTc2OCAqZHc5NzY4ID0gc2RfdG9fZHc5NzY4 KHNkKTsNCj4gPiA+ID4gPiArIGludCByZXQ7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgcmV0 ID0gcmVndWxhdG9yX2J1bGtfZW5hYmxlKEFSUkFZX1NJWkUoZHc5NzY4X3N1cHBseV9uYW1lcyks DQo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZHc5NzY4LT5zdXBwbGll cyk7DQo+ID4gPiA+ID4gKyBpZiAocmV0IDwgMCkgew0KPiA+ID4gPiA+ICsgICAgICAgICBkZXZf ZXJyKGRldiwgImZhaWxlZCB0byBlbmFibGUgcmVndWxhdG9yc1xuIik7DQo+ID4gPiA+ID4gKyAg ICAgICAgIHJldHVybiByZXQ7DQo+ID4gPiA+ID4gKyB9DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ ICsgLyoNCj4gPiA+ID4gPiArICAqIFRoZSBkYXRhc2hlZXQgcmVmZXJzIHRvIHRfT1BSIHRoYXQg bmVlZHMgdG8gYmUgd2FpdGVkIGJlZm9yZSBzZW5kaW5nDQo+ID4gPiA+ID4gKyAgKiBJMkMgY29t bWFuZHMgYWZ0ZXIgcG93ZXItdXAuDQo+ID4gPiA+ID4gKyAgKi8NCj4gPiA+ID4gPiArIHVzbGVl cF9yYW5nZShEVzk3NjhfVF9PUFJfVVMsIERXOTc2OF9UX09QUl9VUyArIDEwMCk7DQo+ID4gPiA+ ID4gKw0KPiA+ID4gPiA+ICsgcmV0ID0gZHc5NzY4X2luaXQoZHc5NzY4KTsNCj4gPiA+ID4gPiAr IGlmIChyZXQgPCAwKQ0KPiA+ID4gPiA+ICsgICAgICAgICBnb3RvIGRpc2FibGVfcmVndWxhdG9y Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJldHVybiAwOw0KPiA+ID4gPiA+ICsNCj4gPiA+ ID4gPiArZGlzYWJsZV9yZWd1bGF0b3I6DQo+ID4gPiA+ID4gKyByZWd1bGF0b3JfYnVsa19kaXNh YmxlKEFSUkFZX1NJWkUoZHc5NzY4X3N1cHBseV9uYW1lcyksDQo+ID4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgIGR3OTc2OC0+c3VwcGxpZXMpOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4g PiArIHJldHVybiByZXQ7DQo+ID4gPiA+ID4gK30NCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gK3N0 YXRpYyBpbnQgZHc5NzY4X3NldF9jdHJsKHN0cnVjdCB2NGwyX2N0cmwgKmN0cmwpDQo+ID4gPiA+ ID4gK3sNCj4gPiA+ID4gPiArIHN0cnVjdCBkdzk3NjggKmR3OTc2OCA9IHRvX2R3OTc2OChjdHJs KTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyBpZiAoY3RybC0+aWQgPT0gVjRMMl9DSURfRk9D VVNfQUJTT0xVVEUpDQo+ID4gPiA+ID4gKyAgICAgICAgIHJldHVybiBkdzk3Njhfc2V0X2RhYyhk dzk3NjgsIGN0cmwtPnZhbCk7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgcmV0dXJuIDA7DQo+ ID4gPiA+ID4gK30NCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qg djRsMl9jdHJsX29wcyBkdzk3NjhfY3RybF9vcHMgPSB7DQo+ID4gPiA+ID4gKyAuc19jdHJsID0g ZHc5NzY4X3NldF9jdHJsLA0KPiA+ID4gPiA+ICt9Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiAr c3RhdGljIGludCBkdzk3Njhfb3BlbihzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNkLCBzdHJ1Y3QgdjRs Ml9zdWJkZXZfZmggKmZoKQ0KPiA+ID4gPiA+ICt7DQo+ID4gPiA+ID4gKyBpbnQgcmV0Ow0KPiA+ ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJldCA9IHBtX3J1bnRpbWVfZ2V0X3N5bmMoc2QtPmRldik7 DQo+ID4gPiA+ID4gKyBpZiAocmV0IDwgMCkgew0KPiA+ID4gPiA+ICsgICAgICAgICBwbV9ydW50 aW1lX3B1dF9ub2lkbGUoc2QtPmRldik7DQo+ID4gPiA+ID4gKyAgICAgICAgIHJldHVybiByZXQ7 DQo+ID4gPiA+ID4gKyB9DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgcmV0dXJuIDA7DQo+ID4g PiA+ID4gK30NCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gK3N0YXRpYyBpbnQgZHc5NzY4X2Nsb3Nl KHN0cnVjdCB2NGwyX3N1YmRldiAqc2QsIHN0cnVjdCB2NGwyX3N1YmRldl9maCAqZmgpDQo+ID4g PiA+ID4gK3sNCj4gPiA+ID4gPiArIHBtX3J1bnRpbWVfcHV0KHNkLT5kZXYpOw0KPiA+ID4gPiA+ ICsNCj4gPiA+ID4gPiArIHJldHVybiAwOw0KPiA+ID4gPiA+ICt9DQo+ID4gPiA+ID4gKw0KPiA+ ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHY0bDJfc3ViZGV2X2ludGVybmFsX29wcyBkdzk3 NjhfaW50X29wcyA9IHsNCj4gPiA+ID4gPiArIC5vcGVuID0gZHc5NzY4X29wZW4sDQo+ID4gPiA+ ID4gKyAuY2xvc2UgPSBkdzk3NjhfY2xvc2UsDQo+ID4gPiA+ID4gK307DQo+ID4gPiA+ID4gKw0K PiA+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHY0bDJfc3ViZGV2X29wcyBkdzk3Njhfb3Bz ID0geyB9Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3RhdGljIGludCBkdzk3NjhfaW5pdF9j b250cm9scyhzdHJ1Y3QgZHc5NzY4ICpkdzk3NjgpDQo+ID4gPiA+ID4gK3sNCj4gPiA+ID4gPiAr IHN0cnVjdCB2NGwyX2N0cmxfaGFuZGxlciAqaGRsID0gJmR3OTc2OC0+Y3RybHM7DQo+ID4gPiA+ ID4gKyBjb25zdCBzdHJ1Y3QgdjRsMl9jdHJsX29wcyAqb3BzID0gJmR3OTc2OF9jdHJsX29wczsN Cj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyB2NGwyX2N0cmxfaGFuZGxlcl9pbml0KGhkbCwgMSk7 DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgZHc5NzY4LT5mb2N1cyA9IHY0bDJfY3RybF9uZXdf c3RkKGhkbCwgb3BzLCBWNEwyX0NJRF9GT0NVU19BQlNPTFVURSwgMCwNCj4gPiA+ID4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEVzk3NjhfTUFYX0ZPQ1VTX1BPUywNCj4g PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBEVzk3NjhfRk9DVVNf U1RFUFMsIDApOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIGlmIChoZGwtPmVycm9yKQ0KPiA+ ID4gPiA+ICsgICAgICAgICByZXR1cm4gaGRsLT5lcnJvcjsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ ID4gKyBkdzk3NjgtPnNkLmN0cmxfaGFuZGxlciA9IGhkbDsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ ID4gKyByZXR1cm4gMDsNCj4gPiA+ID4gPiArfQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3Rh dGljIGludCBkdzk3NjhfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCkNCj4gPiA+ID4g PiArew0KPiA+ID4gPiA+ICsgc3RydWN0IGRldmljZSAqZGV2ID0gJmNsaWVudC0+ZGV2Ow0KPiA+ ID4gPiA+ICsgc3RydWN0IGR3OTc2OCAqZHc5NzY4Ow0KPiA+ID4gPiA+ICsgdW5zaWduZWQgaW50 IGk7DQo+ID4gPiA+ID4gKyBpbnQgcmV0Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIGR3OTc2 OCA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqZHc5NzY4KSwgR0ZQX0tFUk5FTCk7DQo+ID4g PiA+ID4gKyBpZiAoIWR3OTc2OCkNCj4gPiA+ID4gPiArICAgICAgICAgcmV0dXJuIC1FTk9NRU07 DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgdjRsMl9pMmNfc3ViZGV2X2luaXQoJmR3OTc2OC0+ c2QsIGNsaWVudCwgJmR3OTc2OF9vcHMpOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIGZvciAo aSA9IDA7IGkgPCBBUlJBWV9TSVpFKGR3OTc2OF9zdXBwbHlfbmFtZXMpOyBpKyspDQo+ID4gPiA+ ID4gKyAgICAgICAgIGR3OTc2OC0+c3VwcGxpZXNbaV0uc3VwcGx5ID0gZHc5NzY4X3N1cHBseV9u YW1lc1tpXTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyByZXQgPSBkZXZtX3JlZ3VsYXRvcl9i dWxrX2dldChkZXYsIEFSUkFZX1NJWkUoZHc5NzY4X3N1cHBseV9uYW1lcyksDQo+ID4gPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkdzk3NjgtPnN1cHBsaWVzKTsNCj4gPiA+ ID4gPiArIGlmIChyZXQpIHsNCj4gPiA+ID4gPiArICAgICAgICAgZGV2X2VycihkZXYsICJmYWls ZWQgdG8gZ2V0IHJlZ3VsYXRvcnNcbiIpOw0KPiA+ID4gPiA+ICsgICAgICAgICByZXR1cm4gcmV0 Ow0KPiA+ID4gPiA+ICsgfQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJldCA9IGR3OTc2OF9p bml0X2NvbnRyb2xzKGR3OTc2OCk7DQo+ID4gPiA+ID4gKyBpZiAocmV0KQ0KPiA+ID4gPiA+ICsg ICAgICAgICBnb3RvIGVudGl0eV9jbGVhbnVwOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIGR3 OTc2OC0+c2QuZmxhZ3MgfD0gVjRMMl9TVUJERVZfRkxfSEFTX0RFVk5PREU7DQo+ID4gPiA+ID4g KyBkdzk3NjgtPnNkLmludGVybmFsX29wcyA9ICZkdzk3NjhfaW50X29wczsNCj4gPiA+ID4gPiAr DQo+ID4gPiA+ID4gKyByZXQgPSBtZWRpYV9lbnRpdHlfcGFkc19pbml0KCZkdzk3NjgtPnNkLmVu dGl0eSwgMCwgTlVMTCk7DQo+ID4gPiA+ID4gKyBpZiAocmV0IDwgMCkNCj4gPiA+ID4gPiArICAg ICAgICAgZ290byBlbnRpdHlfY2xlYW51cDsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyBkdzk3 NjgtPnNkLmVudGl0eS5mdW5jdGlvbiA9IE1FRElBX0VOVF9GX0xFTlM7DQo+ID4gPiA+ID4gKw0K PiA+ID4gPiA+ICsgcG1fcnVudGltZV9lbmFibGUoZGV2KTsNCj4gPiA+ID4gPiArIGlmICghcG1f cnVudGltZV9lbmFibGVkKGRldikpIHsNCj4gPiA+ID4gPiArICAgICAgICAgcmV0ID0gZHc5NzY4 X3J1bnRpbWVfcmVzdW1lKGRldik7DQo+ID4gPiA+ID4gKyAgICAgICAgIGlmIChyZXQgPCAwKSB7 DQo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgZGV2X2VycihkZXYsICJmYWlsZWQgdG8gcG93 ZXIgb246ICVkXG4iLCByZXQpOw0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgIGdvdG8gZW50 aXR5X2NsZWFudXA7DQo+ID4gPiA+ID4gKyAgICAgICAgIH0NCj4gPiA+ID4gPiArIH0NCj4gPiA+ ID4gPiArDQo+ID4gPiA+ID4gKyByZXQgPSB2NGwyX2FzeW5jX3JlZ2lzdGVyX3N1YmRldigmZHc5 NzY4LT5zZCk7DQo+ID4gPiA+ID4gKyBpZiAocmV0IDwgMCkNCj4gPiA+ID4gPiArICAgICAgICAg Z290byBlbnRpdHlfY2xlYW51cDsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gKyByZXR1cm4gMDsN Cj4gPiA+ID4gPiArDQo+ID4gPiA+ID4gK2VudGl0eV9jbGVhbnVwOg0KPiA+ID4gPiA+ICsgdjRs Ml9jdHJsX2hhbmRsZXJfZnJlZSgmZHc5NzY4LT5jdHJscyk7DQo+ID4gPiA+ID4gKyBtZWRpYV9l bnRpdHlfY2xlYW51cCgmZHc5NzY4LT5zZC5lbnRpdHkpOw0KPiA+ID4gPiA+ICsgcmV0dXJuIHJl dDsNCj4gPiA+ID4gPiArfQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3RhdGljIGludCBkdzk3 NjhfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpDQo+ID4gPiA+ID4gK3sNCj4gPiA+ ID4gPiArIHN0cnVjdCB2NGwyX3N1YmRldiAqc2QgPSBpMmNfZ2V0X2NsaWVudGRhdGEoY2xpZW50 KTsNCj4gPiA+ID4gPiArIHN0cnVjdCBkdzk3NjggKmR3OTc2OCA9IHNkX3RvX2R3OTc2OChzZCk7 DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgcG1fcnVudGltZV9kaXNhYmxlKCZjbGllbnQtPmRl dik7DQo+ID4gPiA+ID4gKyB2NGwyX2FzeW5jX3VucmVnaXN0ZXJfc3ViZGV2KCZkdzk3NjgtPnNk KTsNCj4gPiA+ID4gPiArIHY0bDJfY3RybF9oYW5kbGVyX2ZyZWUoJmR3OTc2OC0+Y3RybHMpOw0K PiA+ID4gPiA+ICsgbWVkaWFfZW50aXR5X2NsZWFudXAoJmR3OTc2OC0+c2QuZW50aXR5KTsNCj4g PiA+ID4gPiArIGlmICghcG1fcnVudGltZV9zdGF0dXNfc3VzcGVuZGVkKCZjbGllbnQtPmRldikp DQo+ID4gPiA+ID4gKyAgICAgICAgIGR3OTc2OF9ydW50aW1lX3N1c3BlbmQoJmNsaWVudC0+ZGV2 KTsNCj4gPiA+ID4gPiArIHBtX3J1bnRpbWVfc2V0X3N1c3BlbmRlZCgmY2xpZW50LT5kZXYpOw0K PiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArIHJldHVybiAwOw0KPiA+ID4gPiA+ICt9DQo+ID4gPiA+ ID4gKw0KPiA+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBkdzk3Njhf b2ZfdGFibGVbXSA9IHsNCj4gPiA+ID4gPiArIHsgLmNvbXBhdGlibGUgPSAiZG9uZ3dvb24sZHc5 NzY4IiB9LA0KPiA+ID4gPiA+ICsge30NCj4gPiA+ID4gPiArfTsNCj4gPiA+ID4gPiArTU9EVUxF X0RFVklDRV9UQUJMRShvZiwgZHc5NzY4X29mX3RhYmxlKTsNCj4gPiA+ID4gPiArDQo+ID4gPiA+ ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBkdzk3NjhfcG1fb3BzID0gew0KPiA+ ID4gPiA+ICsgU0VUX1NZU1RFTV9TTEVFUF9QTV9PUFMocG1fcnVudGltZV9mb3JjZV9zdXNwZW5k LA0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgcG1fcnVudGltZV9mb3JjZV9y ZXN1bWUpDQo+ID4gPiA+ID4gKyBTRVRfUlVOVElNRV9QTV9PUFMoZHc5NzY4X3J1bnRpbWVfc3Vz cGVuZCwgZHc5NzY4X3J1bnRpbWVfcmVzdW1lLCBOVUxMKQ0KPiA+ID4gPiA+ICt9Ow0KPiA+ID4g PiA+ICsNCj4gPiA+ID4gPiArc3RhdGljIHN0cnVjdCBpMmNfZHJpdmVyIGR3OTc2OF9pMmNfZHJp dmVyID0gew0KPiA+ID4gPiA+ICsgLmRyaXZlciA9IHsNCj4gPiA+ID4gPiArICAgICAgICAgLm5h bWUgPSBEVzk3NjhfTkFNRSwNCj4gPiA+ID4gPiArICAgICAgICAgLnBtID0gJmR3OTc2OF9wbV9v cHMsDQo+ID4gPiA+ID4gKyAgICAgICAgIC5vZl9tYXRjaF90YWJsZSA9IGR3OTc2OF9vZl90YWJs ZSwNCj4gPiA+ID4gPiArIH0sDQo+ID4gPiA+ID4gKyAucHJvYmVfbmV3ICA9IGR3OTc2OF9wcm9i ZSwNCj4gPiA+ID4gPiArIC5yZW1vdmUgPSBkdzk3NjhfcmVtb3ZlLA0KPiA+ID4gPiA+ICt9Ow0K PiA+ID4gPiA+ICttb2R1bGVfaTJjX2RyaXZlcihkdzk3NjhfaTJjX2RyaXZlcik7DQo+ID4gPiA+ ID4gKw0KPiA+ID4gPiA+ICtNT0RVTEVfQVVUSE9SKCJEb25nY2h1biBaaHUgPGRvbmdjaHVuLnpo dUBtZWRpYXRlay5jb20+Iik7DQo+ID4gPiA+ID4gK01PRFVMRV9ERVNDUklQVElPTigiRFc5NzY4 IFZDTSBkcml2ZXIiKTsNCj4gPiA+ID4gPiArTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOw0KPiA+ ID4gPg0KPiA+ID4NCj4gPg0KPiA+IC0tDQo+ID4gU2FrYXJpIEFpbHVzDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50C7C35280 for ; Fri, 8 May 2020 03:19:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96D462075E for ; Fri, 8 May 2020 03:19:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QWG+3+mh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="B4hhOqF7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96D462075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LnQPlu12zpD9vIzdR0R1z00CydcdFlRIa/Nq98yd6LY=; b=QWG+3+mhTpcnYI g7nBkJlZFVE2/1RJQtgCIwzd4KlsxQ1PrsOFdPe+FfFq2xP91eRvzN4oXf2LWcqHu14DblwcfKbFd gyZvH+0oS0nXMoj1/s4+99ZE1HaAiwXW+/k+u2Jk6aw2LqLlvfFtgg3b5+dBimB0JsLpWVkB/ips+ TnXxOtuf/aGynUNUp9TkAyShOx871ZH3e2cCaSNlbW1F0bd/z3zii8ws/ecRepzi9Ah0Zgx+nb1NE h5L6byYbqd1+qYmqBcjDRIbU+lU8EToh9mTxY32+KbXWJazQXSWF3fwi1bTXI1aPEj+0ntQcggq8a RDMK73swdj3kuZXWIb0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWtXv-0000Cc-TN; Fri, 08 May 2020 03:19:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWtXq-0000C6-NU; Fri, 08 May 2020 03:19:29 +0000 X-UUID: e5c8f3608ad44370a25eafbf232a277a-20200507 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zxrf2kTs3eDrMnUH9GHDlgcEj1tiqeJAGC48w/+m1fQ=; b=B4hhOqF79DBCCVmd+VWoD5wOIZERKatq0FoeNDxI7i/X2Kx4SIo0VTCkCMFZkxf8y+aWkfYcwXq7IOJLpF7vrATtV4WP+EdsFOWXITIyf3teH/ybdKZzPa2Of7hrnKGYO5KZVamPvH/CRr48rZrgAxrcawmDtQ3TgMh2lXYuDlU=; X-UUID: e5c8f3608ad44370a25eafbf232a277a-20200507 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1651750585; Thu, 07 May 2020 19:19:18 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 May 2020 20:09:18 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 May 2020 11:09:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 May 2020 11:09:15 +0800 Message-ID: <1588907288.8804.188.camel@mhfsdcap03> Subject: Re: [V5, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Tomasz Figa Date: Fri, 8 May 2020 11:08:08 +0800 In-Reply-To: References: <20200502161727.30463-1-dongchun.zhu@mediatek.com> <20200502161727.30463-3-dongchun.zhu@mediatek.com> <20200506151352.GZ9190@paasikivi.fi.intel.com> <1588855524.8804.168.camel@mhfsdcap03> <20200507131220.GC9190@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BDE6ECBE2824A449FE8336CA19D39D8390089DCD152D8C6D3556D62553DB6B162000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_201926_785865_53F78FD1 X-CRM114-Status: GOOD ( 34.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Louis Kuo , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Sakari Ailus , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sakari, Tomasz, Thanks for the review. On Thu, 2020-05-07 at 15:46 +0200, Tomasz Figa wrote: > Hi Sakari, Dongchun, > > On Thu, May 7, 2020 at 3:12 PM Sakari Ailus > wrote: > > > > HI Dongchun, > > > > On Thu, May 07, 2020 at 08:45:24PM +0800, Dongchun Zhu wrote: > > > Hi Sakari, > > > > > > Thanks for the review. > > > > > > On Wed, 2020-05-06 at 18:13 +0300, Sakari Ailus wrote: > > > > Hi Dongchun, > > > > > > > > On Sun, May 03, 2020 at 12:17:27AM +0800, Dongchun Zhu wrote: > > > > > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing > > > > > control to set the desired focus via IIC serial interface. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > --- > > > > > MAINTAINERS | 1 + > > > > > drivers/media/i2c/Kconfig | 11 ++ > > > > > drivers/media/i2c/Makefile | 1 + > > > > > drivers/media/i2c/dw9768.c | 440 +++++++++++++++++++++++++++++++++++++++++++++ > > > > > 4 files changed, 453 insertions(+) > > > > > create mode 100644 drivers/media/i2c/dw9768.c > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 8d72c41..c92dc99 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -5157,6 +5157,7 @@ L: linux-media@vger.kernel.org > > > > > S: Maintained > > > > > T: git git://linuxtv.org/media_tree.git > > > > > F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > > > > +F: drivers/media/i2c/dw9768.c > > > > > > > > > > DONGWOON DW9807 LENS VOICE COIL DRIVER > > > > > M: Sakari Ailus > > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > > > > index 125d596..6a3f9da 100644 > > > > > --- a/drivers/media/i2c/Kconfig > > > > > +++ b/drivers/media/i2c/Kconfig > > > > > @@ -1040,6 +1040,17 @@ config VIDEO_DW9714 > > > > > capability. This is designed for linear control of > > > > > voice coil motors, controlled via I2C serial interface. > > > > > > > > > > +config VIDEO_DW9768 > > > > > + tristate "DW9768 lens voice coil support" > > > > > + depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER > > > > > + depends on VIDEO_V4L2_SUBDEV_API > > > > > > > > Please check how this works in the media tree master branch now --- it's > > > > largely select based. > > > > > > > > > > The actuator driver uses some structures that require the > > > VIDEO_V4L2_SUBDEV_API code, so here we add VIDEO_V4L2_SUBDEV_API > > > dependency to avoid possible build error when it's not enabled. > > > > Please make sure this works with current media tree master. Right now it > > does not. > > > > Dongchun, as Sakari said, please make sure to base the patches on the > master branch of the media tree. > (https://git.linuxtv.org/media_tree.git/). The approach for Kconfig > dependency selection there seems to have changed recently. > I searched the patches on the media tree master branch. It seems that we need to remove the VIDEO_V4L2_SUBDEV_API dependency in Kconfig, and add #ifdef CONFIG_VIDEO_V4L2_SUBDEV_API to include v4l2-subdev code. The change mainly is to make build pass, and don't return ENOTTY if SUBDEV_API is not set. Am I right? > > > > > > > In general the patch seems fine to me, but please see the other comments > > > > below, too. > > > > > > > > > + depends on PM > > > > > + help > > > > > + This is a driver for the DW9768 camera lens voice coil. > > > > > + DW9768 is a 10 bit DAC with 100mA output current sink > > > > > + capability. This is designed for linear control of > > > > > + voice coil motors, controlled via I2C serial interface. > > > > > + > > > > > config VIDEO_DW9807_VCM > > > > > tristate "DW9807 lens voice coil support" > > > > > depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER > > > > > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile > > > > > index 77bf7d0..4057476 100644 > > > > > --- a/drivers/media/i2c/Makefile > > > > > +++ b/drivers/media/i2c/Makefile > > > > > @@ -24,6 +24,7 @@ obj-$(CONFIG_VIDEO_SAA6752HS) += saa6752hs.o > > > > > obj-$(CONFIG_VIDEO_AD5820) += ad5820.o > > > > > obj-$(CONFIG_VIDEO_AK7375) += ak7375.o > > > > > obj-$(CONFIG_VIDEO_DW9714) += dw9714.o > > > > > +obj-$(CONFIG_VIDEO_DW9768) += dw9768.o > > > > > obj-$(CONFIG_VIDEO_DW9807_VCM) += dw9807-vcm.o > > > > > obj-$(CONFIG_VIDEO_ADV7170) += adv7170.o > > > > > obj-$(CONFIG_VIDEO_ADV7175) += adv7175.o > > > > > diff --git a/drivers/media/i2c/dw9768.c b/drivers/media/i2c/dw9768.c > > > > > new file mode 100644 > > > > > index 0000000..dd68534 > > > > > --- /dev/null > > > > > +++ b/drivers/media/i2c/dw9768.c > > > > > @@ -0,0 +1,440 @@ > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > +// Copyright (c) 2020 MediaTek Inc. > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#define DW9768_NAME "dw9768" > > > > > +#define DW9768_MAX_FOCUS_POS (1024 - 1) > > > > > +/* > > > > > + * This sets the minimum granularity for the focus positions. > > > > > + * A value of 1 gives maximum accuracy for a desired focus position > > > > > + */ > > > > > +#define DW9768_FOCUS_STEPS 1 > > > > > + > > > > > +/* > > > > > + * Ring control and Power control register > > > > > + * Bit[1] RING_EN > > > > > + * 0: Direct mode > > > > > + * 1: AAC mode (ringing control mode) > > > > > + * Bit[0] PD > > > > > + * 0: Normal operation mode > > > > > + * 1: Power down mode > > > > > + * DW9768 requires waiting time of Topr after PD reset takes place. > > > > > + */ > > > > > +#define DW9768_RING_PD_CONTROL_REG 0x02 > > > > > +#define DW9768_PD_MODE_OFF 0x00 > > > > > +#define DW9768_PD_MODE_EN BIT(0) > > > > > +#define DW9768_AAC_MODE_EN BIT(1) > > > > > + > > > > > +/* > > > > > + * DW9768 separates two registers to control the VCM position. > > > > > + * One for MSB value, another is LSB value. > > > > > + * DAC_MSB: D[9:8] (ADD: 0x03) > > > > > + * DAC_LSB: D[7:0] (ADD: 0x04) > > > > > + * D[9:0] DAC data input: positive output current = D[9:0] / 1023 * 100[mA] > > > > > + */ > > > > > +#define DW9768_MSB_ADDR 0x03 > > > > > +#define DW9768_LSB_ADDR 0x04 > > > > > +#define DW9768_STATUS_ADDR 0x05 > > > > > + > > > > > +/* > > > > > + * AAC mode control & prescale register > > > > > + * Bit[7:5] Namely AC[2:0], decide the VCM mode and operation time. > > > > > + * 000 Direct(default) > > > > > + * 001 AAC2 0.48xTvib > > > > > + * 010 AAC3 0.70xTvib > > > > > + * 011 AAC4 0.75xTvib > > > > > + * 100 Reserved > > > > > + * 101 AAC8 1.13xTvib > > > > > + * 110 Reserved > > > > > + * 111 Reserved > > > > > + * Bit[2:0] Namely PRESC[2:0], set the internal clock dividing rate as follow. > > > > > + * 000 2 > > > > > + * 001 1(default) > > > > > + * 010 1/2 > > > > > + * 011 1/4 > > > > > + * 100 8 > > > > > + * 101 4 > > > > > + * 110 Reserved > > > > > + * 111 Reserved > > > > > + */ > > > > > +#define DW9768_AAC_PRESC_REG 0x06 > > > > > +#define DW9768_AAC3_SELECT_DIVIDING_RATE_1 0x41 > > > > > > > > I guess we can start with these values. But I can't think of another option > > > > than putting them into DT if there are differences between what hardware > > > > platforms require. > > > > > > > > > > Let's have a discussion about this. > > > Now these non-default register settings represent one AAC operation > > > mode, this is one option and works for a given lens or a module. > > > If sometime in the future hardware platforms require another different > > > settings, then DT properties may need to be created. > > > > If these values indeed are specific to a given lens (and presumably also a > > spring), then I'd put them to DT right now --- we don't have drivers for > > these components the drivers of which could hold this information, nor it > > makes sense to add them just for that. > > > > I tend to stay on the conservative side and only add DT properties > once there is really a need to do so. Right now we haven't seen any > system which would use different values of these parameters. > > Best regards, > Tomasz > > > > > > > > > + > > > > > +/* > > > > > + * VCM period of vibration register > > > > > + * Bit[5:0] Defined as VCM rising periodic time (Tvib) together with PRESC[2:0] > > > > > + * Tvib = (6.3ms + AACT[5:0] * 0.1ms) * Dividing Rate > > > > > + * Dividing Rate is the internal clock dividing rate that is defined at > > > > > + * PRESCALE register (ADD: 0x06) > > > > > + */ > > > > > +#define DW9768_AAC_TIME_REG 0x07 > > > > > +#define DW9768_AACT_CNT 0x39 > > > > > + > > > > > +/* > > > > > + * DW9768 requires waiting time (delay time) of t_OPR after power-up, > > > > > + * or in the case of PD reset taking place. > > > > > + */ > > > > > +#define DW9768_T_OPR_US 1000 > > > > > + > > > > > +/* > > > > > + * This acts as the minimum granularity of lens movement. > > > > > + * Keep this value power of 2, so the control steps can be > > > > > + * uniformly adjusted for gradual lens movement, with desired > > > > > + * number of control steps. > > > > > + */ > > > > > +#define DW9768_MOVE_STEPS 16 > > > > > + > > > > > +/* > > > > > + * DW9768_AAC_PRESC_REG & DW9768_AAC_TIME_REG determine VCM operation time. > > > > > + * If DW9768_AAC_PRESC_REG is 0x41, and DW9768_AAC_TIME_REG is 0x39, VCM mode > > > > > + * would be AAC3, Operation Time would be 0.70xTvib, that is 8.40ms. > > > > > + */ > > > > > +#define DW9768_MOVE_DELAY_US 8400 > > > > > +#define DW9768_STABLE_TIME_US 20000 > > > > > + > > > > > +static const char * const dw9768_supply_names[] = { > > > > > + "vin", /* I2C I/O interface power */ > > > > > + "vdd", /* VCM power */ > > > > > +}; > > > > > + > > > > > +/* dw9768 device structure */ > > > > > +struct dw9768 { > > > > > + struct regulator_bulk_data supplies[ARRAY_SIZE(dw9768_supply_names)]; > > > > > + struct v4l2_ctrl_handler ctrls; > > > > > + struct v4l2_ctrl *focus; > > > > > + struct v4l2_subdev sd; > > > > > +}; > > > > > + > > > > > +static inline struct dw9768 *to_dw9768(struct v4l2_ctrl *ctrl) > > > > > +{ > > > > > + return container_of(ctrl->handler, struct dw9768, ctrls); > > > > > +} > > > > > > > > This is used in a single place. I'd just use container_of() directly there. > > > > > > > > > > Thanks for the reminder. > > > Fixed in next release. > > > > > > > > + > > > > > +static inline struct dw9768 *sd_to_dw9768(struct v4l2_subdev *subdev) > > > > > +{ > > > > > + return container_of(subdev, struct dw9768, sd); > > > > > +} > > > > > + > > > > > +struct regval_list { > > > > > + u8 reg_num; > > > > > + u8 value; > > > > > +}; > > > > > + > > > > > +static const struct regval_list dw9768_init_regs[] = { > > > > > + {DW9768_RING_PD_CONTROL_REG, DW9768_AAC_MODE_EN}, > > > > > + {DW9768_AAC_PRESC_REG, DW9768_AAC3_SELECT_DIVIDING_RATE_1}, > > > > > + {DW9768_AAC_TIME_REG, DW9768_AACT_CNT}, > > > > > +}; > > > > > + > > > > > +static int dw9768_write_array(struct dw9768 *dw9768, > > > > > + const struct regval_list *vals, size_t len) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + unsigned int i; > > > > > + int ret; > > > > > + > > > > > + for (i = 0; i < len; i++) { > > > > > + ret = i2c_smbus_write_byte_data(client, vals[i].reg_num, > > > > > + vals[i].value); > > > > > + if (ret < 0) > > > > > + return ret; > > > > > + } > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_set_dac(struct dw9768 *dw9768, u16 val) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + > > > > > + /* Write VCM position to registers */ > > > > > + return i2c_smbus_write_word_swapped(client, DW9768_MSB_ADDR, val); > > > > > +} > > > > > + > > > > > +static int dw9768_init(struct dw9768 *dw9768) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + int ret, val; > > > > > + > > > > > + /* Reset DW9768_RING_PD_CONTROL_REG to default status 0x00 */ > > > > > + ret = i2c_smbus_write_byte_data(client, DW9768_RING_PD_CONTROL_REG, > > > > > + DW9768_PD_MODE_OFF); > > > > > + if (ret < 0) > > > > > + return ret; > > > > > + > > > > > + /* > > > > > + * DW9769 requires waiting delay time of t_OPR > > > > > + * after PD reset takes place. > > > > > + */ > > > > > + usleep_range(DW9768_T_OPR_US, DW9768_T_OPR_US + 100); > > > > > + > > > > > + ret = dw9768_write_array(dw9768, dw9768_init_regs, > > > > > + ARRAY_SIZE(dw9768_init_regs)); > > > > > + if (ret) > > > > > + return ret; > > > > > + > > > > > + for (val = dw9768->focus->val % DW9768_MOVE_STEPS; > > > > > + val <= dw9768->focus->val; > > > > > + val += DW9768_MOVE_STEPS) { > > > > > + ret = dw9768_set_dac(dw9768, val); > > > > > + if (ret) { > > > > > + dev_err(&client->dev, "%s I2C failure: %d", > > > > > + __func__, ret); > > > > > + return ret; > > > > > + } > > > > > + usleep_range(DW9768_MOVE_DELAY_US, > > > > > + DW9768_MOVE_DELAY_US + 1000); > > > > > + } > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_release(struct dw9768 *dw9768) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + int ret, val; > > > > > + > > > > > + val = round_down(dw9768->focus->val, DW9768_MOVE_STEPS); > > > > > + for ( ; val >= 0; val -= DW9768_MOVE_STEPS) { > > > > > + ret = dw9768_set_dac(dw9768, val); > > > > > + if (ret) { > > > > > + dev_err(&client->dev, "I2C write fail: %d", ret); > > > > > + return ret; > > > > > + } > > > > > + usleep_range(DW9768_MOVE_DELAY_US, DW9768_MOVE_DELAY_US + 1000); > > > > > + } > > > > > + > > > > > + /* > > > > > + * Wait for the motor to stabilize after the last movement > > > > > + * to prevent the motor from shaking. > > > > > + */ > > > > > + usleep_range(DW9768_STABLE_TIME_US - DW9768_MOVE_DELAY_US, > > > > > + DW9768_STABLE_TIME_US - DW9768_MOVE_DELAY_US + 1000); > > > > > + > > > > > + ret = i2c_smbus_write_byte_data(client, DW9768_RING_PD_CONTROL_REG, > > > > > + DW9768_PD_MODE_EN); > > > > > + if (ret < 0) > > > > > + return ret; > > > > > + > > > > > + /* > > > > > + * DW9769 requires waiting delay time of t_OPR > > > > > + * after PD reset takes place. > > > > > + */ > > > > > + usleep_range(DW9768_T_OPR_US, DW9768_T_OPR_US + 100); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int __maybe_unused dw9768_runtime_suspend(struct device *dev) > > > > > +{ > > > > > + struct i2c_client *client = to_i2c_client(dev); > > > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > > + struct dw9768 *dw9768 = sd_to_dw9768(sd); > > > > > + > > > > > + dw9768_release(dw9768); > > > > > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int __maybe_unused dw9768_runtime_resume(struct device *dev) > > > > > +{ > > > > > + struct i2c_client *client = to_i2c_client(dev); > > > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > > + struct dw9768 *dw9768 = sd_to_dw9768(sd); > > > > > + int ret; > > > > > + > > > > > + ret = regulator_bulk_enable(ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + if (ret < 0) { > > > > > + dev_err(dev, "failed to enable regulators\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + /* > > > > > + * The datasheet refers to t_OPR that needs to be waited before sending > > > > > + * I2C commands after power-up. > > > > > + */ > > > > > + usleep_range(DW9768_T_OPR_US, DW9768_T_OPR_US + 100); > > > > > + > > > > > + ret = dw9768_init(dw9768); > > > > > + if (ret < 0) > > > > > + goto disable_regulator; > > > > > + > > > > > + return 0; > > > > > + > > > > > +disable_regulator: > > > > > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + > > > > > + return ret; > > > > > +} > > > > > + > > > > > +static int dw9768_set_ctrl(struct v4l2_ctrl *ctrl) > > > > > +{ > > > > > + struct dw9768 *dw9768 = to_dw9768(ctrl); > > > > > + > > > > > + if (ctrl->id == V4L2_CID_FOCUS_ABSOLUTE) > > > > > + return dw9768_set_dac(dw9768, ctrl->val); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static const struct v4l2_ctrl_ops dw9768_ctrl_ops = { > > > > > + .s_ctrl = dw9768_set_ctrl, > > > > > +}; > > > > > + > > > > > +static int dw9768_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > > > > +{ > > > > > + int ret; > > > > > + > > > > > + ret = pm_runtime_get_sync(sd->dev); > > > > > + if (ret < 0) { > > > > > + pm_runtime_put_noidle(sd->dev); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > > > > +{ > > > > > + pm_runtime_put(sd->dev); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static const struct v4l2_subdev_internal_ops dw9768_int_ops = { > > > > > + .open = dw9768_open, > > > > > + .close = dw9768_close, > > > > > +}; > > > > > + > > > > > +static const struct v4l2_subdev_ops dw9768_ops = { }; > > > > > + > > > > > +static int dw9768_init_controls(struct dw9768 *dw9768) > > > > > +{ > > > > > + struct v4l2_ctrl_handler *hdl = &dw9768->ctrls; > > > > > + const struct v4l2_ctrl_ops *ops = &dw9768_ctrl_ops; > > > > > + > > > > > + v4l2_ctrl_handler_init(hdl, 1); > > > > > + > > > > > + dw9768->focus = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_FOCUS_ABSOLUTE, 0, > > > > > + DW9768_MAX_FOCUS_POS, > > > > > + DW9768_FOCUS_STEPS, 0); > > > > > + > > > > > + if (hdl->error) > > > > > + return hdl->error; > > > > > + > > > > > + dw9768->sd.ctrl_handler = hdl; > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_probe(struct i2c_client *client) > > > > > +{ > > > > > + struct device *dev = &client->dev; > > > > > + struct dw9768 *dw9768; > > > > > + unsigned int i; > > > > > + int ret; > > > > > + > > > > > + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL); > > > > > + if (!dw9768) > > > > > + return -ENOMEM; > > > > > + > > > > > + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops); > > > > > + > > > > > + for (i = 0; i < ARRAY_SIZE(dw9768_supply_names); i++) > > > > > + dw9768->supplies[i].supply = dw9768_supply_names[i]; > > > > > + > > > > > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + if (ret) { > > > > > + dev_err(dev, "failed to get regulators\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + ret = dw9768_init_controls(dw9768); > > > > > + if (ret) > > > > > + goto entity_cleanup; > > > > > + > > > > > + dw9768->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > > > > + dw9768->sd.internal_ops = &dw9768_int_ops; > > > > > + > > > > > + ret = media_entity_pads_init(&dw9768->sd.entity, 0, NULL); > > > > > + if (ret < 0) > > > > > + goto entity_cleanup; > > > > > + > > > > > + dw9768->sd.entity.function = MEDIA_ENT_F_LENS; > > > > > + > > > > > + pm_runtime_enable(dev); > > > > > + if (!pm_runtime_enabled(dev)) { > > > > > + ret = dw9768_runtime_resume(dev); > > > > > + if (ret < 0) { > > > > > + dev_err(dev, "failed to power on: %d\n", ret); > > > > > + goto entity_cleanup; > > > > > + } > > > > > + } > > > > > + > > > > > + ret = v4l2_async_register_subdev(&dw9768->sd); > > > > > + if (ret < 0) > > > > > + goto entity_cleanup; > > > > > + > > > > > + return 0; > > > > > + > > > > > +entity_cleanup: > > > > > + v4l2_ctrl_handler_free(&dw9768->ctrls); > > > > > + media_entity_cleanup(&dw9768->sd.entity); > > > > > + return ret; > > > > > +} > > > > > + > > > > > +static int dw9768_remove(struct i2c_client *client) > > > > > +{ > > > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > > + struct dw9768 *dw9768 = sd_to_dw9768(sd); > > > > > + > > > > > + pm_runtime_disable(&client->dev); > > > > > + v4l2_async_unregister_subdev(&dw9768->sd); > > > > > + v4l2_ctrl_handler_free(&dw9768->ctrls); > > > > > + media_entity_cleanup(&dw9768->sd.entity); > > > > > + if (!pm_runtime_status_suspended(&client->dev)) > > > > > + dw9768_runtime_suspend(&client->dev); > > > > > + pm_runtime_set_suspended(&client->dev); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static const struct of_device_id dw9768_of_table[] = { > > > > > + { .compatible = "dongwoon,dw9768" }, > > > > > + {} > > > > > +}; > > > > > +MODULE_DEVICE_TABLE(of, dw9768_of_table); > > > > > + > > > > > +static const struct dev_pm_ops dw9768_pm_ops = { > > > > > + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > > > > > + pm_runtime_force_resume) > > > > > + SET_RUNTIME_PM_OPS(dw9768_runtime_suspend, dw9768_runtime_resume, NULL) > > > > > +}; > > > > > + > > > > > +static struct i2c_driver dw9768_i2c_driver = { > > > > > + .driver = { > > > > > + .name = DW9768_NAME, > > > > > + .pm = &dw9768_pm_ops, > > > > > + .of_match_table = dw9768_of_table, > > > > > + }, > > > > > + .probe_new = dw9768_probe, > > > > > + .remove = dw9768_remove, > > > > > +}; > > > > > +module_i2c_driver(dw9768_i2c_driver); > > > > > + > > > > > +MODULE_AUTHOR("Dongchun Zhu "); > > > > > +MODULE_DESCRIPTION("DW9768 VCM driver"); > > > > > +MODULE_LICENSE("GPL v2"); > > > > > > > > > > > -- > > Sakari Ailus _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0588DC35280 for ; Fri, 8 May 2020 03:19:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C588C2075E for ; Fri, 8 May 2020 03:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="anWvs9qe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="B4hhOqF7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C588C2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VScgFfp5zX5D6ehvlQ46SkfdR8AuZdGG5EbIjQqTYws=; b=anWvs9qexlOrB2 wq4wQUTjgeOL9k8SU/5Sg/69Q3OkcW8WsePnfDO998Uy/sLSmKnLgpl4WBOOWfcpgTnBPCrtlgUjM JbwxnjW9AHWQ3luSWeGkZ38ZqXXwb1XTikjM4XK1MUNy4I6RWZrG4vChjiFGgDEKJeNVB0KV6v4oe l7El4ps7uBNs1CyDhjTaIElv65pDGpA/q7XlaYMQ86hOaAhuQxI5dk9zBcys2+CdPkdGpOyolWFl/ unTBKBS0qYcbeDea6wIUKmI0lUA9Ext+yHDSUvLFRBaQisrJkD2EA06XkoLQLNxuClXeUhVzBlwa0 igh04gLjEYa1kcGy4tqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWtXx-0000DN-6u; Fri, 08 May 2020 03:19:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWtXq-0000C6-NU; Fri, 08 May 2020 03:19:29 +0000 X-UUID: e5c8f3608ad44370a25eafbf232a277a-20200507 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=zxrf2kTs3eDrMnUH9GHDlgcEj1tiqeJAGC48w/+m1fQ=; b=B4hhOqF79DBCCVmd+VWoD5wOIZERKatq0FoeNDxI7i/X2Kx4SIo0VTCkCMFZkxf8y+aWkfYcwXq7IOJLpF7vrATtV4WP+EdsFOWXITIyf3teH/ybdKZzPa2Of7hrnKGYO5KZVamPvH/CRr48rZrgAxrcawmDtQ3TgMh2lXYuDlU=; X-UUID: e5c8f3608ad44370a25eafbf232a277a-20200507 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1651750585; Thu, 07 May 2020 19:19:18 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 7 May 2020 20:09:18 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 May 2020 11:09:17 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 May 2020 11:09:15 +0800 Message-ID: <1588907288.8804.188.camel@mhfsdcap03> Subject: Re: [V5, 2/2] media: i2c: dw9768: Add DW9768 VCM driver From: Dongchun Zhu To: Tomasz Figa Date: Fri, 8 May 2020 11:08:08 +0800 In-Reply-To: References: <20200502161727.30463-1-dongchun.zhu@mediatek.com> <20200502161727.30463-3-dongchun.zhu@mediatek.com> <20200506151352.GZ9190@paasikivi.fi.intel.com> <1588855524.8804.168.camel@mhfsdcap03> <20200507131220.GC9190@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BDE6ECBE2824A449FE8336CA19D39D8390089DCD152D8C6D3556D62553DB6B162000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_201926_785865_53F78FD1 X-CRM114-Status: GOOD ( 34.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Louis Kuo , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Sakari Ailus , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, Tomasz, Thanks for the review. On Thu, 2020-05-07 at 15:46 +0200, Tomasz Figa wrote: > Hi Sakari, Dongchun, > > On Thu, May 7, 2020 at 3:12 PM Sakari Ailus > wrote: > > > > HI Dongchun, > > > > On Thu, May 07, 2020 at 08:45:24PM +0800, Dongchun Zhu wrote: > > > Hi Sakari, > > > > > > Thanks for the review. > > > > > > On Wed, 2020-05-06 at 18:13 +0300, Sakari Ailus wrote: > > > > Hi Dongchun, > > > > > > > > On Sun, May 03, 2020 at 12:17:27AM +0800, Dongchun Zhu wrote: > > > > > Add a V4L2 sub-device driver for DW9768 voice coil motor, providing > > > > > control to set the desired focus via IIC serial interface. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > --- > > > > > MAINTAINERS | 1 + > > > > > drivers/media/i2c/Kconfig | 11 ++ > > > > > drivers/media/i2c/Makefile | 1 + > > > > > drivers/media/i2c/dw9768.c | 440 +++++++++++++++++++++++++++++++++++++++++++++ > > > > > 4 files changed, 453 insertions(+) > > > > > create mode 100644 drivers/media/i2c/dw9768.c > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 8d72c41..c92dc99 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -5157,6 +5157,7 @@ L: linux-media@vger.kernel.org > > > > > S: Maintained > > > > > T: git git://linuxtv.org/media_tree.git > > > > > F: Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml > > > > > +F: drivers/media/i2c/dw9768.c > > > > > > > > > > DONGWOON DW9807 LENS VOICE COIL DRIVER > > > > > M: Sakari Ailus > > > > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > > > > index 125d596..6a3f9da 100644 > > > > > --- a/drivers/media/i2c/Kconfig > > > > > +++ b/drivers/media/i2c/Kconfig > > > > > @@ -1040,6 +1040,17 @@ config VIDEO_DW9714 > > > > > capability. This is designed for linear control of > > > > > voice coil motors, controlled via I2C serial interface. > > > > > > > > > > +config VIDEO_DW9768 > > > > > + tristate "DW9768 lens voice coil support" > > > > > + depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER > > > > > + depends on VIDEO_V4L2_SUBDEV_API > > > > > > > > Please check how this works in the media tree master branch now --- it's > > > > largely select based. > > > > > > > > > > The actuator driver uses some structures that require the > > > VIDEO_V4L2_SUBDEV_API code, so here we add VIDEO_V4L2_SUBDEV_API > > > dependency to avoid possible build error when it's not enabled. > > > > Please make sure this works with current media tree master. Right now it > > does not. > > > > Dongchun, as Sakari said, please make sure to base the patches on the > master branch of the media tree. > (https://git.linuxtv.org/media_tree.git/). The approach for Kconfig > dependency selection there seems to have changed recently. > I searched the patches on the media tree master branch. It seems that we need to remove the VIDEO_V4L2_SUBDEV_API dependency in Kconfig, and add #ifdef CONFIG_VIDEO_V4L2_SUBDEV_API to include v4l2-subdev code. The change mainly is to make build pass, and don't return ENOTTY if SUBDEV_API is not set. Am I right? > > > > > > > In general the patch seems fine to me, but please see the other comments > > > > below, too. > > > > > > > > > + depends on PM > > > > > + help > > > > > + This is a driver for the DW9768 camera lens voice coil. > > > > > + DW9768 is a 10 bit DAC with 100mA output current sink > > > > > + capability. This is designed for linear control of > > > > > + voice coil motors, controlled via I2C serial interface. > > > > > + > > > > > config VIDEO_DW9807_VCM > > > > > tristate "DW9807 lens voice coil support" > > > > > depends on I2C && VIDEO_V4L2 && MEDIA_CONTROLLER > > > > > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile > > > > > index 77bf7d0..4057476 100644 > > > > > --- a/drivers/media/i2c/Makefile > > > > > +++ b/drivers/media/i2c/Makefile > > > > > @@ -24,6 +24,7 @@ obj-$(CONFIG_VIDEO_SAA6752HS) += saa6752hs.o > > > > > obj-$(CONFIG_VIDEO_AD5820) += ad5820.o > > > > > obj-$(CONFIG_VIDEO_AK7375) += ak7375.o > > > > > obj-$(CONFIG_VIDEO_DW9714) += dw9714.o > > > > > +obj-$(CONFIG_VIDEO_DW9768) += dw9768.o > > > > > obj-$(CONFIG_VIDEO_DW9807_VCM) += dw9807-vcm.o > > > > > obj-$(CONFIG_VIDEO_ADV7170) += adv7170.o > > > > > obj-$(CONFIG_VIDEO_ADV7175) += adv7175.o > > > > > diff --git a/drivers/media/i2c/dw9768.c b/drivers/media/i2c/dw9768.c > > > > > new file mode 100644 > > > > > index 0000000..dd68534 > > > > > --- /dev/null > > > > > +++ b/drivers/media/i2c/dw9768.c > > > > > @@ -0,0 +1,440 @@ > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > +// Copyright (c) 2020 MediaTek Inc. > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#define DW9768_NAME "dw9768" > > > > > +#define DW9768_MAX_FOCUS_POS (1024 - 1) > > > > > +/* > > > > > + * This sets the minimum granularity for the focus positions. > > > > > + * A value of 1 gives maximum accuracy for a desired focus position > > > > > + */ > > > > > +#define DW9768_FOCUS_STEPS 1 > > > > > + > > > > > +/* > > > > > + * Ring control and Power control register > > > > > + * Bit[1] RING_EN > > > > > + * 0: Direct mode > > > > > + * 1: AAC mode (ringing control mode) > > > > > + * Bit[0] PD > > > > > + * 0: Normal operation mode > > > > > + * 1: Power down mode > > > > > + * DW9768 requires waiting time of Topr after PD reset takes place. > > > > > + */ > > > > > +#define DW9768_RING_PD_CONTROL_REG 0x02 > > > > > +#define DW9768_PD_MODE_OFF 0x00 > > > > > +#define DW9768_PD_MODE_EN BIT(0) > > > > > +#define DW9768_AAC_MODE_EN BIT(1) > > > > > + > > > > > +/* > > > > > + * DW9768 separates two registers to control the VCM position. > > > > > + * One for MSB value, another is LSB value. > > > > > + * DAC_MSB: D[9:8] (ADD: 0x03) > > > > > + * DAC_LSB: D[7:0] (ADD: 0x04) > > > > > + * D[9:0] DAC data input: positive output current = D[9:0] / 1023 * 100[mA] > > > > > + */ > > > > > +#define DW9768_MSB_ADDR 0x03 > > > > > +#define DW9768_LSB_ADDR 0x04 > > > > > +#define DW9768_STATUS_ADDR 0x05 > > > > > + > > > > > +/* > > > > > + * AAC mode control & prescale register > > > > > + * Bit[7:5] Namely AC[2:0], decide the VCM mode and operation time. > > > > > + * 000 Direct(default) > > > > > + * 001 AAC2 0.48xTvib > > > > > + * 010 AAC3 0.70xTvib > > > > > + * 011 AAC4 0.75xTvib > > > > > + * 100 Reserved > > > > > + * 101 AAC8 1.13xTvib > > > > > + * 110 Reserved > > > > > + * 111 Reserved > > > > > + * Bit[2:0] Namely PRESC[2:0], set the internal clock dividing rate as follow. > > > > > + * 000 2 > > > > > + * 001 1(default) > > > > > + * 010 1/2 > > > > > + * 011 1/4 > > > > > + * 100 8 > > > > > + * 101 4 > > > > > + * 110 Reserved > > > > > + * 111 Reserved > > > > > + */ > > > > > +#define DW9768_AAC_PRESC_REG 0x06 > > > > > +#define DW9768_AAC3_SELECT_DIVIDING_RATE_1 0x41 > > > > > > > > I guess we can start with these values. But I can't think of another option > > > > than putting them into DT if there are differences between what hardware > > > > platforms require. > > > > > > > > > > Let's have a discussion about this. > > > Now these non-default register settings represent one AAC operation > > > mode, this is one option and works for a given lens or a module. > > > If sometime in the future hardware platforms require another different > > > settings, then DT properties may need to be created. > > > > If these values indeed are specific to a given lens (and presumably also a > > spring), then I'd put them to DT right now --- we don't have drivers for > > these components the drivers of which could hold this information, nor it > > makes sense to add them just for that. > > > > I tend to stay on the conservative side and only add DT properties > once there is really a need to do so. Right now we haven't seen any > system which would use different values of these parameters. > > Best regards, > Tomasz > > > > > > > > > + > > > > > +/* > > > > > + * VCM period of vibration register > > > > > + * Bit[5:0] Defined as VCM rising periodic time (Tvib) together with PRESC[2:0] > > > > > + * Tvib = (6.3ms + AACT[5:0] * 0.1ms) * Dividing Rate > > > > > + * Dividing Rate is the internal clock dividing rate that is defined at > > > > > + * PRESCALE register (ADD: 0x06) > > > > > + */ > > > > > +#define DW9768_AAC_TIME_REG 0x07 > > > > > +#define DW9768_AACT_CNT 0x39 > > > > > + > > > > > +/* > > > > > + * DW9768 requires waiting time (delay time) of t_OPR after power-up, > > > > > + * or in the case of PD reset taking place. > > > > > + */ > > > > > +#define DW9768_T_OPR_US 1000 > > > > > + > > > > > +/* > > > > > + * This acts as the minimum granularity of lens movement. > > > > > + * Keep this value power of 2, so the control steps can be > > > > > + * uniformly adjusted for gradual lens movement, with desired > > > > > + * number of control steps. > > > > > + */ > > > > > +#define DW9768_MOVE_STEPS 16 > > > > > + > > > > > +/* > > > > > + * DW9768_AAC_PRESC_REG & DW9768_AAC_TIME_REG determine VCM operation time. > > > > > + * If DW9768_AAC_PRESC_REG is 0x41, and DW9768_AAC_TIME_REG is 0x39, VCM mode > > > > > + * would be AAC3, Operation Time would be 0.70xTvib, that is 8.40ms. > > > > > + */ > > > > > +#define DW9768_MOVE_DELAY_US 8400 > > > > > +#define DW9768_STABLE_TIME_US 20000 > > > > > + > > > > > +static const char * const dw9768_supply_names[] = { > > > > > + "vin", /* I2C I/O interface power */ > > > > > + "vdd", /* VCM power */ > > > > > +}; > > > > > + > > > > > +/* dw9768 device structure */ > > > > > +struct dw9768 { > > > > > + struct regulator_bulk_data supplies[ARRAY_SIZE(dw9768_supply_names)]; > > > > > + struct v4l2_ctrl_handler ctrls; > > > > > + struct v4l2_ctrl *focus; > > > > > + struct v4l2_subdev sd; > > > > > +}; > > > > > + > > > > > +static inline struct dw9768 *to_dw9768(struct v4l2_ctrl *ctrl) > > > > > +{ > > > > > + return container_of(ctrl->handler, struct dw9768, ctrls); > > > > > +} > > > > > > > > This is used in a single place. I'd just use container_of() directly there. > > > > > > > > > > Thanks for the reminder. > > > Fixed in next release. > > > > > > > > + > > > > > +static inline struct dw9768 *sd_to_dw9768(struct v4l2_subdev *subdev) > > > > > +{ > > > > > + return container_of(subdev, struct dw9768, sd); > > > > > +} > > > > > + > > > > > +struct regval_list { > > > > > + u8 reg_num; > > > > > + u8 value; > > > > > +}; > > > > > + > > > > > +static const struct regval_list dw9768_init_regs[] = { > > > > > + {DW9768_RING_PD_CONTROL_REG, DW9768_AAC_MODE_EN}, > > > > > + {DW9768_AAC_PRESC_REG, DW9768_AAC3_SELECT_DIVIDING_RATE_1}, > > > > > + {DW9768_AAC_TIME_REG, DW9768_AACT_CNT}, > > > > > +}; > > > > > + > > > > > +static int dw9768_write_array(struct dw9768 *dw9768, > > > > > + const struct regval_list *vals, size_t len) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + unsigned int i; > > > > > + int ret; > > > > > + > > > > > + for (i = 0; i < len; i++) { > > > > > + ret = i2c_smbus_write_byte_data(client, vals[i].reg_num, > > > > > + vals[i].value); > > > > > + if (ret < 0) > > > > > + return ret; > > > > > + } > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_set_dac(struct dw9768 *dw9768, u16 val) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + > > > > > + /* Write VCM position to registers */ > > > > > + return i2c_smbus_write_word_swapped(client, DW9768_MSB_ADDR, val); > > > > > +} > > > > > + > > > > > +static int dw9768_init(struct dw9768 *dw9768) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + int ret, val; > > > > > + > > > > > + /* Reset DW9768_RING_PD_CONTROL_REG to default status 0x00 */ > > > > > + ret = i2c_smbus_write_byte_data(client, DW9768_RING_PD_CONTROL_REG, > > > > > + DW9768_PD_MODE_OFF); > > > > > + if (ret < 0) > > > > > + return ret; > > > > > + > > > > > + /* > > > > > + * DW9769 requires waiting delay time of t_OPR > > > > > + * after PD reset takes place. > > > > > + */ > > > > > + usleep_range(DW9768_T_OPR_US, DW9768_T_OPR_US + 100); > > > > > + > > > > > + ret = dw9768_write_array(dw9768, dw9768_init_regs, > > > > > + ARRAY_SIZE(dw9768_init_regs)); > > > > > + if (ret) > > > > > + return ret; > > > > > + > > > > > + for (val = dw9768->focus->val % DW9768_MOVE_STEPS; > > > > > + val <= dw9768->focus->val; > > > > > + val += DW9768_MOVE_STEPS) { > > > > > + ret = dw9768_set_dac(dw9768, val); > > > > > + if (ret) { > > > > > + dev_err(&client->dev, "%s I2C failure: %d", > > > > > + __func__, ret); > > > > > + return ret; > > > > > + } > > > > > + usleep_range(DW9768_MOVE_DELAY_US, > > > > > + DW9768_MOVE_DELAY_US + 1000); > > > > > + } > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_release(struct dw9768 *dw9768) > > > > > +{ > > > > > + struct i2c_client *client = v4l2_get_subdevdata(&dw9768->sd); > > > > > + int ret, val; > > > > > + > > > > > + val = round_down(dw9768->focus->val, DW9768_MOVE_STEPS); > > > > > + for ( ; val >= 0; val -= DW9768_MOVE_STEPS) { > > > > > + ret = dw9768_set_dac(dw9768, val); > > > > > + if (ret) { > > > > > + dev_err(&client->dev, "I2C write fail: %d", ret); > > > > > + return ret; > > > > > + } > > > > > + usleep_range(DW9768_MOVE_DELAY_US, DW9768_MOVE_DELAY_US + 1000); > > > > > + } > > > > > + > > > > > + /* > > > > > + * Wait for the motor to stabilize after the last movement > > > > > + * to prevent the motor from shaking. > > > > > + */ > > > > > + usleep_range(DW9768_STABLE_TIME_US - DW9768_MOVE_DELAY_US, > > > > > + DW9768_STABLE_TIME_US - DW9768_MOVE_DELAY_US + 1000); > > > > > + > > > > > + ret = i2c_smbus_write_byte_data(client, DW9768_RING_PD_CONTROL_REG, > > > > > + DW9768_PD_MODE_EN); > > > > > + if (ret < 0) > > > > > + return ret; > > > > > + > > > > > + /* > > > > > + * DW9769 requires waiting delay time of t_OPR > > > > > + * after PD reset takes place. > > > > > + */ > > > > > + usleep_range(DW9768_T_OPR_US, DW9768_T_OPR_US + 100); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int __maybe_unused dw9768_runtime_suspend(struct device *dev) > > > > > +{ > > > > > + struct i2c_client *client = to_i2c_client(dev); > > > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > > + struct dw9768 *dw9768 = sd_to_dw9768(sd); > > > > > + > > > > > + dw9768_release(dw9768); > > > > > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int __maybe_unused dw9768_runtime_resume(struct device *dev) > > > > > +{ > > > > > + struct i2c_client *client = to_i2c_client(dev); > > > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > > + struct dw9768 *dw9768 = sd_to_dw9768(sd); > > > > > + int ret; > > > > > + > > > > > + ret = regulator_bulk_enable(ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + if (ret < 0) { > > > > > + dev_err(dev, "failed to enable regulators\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + /* > > > > > + * The datasheet refers to t_OPR that needs to be waited before sending > > > > > + * I2C commands after power-up. > > > > > + */ > > > > > + usleep_range(DW9768_T_OPR_US, DW9768_T_OPR_US + 100); > > > > > + > > > > > + ret = dw9768_init(dw9768); > > > > > + if (ret < 0) > > > > > + goto disable_regulator; > > > > > + > > > > > + return 0; > > > > > + > > > > > +disable_regulator: > > > > > + regulator_bulk_disable(ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + > > > > > + return ret; > > > > > +} > > > > > + > > > > > +static int dw9768_set_ctrl(struct v4l2_ctrl *ctrl) > > > > > +{ > > > > > + struct dw9768 *dw9768 = to_dw9768(ctrl); > > > > > + > > > > > + if (ctrl->id == V4L2_CID_FOCUS_ABSOLUTE) > > > > > + return dw9768_set_dac(dw9768, ctrl->val); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static const struct v4l2_ctrl_ops dw9768_ctrl_ops = { > > > > > + .s_ctrl = dw9768_set_ctrl, > > > > > +}; > > > > > + > > > > > +static int dw9768_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > > > > +{ > > > > > + int ret; > > > > > + > > > > > + ret = pm_runtime_get_sync(sd->dev); > > > > > + if (ret < 0) { > > > > > + pm_runtime_put_noidle(sd->dev); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_close(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh) > > > > > +{ > > > > > + pm_runtime_put(sd->dev); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static const struct v4l2_subdev_internal_ops dw9768_int_ops = { > > > > > + .open = dw9768_open, > > > > > + .close = dw9768_close, > > > > > +}; > > > > > + > > > > > +static const struct v4l2_subdev_ops dw9768_ops = { }; > > > > > + > > > > > +static int dw9768_init_controls(struct dw9768 *dw9768) > > > > > +{ > > > > > + struct v4l2_ctrl_handler *hdl = &dw9768->ctrls; > > > > > + const struct v4l2_ctrl_ops *ops = &dw9768_ctrl_ops; > > > > > + > > > > > + v4l2_ctrl_handler_init(hdl, 1); > > > > > + > > > > > + dw9768->focus = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_FOCUS_ABSOLUTE, 0, > > > > > + DW9768_MAX_FOCUS_POS, > > > > > + DW9768_FOCUS_STEPS, 0); > > > > > + > > > > > + if (hdl->error) > > > > > + return hdl->error; > > > > > + > > > > > + dw9768->sd.ctrl_handler = hdl; > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int dw9768_probe(struct i2c_client *client) > > > > > +{ > > > > > + struct device *dev = &client->dev; > > > > > + struct dw9768 *dw9768; > > > > > + unsigned int i; > > > > > + int ret; > > > > > + > > > > > + dw9768 = devm_kzalloc(dev, sizeof(*dw9768), GFP_KERNEL); > > > > > + if (!dw9768) > > > > > + return -ENOMEM; > > > > > + > > > > > + v4l2_i2c_subdev_init(&dw9768->sd, client, &dw9768_ops); > > > > > + > > > > > + for (i = 0; i < ARRAY_SIZE(dw9768_supply_names); i++) > > > > > + dw9768->supplies[i].supply = dw9768_supply_names[i]; > > > > > + > > > > > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dw9768_supply_names), > > > > > + dw9768->supplies); > > > > > + if (ret) { > > > > > + dev_err(dev, "failed to get regulators\n"); > > > > > + return ret; > > > > > + } > > > > > + > > > > > + ret = dw9768_init_controls(dw9768); > > > > > + if (ret) > > > > > + goto entity_cleanup; > > > > > + > > > > > + dw9768->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; > > > > > + dw9768->sd.internal_ops = &dw9768_int_ops; > > > > > + > > > > > + ret = media_entity_pads_init(&dw9768->sd.entity, 0, NULL); > > > > > + if (ret < 0) > > > > > + goto entity_cleanup; > > > > > + > > > > > + dw9768->sd.entity.function = MEDIA_ENT_F_LENS; > > > > > + > > > > > + pm_runtime_enable(dev); > > > > > + if (!pm_runtime_enabled(dev)) { > > > > > + ret = dw9768_runtime_resume(dev); > > > > > + if (ret < 0) { > > > > > + dev_err(dev, "failed to power on: %d\n", ret); > > > > > + goto entity_cleanup; > > > > > + } > > > > > + } > > > > > + > > > > > + ret = v4l2_async_register_subdev(&dw9768->sd); > > > > > + if (ret < 0) > > > > > + goto entity_cleanup; > > > > > + > > > > > + return 0; > > > > > + > > > > > +entity_cleanup: > > > > > + v4l2_ctrl_handler_free(&dw9768->ctrls); > > > > > + media_entity_cleanup(&dw9768->sd.entity); > > > > > + return ret; > > > > > +} > > > > > + > > > > > +static int dw9768_remove(struct i2c_client *client) > > > > > +{ > > > > > + struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > > + struct dw9768 *dw9768 = sd_to_dw9768(sd); > > > > > + > > > > > + pm_runtime_disable(&client->dev); > > > > > + v4l2_async_unregister_subdev(&dw9768->sd); > > > > > + v4l2_ctrl_handler_free(&dw9768->ctrls); > > > > > + media_entity_cleanup(&dw9768->sd.entity); > > > > > + if (!pm_runtime_status_suspended(&client->dev)) > > > > > + dw9768_runtime_suspend(&client->dev); > > > > > + pm_runtime_set_suspended(&client->dev); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static const struct of_device_id dw9768_of_table[] = { > > > > > + { .compatible = "dongwoon,dw9768" }, > > > > > + {} > > > > > +}; > > > > > +MODULE_DEVICE_TABLE(of, dw9768_of_table); > > > > > + > > > > > +static const struct dev_pm_ops dw9768_pm_ops = { > > > > > + SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, > > > > > + pm_runtime_force_resume) > > > > > + SET_RUNTIME_PM_OPS(dw9768_runtime_suspend, dw9768_runtime_resume, NULL) > > > > > +}; > > > > > + > > > > > +static struct i2c_driver dw9768_i2c_driver = { > > > > > + .driver = { > > > > > + .name = DW9768_NAME, > > > > > + .pm = &dw9768_pm_ops, > > > > > + .of_match_table = dw9768_of_table, > > > > > + }, > > > > > + .probe_new = dw9768_probe, > > > > > + .remove = dw9768_remove, > > > > > +}; > > > > > +module_i2c_driver(dw9768_i2c_driver); > > > > > + > > > > > +MODULE_AUTHOR("Dongchun Zhu "); > > > > > +MODULE_DESCRIPTION("DW9768 VCM driver"); > > > > > +MODULE_LICENSE("GPL v2"); > > > > > > > > > > > -- > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel