From: Chris Wilson <chris@chris-wilson.co.uk>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Force pte cacheline to main memory
Date: Mon, 11 May 2020 17:13:52 +0100 [thread overview]
Message-ID: <158921363228.1729.5879156210323656119@build.alporthouse.com> (raw)
In-Reply-To: <20200511160803.15407-1-mika.kuoppala@linux.intel.com>
Quoting Mika Kuoppala (2020-05-11 17:08:03)
> We have problems of tgl not seeing a valid pte entry
> when iommu is enabled. Add heavy handed flushing
> of entry modification by flushing the cpu, cacheline
> and then wcb. This forces the pte out to main memory
> past this point regarless of promises of coherency.
>
> This is an evolution of an experimental patch from
> Chris Wilson of adding wmb for coherent partners,
> by adding a clflush to force the cache->memory step.
>
> Testcase: igt/gem_exec_fence/parallel
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Not only does it help tgl, but it is also helping with a coherency
problem on Braswell. We see similar problems on gen9 and icl, and I have
a trybot run to see if it helps with those.
As it is helping with multiple platforms and diverse symptoms, even if
we can't explain why it helps, it is. That makes it prudent to apply to
improve the baseline and work from there.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-11 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:08 [Intel-gfx] [PATCH] drm/i915: Force pte cacheline to main memory Mika Kuoppala
2020-05-11 16:13 ` Chris Wilson [this message]
2020-05-11 16:16 ` Chris Wilson
2020-05-11 18:45 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-11 22:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158921363228.1729.5879156210323656119@build.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.