* [Intel-gfx] [PATCH] drm/i915: Remove unused HAS_FWTABLE macro
@ 2020-05-10 21:25 Pascal Terjan
2020-05-11 15:55 ` Chris Wilson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Pascal Terjan @ 2020-05-10 21:25 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, intel-gfx; +Cc: Pascal Terjan
It has been unused since commit ccb2aceaaa5f ("drm/i915: use vfuncs for
reg_read/write_fw_domains").
Signed-off-by: Pascal Terjan <pterjan@google.com>
---
drivers/gpu/drm/i915/intel_uncore.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
index abb18b90d7c3..fd64415fcf8f 100644
--- a/drivers/gpu/drm/i915/intel_uncore.c
+++ b/drivers/gpu/drm/i915/intel_uncore.c
@@ -877,11 +877,6 @@ find_fw_domain(struct intel_uncore *uncore, u32 offset)
#define GEN_FW_RANGE(s, e, d) \
{ .start = (s), .end = (e), .domains = (d) }
-#define HAS_FWTABLE(dev_priv) \
- (INTEL_GEN(dev_priv) >= 9 || \
- IS_CHERRYVIEW(dev_priv) || \
- IS_VALLEYVIEW(dev_priv))
-
/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */
static const struct intel_forcewake_range __vlv_fw_ranges[] = {
GEN_FW_RANGE(0x2000, 0x3fff, FORCEWAKE_RENDER),
--
2.26.2.645.ge9eca65c58-goog
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove unused HAS_FWTABLE macro
2020-05-10 21:25 [Intel-gfx] [PATCH] drm/i915: Remove unused HAS_FWTABLE macro Pascal Terjan
@ 2020-05-11 15:55 ` Chris Wilson
2020-05-11 17:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-11 22:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2020-05-11 15:55 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Pascal Terjan, Rodrigo Vivi, intel-gfx
Cc: Pascal Terjan
Quoting Pascal Terjan (2020-05-10 22:25:21)
> It has been unused since commit ccb2aceaaa5f ("drm/i915: use vfuncs for
> reg_read/write_fw_domains").
>
> Signed-off-by: Pascal Terjan <pterjan@google.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused HAS_FWTABLE macro
2020-05-10 21:25 [Intel-gfx] [PATCH] drm/i915: Remove unused HAS_FWTABLE macro Pascal Terjan
2020-05-11 15:55 ` Chris Wilson
@ 2020-05-11 17:15 ` Patchwork
2020-05-11 22:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-11 17:15 UTC (permalink / raw)
To: Pascal Terjan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused HAS_FWTABLE macro
URL : https://patchwork.freedesktop.org/series/77158/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8466 -> Patchwork_17627
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/index.html
Known issues
------------
Here are the changes found in Patchwork_17627 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@hangcheck:
- fi-bwr-2160: [PASS][1] -> [INCOMPLETE][2] ([i915#489])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/fi-bwr-2160/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/fi-bwr-2160/igt@i915_selftest@live@hangcheck.html
[i915#489]: https://gitlab.freedesktop.org/drm/intel/issues/489
Participating hosts (49 -> 43)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8466 -> Patchwork_17627
CI-20190529: 20190529
CI_DRM_8466: eea130b942bec4cb8c19514b3a63aed25e4dec27 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5646: 5a5a3162a7638b3ae38b6dc2545622c204d1b97c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17627: e3dc906cf5dbe7fa3ab94c3053b490c3657d9c08 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e3dc906cf5db drm/i915: Remove unused HAS_FWTABLE macro
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove unused HAS_FWTABLE macro
2020-05-10 21:25 [Intel-gfx] [PATCH] drm/i915: Remove unused HAS_FWTABLE macro Pascal Terjan
2020-05-11 15:55 ` Chris Wilson
2020-05-11 17:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-05-11 22:38 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2020-05-11 22:38 UTC (permalink / raw)
To: Pascal Terjan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unused HAS_FWTABLE macro
URL : https://patchwork.freedesktop.org/series/77158/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8466_full -> Patchwork_17627_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17627_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#180])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-apl2/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#72])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-glk6/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][5] -> [FAIL][6] ([i915#1188])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-skl2/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][7] -> [FAIL][8] ([fdo#108145] / [i915#265])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109441]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][13] ([i915#180]) -> [PASS][14] +9 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
- shard-skl: [INCOMPLETE][15] ([i915#300]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-skl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_legacy@pipe-d-single-move:
- shard-tglb: [SKIP][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-tglb3/igt@kms_cursor_legacy@pipe-d-single-move.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-tglb7/igt@kms_cursor_legacy@pipe-d-single-move.html
* {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}:
- shard-apl: [DMESG-WARN][19] ([i915#180]) -> [PASS][20] +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][21] ([fdo#109441]) -> [PASS][22] +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][23] ([i915#31]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-apl8/igt@kms_setmode@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-apl2/igt@kms_setmode@basic.html
* {igt@perf@blocking-parameterized}:
- shard-iclb: [FAIL][25] ([i915#1542]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-iclb7/igt@perf@blocking-parameterized.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-iclb2/igt@perf@blocking-parameterized.html
#### Warnings ####
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: [FAIL][27] ([i915#454]) -> [SKIP][28] ([i915#468])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-tglb1/igt@i915_pm_dc@dc6-dpms.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-tglb2/igt@i915_pm_dc@dc6-dpms.html
* igt@kms_content_protection@srm:
- shard-apl: [TIMEOUT][29] ([i915#1319]) -> [FAIL][30] ([fdo#110321])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-apl1/igt@kms_content_protection@srm.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-apl1/igt@kms_content_protection@srm.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: [FAIL][31] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][32] ([fdo#108145] / [i915#265])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8466/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8466 -> Patchwork_17627
CI-20190529: 20190529
CI_DRM_8466: eea130b942bec4cb8c19514b3a63aed25e4dec27 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5646: 5a5a3162a7638b3ae38b6dc2545622c204d1b97c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17627: e3dc906cf5dbe7fa3ab94c3053b490c3657d9c08 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17627/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-11 22:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 21:25 [Intel-gfx] [PATCH] drm/i915: Remove unused HAS_FWTABLE macro Pascal Terjan
2020-05-11 15:55 ` Chris Wilson
2020-05-11 17:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-11 22:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.