From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BA0C54E4A for ; Tue, 12 May 2020 10:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 07EF5205ED for ; Tue, 12 May 2020 10:52:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729283AbgELKwC convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2020 06:52:02 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:54379 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729247AbgELKwC (ORCPT ); Tue, 12 May 2020 06:52:02 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21171647-1500050 for multiple; Tue, 12 May 2020 11:51:24 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT In-Reply-To: <87lflx309o.fsf@gaia.fi.intel.com> References: <20200509115217.26853-1-chris@chris-wilson.co.uk> <87lflx309o.fsf@gaia.fi.intel.com> From: Chris Wilson Cc: stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Watch out for idling during i915_gem_evict_something To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Message-ID: <158928068371.21674.17585538612679770949@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Tue, 12 May 2020 11:51:23 +0100 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Quoting Mika Kuoppala (2020-05-12 11:39:31) > Chris Wilson writes: > > > i915_gem_evict_something() is charged with finding a slot within the GTT > > that we may reuse. Since our goal is not to stall, we first look for a > > slot that only overlaps idle vma. To this end, on the first pass we move > > any active vma to the end of the search list. However, we only stopped > > moving active vma after we see the first active vma twice. If during the > > search, that first active vma completed, we would not notice and keep on > > extending the search list. > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1746 > > Signed-off-by: Chris Wilson > > Cc: Tvrtko Ursulin > > Cc: # v5.5+ > > Only thing I would change is tune up the subject line. > It fixes a possible busy loop in eviction so I feel 'watch out' is not > strong enough for my liking. Duck and cover for the idling is a-coming! -Chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A69C54E4A for ; Tue, 12 May 2020 10:51:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17464205ED for ; Tue, 12 May 2020 10:51:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17464205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AC2BD6E0CE; Tue, 12 May 2020 10:51:28 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id D30D66E0CE for ; Tue, 12 May 2020 10:51:27 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21171647-1500050 for multiple; Tue, 12 May 2020 11:51:24 +0100 MIME-Version: 1.0 In-Reply-To: <87lflx309o.fsf@gaia.fi.intel.com> References: <20200509115217.26853-1-chris@chris-wilson.co.uk> <87lflx309o.fsf@gaia.fi.intel.com> From: Chris Wilson To: Mika Kuoppala , intel-gfx@lists.freedesktop.org Message-ID: <158928068371.21674.17585538612679770949@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Tue, 12 May 2020 11:51:23 +0100 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Watch out for idling during i915_gem_evict_something X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Mika Kuoppala (2020-05-12 11:39:31) > Chris Wilson writes: > > > i915_gem_evict_something() is charged with finding a slot within the GTT > > that we may reuse. Since our goal is not to stall, we first look for a > > slot that only overlaps idle vma. To this end, on the first pass we move > > any active vma to the end of the search list. However, we only stopped > > moving active vma after we see the first active vma twice. If during the > > search, that first active vma completed, we would not notice and keep on > > extending the search list. > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1746 > > Signed-off-by: Chris Wilson > > Cc: Tvrtko Ursulin > > Cc: # v5.5+ > > Only thing I would change is tune up the subject line. > It fixes a possible busy loop in eviction so I feel 'watch out' is not > strong enough for my liking. Duck and cover for the idling is a-coming! -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx