* [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization
@ 2020-05-13 12:28 Chris Wilson
2020-05-13 12:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Chris Wilson @ 2020-05-13 12:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Chris Wilson
It is possible for a residual tasklet to be pending execution as we
resume (whether that's some prior test kicking off the tasklet, or if we
are in a suspend/resume stress test). As such, we do not want that
tasklet to execute in the middle of our sanitization, such that it sees
the poisoned state. For example,
<4>[ 449.386553] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
<4>[ 449.386555] CPU: 1 PID: 5115 Comm: i915_selftest Tainted: G U W 5.7.0-rc4-CI-CI_DRM_8472+ #1
<4>[ 449.386556] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
<4>[ 449.386585] RIP: 0010:process_csb+0x6bf/0x830 [i915]
<4>[ 449.386588] Code: 00 48 c7 c2 10 bc 4c a0 48 c7 c7 d4 75 34 a0 e8 87 0e e6 e0 bf 01 00 00 00 e8 9d e0 e5 e0 31 f6 bf 09 00 00 00 e8 e1 ba d6 e0 <0f> 0b 8b 87 10 05 00 00 85 c0 0f 85 5f f9 ff ff 48 c7 c1 70 a5 4f
<4>[ 449.386591] RSP: 0018:ffffc90000170ea0 EFLAGS: 00010297
<4>[ 449.386594] RAX: 0000000080000101 RBX: 0000000000000000 RCX: 0000000000000000
<4>[ 449.386596] RDX: ffff88849d5bc040 RSI: 0000000000000000 RDI: 0000000000000009
<4>[ 449.386598] RBP: ffffc90000170f00 R08: 0000000000000000 R09: 0000000000000000
<4>[ 449.386600] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88843ccea018
<4>[ 449.386602] R13: ffff88843ccea658 R14: ffff88843ccea640 R15: ffff88843ccea000
<4>[ 449.386605] FS: 00007f826a813300(0000) GS:ffff88849fe80000(0000) knlGS:0000000000000000
<4>[ 449.386607] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[ 449.386609] CR2: 0000560366b94280 CR3: 000000048ba02002 CR4: 0000000000760ee0
<4>[ 449.386611] PKRU: 55555554
<4>[ 449.386613] Call Trace:
<4>[ 449.386616] <IRQ>
<4>[ 449.386646] ? execlists_submission_tasklet+0xcf/0x140 [i915]
<4>[ 449.386674] execlists_submission_tasklet+0x2f/0x140 [i915]
<4>[ 449.386679] tasklet_action_common.isra.16+0x6c/0x1c0
<4>[ 449.386684] __do_softirq+0xdf/0x49e
<4>[ 449.386687] irq_exit+0xba/0xc0
<4>[ 449.386690] smp_apic_timer_interrupt+0xb7/0x280
<4>[ 449.386693] apic_timer_interrupt+0xf/0x20
<4>[ 449.386695] </IRQ>
<4>[ 449.386698] RIP: 0010:_raw_spin_unlock_irqrestore+0x49/0x60
<4>[ 449.386701] Code: c7 02 75 1f 53 9d e8 26 ab 75 ff bf 01 00 00 00 e8 7c a3 69 ff 65 8b 05 7d 9b 5c 7e 85 c0 74 0c 5b 5d c3 e8 09 aa 75 ff 53 9d <eb> df e8 ca 39 5b ff 5b 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00
<4>[ 449.386703] RSP: 0018:ffffc90000a6b950 EFLAGS: 00000202 ORIG_RAX: ffffffffffffff13
<4>[ 449.386706] RAX: 0000000080000001 RBX: 0000000000000202 RCX: 0000000000000000
<4>[ 449.386708] RDX: ffff88849d5bc040 RSI: ffff88849d5bc900 RDI: ffffffff82386f12
<4>[ 449.386710] RBP: ffff88847d400f00 R08: ffff88849d5bc900 R09: 0000000000000000
<4>[ 449.386712] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000ffff0b0b
<4>[ 449.386714] R13: 000000000000000c R14: ffff88847d40bf70 R15: ffff88847d40cef8
<4>[ 449.386742] reset_csb_pointers+0x59/0x140 [i915]
<4>[ 449.386769] execlists_sanitize+0x3e/0x60 [i915]
<4>[ 449.386797] gt_sanitize+0xd6/0x260 [i915]
As part of the reset preparation, engine->reset.prepare() prevents the
tasklet from running, so pull the sanitization inside the critical
section for reset.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1812
Fixes: 23122a4d992b ("drm/i915/gt: Scrub execlists state on resume")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index e59776485457..6bdb434a442d 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -150,10 +150,6 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
if (intel_gt_is_wedged(gt))
intel_gt_unset_wedged(gt);
- for_each_engine(engine, gt, id)
- if (engine->sanitize)
- engine->sanitize(engine);
-
intel_uc_sanitize(>->uc);
for_each_engine(engine, gt, id)
@@ -162,6 +158,10 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
intel_uc_reset_prepare(>->uc);
+ for_each_engine(engine, gt, id)
+ if (engine->sanitize)
+ engine->sanitize(engine);
+
if (reset_engines(gt) || force) {
for_each_engine(engine, gt, id)
__intel_engine_reset(engine, false);
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Suspend tasklets before resume sanitization
2020-05-13 12:28 [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization Chris Wilson
@ 2020-05-13 12:48 ` Patchwork
2020-05-13 13:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-05-13 12:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Suspend tasklets before resume sanitization
URL : https://patchwork.freedesktop.org/series/77223/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a06430f11a80 drm/i915/gt: Suspend tasklets before resume sanitization
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
<4>[ 449.386555] CPU: 1 PID: 5115 Comm: i915_selftest Tainted: G U W 5.7.0-rc4-CI-CI_DRM_8472+ #1
total: 0 errors, 1 warnings, 0 checks, 20 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Suspend tasklets before resume sanitization
2020-05-13 12:28 [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization Chris Wilson
2020-05-13 12:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2020-05-13 13:12 ` Patchwork
2020-05-13 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-13 16:05 ` [Intel-gfx] [PATCH] " Mika Kuoppala
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-05-13 13:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Suspend tasklets before resume sanitization
URL : https://patchwork.freedesktop.org/series/77223/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8472 -> Patchwork_17645
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/index.html
Known issues
------------
Here are the changes found in Patchwork_17645 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_lrc:
- fi-bsw-n3050: [PASS][1] -> [INCOMPLETE][2] ([i915#1250] / [i915#1436])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- fi-skl-guc: [INCOMPLETE][3] ([i915#1874]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/fi-skl-guc/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/fi-skl-guc/igt@i915_selftest@live@execlists.html
- {fi-tgl-dsi}: [INCOMPLETE][5] ([i915#1803]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/fi-tgl-dsi/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/fi-tgl-dsi/igt@i915_selftest@live@execlists.html
* igt@i915_selftest@live@gt_pm:
- fi-icl-u2: [INCOMPLETE][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/fi-icl-u2/igt@i915_selftest@live@gt_pm.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/fi-icl-u2/igt@i915_selftest@live@gt_pm.html
- fi-bdw-5557u: [INCOMPLETE][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/fi-bdw-5557u/igt@i915_selftest@live@gt_pm.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/fi-bdw-5557u/igt@i915_selftest@live@gt_pm.html
* {igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2}:
- fi-bsw-n3050: [FAIL][11] ([i915#34]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/fi-bsw-n3050/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1250]: https://gitlab.freedesktop.org/drm/intel/issues/1250
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1803]: https://gitlab.freedesktop.org/drm/intel/issues/1803
[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
Participating hosts (39 -> 44)
------------------------------
Additional (9): fi-cml-s fi-cfl-8700k fi-kbl-7500u fi-pnv-d510 fi-kbl-8809g fi-elk-e7500 fi-tgl-y fi-bsw-nick fi-kbl-r
Missing (4): fi-byt-clapper fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8472 -> Patchwork_17645
CI-20190529: 20190529
CI_DRM_8472: 57acc5ba2cfb81691917a3da729573a99c893e5a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5651: e54e2642f1967ca3c488db32264607df670d1dfb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17645: a06430f11a8054e6b4ee2cbae13fd781319329aa @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a06430f11a80 drm/i915/gt: Suspend tasklets before resume sanitization
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Suspend tasklets before resume sanitization
2020-05-13 12:28 [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization Chris Wilson
2020-05-13 12:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-05-13 13:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2020-05-13 15:23 ` Patchwork
2020-05-13 16:05 ` [Intel-gfx] [PATCH] " Mika Kuoppala
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-05-13 15:23 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Suspend tasklets before resume sanitization
URL : https://patchwork.freedesktop.org/series/77223/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8472_full -> Patchwork_17645_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
New tests
---------
New tests have been introduced between CI_DRM_8472_full and Patchwork_17645_full:
### New IGT tests (123) ###
* igt@kms_cursor_crc@pipe-a-cursor-128x128-offscreen:
- Statuses : 8 pass(s)
- Exec time: [2.98, 4.98] s
* igt@kms_cursor_crc@pipe-a-cursor-128x128-onscreen:
- Statuses : 8 pass(s)
- Exec time: [1.71, 2.86] s
* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- Statuses : 8 pass(s)
- Exec time: [2.73, 4.87] s
* igt@kms_cursor_crc@pipe-a-cursor-128x128-rapid-movement:
- Statuses : 8 pass(s)
- Exec time: [0.18, 1.08] s
* igt@kms_cursor_crc@pipe-a-cursor-128x128-sliding:
- Statuses : 8 pass(s)
- Exec time: [2.60, 4.27] s
* igt@kms_cursor_crc@pipe-a-cursor-128x42-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.96] s
* igt@kms_cursor_crc@pipe-a-cursor-128x42-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.92] s
* igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.42] s
* igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.27] s
* igt@kms_cursor_crc@pipe-a-cursor-256x256-offscreen:
- Statuses : 8 pass(s)
- Exec time: [2.96, 4.95] s
* igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen:
- Statuses : 7 pass(s)
- Exec time: [1.73, 2.88] s
* igt@kms_cursor_crc@pipe-a-cursor-256x256-random:
- Statuses : 1 fail(s) 7 pass(s)
- Exec time: [0.41, 4.43] s
* igt@kms_cursor_crc@pipe-a-cursor-256x256-rapid-movement:
- Statuses : 8 pass(s)
- Exec time: [0.28, 1.11] s
* igt@kms_cursor_crc@pipe-a-cursor-256x256-sliding:
- Statuses : 8 pass(s)
- Exec time: [2.62, 4.29] s
* igt@kms_cursor_crc@pipe-a-cursor-256x85-offscreen:
- Statuses : 1 fail(s) 6 pass(s) 1 skip(s)
- Exec time: [0.0, 4.95] s
* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.90] s
* igt@kms_cursor_crc@pipe-a-cursor-256x85-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.46] s
* igt@kms_cursor_crc@pipe-a-cursor-256x85-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.26] s
* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x170-random:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x170-sliding:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x512-onscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x512-random:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-512x512-sliding:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-a-cursor-64x21-offscreen:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 4.95] s
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.90] s
* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- Statuses : 1 fail(s) 6 pass(s) 1 skip(s)
- Exec time: [0.0, 4.44] s
* igt@kms_cursor_crc@pipe-a-cursor-64x21-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.71] s
* igt@kms_cursor_crc@pipe-a-cursor-64x64-offscreen:
- Statuses : 8 pass(s)
- Exec time: [2.98, 4.98] s
* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- Statuses : 8 pass(s)
- Exec time: [1.78, 3.27] s
* igt@kms_cursor_crc@pipe-a-cursor-64x64-random:
- Statuses : 8 pass(s)
- Exec time: [2.69, 4.47] s
* igt@kms_cursor_crc@pipe-a-cursor-64x64-rapid-movement:
- Statuses : 8 pass(s)
- Exec time: [0.19, 1.11] s
* igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
- Statuses : 8 pass(s)
- Exec time: [2.64, 5.73] s
* igt@kms_cursor_crc@pipe-a-cursor-alpha-opaque:
- Statuses : 8 pass(s)
- Exec time: [0.28, 1.07] s
* igt@kms_cursor_crc@pipe-a-cursor-alpha-transparent:
- Statuses : 8 pass(s)
- Exec time: [0.27, 1.06] s
* igt@kms_cursor_crc@pipe-a-cursor-dpms:
- Statuses : 8 pass(s)
- Exec time: [0.83, 4.28] s
* igt@kms_cursor_crc@pipe-a-cursor-size-change:
- Statuses : 8 pass(s)
- Exec time: [0.49, 1.86] s
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- Statuses : 8 pass(s)
- Exec time: [2.34, 5.20] s
* igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen:
- Statuses : 8 pass(s)
- Exec time: [4.04, 5.95] s
* igt@kms_cursor_crc@pipe-b-cursor-128x128-onscreen:
- Statuses : 8 pass(s)
- Exec time: [2.24, 4.53] s
* igt@kms_cursor_crc@pipe-b-cursor-128x128-random:
- Statuses : 8 pass(s)
- Exec time: [3.70, 5.49] s
* igt@kms_cursor_crc@pipe-b-cursor-128x128-rapid-movement:
- Statuses : 8 pass(s)
- Exec time: [0.27, 2.24] s
* igt@kms_cursor_crc@pipe-b-cursor-128x128-sliding:
- Statuses : 7 pass(s)
- Exec time: [3.58, 4.86] s
* igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen:
- Statuses : 1 fail(s) 6 pass(s) 1 skip(s)
- Exec time: [0.0, 5.40] s
* igt@kms_cursor_crc@pipe-b-cursor-128x42-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.02] s
* igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 6.01] s
* igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.42] s
* igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
- Statuses : 8 pass(s)
- Exec time: [4.08, 5.87] s
* igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
- Statuses : 8 pass(s)
- Exec time: [2.24, 3.99] s
* igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
- Statuses : 7 pass(s)
- Exec time: [3.71, 5.51] s
* igt@kms_cursor_crc@pipe-b-cursor-256x256-rapid-movement:
- Statuses : 8 pass(s)
- Exec time: [0.27, 2.24] s
* igt@kms_cursor_crc@pipe-b-cursor-256x256-sliding:
- Statuses : 8 pass(s)
- Exec time: [3.57, 5.38] s
* igt@kms_cursor_crc@pipe-b-cursor-256x85-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.91] s
* igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.52] s
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.50] s
* igt@kms_cursor_crc@pipe-b-cursor-256x85-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.39] s
* igt@kms_cursor_crc@pipe-b-cursor-512x170-offscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x170-onscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x170-sliding:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x512-offscreen:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x512-onscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-512x512-sliding:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-b-cursor-64x21-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.87] s
* igt@kms_cursor_crc@pipe-b-cursor-64x21-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.03] s
* igt@kms_cursor_crc@pipe-b-cursor-64x21-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.50] s
* igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.36] s
* igt@kms_cursor_crc@pipe-b-cursor-64x64-offscreen:
- Statuses : 8 pass(s)
- Exec time: [4.14, 6.33] s
* igt@kms_cursor_crc@pipe-b-cursor-64x64-onscreen:
- Statuses : 7 pass(s)
- Exec time: [2.30, 4.43] s
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- Statuses : 8 pass(s)
- Exec time: [3.72, 5.49] s
* igt@kms_cursor_crc@pipe-b-cursor-64x64-rapid-movement:
- Statuses : 8 pass(s)
- Exec time: [0.26, 2.27] s
* igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding:
- Statuses : 8 pass(s)
- Exec time: [3.58, 5.37] s
* igt@kms_cursor_crc@pipe-b-cursor-alpha-opaque:
- Statuses : 8 pass(s)
- Exec time: [0.38, 2.21] s
* igt@kms_cursor_crc@pipe-b-cursor-alpha-transparent:
- Statuses : 8 pass(s)
- Exec time: [0.42, 2.24] s
* igt@kms_cursor_crc@pipe-b-cursor-dpms:
- Statuses : 8 pass(s)
- Exec time: [0.90, 5.37] s
* igt@kms_cursor_crc@pipe-b-cursor-size-change:
- Statuses : 8 pass(s)
- Exec time: [0.51, 2.40] s
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- Statuses : 8 pass(s)
- Exec time: [1.76, 6.16] s
* igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.84] s
* igt@kms_cursor_crc@pipe-c-cursor-128x128-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 4.38] s
* igt@kms_cursor_crc@pipe-c-cursor-128x128-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.94] s
* igt@kms_cursor_crc@pipe-c-cursor-128x128-rapid-movement:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.24] s
* igt@kms_cursor_crc@pipe-c-cursor-128x128-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.30] s
* igt@kms_cursor_crc@pipe-c-cursor-128x42-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.88] s
* igt@kms_cursor_crc@pipe-c-cursor-128x42-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 3.96] s
* igt@kms_cursor_crc@pipe-c-cursor-128x42-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.48] s
* igt@kms_cursor_crc@pipe-c-cursor-128x42-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.75] s
* igt@kms_cursor_crc@pipe-c-cursor-256x256-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.84] s
* igt@kms_cursor_crc@pipe-c-cursor-256x256-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 3.98] s
* igt@kms_cursor_crc@pipe-c-cursor-256x256-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.48] s
* igt@kms_cursor_crc@pipe-c-cursor-256x256-rapid-movement:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.23] s
* igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.78] s
* igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.89] s
* igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 3.50] s
* igt@kms_cursor_crc@pipe-c-cursor-256x85-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.49] s
* igt@kms_cursor_crc@pipe-c-cursor-256x85-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.30] s
* igt@kms_cursor_crc@pipe-c-cursor-512x170-offscreen:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x170-onscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x170-random:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x512-offscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x512-onscreen:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x512-rapid-movement:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:
- Statuses : 8 skip(s)
- Exec time: [0.0] s
* igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.87] s
* igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 3.95] s
* igt@kms_cursor_crc@pipe-c-cursor-64x21-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.45] s
* igt@kms_cursor_crc@pipe-c-cursor-64x21-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.37] s
* igt@kms_cursor_crc@pipe-c-cursor-64x64-offscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.86] s
* igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 3.97] s
* igt@kms_cursor_crc@pipe-c-cursor-64x64-random:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.47] s
* igt@kms_cursor_crc@pipe-c-cursor-64x64-rapid-movement:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.21] s
* igt@kms_cursor_crc@pipe-c-cursor-64x64-sliding:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 5.81] s
* igt@kms_cursor_crc@pipe-c-cursor-alpha-opaque:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.68] s
* igt@kms_cursor_crc@pipe-c-cursor-alpha-transparent:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.20] s
* igt@kms_cursor_crc@pipe-c-cursor-dpms:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0, 4.42] s
* igt@kms_cursor_crc@pipe-c-cursor-size-change:
- Statuses : 7 pass(s) 1 skip(s)
- Exec time: [0.0, 2.32] s
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- Statuses : 1 incomplete(s) 6 pass(s) 1 skip(s)
- Exec time: [0.0, 6.46] s
Known issues
------------
Here are the changes found in Patchwork_17645_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_workarounds@suspend-resume-fd:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#180])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl1/igt@gem_workarounds@suspend-resume-fd.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-apl1/igt@gem_workarounds@suspend-resume-fd.html
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [PASS][3] -> [INCOMPLETE][4] ([i915#151] / [i915#69])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl5/igt@i915_pm_rpm@system-suspend.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl7/igt@i915_pm_rpm@system-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen (NEW):
- shard-skl: [PASS][5] -> [FAIL][6] ([i915#54])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-128x42-offscreen.html
* igt@kms_cursor_legacy@flip-vs-cursor-toggle:
- shard-skl: [PASS][7] -> [FAIL][8] ([IGT#5] / [i915#697])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-toggle.html
* igt@kms_fbcon_fbt@fbc:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#64])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-tglb3/igt@kms_fbcon_fbt@fbc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-tglb6/igt@kms_fbcon_fbt@fbc.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#1188])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [PASS][13] -> [INCOMPLETE][14] ([i915#69])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][15] -> [FAIL][16] ([fdo#108145] / [i915#265]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
#### Possible fixes ####
* igt@i915_selftest@live@execlists:
- shard-skl: [INCOMPLETE][19] ([i915#1874]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl6/igt@i915_selftest@live@execlists.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl10/igt@i915_selftest@live@execlists.html
* igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen (NEW):
- shard-skl: [FAIL][21] ([i915#54]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
* {igt@kms_flip@flip-vs-suspend-interruptible@c-dp1}:
- shard-apl: [DMESG-WARN][23] ([i915#180]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][25] ([fdo#108145] / [i915#265]) -> [PASS][26] +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][27] ([fdo#109441]) -> [PASS][28] +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][29] ([i915#658]) -> [SKIP][30] ([i915#588])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-iclb3/igt@i915_pm_dc@dc3co-vpb-simulation.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@kms_content_protection@legacy:
- shard-apl: [TIMEOUT][31] ([i915#1319]) -> [FAIL][32] ([fdo#110321] / [fdo#110336] / [i915#95])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl4/igt@kms_content_protection@legacy.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-apl4/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@lic:
- shard-apl: [FAIL][33] ([fdo#110321]) -> [TIMEOUT][34] ([i915#1319]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8472/shard-apl8/igt@kms_content_protection@lic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/shard-apl7/igt@kms_content_protection@lic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1874]: https://gitlab.freedesktop.org/drm/intel/issues/1874
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#64]: https://gitlab.freedesktop.org/drm/intel/issues/64
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#697]: https://gitlab.freedesktop.org/drm/intel/issues/697
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8472 -> Patchwork_17645
CI-20190529: 20190529
CI_DRM_8472: 57acc5ba2cfb81691917a3da729573a99c893e5a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5651: e54e2642f1967ca3c488db32264607df670d1dfb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17645: a06430f11a8054e6b4ee2cbae13fd781319329aa @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17645/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization
2020-05-13 12:28 [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization Chris Wilson
` (2 preceding siblings ...)
2020-05-13 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2020-05-13 16:05 ` Mika Kuoppala
3 siblings, 0 replies; 5+ messages in thread
From: Mika Kuoppala @ 2020-05-13 16:05 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Chris Wilson
Chris Wilson <chris@chris-wilson.co.uk> writes:
> It is possible for a residual tasklet to be pending execution as we
> resume (whether that's some prior test kicking off the tasklet, or if we
> are in a suspend/resume stress test). As such, we do not want that
> tasklet to execute in the middle of our sanitization, such that it sees
> the poisoned state. For example,
>
> <4>[ 449.386553] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
> <4>[ 449.386555] CPU: 1 PID: 5115 Comm: i915_selftest Tainted: G U W 5.7.0-rc4-CI-CI_DRM_8472+ #1
> <4>[ 449.386556] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
> <4>[ 449.386585] RIP: 0010:process_csb+0x6bf/0x830 [i915]
> <4>[ 449.386588] Code: 00 48 c7 c2 10 bc 4c a0 48 c7 c7 d4 75 34 a0 e8 87 0e e6 e0 bf 01 00 00 00 e8 9d e0 e5 e0 31 f6 bf 09 00 00 00 e8 e1 ba d6 e0 <0f> 0b 8b 87 10 05 00 00 85 c0 0f 85 5f f9 ff ff 48 c7 c1 70 a5 4f
> <4>[ 449.386591] RSP: 0018:ffffc90000170ea0 EFLAGS: 00010297
> <4>[ 449.386594] RAX: 0000000080000101 RBX: 0000000000000000 RCX: 0000000000000000
> <4>[ 449.386596] RDX: ffff88849d5bc040 RSI: 0000000000000000 RDI: 0000000000000009
> <4>[ 449.386598] RBP: ffffc90000170f00 R08: 0000000000000000 R09: 0000000000000000
> <4>[ 449.386600] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88843ccea018
> <4>[ 449.386602] R13: ffff88843ccea658 R14: ffff88843ccea640 R15: ffff88843ccea000
> <4>[ 449.386605] FS: 00007f826a813300(0000) GS:ffff88849fe80000(0000) knlGS:0000000000000000
> <4>[ 449.386607] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> <4>[ 449.386609] CR2: 0000560366b94280 CR3: 000000048ba02002 CR4: 0000000000760ee0
> <4>[ 449.386611] PKRU: 55555554
> <4>[ 449.386613] Call Trace:
> <4>[ 449.386616] <IRQ>
> <4>[ 449.386646] ? execlists_submission_tasklet+0xcf/0x140 [i915]
> <4>[ 449.386674] execlists_submission_tasklet+0x2f/0x140 [i915]
> <4>[ 449.386679] tasklet_action_common.isra.16+0x6c/0x1c0
> <4>[ 449.386684] __do_softirq+0xdf/0x49e
> <4>[ 449.386687] irq_exit+0xba/0xc0
> <4>[ 449.386690] smp_apic_timer_interrupt+0xb7/0x280
> <4>[ 449.386693] apic_timer_interrupt+0xf/0x20
> <4>[ 449.386695] </IRQ>
> <4>[ 449.386698] RIP: 0010:_raw_spin_unlock_irqrestore+0x49/0x60
> <4>[ 449.386701] Code: c7 02 75 1f 53 9d e8 26 ab 75 ff bf 01 00 00 00 e8 7c a3 69 ff 65 8b 05 7d 9b 5c 7e 85 c0 74 0c 5b 5d c3 e8 09 aa 75 ff 53 9d <eb> df e8 ca 39 5b ff 5b 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00
> <4>[ 449.386703] RSP: 0018:ffffc90000a6b950 EFLAGS: 00000202 ORIG_RAX: ffffffffffffff13
> <4>[ 449.386706] RAX: 0000000080000001 RBX: 0000000000000202 RCX: 0000000000000000
> <4>[ 449.386708] RDX: ffff88849d5bc040 RSI: ffff88849d5bc900 RDI: ffffffff82386f12
> <4>[ 449.386710] RBP: ffff88847d400f00 R08: ffff88849d5bc900 R09: 0000000000000000
> <4>[ 449.386712] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000ffff0b0b
> <4>[ 449.386714] R13: 000000000000000c R14: ffff88847d40bf70 R15: ffff88847d40cef8
> <4>[ 449.386742] reset_csb_pointers+0x59/0x140 [i915]
> <4>[ 449.386769] execlists_sanitize+0x3e/0x60 [i915]
> <4>[ 449.386797] gt_sanitize+0xd6/0x260 [i915]
>
> As part of the reset preparation, engine->reset.prepare() prevents the
> tasklet from running, so pull the sanitization inside the critical
> section for reset.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1812
> Fixes: 23122a4d992b ("drm/i915/gt: Scrub execlists state on resume")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index e59776485457..6bdb434a442d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -150,10 +150,6 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
> if (intel_gt_is_wedged(gt))
> intel_gt_unset_wedged(gt);
>
> - for_each_engine(engine, gt, id)
> - if (engine->sanitize)
> - engine->sanitize(engine);
> -
> intel_uc_sanitize(>->uc);
>
> for_each_engine(engine, gt, id)
> @@ -162,6 +158,10 @@ static void gt_sanitize(struct intel_gt *gt, bool force)
>
> intel_uc_reset_prepare(>->uc);
>
> + for_each_engine(engine, gt, id)
> + if (engine->sanitize)
> + engine->sanitize(engine);
> +
> if (reset_engines(gt) || force) {
> for_each_engine(engine, gt, id)
> __intel_engine_reset(engine, false);
> --
> 2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-13 16:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 12:28 [Intel-gfx] [PATCH] drm/i915/gt: Suspend tasklets before resume sanitization Chris Wilson
2020-05-13 12:48 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-05-13 13:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-13 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-05-13 16:05 ` [Intel-gfx] [PATCH] " Mika Kuoppala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.