From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kurt Miller <kurt@intricatesoftware.com>
Date: Thu, 14 May 2020 13:02:20 -0400
Subject: [PATCH v3 7/9] rockchip: dts: rk3328: Sync device tree files
 from Linux
In-Reply-To: <CAGb2v64yjD25tV9QPaX2VOQCJMH0ZWrQXeBR8oTjkfVGcHLdKw@mail.gmail.com>
References: <20200427065254.15397-1-wens@kernel.org>
 <20200427065254.15397-8-wens@kernel.org>
 <1589223597.8607.119.camel@intricatesoftware.com>
 <CAGb2v64yjD25tV9QPaX2VOQCJMH0ZWrQXeBR8oTjkfVGcHLdKw@mail.gmail.com>
Message-ID: <1589475740.8607.162.camel@intricatesoftware.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 2020-05-14 at 12:10 +0800, Chen-Yu Tsai wrote:
> Hi Kurt
> 
> On Tue, May 12, 2020 at 3:00 AM Kurt Miller <kurt@intricatesoftware.com> wrote:
> > 
> > 
> > On Mon, 2020-04-27 at 14:52 +0800, Chen-Yu Tsai wrote:
> > > 
> > > From: Chen-Yu Tsai <wens@csie.org>
> > > 
> > > This syncs rk3328 device tree files from the Linux kernel next-20200324.
> > > The last commit to touch these files is:
> > > 
> > > ????b2411befed60 ("arm64: dts: add bus to rockchip amba nodenames")
> > > 
> > > Additional changes not yet in the Linux kernel include:
> > > 
> > > ????arm64: dts: rockchip: rk3328: drop #address-cells, #size-cells from grf node
> > > ????arm64: dts: rockchip: rk3328: drop non-existent gmac2phy pinmux options
> > > ????arm64: dts: rockchip: rk3328: Replace RK805 PMIC node name with "pmic"
> > > 
> > > Changes include:
> > > 
> > > ? - conversion of raw pin numbers to macros
> > > ? - removal of deprecated RK_FUNC_* macros
> > > ? - update of device tree binding headers
> > > ? - new devices
> > > ? - device tree cleanups
> > > ? - gmac2phy disabled in -u-boot.dtsi as it is not supported in U-boot
> > > 
> > > This includes a re-ordering of the USB device nodes compared to upstream
> > > Linux, moving the dwc2 OTG controller after the EHCI/OHCI nodes. This is
> > > currently required as otherwise the dwc2 controller would not be able to
> > > detect devices in some cases. This may be due to lack of USB PHY support
> > > in U-boot.
> > Hi Chen-Yu,
> > 
> > Thank you for syncing rk3328 device tree files. On the rock64 with
> > v2020.04 one USB 2.0 port was working (the lower one). Building
> > master now with this merged, no USB ports are working. No power
> > appears to be enabled on them and USB devices are not recognized.
> When I was working on v3, it was based on
> 
> ????d202f67db077 Merge branch '2020-04-25-master-imports'
> 
> And it was definitely working. My Rock64 is back in its case, so I tested
> again with the ROC-RK3328-CC just now. All three USB ports work properly,
> on both the old tree and current master.
> 
> Are you using the defconfig, or have you deviated from it? XHCI must be
> enabled, as VBUS is tied to it (to get everything to work).
> 

Hi Chen-Yu,

Thank you for your reply. I've tested with and without the SPL gen3 changes
I posted yesterday on gen2 and gen3 boards. In all cases there's no power
to all three usb ports. The only other change I have in defconfig is?
adjusting the baud rate.

Mark Kettenis suggested I revert Patch 9/9 from this series and with
that reverted the one USB 2.0 port works again. Mark has a better
understanding of the issues and perhaps can comment further - cc'ed.

Regards,
-Kurt