From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9177EC433E0 for ; Fri, 15 May 2020 03:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BC7720722 for ; Fri, 15 May 2020 03:55:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Do86qxYH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728256AbgEODzo (ORCPT ); Thu, 14 May 2020 23:55:44 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:17311 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726665AbgEODzo (ORCPT ); Thu, 14 May 2020 23:55:44 -0400 X-UUID: 8a4f21b0b7d84073b78ae9e67e94ec41-20200515 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FIgtJPFxyfCI4OyCVzpT8IeOjmdr2nF5V1WfWYeRSDo=; b=Do86qxYH39Brv/cvZSm/P3gZCC4EVUvzLH4BEaEG9Y+KEcKpBbEatL3xXFJcIhD0Lbd/BH6RLCwOCRzkk1hKpzaZO01NPqsHtA7TnljbwfUXhKBcUvabiOjUiaHRIPHmLDWdljVooxYDpmV4JE0woRgEkUf/GpI+R/keh61YJ5w=; X-UUID: 8a4f21b0b7d84073b78ae9e67e94ec41-20200515 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 216926550; Fri, 15 May 2020 11:55:37 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 May 2020 11:55:36 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 15 May 2020 11:55:36 +0800 Message-ID: <1589514936.3197.108.camel@mtkswgap22> Subject: Re: [PATCH v13 06/12] scsi: ufs: UFS driver v2.1 spec crypto additions From: Stanley Chu To: Satya Tangirala CC: , , , , , , "Barani Muthukumaran" , Kuohong Wang , Kim Boojin , "Eric Biggers" Date: Fri, 15 May 2020 11:55:36 +0800 In-Reply-To: <20200514003727.69001-7-satyat@google.com> References: <20200514003727.69001-1-satyat@google.com> <20200514003727.69001-7-satyat@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org SGkgU2F0eWEsDQoNCk9uIFRodSwgMjAyMC0wNS0xNCBhdCAwMDozNyArMDAwMCwgU2F0eWEgVGFu Z2lyYWxhIHdyb3RlOg0KPiBBZGQgdGhlIGNyeXB0byByZWdpc3RlcnMgYW5kIHN0cnVjdHMgZGVm aW5lZCBpbiB2Mi4xIG9mIHRoZSBKRURFQyBVRlNIQ0kNCj4gc3BlY2lmaWNhdGlvbiBpbiBwcmVw YXJhdGlvbiB0byBhZGQgc3VwcG9ydCBmb3IgaW5saW5lIGVuY3J5cHRpb24gdG8NCj4gVUZTLg0K PiANCj4gU2lnbmVkLW9mZi1ieTogU2F0eWEgVGFuZ2lyYWxhIDxzYXR5YXRAZ29vZ2xlLmNvbT4N Cj4gUmV2aWV3ZWQtYnk6IEVyaWMgQmlnZ2VycyA8ZWJpZ2dlcnNAZ29vZ2xlLmNvbT4NCj4gLS0t DQo+ICBkcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC5jIHwgIDIgKysNCj4gIGRyaXZlcnMvc2NzaS91 ZnMvdWZzaGNkLmggfCAgNiArKysrDQo+ICBkcml2ZXJzL3Njc2kvdWZzL3Vmc2hjaS5oIHwgNjcg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tDQo+ICAzIGZpbGVzIGNoYW5n ZWQsIDczIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2QuYyBiL2RyaXZlcnMvc2NzaS91ZnMvdWZzaGNkLmMNCj4g aW5kZXggNjk4ZThkMjBiNGJhYy4uMjQzNWM2MDBjYjJkOSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVy cy9zY3NpL3Vmcy91ZnNoY2QuYw0KPiArKysgYi9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjZC5jDQo+ IEBAIC00NzY3LDYgKzQ3NjcsOCBAQCB1ZnNoY2RfdHJhbnNmZXJfcnNwX3N0YXR1cyhzdHJ1Y3Qg dWZzX2hiYSAqaGJhLCBzdHJ1Y3QgdWZzaGNkX2xyYiAqbHJicCkNCj4gIAljYXNlIE9DU19NSVNN QVRDSF9SRVNQX1VQSVVfU0laRToNCj4gIAljYXNlIE9DU19QRUVSX0NPTU1fRkFJTFVSRToNCj4g IAljYXNlIE9DU19GQVRBTF9FUlJPUjoNCj4gKwljYXNlIE9DU19JTlZBTElEX0NSWVBUT19DT05G SUc6DQo+ICsJY2FzZSBPQ1NfR0VORVJBTF9DUllQVE9fRVJST1I6DQo+ICAJZGVmYXVsdDoNCj4g IAkJcmVzdWx0IHw9IERJRF9FUlJPUiA8PCAxNjsNCj4gIAkJZGV2X2VycihoYmEtPmRldiwNCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvc2NzaS91ZnMvdWZzaGNkLmggYi9kcml2ZXJzL3Njc2kvdWZz L3Vmc2hjZC5oDQo+IGluZGV4IDZmZmMwOGFkODVmNjMuLjgzNWI5YTg0NGFhMjEgMTAwNjQ0DQo+ IC0tLSBhL2RyaXZlcnMvc2NzaS91ZnMvdWZzaGNkLmgNCj4gKysrIGIvZHJpdmVycy9zY3NpL3Vm cy91ZnNoY2QuaA0KPiBAQCAtNTU1LDYgKzU1NSwxMiBAQCBlbnVtIHVmc2hjZF9jYXBzIHsNCj4g IAkgKiBmb3IgdXNlcnNwYWNlIHRvIGNvbnRyb2wgdGhlIHBvd2VyIG1hbmFnZW1lbnQuDQo+ICAJ ICovDQo+ICAJVUZTSENEX0NBUF9SUE1fQVVUT1NVU1BFTkQJCQk9IDEgPDwgNiwNCj4gKw0KPiAr CS8qDQo+ICsJICogVGhpcyBjYXBhYmlsaXR5IGFsbG93cyB0aGUgaG9zdCBjb250cm9sbGVyIGRy aXZlciB0byB1c2UgdGhlDQo+ICsJICogaW5saW5lIGNyeXB0byBlbmdpbmUsIGlmIGl0IGlzIHBy ZXNlbnQNCj4gKwkgKi8NCj4gKwlVRlNIQ0RfQ0FQX0NSWVBUTwkJCQk9IDEgPDwgNywNCj4gIH07 DQo+ICANCj4gIC8qKg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2kuaCBi L2RyaXZlcnMvc2NzaS91ZnMvdWZzaGNpLmgNCj4gaW5kZXggYzI5NjFkMzdjYzFjZi4uYzA2NTFm ZTZkYmJjNiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9zY3NpL3Vmcy91ZnNoY2kuaA0KPiArKysg Yi9kcml2ZXJzL3Njc2kvdWZzL3Vmc2hjaS5oDQo+IEBAIC05MCw2ICs5MCw3IEBAIGVudW0gew0K PiAgCU1BU0tfNjRfQUREUkVTU0lOR19TVVBQT1JUCQk9IDB4MDEwMDAwMDAsDQo+ICAJTUFTS19P VVRfT0ZfT1JERVJfREFUQV9ERUxJVkVSWV9TVVBQT1JUCT0gMHgwMjAwMDAwMCwNCj4gIAlNQVNL X1VJQ19ETUVfVEVTVF9NT0RFX1NVUFBPUlQJCT0gMHgwNDAwMDAwMCwNCj4gKwlNQVNLX0NSWVBU T19TVVBQT1JUCQkJPSAweDEwMDAwMDAwLA0KPiAgfTsNCj4gIA0KPiAgI2RlZmluZSBVRlNfTUFT SyhtYXNrLCBvZmZzZXQpCQkoKG1hc2spIDw8IChvZmZzZXQpKQ0KPiBAQCAtMTQzLDYgKzE0NCw3 IEBAIGVudW0gew0KPiAgI2RlZmluZSBERVZJQ0VfRkFUQUxfRVJST1IJCQkweDgwMA0KPiAgI2Rl ZmluZSBDT05UUk9MTEVSX0ZBVEFMX0VSUk9SCQkJMHgxMDAwMA0KPiAgI2RlZmluZSBTWVNURU1f QlVTX0ZBVEFMX0VSUk9SCQkJMHgyMDAwMA0KPiArI2RlZmluZSBDUllQVE9fRU5HSU5FX0ZBVEFM X0VSUk9SCQkweDQwMDAwDQo+ICANCj4gICNkZWZpbmUgVUZTSENEX1VJQ19ISUJFUk44X01BU0sJ KFVJQ19ISUJFUk5BVEVfRU5URVIgfFwNCj4gIAkJCQlVSUNfSElCRVJOQVRFX0VYSVQpDQo+IEBA IC0xNTUsMTEgKzE1NywxMyBAQCBlbnVtIHsNCj4gICNkZWZpbmUgVUZTSENEX0VSUk9SX01BU0sJ KFVJQ19FUlJPUiB8XA0KPiAgCQkJCURFVklDRV9GQVRBTF9FUlJPUiB8XA0KPiAgCQkJCUNPTlRS T0xMRVJfRkFUQUxfRVJST1IgfFwNCj4gLQkJCQlTWVNURU1fQlVTX0ZBVEFMX0VSUk9SKQ0KPiAr CQkJCVNZU1RFTV9CVVNfRkFUQUxfRVJST1IgfFwNCj4gKwkJCQlDUllQVE9fRU5HSU5FX0ZBVEFM X0VSUk9SKQ0KPiAgDQo+ICAjZGVmaW5lIElOVF9GQVRBTF9FUlJPUlMJKERFVklDRV9GQVRBTF9F UlJPUiB8XA0KPiAgCQkJCUNPTlRST0xMRVJfRkFUQUxfRVJST1IgfFwNCj4gLQkJCQlTWVNURU1f QlVTX0ZBVEFMX0VSUk9SKQ0KPiArCQkJCVNZU1RFTV9CVVNfRkFUQUxfRVJST1IgfFwNCj4gKwkJ CQlDUllQVE9fRU5HSU5FX0ZBVEFMX0VSUk9SKQ0KPiAgDQo+ICAvKiBIQ1MgLSBIb3N0IENvbnRy b2xsZXIgU3RhdHVzIDMwaCAqLw0KPiAgI2RlZmluZSBERVZJQ0VfUFJFU0VOVAkJCQkweDENCj4g QEAgLTMxOCw2ICszMjIsNjEgQEAgZW51bSB7DQo+ICAJSU5URVJSVVBUX01BU0tfQUxMX1ZFUl8y MQk9IDB4NzFGRkYsDQo+ICB9Ow0KPiAgDQo+ICsvKiBDQ0FQIC0gQ3J5cHRvIENhcGFiaWxpdHkg MTAwaCAqLw0KPiArdW5pb24gdWZzX2NyeXB0b19jYXBhYmlsaXRpZXMgew0KPiArCV9fbGUzMiBy ZWdfdmFsOw0KPiArCXN0cnVjdCB7DQo+ICsJCXU4IG51bV9jcnlwdG9fY2FwOw0KPiArCQl1OCBj b25maWdfY291bnQ7DQo+ICsJCXU4IHJlc2VydmVkOw0KPiArCQl1OCBjb25maWdfYXJyYXlfcHRy Ow0KPiArCX07DQo+ICt9Ow0KPiArDQo+ICtlbnVtIHVmc19jcnlwdG9fa2V5X3NpemUgew0KPiAr CVVGU19DUllQVE9fS0VZX1NJWkVfSU5WQUxJRAk9IDB4MCwNCj4gKwlVRlNfQ1JZUFRPX0tFWV9T SVpFXzEyOAkJPSAweDEsDQo+ICsJVUZTX0NSWVBUT19LRVlfU0laRV8xOTIJCT0gMHgyLA0KPiAr CVVGU19DUllQVE9fS0VZX1NJWkVfMjU2CQk9IDB4MywNCj4gKwlVRlNfQ1JZUFRPX0tFWV9TSVpF XzUxMgkJPSAweDQsDQo+ICt9Ow0KPiArDQo+ICtlbnVtIHVmc19jcnlwdG9fYWxnIHsNCj4gKwlV RlNfQ1JZUFRPX0FMR19BRVNfWFRTCQkJPSAweDAsDQo+ICsJVUZTX0NSWVBUT19BTEdfQklUTE9D S0VSX0FFU19DQkMJPSAweDEsDQo+ICsJVUZTX0NSWVBUT19BTEdfQUVTX0VDQgkJCT0gMHgyLA0K PiArCVVGU19DUllQVE9fQUxHX0VTU0lWX0FFU19DQkMJCT0gMHgzLA0KPiArfTsNCj4gKw0KPiAr LyogeC1DUllQVE9DQVAgLSBDcnlwdG8gQ2FwYWJpbGl0eSBYICovDQo+ICt1bmlvbiB1ZnNfY3J5 cHRvX2NhcF9lbnRyeSB7DQo+ICsJX19sZTMyIHJlZ192YWw7DQo+ICsJc3RydWN0IHsNCj4gKwkJ dTggYWxnb3JpdGhtX2lkOw0KPiArCQl1OCBzZHVzX21hc2s7IC8qIFN1cHBvcnRlZCBkYXRhIHVu aXQgc2l6ZSBtYXNrICovDQo+ICsJCXU4IGtleV9zaXplOw0KPiArCQl1OCByZXNlcnZlZDsNCj4g Kwl9Ow0KPiArfTsNCj4gKw0KPiArI2RlZmluZSBVRlNfQ1JZUFRPX0NPTkZJR1VSQVRJT05fRU5B QkxFICgxIDw8IDcpDQo+ICsjZGVmaW5lIFVGU19DUllQVE9fS0VZX01BWF9TSVpFIDY0DQo+ICsv KiB4LUNSWVBUT0NGRyAtIENyeXB0byBDb25maWd1cmF0aW9uIFggKi8NCj4gK3VuaW9uIHVmc19j cnlwdG9fY2ZnX2VudHJ5IHsNCj4gKwlfX2xlMzIgcmVnX3ZhbFszMl07DQo+ICsJc3RydWN0IHsN Cj4gKwkJdTggY3J5cHRvX2tleVtVRlNfQ1JZUFRPX0tFWV9NQVhfU0laRV07DQo+ICsJCXU4IGRh dGFfdW5pdF9zaXplOw0KPiArCQl1OCBjcnlwdG9fY2FwX2lkeDsNCj4gKwkJdTggcmVzZXJ2ZWRf MTsNCj4gKwkJdTggY29uZmlnX2VuYWJsZTsNCj4gKwkJdTggcmVzZXJ2ZWRfbXVsdGlfaG9zdDsN Cj4gKwkJdTggcmVzZXJ2ZWRfMjsNCj4gKwkJdTggdnNiWzJdOw0KPiArCQl1OCByZXNlcnZlZF8z WzU2XTsNCj4gKwl9Ow0KPiArfTsNCj4gKw0KPiAgLyoNCj4gICAqIFJlcXVlc3QgRGVzY3JpcHRv ciBEZWZpbml0aW9ucw0KPiAgICovDQo+IEBAIC0zMzksNiArMzk4LDcgQEAgZW51bSB7DQo+ICAJ VVRQX05BVElWRV9VRlNfQ09NTUFORAkJPSAweDEwMDAwMDAwLA0KPiAgCVVUUF9ERVZJQ0VfTUFO QUdFTUVOVF9GVU5DVElPTgk9IDB4MjAwMDAwMDAsDQo+ICAJVVRQX1JFUV9ERVNDX0lOVF9DTUQJ CT0gMHgwMTAwMDAwMCwNCj4gKwlVVFBfUkVRX0RFU0NfQ1JZUFRPX0VOQUJMRV9DTUQJPSAweDAw ODAwMDAwLA0KPiAgfTsNCj4gIA0KPiAgLyogVVRQIFRyYW5zZmVyIFJlcXVlc3QgRGF0YSBEaXJl Y3Rpb24gKEREKSAqLw0KPiBAQCAtMzU4LDYgKzQxOCw5IEBAIGVudW0gew0KPiAgCU9DU19QRUVS X0NPTU1fRkFJTFVSRQkJPSAweDUsDQo+ICAJT0NTX0FCT1JURUQJCQk9IDB4NiwNCj4gIAlPQ1Nf RkFUQUxfRVJST1IJCQk9IDB4NywNCj4gKwlPQ1NfREVWSUNFX0ZBVEFMX0VSUk9SCQk9IDB4OCwN Cj4gKwlPQ1NfSU5WQUxJRF9DUllQVE9fQ09ORklHCT0gMHg5LA0KPiArCU9DU19HRU5FUkFMX0NS WVBUT19FUlJPUgk9IDB4QSwNCg0KQSBuaXQgaXMgdGhhdCBPQ1NfREVWSUNFX0ZBVEFMX0VSUk9S IGRlZmluaXRpb24gaXMgYWRkZWQgaGVyZSBidXQgbm90DQphZGRlZCBpbiB1ZnNoY2RfdHJhbnNm ZXJfcnNwX3N0YXR1cygpLg0KDQpUaGlzIHdpbGwgbm90IGhhdmUgYW55IHNpZGUgZWZmZWN0IGJl Y2F1c2UgT0NTX0RFVklDRV9GQVRBTF9FUlJPUiB3YXMNCmFscmVhZHkgaGFuZGxlZCBieSAiZGVm YXVsdCIgbGFiZWwgaW4gdWZzaGNkX3RyYW5zZmVyX3JzcF9zdGF0dXMoKS4NCg0KPiAgCU9DU19J TlZBTElEX0NPTU1BTkRfU1RBVFVTCT0gMHgwRiwNCj4gIAlNQVNLX09DUwkJCT0gMHgwRiwNCj4g IH07DQoNCk90aGVyd2lzZSBsb29rcyBnb29kIHRvIG1lLg0KDQpSZXZpZXdlZC1ieTogU3Rhbmxl eSBDaHUgPHN0YW5sZXkuY2h1QG1lZGlhdGVrLmNvbT4NCg0KVGhhbmtzLg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D360AC433DF for ; Fri, 15 May 2020 03:56:11 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BE162065F; Fri, 15 May 2020 03:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="S88aF68w"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="hlMHAfOw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Do86qxYH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BE162065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jZRSE-0003mi-Cx; Fri, 15 May 2020 03:56:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZRSD-0003mV-8o for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 May 2020 03:56:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Content-Type :References:In-Reply-To:Date:CC:To:From:Subject:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FIgtJPFxyfCI4OyCVzpT8IeOjmdr2nF5V1WfWYeRSDo=; b=S88aF68wOc9wYBAdEG8bIoGgbH fw37S5/4LpemL1AIp7/IL3si4N+z6obnDWyX+PYxsmBQmeErXCL4rK+vpePPAvQRrF6HjJHXaJQSQ f/f9X3TlsmxAsu82pPmJZZLwuR1kEB96oI40rhbcQwv06kA4nrRci0sBpHFKCPJdeJgU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References: In-Reply-To:Date:CC:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FIgtJPFxyfCI4OyCVzpT8IeOjmdr2nF5V1WfWYeRSDo=; b=hlMHAfOwOa3YVCzAcSTpIdIe5U axiw1SVxx6UTY1JysIPv+wBsjUZJY24PNP66yZhskPZOjQ7xzfUSOcEio2LduuVGKH2nQm26uN4vo Pc91Q7GYfOPyHxgUn7IPNr3IJTgRnrE+urBB1qgYtSrmrOGHpnraXfB2SHY0l0TlXpJE=; Received: from [210.61.82.183] (helo=mailgw01.mediatek.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtp (Exim 4.92.2) id 1jZRS6-00851M-RY for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 May 2020 03:56:09 +0000 X-UUID: 8a4f21b0b7d84073b78ae9e67e94ec41-20200515 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=FIgtJPFxyfCI4OyCVzpT8IeOjmdr2nF5V1WfWYeRSDo=; b=Do86qxYH39Brv/cvZSm/P3gZCC4EVUvzLH4BEaEG9Y+KEcKpBbEatL3xXFJcIhD0Lbd/BH6RLCwOCRzkk1hKpzaZO01NPqsHtA7TnljbwfUXhKBcUvabiOjUiaHRIPHmLDWdljVooxYDpmV4JE0woRgEkUf/GpI+R/keh61YJ5w=; X-UUID: 8a4f21b0b7d84073b78ae9e67e94ec41-20200515 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 216926550; Fri, 15 May 2020 11:55:37 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 May 2020 11:55:36 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 15 May 2020 11:55:36 +0800 Message-ID: <1589514936.3197.108.camel@mtkswgap22> From: Stanley Chu To: Satya Tangirala Date: Fri, 15 May 2020 11:55:36 +0800 In-Reply-To: <20200514003727.69001-7-satyat@google.com> References: <20200514003727.69001-1-satyat@google.com> <20200514003727.69001-7-satyat@google.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-Headers-End: 1jZRS6-00851M-RY Subject: Re: [f2fs-dev] [PATCH v13 06/12] scsi: ufs: UFS driver v2.1 spec crypto additions X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, Kim Boojin , Kuohong Wang , Eric Biggers , Barani Muthukumaran , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Hi Satya, On Thu, 2020-05-14 at 00:37 +0000, Satya Tangirala wrote: > Add the crypto registers and structs defined in v2.1 of the JEDEC UFSHCI > specification in preparation to add support for inline encryption to > UFS. > > Signed-off-by: Satya Tangirala > Reviewed-by: Eric Biggers > --- > drivers/scsi/ufs/ufshcd.c | 2 ++ > drivers/scsi/ufs/ufshcd.h | 6 ++++ > drivers/scsi/ufs/ufshci.h | 67 +++++++++++++++++++++++++++++++++++++-- > 3 files changed, 73 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 698e8d20b4bac..2435c600cb2d9 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -4767,6 +4767,8 @@ ufshcd_transfer_rsp_status(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > case OCS_MISMATCH_RESP_UPIU_SIZE: > case OCS_PEER_COMM_FAILURE: > case OCS_FATAL_ERROR: > + case OCS_INVALID_CRYPTO_CONFIG: > + case OCS_GENERAL_CRYPTO_ERROR: > default: > result |= DID_ERROR << 16; > dev_err(hba->dev, > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > index 6ffc08ad85f63..835b9a844aa21 100644 > --- a/drivers/scsi/ufs/ufshcd.h > +++ b/drivers/scsi/ufs/ufshcd.h > @@ -555,6 +555,12 @@ enum ufshcd_caps { > * for userspace to control the power management. > */ > UFSHCD_CAP_RPM_AUTOSUSPEND = 1 << 6, > + > + /* > + * This capability allows the host controller driver to use the > + * inline crypto engine, if it is present > + */ > + UFSHCD_CAP_CRYPTO = 1 << 7, > }; > > /** > diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h > index c2961d37cc1cf..c0651fe6dbbc6 100644 > --- a/drivers/scsi/ufs/ufshci.h > +++ b/drivers/scsi/ufs/ufshci.h > @@ -90,6 +90,7 @@ enum { > MASK_64_ADDRESSING_SUPPORT = 0x01000000, > MASK_OUT_OF_ORDER_DATA_DELIVERY_SUPPORT = 0x02000000, > MASK_UIC_DME_TEST_MODE_SUPPORT = 0x04000000, > + MASK_CRYPTO_SUPPORT = 0x10000000, > }; > > #define UFS_MASK(mask, offset) ((mask) << (offset)) > @@ -143,6 +144,7 @@ enum { > #define DEVICE_FATAL_ERROR 0x800 > #define CONTROLLER_FATAL_ERROR 0x10000 > #define SYSTEM_BUS_FATAL_ERROR 0x20000 > +#define CRYPTO_ENGINE_FATAL_ERROR 0x40000 > > #define UFSHCD_UIC_HIBERN8_MASK (UIC_HIBERNATE_ENTER |\ > UIC_HIBERNATE_EXIT) > @@ -155,11 +157,13 @@ enum { > #define UFSHCD_ERROR_MASK (UIC_ERROR |\ > DEVICE_FATAL_ERROR |\ > CONTROLLER_FATAL_ERROR |\ > - SYSTEM_BUS_FATAL_ERROR) > + SYSTEM_BUS_FATAL_ERROR |\ > + CRYPTO_ENGINE_FATAL_ERROR) > > #define INT_FATAL_ERRORS (DEVICE_FATAL_ERROR |\ > CONTROLLER_FATAL_ERROR |\ > - SYSTEM_BUS_FATAL_ERROR) > + SYSTEM_BUS_FATAL_ERROR |\ > + CRYPTO_ENGINE_FATAL_ERROR) > > /* HCS - Host Controller Status 30h */ > #define DEVICE_PRESENT 0x1 > @@ -318,6 +322,61 @@ enum { > INTERRUPT_MASK_ALL_VER_21 = 0x71FFF, > }; > > +/* CCAP - Crypto Capability 100h */ > +union ufs_crypto_capabilities { > + __le32 reg_val; > + struct { > + u8 num_crypto_cap; > + u8 config_count; > + u8 reserved; > + u8 config_array_ptr; > + }; > +}; > + > +enum ufs_crypto_key_size { > + UFS_CRYPTO_KEY_SIZE_INVALID = 0x0, > + UFS_CRYPTO_KEY_SIZE_128 = 0x1, > + UFS_CRYPTO_KEY_SIZE_192 = 0x2, > + UFS_CRYPTO_KEY_SIZE_256 = 0x3, > + UFS_CRYPTO_KEY_SIZE_512 = 0x4, > +}; > + > +enum ufs_crypto_alg { > + UFS_CRYPTO_ALG_AES_XTS = 0x0, > + UFS_CRYPTO_ALG_BITLOCKER_AES_CBC = 0x1, > + UFS_CRYPTO_ALG_AES_ECB = 0x2, > + UFS_CRYPTO_ALG_ESSIV_AES_CBC = 0x3, > +}; > + > +/* x-CRYPTOCAP - Crypto Capability X */ > +union ufs_crypto_cap_entry { > + __le32 reg_val; > + struct { > + u8 algorithm_id; > + u8 sdus_mask; /* Supported data unit size mask */ > + u8 key_size; > + u8 reserved; > + }; > +}; > + > +#define UFS_CRYPTO_CONFIGURATION_ENABLE (1 << 7) > +#define UFS_CRYPTO_KEY_MAX_SIZE 64 > +/* x-CRYPTOCFG - Crypto Configuration X */ > +union ufs_crypto_cfg_entry { > + __le32 reg_val[32]; > + struct { > + u8 crypto_key[UFS_CRYPTO_KEY_MAX_SIZE]; > + u8 data_unit_size; > + u8 crypto_cap_idx; > + u8 reserved_1; > + u8 config_enable; > + u8 reserved_multi_host; > + u8 reserved_2; > + u8 vsb[2]; > + u8 reserved_3[56]; > + }; > +}; > + > /* > * Request Descriptor Definitions > */ > @@ -339,6 +398,7 @@ enum { > UTP_NATIVE_UFS_COMMAND = 0x10000000, > UTP_DEVICE_MANAGEMENT_FUNCTION = 0x20000000, > UTP_REQ_DESC_INT_CMD = 0x01000000, > + UTP_REQ_DESC_CRYPTO_ENABLE_CMD = 0x00800000, > }; > > /* UTP Transfer Request Data Direction (DD) */ > @@ -358,6 +418,9 @@ enum { > OCS_PEER_COMM_FAILURE = 0x5, > OCS_ABORTED = 0x6, > OCS_FATAL_ERROR = 0x7, > + OCS_DEVICE_FATAL_ERROR = 0x8, > + OCS_INVALID_CRYPTO_CONFIG = 0x9, > + OCS_GENERAL_CRYPTO_ERROR = 0xA, A nit is that OCS_DEVICE_FATAL_ERROR definition is added here but not added in ufshcd_transfer_rsp_status(). This will not have any side effect because OCS_DEVICE_FATAL_ERROR was already handled by "default" label in ufshcd_transfer_rsp_status(). > OCS_INVALID_COMMAND_STATUS = 0x0F, > MASK_OCS = 0x0F, > }; Otherwise looks good to me. Reviewed-by: Stanley Chu Thanks. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel