From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F65C433E0 for ; Fri, 15 May 2020 11:21:51 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D46E1204EF for ; Fri, 15 May 2020 11:21:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=marvell.com header.i=@marvell.com header.b="UYlhScw7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="Cg0d+dKt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D46E1204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2580B1DA96; Fri, 15 May 2020 13:21:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7C8941DA24 for ; Fri, 15 May 2020 13:21:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04FBKo1D025569 for ; Fri, 15 May 2020 04:21:47 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : mime-version; s=pfpt0818; bh=pIOjgL6VbApc9e7jhAqwMtK7J4cic8j6o67dH+7RwTE=; b=UYlhScw76yZ83XCvfWe+TAqw1+K/mik5EXT0ZTFQ1xrrN1nAfOD+b2NwaBhBK0iOe31x ySC7n078Bn7P8zZT9TUY4z/zq2OasiRUdMIssNgwVrz0dvTUoWLQdryU5CtUozS7mV2b r+Ki2IUtPhnUhwUlK1utYqs5mVAnLyJVbAkTpn5JuV8ELbIPVL1//W7S49WyMbcqPCtN c+Md5pG1YRHAeuZJfVA+hQnNr4wVyS2b68VPYc2WbboJKJOO4RlkN8hkvTLgPQxLFWo3 oqcUV7zVpDl07dEP4Gj2a0MU74j/LliDfWgD/9UK3/dAgdcSujhidsXy72vo8hgwWJNY KQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 3100xk7k44-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Fri, 15 May 2020 04:21:47 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 15 May 2020 04:21:45 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 15 May 2020 04:21:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXVU8h0qetbIWIAhY4K7zdP35AlKY9DiUyqgevMER9xTrNevB2JXURf9qVRZfkEj0RPetkGqpwiTuaeiT4DOY+jSVhDmT1UdbGbv0yXdcSOKneb5zNN28mDCr+Fc7RuU5OOF5gS9PesNxRzPd7IfdpFOUX5LUvVWVGAk0RZxslS2L+hRMfE8ya23EKpfT9DqI9KN+AuLFbEltZB+am2rk7xk2NGENqko1cgoItgdrQXWUTLzCJYtqWnrbG/33AXCJWQrAo0/3Ccu52v8MpfrkFxUxsA9Wa5SphEOVJRRwD8IQaJFrGcuNqe6gpw/vOswpfzw5S8YOPF90i2NKq2oQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIOjgL6VbApc9e7jhAqwMtK7J4cic8j6o67dH+7RwTE=; b=GsYUr4rb68yy6MpucIOehtt4j8NRQL5zBDAWi/NFvlg/K3qNe3BNoZuAidQZnLZ9P6FS1SK5wOXrnZR7zvBVvJ5i4TZBGb0m6uetVtKj5FTn4ZUShI58x0eWVW71w2Ev6qzeAHyHKIl/YnjFBrZy0MPZCKeVNyHmZ5/fg5gseZD9aUUV4Hrj6tLgP5SXW3ZaBO3fR8/ZOG/Ipw2YBcygsa4H7sSUTc3Zd4CtGQ2H+EsXuo0TGENoRP+YBx0k2i7aHn2NbKDyEfUeQJDiADCvc0Z0+gk7XPlDHHOfHzxiNySzIalY5M3mjDKbqw087/bjMjmsC4s5FrywQEgt1xmG5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIOjgL6VbApc9e7jhAqwMtK7J4cic8j6o67dH+7RwTE=; b=Cg0d+dKt3BsP081+R6ZoHLQlJEY+6fWeBTTD4qhMHeB006LUqqYjYPpfBJ1FDvb+asAVIyy/UTWZ1Iz6EV9d7GLszxDUMrckB/J0J0i519ylmr7zmeP+IcpvT4MLkWcYZu81agapsxCaap4x7/Da9RNBViPGv7wm6FpQ7Vnnehs= Received: from MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) by MN2PR18MB3573.namprd18.prod.outlook.com (2603:10b6:208:265::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24; Fri, 15 May 2020 11:21:44 +0000 Received: from MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::a8b1:45c4:b84:9c02]) by MN2PR18MB2848.namprd18.prod.outlook.com ([fe80::a8b1:45c4:b84:9c02%7]) with mapi id 15.20.3000.022; Fri, 15 May 2020 11:21:44 +0000 From: Harman Kalra To: Jerin Jacob CC: , Harman Kalra Date: Fri, 15 May 2020 16:51:24 +0530 Message-ID: <1589541684-23246-1-git-send-email-hkalra@marvell.com> X-Mailer: git-send-email 2.7.4 Content-Type: text/plain X-ClientProxiedBy: BM1PR01CA0147.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::17) To MN2PR18MB2848.namprd18.prod.outlook.com (2603:10b6:208:38::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from hkarlara-OptiPlex-3046.marvell.com (115.113.156.2) by BM1PR01CA0147.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3000.20 via Frontend Transport; Fri, 15 May 2020 11:21:42 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [115.113.156.2] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e932cbd5-627e-4aec-aabe-08d7f8c225b4 X-MS-TrafficTypeDiagnostic: MN2PR18MB3573: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RvZnzU1CMutnrHvvoc3OB6vzUAOLZlwIbAVf/WrHb6IGdL6FrXgX2cCnteD9eLfYwlpP4UBtlZWBR6Srrto0LYDI6VuaOZW4bLH/LQ79lsjFSorKtqRlq3ks4qtFkDtr/a8AmT7QwuVNgnzDMrfTLz45Cbw3DIOWqjNdNL8fkZNOmCnb76rxv46GpipleCJyjd2870ofQcZsvUS4/w+GBYI7gBUg877jIf238RpNdxIGvMzMvhs0AwqN/TMUXura+BzCXQ36HgKwJZV54kBNWA6upGsIz0ZILnlEDOtHCrxz51jaDTH9CGZf1AHPM/f960ituATzQGdAwW5qiZrzYASiy2q7uuwJsKu1+EWwx0ukyWQWui2Q/380cH1d9e/s3/OJFW97Vxaa0LdOmje4s/+SKd2Uv2BEK6zTmkTr3qKb03fNv78K6j2B2T0obkdF X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR18MB2848.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(366004)(346002)(396003)(136003)(39860400002)(7696005)(6486002)(26005)(52116002)(55236004)(478600001)(186003)(956004)(2616005)(8676002)(8936002)(66476007)(66946007)(16526019)(66556008)(86362001)(6862004)(4326008)(2906002)(6666004)(37006003)(6636002)(316002)(36756003)(5660300002)(107886003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: +U4bb4ZTMRtwjcP8GJ0BDJcccc0NlvMxA6gepnTItxugXH2PqrcAB6udNynqh7L7jwYxVA5oQCVwhMm9Z1t5i3ef1kJfVVu3F/5iPRA+vPeslJpOeos3Wuo5Wb1eakIqWeVQYVgapCeQfRfLkIxODI/t0XiBB8Nu64NfokMkYul+cyzcmVBKbitYe3rsL3G7Eq6S8pgTBCjWKgA/8WyuxNHlGJtKLOT6aowfeKSnDRjUVB1BZUA28OiHndXjrznEQa/UgkJ/gJB7cKLZXybl2+kwDpkdlpGEzUCYVFOu9LXnL/CgHzFLB1mWIf5qTKHehmJfATBzj70LJxZK85tnBDXaD5bvbXGoD8r8Z4bsOSsU0eX7RBt+tHMYUbrae1i/OPV9yXiUdb4XTSFzvnQ0a2O2VQ7IivEOVrOUjTbw8uOKWN0xILblvjNqkIyC9+MFyqQlY2tEBkGEPemAjMJyZDOkFYV15fT/auTQ/i63CP0= X-MS-Exchange-CrossTenant-Network-Message-Id: e932cbd5-627e-4aec-aabe-08d7f8c225b4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 11:21:44.2761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Aw4BRibWohO+mbUbatRVwOzp5CthgK3UP7hxn8gcNeeLfGOxhJs0O5zzmo26dsZihT4SMfclt2ac6cP2G7h+7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3573 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.676 definitions=2020-05-15_04:2020-05-15, 2020-05-15 signatures=0 Subject: [dpdk-dev] [PATCH] event/octeontx: fix memory corruption X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since PMD enqueues a single event at a time, fixing the issue by passing 1 rather than nb_events to avoid any out of bound access as reported by coverity. Coverity issue: 358447 Fixes: 56a96aa42464 ("event/octeontx: add framework for Rx/Tx offloads") Signed-off-by: Harman Kalra --- drivers/event/octeontx/ssovf_worker.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/event/octeontx/ssovf_worker.c b/drivers/event/octeontx/ssovf_worker.c index d2d5eea8f..18b7926e8 100644 --- a/drivers/event/octeontx/ssovf_worker.c +++ b/drivers/event/octeontx/ssovf_worker.c @@ -282,6 +282,7 @@ __sso_event_tx_adapter_enqueue(void *port, struct rte_event ev[], struct ssows *ws = port; struct octeontx_txq *txq; + RTE_SET_USED(nb_events); switch (ev->sched_type) { case SSO_SYNC_ORDERED: ssows_swtag_norm(ws, ev->event, SSO_SYNC_ATOMIC); @@ -305,7 +306,7 @@ __sso_event_tx_adapter_enqueue(void *port, struct rte_event ev[], ethdev = &rte_eth_devices[port_id]; txq = ethdev->data->tx_queues[queue_id]; - return __octeontx_xmit_pkts(txq, &m, nb_events, cmd, flag); + return __octeontx_xmit_pkts(txq, &m, 1, cmd, flag); } #define T(name, f3, f2, f1, f0, sz, flags) \ -- 2.18.0