All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v3 1/7] bus: mhi: core: Abort suspends due to outgoing pending packets
Date: Mon, 18 May 2020 13:03:55 -0700	[thread overview]
Message-ID: <1589832241-13867-2-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1589832241-13867-1-git-send-email-bbhatt@codeaurora.org>

Add the missing check to abort suspends if a client has pending outgoing
packets to send to the device. This allows better utilization of the MHI
bus wherein clients on the host are not left waiting for longer suspend
or resume cycles to finish for data transfers.

Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
---
 drivers/bus/mhi/core/pm.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 7960980..661d704 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -686,7 +686,8 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
 		return -EIO;
 
 	/* Return busy if there are any pending resources */
-	if (atomic_read(&mhi_cntrl->dev_wake))
+	if (atomic_read(&mhi_cntrl->dev_wake) ||
+	    atomic_read(&mhi_cntrl->pending_pkts))
 		return -EBUSY;
 
 	/* Take MHI out of M2 state */
@@ -712,7 +713,8 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
 
 	write_lock_irq(&mhi_cntrl->pm_lock);
 
-	if (atomic_read(&mhi_cntrl->dev_wake)) {
+	if (atomic_read(&mhi_cntrl->dev_wake) ||
+	    atomic_read(&mhi_cntrl->pending_pkts)) {
 		write_unlock_irq(&mhi_cntrl->pm_lock);
 		return -EBUSY;
 	}
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2020-05-18 20:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-18 20:03 [PATCH v3 0/7] Introduce features and debugfs/sysfs entries for MHI Bhaumik Bhatt
2020-05-18 20:03 ` Bhaumik Bhatt [this message]
2020-05-20 16:48   ` [PATCH v3 1/7] bus: mhi: core: Abort suspends due to outgoing pending packets Jeffrey Hugo
2020-05-18 20:03 ` [PATCH v3 2/7] bus: mhi: core: Introduce independent voting mechanism Bhaumik Bhatt
2020-05-20 16:54   ` Jeffrey Hugo
2020-05-20 18:43     ` bbhatt
2020-05-20 19:06       ` Jeffrey Hugo
2020-05-20 19:44         ` bbhatt
2020-05-20 20:41           ` Jeffrey Hugo
2020-05-18 20:03 ` [PATCH v3 3/7] bus: mhi: core: Use generic name field for an MHI device Bhaumik Bhatt
2020-05-18 20:03 ` [PATCH v3 4/7] bus: mhi: core: Introduce helper function to check device state Bhaumik Bhatt
2020-05-18 20:03 ` [PATCH v3 5/7] bus: mhi: core: Introduce debugfs entries and counters for MHI Bhaumik Bhatt
2020-05-25  6:35   ` Greg KH
2020-05-18 20:04 ` [PATCH v3 6/7] bus: mhi: core: Read and save device hardware information from BHI Bhaumik Bhatt
2020-05-18 20:04 ` [PATCH v3 7/7] bus: mhi: core: Introduce sysfs entries for MHI Bhaumik Bhatt
2020-05-21 13:23 ` [PATCH v3 0/7] Introduce features and debugfs/sysfs " Manivannan Sadhasivam
2020-05-21 15:32   ` Manivannan Sadhasivam
2020-05-21 19:33   ` bbhatt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1589832241-13867-2-git-send-email-bbhatt@codeaurora.org \
    --to=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.