From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C909C433E0 for ; Wed, 20 May 2020 12:08:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D183520758 for ; Wed, 20 May 2020 12:08:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D183520758 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7CB2788310; Wed, 20 May 2020 12:08:05 +0000 (UTC) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47D1688310; Wed, 20 May 2020 12:08:03 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21240219-1500050 for multiple; Wed, 20 May 2020 13:08:01 +0100 MIME-Version: 1.0 In-Reply-To: <158997609575.8153.10522585692912987684@build.alporthouse.com> References: <20200520103853.2484519-1-chris@chris-wilson.co.uk> <0b2857c3-25aa-775c-b559-3de68b9ec032@linux.intel.com> <158997609575.8153.10522585692912987684@build.alporthouse.com> To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org From: Chris Wilson Message-ID: <158997647985.8153.12187123507086139445@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Wed, 20 May 2020 13:07:59 +0100 Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tools/intel_gpu_top: Include total package power X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Chris Wilson (2020-05-20 13:01:35) > Quoting Tvrtko Ursulin (2020-05-20 12:54:19) > > > > On 20/05/2020 11:38, Chris Wilson wrote: > > > @@ -1083,10 +1154,10 @@ print_header(struct engines *engines, double t, > > > printf("\033[H\033[J"); > > > > > > if (lines++ < con_h) > > > - printf("intel-gpu-top - %s/%s MHz; %s%% RC6; %s %s; %s irqs/s\n", > > > + printf("intel-gpu-top - %s/%s MHz; %s%% RC6; %s/%s W; %s irqs/s\n", > > > > Detecting the unit was also a good thing to have so why drop it? > > Because I'm lazy and reused some packaged code rather than try and > repackage the code here. Even too lazy to add libigt_rapl.la. Also, we would only ever report W or mW as the SI unit, the choose is ours and whatever we choose requires adjusting of the reported rapl scalefactor. Since we measure in seconds, the rapl scalefactor itself would have to convert from horsepower into J for the results to make sense, and defined that way. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 In-Reply-To: <158997609575.8153.10522585692912987684@build.alporthouse.com> References: <20200520103853.2484519-1-chris@chris-wilson.co.uk> <0b2857c3-25aa-775c-b559-3de68b9ec032@linux.intel.com> <158997609575.8153.10522585692912987684@build.alporthouse.com> From: Chris Wilson Message-ID: <158997647985.8153.12187123507086139445@build.alporthouse.com> Date: Wed, 20 May 2020 13:07:59 +0100 Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] tools/intel_gpu_top: Include total package power List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-ID: Quoting Chris Wilson (2020-05-20 13:01:35) > Quoting Tvrtko Ursulin (2020-05-20 12:54:19) > > > > On 20/05/2020 11:38, Chris Wilson wrote: > > > @@ -1083,10 +1154,10 @@ print_header(struct engines *engines, double t, > > > printf("\033[H\033[J"); > > > > > > if (lines++ < con_h) > > > - printf("intel-gpu-top - %s/%s MHz; %s%% RC6; %s %s; %s irqs/s\n", > > > + printf("intel-gpu-top - %s/%s MHz; %s%% RC6; %s/%s W; %s irqs/s\n", > > > > Detecting the unit was also a good thing to have so why drop it? > > Because I'm lazy and reused some packaged code rather than try and > repackage the code here. Even too lazy to add libigt_rapl.la. Also, we would only ever report W or mW as the SI unit, the choose is ours and whatever we choose requires adjusting of the reported rapl scalefactor. Since we measure in seconds, the rapl scalefactor itself would have to convert from horsepower into J for the results to make sense, and defined that way. -Chris _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev