All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Changbin Du <changbin.du@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: replace in_irq() with in_hardirq()
Date: Mon, 16 Aug 2021 08:23:57 +0200	[thread overview]
Message-ID: <158e002d-3fa4-6027-29cd-33e446cddf19@kernel.org> (raw)
In-Reply-To: <20210814005033.2381-1-changbin.du@gmail.com>

On 14. 08. 21, 2:50, Changbin Du wrote:
> Replace the obsolete and ambiguos macro in_irq() with new
> macro in_hardirq().

... which is just a new name.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
>   drivers/tty/sysrq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 6628792431dc..c911196ac893 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -258,7 +258,7 @@ static void sysrq_handle_showallcpus(int key)
>   	if (!trigger_all_cpu_backtrace()) {
>   		struct pt_regs *regs = NULL;
>   
> -		if (in_irq())
> +		if (in_hardirq())
>   			regs = get_irq_regs();
>   		if (regs) {
>   			pr_info("CPU%d:\n", smp_processor_id());
> @@ -280,7 +280,7 @@ static void sysrq_handle_showregs(int key)
>   {
>   	struct pt_regs *regs = NULL;
>   
> -	if (in_irq())
> +	if (in_hardirq())
>   		regs = get_irq_regs();
>   	if (regs)
>   		show_regs(regs);
> 


-- 
js
suse labs

      reply	other threads:[~2021-08-16  6:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14  0:50 [PATCH] tty: replace in_irq() with in_hardirq() Changbin Du
2021-08-16  6:23 ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=158e002d-3fa4-6027-29cd-33e446cddf19@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=changbin.du@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.