From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85CDC433E0 for ; Thu, 21 May 2020 08:52:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C45FF20829 for ; Thu, 21 May 2020 08:52:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="U+FaTvlt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728654AbgEUIwj (ORCPT ); Thu, 21 May 2020 04:52:39 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:33210 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728389AbgEUIwj (ORCPT ); Thu, 21 May 2020 04:52:39 -0400 X-UUID: eea90d1380b540bfb2d3f2d6437f50f9-20200521 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:From:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:Message-ID:Subject; bh=Ntq+xnZqQIn/7PE5MMeGwbIxDp+MLU6cQe0dH7iWCZU=; b=U+FaTvltahZ7khZZtzciTGjMw2cZP8cOg2BL98HP1W7g5hyOid75Bmg0LrszMbJtAAxkfHtinTC2SXMb5srzC76X1Z7gdg9IzMdrRlqsl9tS5oBEWIwCw4A6ypqd2JE4FA2ICmwR3itSyFk8/m9lRlcMk+gnZ8c9+Y+p97FVTFs=; X-UUID: eea90d1380b540bfb2d3f2d6437f50f9-20200521 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1294609958; Thu, 21 May 2020 16:52:36 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 16:52:34 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 21 May 2020 16:52:34 +0800 Subject: Re: [PATCH 09/12] devfreq: add mediatek cci devfreq Message-ID: <1590051155.14062.3.camel@mtksdaap41> SubjeTo: Mark Brown CC: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , "Rob Herring" , Mark Rutland , "Matthias Brugger" , "Rafael J . Wysocki" , Viresh Kumar , Nishanth Menon , "Stephen Boyd" , Liam Girdwood , , , , , , Date: Thu, 21 May 2020 16:52:35 +0800 In-Reply-To: <20200520123135.GD4823@sirena.org.uk> References: <20200520034307.20435-1-andrew-sh.cheng@mediatek.com> <20200520034307.20435-10-andrew-sh.cheng@mediatek.com> <20200520123135.GD4823@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 From: X-MTK: N Content-Transfer-Encoding: base64 To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQpPbiBXZWQsIDIwMjAtMDUtMjAgYXQgMTM6MzEgKzAxMDAsIE1hcmsgQnJvd24gd3JvdGU6DQo+ IE9uIFdlZCwgTWF5IDIwLCAyMDIwIGF0IDExOjQzOjA0QU0gKzA4MDAsIEFuZHJldy1zaC5DaGVu ZyB3cm90ZToNCj4gDQo+ID4gKwljY2lfZGYtPnByb2NfcmVnID0gZGV2bV9yZWd1bGF0b3JfZ2V0 X29wdGlvbmFsKGNjaV9kZXYsICJwcm9jIik7DQo+ID4gKwlyZXQgPSBQVFJfRVJSX09SX1pFUk8o Y2NpX2RmLT5wcm9jX3JlZyk7DQo+ID4gKwlpZiAocmV0KSB7DQo+ID4gKwkJaWYgKHJldCAhPSAt RVBST0JFX0RFRkVSKQ0KPiA+ICsJCQlkZXZfZXJyKGNjaV9kZXYsICJmYWlsZWQgdG8gZ2V0IHJl Z3VsYXRvciBmb3IgQ0NJOiAlZFxuIiwNCj4gPiArCQkJCXJldCk7DQo+ID4gKwkJcmV0dXJuIHJl dDsNCj4gPiArCX0NCj4gPiArCXJldCA9IHJlZ3VsYXRvcl9lbmFibGUoY2NpX2RmLT5wcm9jX3Jl Zyk7DQo+IA0KPiBUaGUgY29kZSBhcHBlYXJzIHRvIHJlcXVpcmUgYSByZWd1bGF0b3IgKGFuZCBJ J20gZ3Vlc3NpbmcgdGhlIGRldmljZQ0KPiBuZWVkcyBwb3dlcikgc28gd2h5IGlzIHRoaXMgdXNp bmcgcmVndWxhdG9yX2dldF9vcHRpb25hbCgpPw0KDQpIaSBNYXJrLA0KDQpEbyB5b3UgbWVhbiwg d2h5IG5vdCB1c2UgcmVndWxhdG9yX2dldF9leGNsdXNpdmUoKSBvciByZWd1bGF0b3JfZ2V0KCk/ DQpCZWNhdXNlIGNjaSBhbmQgY3B1IGxpdHRlciBjb3JlIHNoYXJlZCBidWNrLCBpdCBjYW5ub3Qg dXNlDQpyZWd1bGF0b3JfZ2V0X2V4Y2x1c2l2ZSgpLg0KQmVjYXVzZSBib3RoIGNjaSBhbmQgY3B1 IHdhbnQgdG8gdHVuZSB2b2x0YWdlLCBpdCBjYW5ub3QgdXNlDQpyZWd1bGF0b3JfZ2V0KCksIG90 aGVyd2lzZSBpdCB3aWxsIGdldCBkdW1teSByZWd1bGF0b3IgZXZlbiB0aGlzIGJ1Y2sNCmRvZXNu J3QgcmVnaXN0ZXIuYXMgcmVndWxhdG9yLg0KDQpCUiwNCkFuZHJldy1zaC5DaGVuZw0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MISSING_HEADERS, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F19C433DF for ; Thu, 21 May 2020 08:53:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA23020721 for ; Thu, 21 May 2020 08:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GU/ZvmZD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="U+FaTvlt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA23020721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:MIME-Version:References: In-Reply-To:Date:Message-ID:Subject:Reply-To:To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2BWQt1dbyFcB3zXyWA92vT/Kh2lrFiz1lPXaS5c1ZUk=; b=GU/ZvmZDtPH5ysIgGJzQnoMrIY 73KHz77Lm35jHPhldiYTT1OHypX856IcJUn3vbLO/PaYktkOUGJ+RlooG8FtI4cZ4b/LLC+mli1Y5 DM/O2iWv/Pyzc/xUXnXjEg0Ercd5HZ531GmoWC4stEMuQpbHjtP2X/7IHtE25LVUmd9OAH/94fl/3 sJJVC90kBpprDuXsR2b1MgRHP/X50ch/x4ui47MJ+C9iTVOhAbljE7YiD4tBoV0ZPIsDi5w6PuezN z9jcnCl4oO3FIVmQVE990Eg8YOUpQkTj2byntzxcXMvj9+1YQ5sD6RpZE5RXUrRAcCHA1+MnILRj/ vMTKrmXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbgwm-0000gA-GU; Thu, 21 May 2020 08:53:00 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbgwj-0000eO-Hs; Thu, 21 May 2020 08:52:58 +0000 X-UUID: 126a4a26ffaf491c9a87184c3e6004df-20200521 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:From:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:Message-ID:Subject; bh=Ntq+xnZqQIn/7PE5MMeGwbIxDp+MLU6cQe0dH7iWCZU=; b=U+FaTvltahZ7khZZtzciTGjMw2cZP8cOg2BL98HP1W7g5hyOid75Bmg0LrszMbJtAAxkfHtinTC2SXMb5srzC76X1Z7gdg9IzMdrRlqsl9tS5oBEWIwCw4A6ypqd2JE4FA2ICmwR3itSyFk8/m9lRlcMk+gnZ8c9+Y+p97FVTFs=; X-UUID: 126a4a26ffaf491c9a87184c3e6004df-20200521 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2091865296; Thu, 21 May 2020 00:52:38 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 01:52:37 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 16:52:34 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 21 May 2020 16:52:34 +0800 Subject: Re: [PATCH 09/12] devfreq: add mediatek cci devfreq Message-ID: <1590051155.14062.3.camel@mtksdaap41> SubjeTo: Mark Brown Date: Thu, 21 May 2020 16:52:35 +0800 In-Reply-To: <20200520123135.GD4823@sirena.org.uk> References: <20200520034307.20435-1-andrew-sh.cheng@mediatek.com> <20200520034307.20435-10-andrew-sh.cheng@mediatek.com> <20200520123135.GD4823@sirena.org.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 From: X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_015257_594285_99545AA5 X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nishanth Menon , srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , "Rafael J . Wysocki" , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Chanwoo Choi , Kyungmin Park , MyungJoo Ham , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2020-05-20 at 13:31 +0100, Mark Brown wrote: > On Wed, May 20, 2020 at 11:43:04AM +0800, Andrew-sh.Cheng wrote: > > > + cci_df->proc_reg = devm_regulator_get_optional(cci_dev, "proc"); > > + ret = PTR_ERR_OR_ZERO(cci_df->proc_reg); > > + if (ret) { > > + if (ret != -EPROBE_DEFER) > > + dev_err(cci_dev, "failed to get regulator for CCI: %d\n", > > + ret); > > + return ret; > > + } > > + ret = regulator_enable(cci_df->proc_reg); > > The code appears to require a regulator (and I'm guessing the device > needs power) so why is this using regulator_get_optional()? Hi Mark, Do you mean, why not use regulator_get_exclusive() or regulator_get()? Because cci and cpu litter core shared buck, it cannot use regulator_get_exclusive(). Because both cci and cpu want to tune voltage, it cannot use regulator_get(), otherwise it will get dummy regulator even this buck doesn't register.as regulator. BR, Andrew-sh.Cheng _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MISSING_HEADERS, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1631FC433DF for ; Thu, 21 May 2020 08:53:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D19AF20721 for ; Thu, 21 May 2020 08:53:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r6eKxgMd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="U+FaTvlt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D19AF20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:From:MIME-Version:References: In-Reply-To:Date:Message-ID:Subject:Reply-To:To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=uiy9jKAyXCgdymoNgQSLmd87uNINNFbdu4QDa7hC5H0=; b=r6eKxgMd1jlk6dzZkBAXpadbnJ hRP5mix2EyJw2VATBYgUtuqssA7sdOdZO4wEVhywynr040kyVaXJYuQb3mY+ARkVR9fTLb3tTAgoC uQksXfnHZBAjUl9zPVfKrS36cvip0JA4SbghsupW8LNkbvHPALIc1QQWOZe6w+KYc7Wx3hW7b6S5K B5bD1FPGHyeXmaXzuHftV7QXa7wt70xChJVKW8gb64AHuY5tmYDMjNlqi/mykxLGkovYg16wt1xKP kIoJ+y9lZsooO7vDW70gfE6xZOLbm355FAVebbklZ5V/c04Aef+gTB1DfCSGm0p1Rcbuid3LTiECa extDYnvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbgwn-0000gr-E1; Thu, 21 May 2020 08:53:01 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbgwj-0000eO-Hs; Thu, 21 May 2020 08:52:58 +0000 X-UUID: 126a4a26ffaf491c9a87184c3e6004df-20200521 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:From:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:Message-ID:Subject; bh=Ntq+xnZqQIn/7PE5MMeGwbIxDp+MLU6cQe0dH7iWCZU=; b=U+FaTvltahZ7khZZtzciTGjMw2cZP8cOg2BL98HP1W7g5hyOid75Bmg0LrszMbJtAAxkfHtinTC2SXMb5srzC76X1Z7gdg9IzMdrRlqsl9tS5oBEWIwCw4A6ypqd2JE4FA2ICmwR3itSyFk8/m9lRlcMk+gnZ8c9+Y+p97FVTFs=; X-UUID: 126a4a26ffaf491c9a87184c3e6004df-20200521 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2091865296; Thu, 21 May 2020 00:52:38 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 01:52:37 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 21 May 2020 16:52:34 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 21 May 2020 16:52:34 +0800 Subject: Re: [PATCH 09/12] devfreq: add mediatek cci devfreq Message-ID: <1590051155.14062.3.camel@mtksdaap41> SubjeTo: Mark Brown Date: Thu, 21 May 2020 16:52:35 +0800 In-Reply-To: <20200520123135.GD4823@sirena.org.uk> References: <20200520034307.20435-1-andrew-sh.cheng@mediatek.com> <20200520034307.20435-10-andrew-sh.cheng@mediatek.com> <20200520123135.GD4823@sirena.org.uk> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 From: X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200521_015257_594285_99545AA5 X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nishanth Menon , srv_heupstream@mediatek.com, linux-pm@vger.kernel.org, Stephen Boyd , Viresh Kumar , "Rafael J . Wysocki" , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Chanwoo Choi , Kyungmin Park , MyungJoo Ham , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Matthias Brugger , devicetree@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-05-20 at 13:31 +0100, Mark Brown wrote: > On Wed, May 20, 2020 at 11:43:04AM +0800, Andrew-sh.Cheng wrote: > > > + cci_df->proc_reg = devm_regulator_get_optional(cci_dev, "proc"); > > + ret = PTR_ERR_OR_ZERO(cci_df->proc_reg); > > + if (ret) { > > + if (ret != -EPROBE_DEFER) > > + dev_err(cci_dev, "failed to get regulator for CCI: %d\n", > > + ret); > > + return ret; > > + } > > + ret = regulator_enable(cci_df->proc_reg); > > The code appears to require a regulator (and I'm guessing the device > needs power) so why is this using regulator_get_optional()? Hi Mark, Do you mean, why not use regulator_get_exclusive() or regulator_get()? Because cci and cpu litter core shared buck, it cannot use regulator_get_exclusive(). Because both cci and cpu want to tune voltage, it cannot use regulator_get(), otherwise it will get dummy regulator even this buck doesn't register.as regulator. BR, Andrew-sh.Cheng _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel