From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 007E4C433E0 for ; Thu, 28 May 2020 01:59:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9CFC2084C for ; Thu, 28 May 2020 01:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590631167; bh=f+8uYByHjJyZ01uYG5pSv1ZMt/fLT2/K91SdYiWRq5U=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=FtGCW9NWmvcLIE7bgpgJ0mSwm4JC/8S58R9HNmaR+rxDUzZ5svrDNQB1Qtv+ABtei 21yFO/0dEef0kJsYam3tMO5asUA1q+14aAVz5n5IxrmZP8sUBbYT0LHVyt5OXa6oWo +0YGmwBKd9ATjJtYTgCpAyf36ZiiGmr3T4UjxQzc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726495AbgE1B71 (ORCPT ); Wed, 27 May 2020 21:59:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:53516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgE1B70 (ORCPT ); Wed, 27 May 2020 21:59:26 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8062B207CB; Thu, 28 May 2020 01:59:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590631165; bh=f+8uYByHjJyZ01uYG5pSv1ZMt/fLT2/K91SdYiWRq5U=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=yD7Uu1nQC3xDzb9PlMBLlcHcr4LToVohxsPcF3NquhIallyf3+LUL9fUdQV+eOave LRdvu88+vs9sedAjrVT/3+bQ0BoHF+ApEaZQ5sj9bvl3lvXe+znrcqnng0gnags5x7 g8cODBavPQ5F4DxJ5c+5JoNBJAAKmMBVFL+3eVEE= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1590582292-13314-5-git-send-email-sivaprak@codeaurora.org> References: <1590582292-13314-1-git-send-email-sivaprak@codeaurora.org> <1590582292-13314-5-git-send-email-sivaprak@codeaurora.org> Subject: Re: [PATCH V6 4/5] clk: qcom: Add ipq6018 apss clock controller From: Stephen Boyd Cc: Sivaprakash Murugesan To: Sivaprakash Murugesan , agross@kernel.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, robh+dt@kernel.org Date: Wed, 27 May 2020 18:59:24 -0700 Message-ID: <159063116486.69627.5280506237179820811@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Sivaprakash Murugesan (2020-05-27 05:24:51) > diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6= 018.c > new file mode 100644 > index 0000000..004f7e1 > --- /dev/null > +++ b/drivers/clk/qcom/apss-ipq6018.c > @@ -0,0 +1,106 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2018, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +#include "common.h" > +#include "clk-regmap.h" > +#include "clk-branch.h" > +#include "clk-alpha-pll.h" > +#include "clk-regmap-mux.h" > + > +enum { > + P_XO, > + P_APSS_PLL_EARLY, > +}; > + > +static const struct clk_parent_data parents_apcs_alias0_clk_src[] =3D { > + { .fw_name =3D "xo" }, > + { .fw_name =3D "pll" }, This pll clk is not described in the binding. Please add it there. > +}; > + > +static const struct parent_map parents_apcs_alias0_clk_src_map[] =3D { > + { P_XO, 0 }, > + { P_APSS_PLL_EARLY, 5 }, > +}; > +