All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com>
To: qemu-devel@nongnu.org
Cc: wrampazz@redhat.com, alex.bennee@linaro.org, dovgaluk@ispras.ru,
	pavel.dovgaluk@ispras.ru, crosa@redhat.com, pbonzini@redhat.com,
	philmd@redhat.com, ehabkost@redhat.com
Subject: [PATCH v3 02/11] tests/acceptance: refactor boot_linux_console test to allow code reuse
Date: Fri, 29 May 2020 10:04:44 +0300	[thread overview]
Message-ID: <159073588490.20809.13942096070255577558.stgit@pasha-ThinkPad-X280> (raw)
In-Reply-To: <159073587336.20809.5404476664125786279.stgit@pasha-ThinkPad-X280>

This patch splits code in BootLinuxConsole class into two different
classes to allow reusing it by record/replay tests.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
 0 files changed

diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index c6b06a1a13..12725d4529 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -28,19 +28,13 @@ try:
 except CmdNotFoundError:
     P7ZIP_AVAILABLE = False
 
-class BootLinuxConsole(Test):
-    """
-    Boots a Linux kernel and checks that the console is operational and the
-    kernel command line is properly passed from QEMU to the kernel
-    """
-
-    timeout = 90
-
+class LinuxKernelTest(Test):
     KERNEL_COMMON_COMMAND_LINE = 'printk.time=0 '
 
-    def wait_for_console_pattern(self, success_message):
+    def wait_for_console_pattern(self, success_message, vm=None):
         wait_for_console_pattern(self, success_message,
-                                 failure_message='Kernel panic - not syncing')
+                                 failure_message='Kernel panic - not syncing',
+                                 vm=vm)
 
     def extract_from_deb(self, deb, path):
         """
@@ -79,6 +73,13 @@ class BootLinuxConsole(Test):
         os.chdir(cwd)
         return os.path.normpath(os.path.join(self.workdir, path))
 
+class BootLinuxConsole(LinuxKernelTest):
+    """
+    Boots a Linux kernel and checks that the console is operational and the
+    kernel command line is properly passed from QEMU to the kernel
+    """
+    timeout = 90
+
     def test_x86_64_pc(self):
         """
         :avocado: tags=arch:x86_64



  parent reply	other threads:[~2020-05-29  7:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  7:04 [PATCH v3 00/11] Record/replay acceptance tests Pavel Dovgalyuk
2020-05-29  7:04 ` [PATCH v3 01/11] tests/acceptance: allow console interaction with specific VMs Pavel Dovgalyuk
2020-05-29  7:04 ` Pavel Dovgalyuk [this message]
2020-05-29  7:04 ` [PATCH v3 03/11] tests/acceptance: add base class record/replay kernel tests Pavel Dovgalyuk
2020-05-29  7:04 ` [PATCH v3 04/11] tests/acceptance: add kernel record/replay test for x86_64 Pavel Dovgalyuk
2020-05-29  7:05 ` [PATCH v3 05/11] tests/acceptance: add record/replay test for aarch64 Pavel Dovgalyuk
2020-05-29  7:05 ` [PATCH v3 06/11] tests/acceptance: add record/replay test for arm Pavel Dovgalyuk
2020-05-29  7:05 ` [PATCH v3 07/11] tests/acceptance: add record/replay test for ppc64 Pavel Dovgalyuk
2020-05-29  7:05 ` [PATCH v3 08/11] tests/acceptance: add record/replay test for m68k Pavel Dovgalyuk
2020-06-19 16:08   ` Laurent Vivier
2020-05-29  7:05 ` [PATCH v3 09/11] tests/acceptance: record/replay tests with advcal images Pavel Dovgalyuk
2020-06-21 11:51   ` Philippe Mathieu-Daudé
2020-05-29  7:05 ` [PATCH v3 10/11] tests/acceptance: refactor boot_linux to allow code reuse Pavel Dovgalyuk
2020-05-31 12:04   ` Philippe Mathieu-Daudé
2020-05-29  7:05 ` [PATCH v3 11/11] tests/acceptance: Linux boot test for record/replay Pavel Dovgalyuk
2020-06-22  8:03   ` Philippe Mathieu-Daudé
2020-06-22  8:54     ` Philippe Mathieu-Daudé
2020-05-31 15:09 ` [PATCH v3 00/11] Record/replay acceptance tests Philippe Mathieu-Daudé
2020-06-20 23:36   ` Philippe Mathieu-Daudé
2020-06-22  7:44     ` Pavel Dovgalyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159073588490.20809.13942096070255577558.stgit@pasha-ThinkPad-X280 \
    --to=pavel.dovgaluk@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=dovgaluk@ispras.ru \
    --cc=ehabkost@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.