From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Change ether_addr to avoid conflict Date: Tue, 23 Oct 2018 10:37:34 +0200 Message-ID: <1590899.CaVHfE2u3J@xps> References: <9DDD01EB-C8A2-40F1-AF77-EBFA1E96D595@perftech.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, "Wiles, Keith" To: Lewis Donzis Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8A1D81B107 for ; Tue, 23 Oct 2018 10:37:34 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/10/2018 17:06, Wiles, Keith: >=20 > > On Oct 21, 2018, at 8:39 AM, Lewis Donzis wrote: > >=20 > > Please consider changing =E2=80=9Cstruct ether_addr=E2=80=9D in rte_eth= er.h to =E2=80=9Cstruct rte_ether_addr=E2=80=9D, in order to avoid conflict= s with the same structure name /usr/include/net/ethernet.h. > >=20 > > This is kind of a pain for us since we would like to include ethernet.h= in order to get some other definitions, but we can=E2=80=99t because it co= nflicts with the same structure name in rte_ether.h. >=20 > I agree, but it will require a deprecation notice as a lot of code uses i= t. Yes, it is a very long standing issue. During the last technical board meeting, we discussed a plan to fix it: http://mails.dpdk.org/archives/dev/2018-October/116695.html