From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9CCC433DF for ; Wed, 3 Jun 2020 07:29:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62F162068D for ; Wed, 3 Jun 2020 07:29:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="rsiYpbdr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbgFCH3H (ORCPT ); Wed, 3 Jun 2020 03:29:07 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:6641 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725810AbgFCH3H (ORCPT ); Wed, 3 Jun 2020 03:29:07 -0400 X-UUID: 46bdbf9e4142415ea62346d624dd87a7-20200603 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uxJ/OyZIhvn8jO7euhdxxdoo6BqLiSJM0zglxbBqOos=; b=rsiYpbdrvrTKk8pW+Ygso90z2A10JD7TpaJ9wdg6yWauTg7OT4Hw6IgcOEpu9vtFhCjL64pw7yMgy2sMrsE8tK5quGWduMsZI+iGlpkM0KyiC0grLkG+7Aq2sOQ2Dqodeo/S/GdP4dGfcFQZX2HhNDZkkobZQerRHTMBp+aW4Ik=; X-UUID: 46bdbf9e4142415ea62346d624dd87a7-20200603 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 526761993; Wed, 03 Jun 2020 15:29:03 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 15:29:02 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 3 Jun 2020 15:29:01 +0800 Message-ID: <1591169342.4878.9.camel@mtkswgap22> Subject: Re: Security Random Number Generator support From: Neal Liu To: Marc Zyngier , Julius Werner , Ard Biesheuvel CC: Neal Liu , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Herbert Xu , Arnd Bergmann , "Greg Kroah-Hartman" , Sean Wang , lkml , wsd_upstream , Crystal Guo =?UTF-8?Q?=28=E9=83=AD=E6=99=B6=29?= , "Rob Herring" , Linux Crypto Mailing List , Matt Mackall , "Matthias Brugger" , "linux-mediatek@lists.infradead.org" , Linux ARM Date: Wed, 3 Jun 2020 15:29:02 +0800 In-Reply-To: <85dfc0142d3879d50c0ba18bcc71e199@misterjones.org> References: <1591085678-22764-1-git-send-email-neal.liu@mediatek.com> <85dfc0142d3879d50c0ba18bcc71e199@misterjones.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org T24gVHVlLCAyMDIwLTA2LTAyIGF0IDIxOjAyICswODAwLCBNYXJjIFp5bmdpZXIgd3JvdGU6DQo+ IE9uIDIwMjAtMDYtMDIgMTM6MTQsIEFyZCBCaWVzaGV1dmVsIHdyb3RlOg0KPiA+IE9uIFR1ZSwg MiBKdW4gMjAyMCBhdCAxMDoxNSwgTmVhbCBMaXUgPG5lYWwubGl1QG1lZGlhdGVrLmNvbT4gd3Jv dGU6DQo+ID4+IA0KPiA+PiBUaGVzZSBwYXRjaCBzZXJpZXMgaW50cm9kdWNlIGEgc2VjdXJpdHkg cmFuZG9tIG51bWJlciBnZW5lcmF0b3INCj4gPj4gd2hpY2ggcHJvdmlkZXMgYSBnZW5lcmljIGlu dGVyZmFjZSB0byBnZXQgaGFyZHdhcmUgcm5kIGZyb20gU2VjdXJlDQo+ID4+IHN0YXRlLiBUaGUg U2VjdXJlIHN0YXRlIGNhbiBiZSBBcm0gVHJ1c3RlZCBGaXJtd2FyZShBVEYpLCBUcnVzdGVkDQo+ ID4+IEV4ZWN1dGlvbiBFbnZpcm9ubWVudChURUUpLCBvciBldmVuIEVMMiBoeXBlcnZpc29yLg0K PiA+PiANCj4gPj4gUGF0Y2ggIzEuLjIgYWRkcyBzZWMtcm5nIGtlcm5lbCBkcml2ZXIgZm9yIFRy dXN0em9uZSBiYXNlZCBTb0NzLg0KPiA+PiBGb3Igc2VjdXJpdHkgYXdhcmVuZXNzIFNvQ3Mgb24g QVJNdjggd2l0aCBUcnVzdFpvbmUgZW5hYmxlZCwNCj4gPj4gcGVyaXBoZXJhbHMgbGlrZSBlbnRy b3B5IHNvdXJjZXMgaXMgbm90IGFjY2Vzc2libGUgZnJvbSBub3JtYWwgd29ybGQNCj4gPj4gKGxp bnV4KSBhbmQgcmF0aGVyIGFjY2Vzc2libGUgZnJvbSBzZWN1cmUgd29ybGQgKEhZUC9BVEYvVEVF KSBvbmx5Lg0KPiA+PiBUaGlzIGRyaXZlciBhaW1zIHRvIHByb3ZpZGUgYSBnZW5lcmljIGludGVy ZmFjZSB0byBBcm0gVHJ1c3RlZA0KPiA+PiBGaXJtd2FyZSBvciBIeXBlcnZpc29yIHJuZyBzZXJ2 aWNlLg0KPiA+PiANCj4gPj4gDQo+ID4+IGNoYW5nZXMgc2luY2UgdjE6DQo+ID4+IC0gcmVuYW1l IG10Njd4eC1ybmcgdG8gbXRrLXNlYy1ybmcgc2luY2UgYWxsIE1lZGlhVGVrIEFSTXY4IFNvQ3Mg Y2FuIA0KPiA+PiByZXVzZQ0KPiA+PiAgIHRoaXMgZHJpdmVyLg0KPiA+PiAgIC0gcmVmaW5lIGNv ZGluZyBzdHlsZSBhbmQgdW5uZWNlc3NhcnkgY2hlY2suDQo+ID4+IA0KPiA+PiAgIGNoYW5nZXMg c2luY2UgdjI6DQo+ID4+ICAgLSByZW1vdmUgdW51c2VkIGNvbW1lbnRzLg0KPiA+PiAgIC0gcmVt b3ZlIHJlZHVuZGFudCB2YXJpYWJsZS4NCj4gPj4gDQo+ID4+ICAgY2hhbmdlcyBzaW5jZSB2MzoN Cj4gPj4gICAtIGFkZCBkdC1iaW5kaW5ncyBmb3IgTWVkaWFUZWsgcm5nIHdpdGggVHJ1c3Rab25l IGVuYWJsZWQuDQo+ID4+ICAgLSByZXZpc2UgSFdSTkcgU01DIGNhbGwgZmlkLg0KPiA+PiANCj4g Pj4gICBjaGFuZ2VzIHNpbmNlIHY0Og0KPiA+PiAgIC0gbW92ZSBiaW5kaW5ncyB0byB0aGUgYXJt L2Zpcm13YXJlIGRpcmVjdG9yeS4NCj4gPj4gICAtIHJldmlzZSBkcml2ZXIgaW5pdCBmbG93IHRv IGNoZWNrIG1vcmUgcHJvcGVydHkuDQo+ID4+IA0KPiA+PiAgIGNoYW5nZXMgc2luY2UgdjU6DQo+ ID4+ICAgLSByZWZhY3RvciB0byBtb3JlIGdlbmVyaWMgc2VjdXJpdHkgcm5nIGRyaXZlciB3aGlj aA0KPiA+PiAgICAgaXMgbm90IHBsYXRmb3JtIHNwZWNpZmljLg0KPiA+PiANCj4gPj4gKioqIEJM VVJCIEhFUkUgKioqDQo+ID4+IA0KPiA+PiBOZWFsIExpdSAoMik6DQo+ID4+ICAgZHQtYmluZGlu Z3M6IHJuZzogYWRkIGJpbmRpbmdzIGZvciBzZWMtcm5nDQo+ID4+ICAgaHdybmc6IGFkZCBzZWMt cm5nIGRyaXZlcg0KPiA+PiANCj4gPiANCj4gPiBUaGVyZSBpcyBubyByZWFzb24gdG8gbW9kZWwg YSBTTUMgY2FsbCBhcyBhIGRyaXZlciwgYW5kIHJlcHJlc2VudCBpdA0KPiA+IHZpYSBhIERUIG5v ZGUgbGlrZSB0aGlzLg0KPiANCj4gKzEuDQo+IA0KPiA+IEl0IHdvdWxkIGJlIG11Y2ggYmV0dGVy IGlmIHRoaXMgU01DIGludGVyZmFjZSBpcyBtYWRlIHRydWx5IGdlbmVyaWMsDQo+ID4gYW5kIHdp cmVkIGludG8gdGhlIGFyY2hfZ2V0X3JhbmRvbSgpIGludGVyZmFjZSwgd2hpY2ggY2FuIGJlIHVz ZWQgbXVjaA0KPiA+IGVhcmxpZXIuDQo+IA0KPiBXYXNuJ3QgdGhlcmUgYSBwbGFuIHRvIHN0YW5k YXJkaXplIGEgU01DIGNhbGwgdG8gcnVsZSB0aGVtIGFsbD8NCj4gDQo+ICAgICAgICAgIE0uDQoN CkNvdWxkIHlvdSBnaXZlIHVzIGEgaGludCBob3cgdG8gbWFrZSB0aGlzIFNNQyBpbnRlcmZhY2Ug bW9yZSBnZW5lcmljIGluDQphZGRpdGlvbiB0byBteSBhcHByb2FjaD8NClRoZXJlIGlzIG5vIChl YXN5KSB3YXkgdG8gZ2V0IHBsYXRmb3JtLWluZGVwZW5kZW50IFNNQyBmdW5jdGlvbiBJRCwNCndo aWNoIGlzIHdoeSB3ZSBlbmNvZGUgaXQgaW50byBkZXZpY2UgdHJlZSwgYW5kIHByb3ZpZGUgYSBn ZW5lcmljDQpkcml2ZXIuIEluIHRoaXMgd2F5LCBkaWZmZXJlbnQgZGV2aWNlcyBjYW4gYmUgbWFw cGVkIGFuZCB0aGVuIGdldA0KZGlmZmVyZW50IGZ1bmN0aW9uIElEIGludGVybmFsbHkuDQoNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D216FC433DF for ; Wed, 3 Jun 2020 07:29:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A275D2067B for ; Wed, 3 Jun 2020 07:29:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cpCPAzZu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="CEt6aRgE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A275D2067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YkZFRo2AtB0bvDk4VOlXCpbkh1WxljSSmePLme/r7gc=; b=cpCPAzZu88VO5O FG4kOz4dSgQroTeqG1N5fo8Pjd4Dbu4KBoY/76XyWInhWrQzIox2JwS8q8LoIHkqzeNHslT8kDFmp YgxHYWGv+PrB7u8tTJqSbAe/G1d7qm5Q4FQhuDc1VXu9hLI9IAI5oWTcOaT0/xNkeNoeQq0YstkOO XS8Xe6fYmBILsFaPXKgw8/CAmAhD1/iqGphze4hTk0P7ATQXbcJaEFuSwJb5vTwNAsm1Q9Je9JhV3 cR0FK0NQNT8qQvPWklG/DifCXe2E5TbW95HFVBgl2ssKpOGAOoR9fJmvm7K7IUzgEzuLR6YMzkEsw mnno36Vu7tsXZ5jqtKpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgNpu-0004Hu-Bc; Wed, 03 Jun 2020 07:29:18 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgNpr-0004HL-6t; Wed, 03 Jun 2020 07:29:16 +0000 X-UUID: 68f36bbf5ee94faa878b71255c900f2d-20200602 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uxJ/OyZIhvn8jO7euhdxxdoo6BqLiSJM0zglxbBqOos=; b=CEt6aRgES19HkCxvzzojs8LYRDsf4UJVp+a2UCrOlilmbI/BJ9L+e5CoG6mCq5ixCZDHQIaqUIueDXroGlcGygPjR0x6ZgRF82VMqtmxQ42zwJrUvXSFxhlIQAOOERT8R6KrbMeGLoZRbjuzOsvDoZDjUGLoVhJABTso3DwAuZY=; X-UUID: 68f36bbf5ee94faa878b71255c900f2d-20200602 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 521984248; Tue, 02 Jun 2020 23:29:00 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 00:29:08 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 15:29:02 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 3 Jun 2020 15:29:01 +0800 Message-ID: <1591169342.4878.9.camel@mtkswgap22> Subject: Re: Security Random Number Generator support From: Neal Liu To: Marc Zyngier , Julius Werner , Ard Biesheuvel Date: Wed, 3 Jun 2020 15:29:02 +0800 In-Reply-To: <85dfc0142d3879d50c0ba18bcc71e199@misterjones.org> References: <1591085678-22764-1-git-send-email-neal.liu@mediatek.com> <85dfc0142d3879d50c0ba18bcc71e199@misterjones.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_002915_254003_A5C3EB4E X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Sean Wang , "linux-mediatek@lists.infradead.org" , lkml , wsd_upstream , Rob Herring , Neal Liu , Linux Crypto Mailing List , Matt Mackall , Matthias Brugger , Crystal Guo =?UTF-8?Q?=28=E9=83=AD=E6=99=B6=29?= , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2020-06-02 at 21:02 +0800, Marc Zyngier wrote: > On 2020-06-02 13:14, Ard Biesheuvel wrote: > > On Tue, 2 Jun 2020 at 10:15, Neal Liu wrote: > >> > >> These patch series introduce a security random number generator > >> which provides a generic interface to get hardware rnd from Secure > >> state. The Secure state can be Arm Trusted Firmware(ATF), Trusted > >> Execution Environment(TEE), or even EL2 hypervisor. > >> > >> Patch #1..2 adds sec-rng kernel driver for Trustzone based SoCs. > >> For security awareness SoCs on ARMv8 with TrustZone enabled, > >> peripherals like entropy sources is not accessible from normal world > >> (linux) and rather accessible from secure world (HYP/ATF/TEE) only. > >> This driver aims to provide a generic interface to Arm Trusted > >> Firmware or Hypervisor rng service. > >> > >> > >> changes since v1: > >> - rename mt67xx-rng to mtk-sec-rng since all MediaTek ARMv8 SoCs can > >> reuse > >> this driver. > >> - refine coding style and unnecessary check. > >> > >> changes since v2: > >> - remove unused comments. > >> - remove redundant variable. > >> > >> changes since v3: > >> - add dt-bindings for MediaTek rng with TrustZone enabled. > >> - revise HWRNG SMC call fid. > >> > >> changes since v4: > >> - move bindings to the arm/firmware directory. > >> - revise driver init flow to check more property. > >> > >> changes since v5: > >> - refactor to more generic security rng driver which > >> is not platform specific. > >> > >> *** BLURB HERE *** > >> > >> Neal Liu (2): > >> dt-bindings: rng: add bindings for sec-rng > >> hwrng: add sec-rng driver > >> > > > > There is no reason to model a SMC call as a driver, and represent it > > via a DT node like this. > > +1. > > > It would be much better if this SMC interface is made truly generic, > > and wired into the arch_get_random() interface, which can be used much > > earlier. > > Wasn't there a plan to standardize a SMC call to rule them all? > > M. Could you give us a hint how to make this SMC interface more generic in addition to my approach? There is no (easy) way to get platform-independent SMC function ID, which is why we encode it into device tree, and provide a generic driver. In this way, different devices can be mapped and then get different function ID internally. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67686C433E2 for ; Wed, 3 Jun 2020 07:29:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C1F32067B for ; Wed, 3 Jun 2020 07:29:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BPRkewMp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="CEt6aRgE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C1F32067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/mReve4s27azeQ5Gg6gKh7kcRy5y/bnTmuRxVHjnGdM=; b=BPRkewMpI5y39k JQMdok4u29VEWPOlScILc4MrxsVa4+vV21Ikepf8o710s9WwyLkZ6tmygtaJZZafirgYGzhpSSWpC 5nax2pZhqk2+RnI+K4j0xMHBE3O65xg5hJD6EniDg8tPO49N0/FquA3BMySpVQtzeEwH2qObuTJoK u3nX8ce/SXwRlBSN5DNw6quuIdm/A+mOOoMAKTsS/ciheA2vETojsBz3QJmQvfE9ssFUDxypYHpMq zegiFUPwfwKTnAGRR9fErq359MM6pn5+6dkLMOdffXDeFnOPsJiiHcTz48+17PFdvTJ2n2c9dHDUt Yf/xoMLg/VxiLPmZmE5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgNpv-0004IU-4S; Wed, 03 Jun 2020 07:29:19 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgNpr-0004HL-6t; Wed, 03 Jun 2020 07:29:16 +0000 X-UUID: 68f36bbf5ee94faa878b71255c900f2d-20200602 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=uxJ/OyZIhvn8jO7euhdxxdoo6BqLiSJM0zglxbBqOos=; b=CEt6aRgES19HkCxvzzojs8LYRDsf4UJVp+a2UCrOlilmbI/BJ9L+e5CoG6mCq5ixCZDHQIaqUIueDXroGlcGygPjR0x6ZgRF82VMqtmxQ42zwJrUvXSFxhlIQAOOERT8R6KrbMeGLoZRbjuzOsvDoZDjUGLoVhJABTso3DwAuZY=; X-UUID: 68f36bbf5ee94faa878b71255c900f2d-20200602 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 521984248; Tue, 02 Jun 2020 23:29:00 -0800 Received: from MTKMBS02N1.mediatek.inc (172.21.101.77) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 00:29:08 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 3 Jun 2020 15:29:02 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 3 Jun 2020 15:29:01 +0800 Message-ID: <1591169342.4878.9.camel@mtkswgap22> Subject: Re: Security Random Number Generator support From: Neal Liu To: Marc Zyngier , Julius Werner , Ard Biesheuvel Date: Wed, 3 Jun 2020 15:29:02 +0800 In-Reply-To: <85dfc0142d3879d50c0ba18bcc71e199@misterjones.org> References: <1591085678-22764-1-git-send-email-neal.liu@mediatek.com> <85dfc0142d3879d50c0ba18bcc71e199@misterjones.org> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_002915_254003_A5C3EB4E X-CRM114-Status: GOOD ( 16.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Herbert Xu , Arnd Bergmann , Greg Kroah-Hartman , Sean Wang , "linux-mediatek@lists.infradead.org" , lkml , wsd_upstream , Rob Herring , Neal Liu , Linux Crypto Mailing List , Matt Mackall , Matthias Brugger , Crystal Guo =?UTF-8?Q?=28=E9=83=AD=E6=99=B6=29?= , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2020-06-02 at 21:02 +0800, Marc Zyngier wrote: > On 2020-06-02 13:14, Ard Biesheuvel wrote: > > On Tue, 2 Jun 2020 at 10:15, Neal Liu wrote: > >> > >> These patch series introduce a security random number generator > >> which provides a generic interface to get hardware rnd from Secure > >> state. The Secure state can be Arm Trusted Firmware(ATF), Trusted > >> Execution Environment(TEE), or even EL2 hypervisor. > >> > >> Patch #1..2 adds sec-rng kernel driver for Trustzone based SoCs. > >> For security awareness SoCs on ARMv8 with TrustZone enabled, > >> peripherals like entropy sources is not accessible from normal world > >> (linux) and rather accessible from secure world (HYP/ATF/TEE) only. > >> This driver aims to provide a generic interface to Arm Trusted > >> Firmware or Hypervisor rng service. > >> > >> > >> changes since v1: > >> - rename mt67xx-rng to mtk-sec-rng since all MediaTek ARMv8 SoCs can > >> reuse > >> this driver. > >> - refine coding style and unnecessary check. > >> > >> changes since v2: > >> - remove unused comments. > >> - remove redundant variable. > >> > >> changes since v3: > >> - add dt-bindings for MediaTek rng with TrustZone enabled. > >> - revise HWRNG SMC call fid. > >> > >> changes since v4: > >> - move bindings to the arm/firmware directory. > >> - revise driver init flow to check more property. > >> > >> changes since v5: > >> - refactor to more generic security rng driver which > >> is not platform specific. > >> > >> *** BLURB HERE *** > >> > >> Neal Liu (2): > >> dt-bindings: rng: add bindings for sec-rng > >> hwrng: add sec-rng driver > >> > > > > There is no reason to model a SMC call as a driver, and represent it > > via a DT node like this. > > +1. > > > It would be much better if this SMC interface is made truly generic, > > and wired into the arch_get_random() interface, which can be used much > > earlier. > > Wasn't there a plan to standardize a SMC call to rule them all? > > M. Could you give us a hint how to make this SMC interface more generic in addition to my approach? There is no (easy) way to get platform-independent SMC function ID, which is why we encode it into device tree, and provide a generic driver. In this way, different devices can be mapped and then get different function ID internally. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel