All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 714629] Re: BIOS doesn't load when read() returns less than the full ROM length
  2011-02-07 14:58 [Qemu-devel] [Bug 714629] [NEW] BIOS doesn't load when read() returns less than the full ROM length Matthew Bloch
@ 2011-02-07 14:58 ` Matthew Bloch
  2020-06-04 14:59 ` Philippe Mathieu-Daudé
  2020-06-04 15:00 ` Philippe Mathieu-Daudé
  2 siblings, 0 replies; 4+ messages in thread
From: Matthew Bloch @ 2011-02-07 14:58 UTC (permalink / raw)
  To: qemu-devel


** Patch added: "Fix loading of BIOS file over 9p/network filesystems"
   https://bugs.launchpad.net/bugs/714629/+attachment/1836057/+files/rom_read.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/714629

Title:
  BIOS doesn't load when read() returns less than the full ROM length

Status in QEMU:
  New

Bug description:
  When qemu is running over a 9p filesystem (e.g. when running
  underneath -virtfs of another qemu), and probably some other network
  filesystems, it fails to read its BIOS image.  This is because it uses
  a single low-level read() call on the bios.bin, asking for the full
  file.  However read() may return less than the full length, and it's
  the caller's responsibility to call it repeatedly if necessary.  When
  read does come up short, qemu doesn't repeat the call, and reports an
  error instead.  The attached patch fixes the one problem I saw, but I
  haven't tried to cover the general case (e.g. extension ROMs).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Qemu-devel] [Bug 714629] [NEW] BIOS doesn't load when read() returns less than the full ROM length
@ 2011-02-07 14:58 Matthew Bloch
  2011-02-07 14:58 ` [Qemu-devel] [Bug 714629] " Matthew Bloch
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Matthew Bloch @ 2011-02-07 14:58 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

When qemu is running over a 9p filesystem (e.g. when running underneath
-virtfs of another qemu), and probably some other network filesystems,
it fails to read its BIOS image.  This is because it uses a single low-
level read() call on the bios.bin, asking for the full file.  However
read() may return less than the full length, and it's the caller's
responsibility to call it repeatedly if necessary.  When read does come
up short, qemu doesn't repeat the call, and reports an error instead.
The attached patch fixes the one problem I saw, but I haven't tried to
cover the general case (e.g. extension ROMs).

** Affects: qemu
     Importance: Undecided
         Status: New


** Tags: bios

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/714629

Title:
  BIOS doesn't load when read() returns less than the full ROM length

Status in QEMU:
  New

Bug description:
  When qemu is running over a 9p filesystem (e.g. when running
  underneath -virtfs of another qemu), and probably some other network
  filesystems, it fails to read its BIOS image.  This is because it uses
  a single low-level read() call on the bios.bin, asking for the full
  file.  However read() may return less than the full length, and it's
  the caller's responsibility to call it repeatedly if necessary.  When
  read does come up short, qemu doesn't repeat the call, and reports an
  error instead.  The attached patch fixes the one problem I saw, but I
  haven't tried to cover the general case (e.g. extension ROMs).

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 714629] Re: BIOS doesn't load when read() returns less than the full ROM length
  2011-02-07 14:58 [Qemu-devel] [Bug 714629] [NEW] BIOS doesn't load when read() returns less than the full ROM length Matthew Bloch
  2011-02-07 14:58 ` [Qemu-devel] [Bug 714629] " Matthew Bloch
@ 2020-06-04 14:59 ` Philippe Mathieu-Daudé
  2020-06-04 15:00 ` Philippe Mathieu-Daudé
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-04 14:59 UTC (permalink / raw)
  To: qemu-devel

This seems to have been fixed by commit
1f40547f5ce0c135faa7d14f066b97002fd8c204.

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/714629

Title:
  BIOS doesn't load when read() returns less than the full ROM length

Status in QEMU:
  Fix Released

Bug description:
  When qemu is running over a 9p filesystem (e.g. when running
  underneath -virtfs of another qemu), and probably some other network
  filesystems, it fails to read its BIOS image.  This is because it uses
  a single low-level read() call on the bios.bin, asking for the full
  file.  However read() may return less than the full length, and it's
  the caller's responsibility to call it repeatedly if necessary.  When
  read does come up short, qemu doesn't repeat the call, and reports an
  error instead.  The attached patch fixes the one problem I saw, but I
  haven't tried to cover the general case (e.g. extension ROMs).

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/714629/+subscriptions


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug 714629] Re: BIOS doesn't load when read() returns less than the full ROM length
  2011-02-07 14:58 [Qemu-devel] [Bug 714629] [NEW] BIOS doesn't load when read() returns less than the full ROM length Matthew Bloch
  2011-02-07 14:58 ` [Qemu-devel] [Bug 714629] " Matthew Bloch
  2020-06-04 14:59 ` Philippe Mathieu-Daudé
@ 2020-06-04 15:00 ` Philippe Mathieu-Daudé
  2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-06-04 15:00 UTC (permalink / raw)
  To: qemu-devel

Fix included in QEMU v4.0.0.

** Changed in: qemu
       Status: New => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/714629

Title:
  BIOS doesn't load when read() returns less than the full ROM length

Status in QEMU:
  Fix Released

Bug description:
  When qemu is running over a 9p filesystem (e.g. when running
  underneath -virtfs of another qemu), and probably some other network
  filesystems, it fails to read its BIOS image.  This is because it uses
  a single low-level read() call on the bios.bin, asking for the full
  file.  However read() may return less than the full length, and it's
  the caller's responsibility to call it repeatedly if necessary.  When
  read does come up short, qemu doesn't repeat the call, and reports an
  error instead.  The attached patch fixes the one problem I saw, but I
  haven't tried to cover the general case (e.g. extension ROMs).

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/714629/+subscriptions


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-04 15:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-07 14:58 [Qemu-devel] [Bug 714629] [NEW] BIOS doesn't load when read() returns less than the full ROM length Matthew Bloch
2011-02-07 14:58 ` [Qemu-devel] [Bug 714629] " Matthew Bloch
2020-06-04 14:59 ` Philippe Mathieu-Daudé
2020-06-04 15:00 ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.