From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D6CC433E0 for ; Fri, 12 Jun 2020 11:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CDD12081A for ; Fri, 12 Jun 2020 11:03:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="opsJHtnZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbgFLLDt (ORCPT ); Fri, 12 Jun 2020 07:03:49 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:48484 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725805AbgFLLDt (ORCPT ); Fri, 12 Jun 2020 07:03:49 -0400 X-UUID: 9c3d95f8b6d742db968f62d491877d9b-20200612 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qaglRPWqGP4IdwsQlkYgHrfbKPtnhQyQo7nkYFx8tsM=; b=opsJHtnZQPOHAn4VbAvA7iH35vWcR8TZQbA5gFuQp12G1sRNXDVOVWPR4Vtt6JKLauhKaUxNA5wIFsnGcxcJ9xM3n4YO7P9e8QY3XRUXFI50rfAhA/NXu03hQQYAPLasfjAcW2R0+uUzUpPyDO38r3r+MW2dGnxNsmgGCsKni6I=; X-UUID: 9c3d95f8b6d742db968f62d491877d9b-20200612 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 444859813; Fri, 12 Jun 2020 19:03:40 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 19:03:39 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 12 Jun 2020 19:03:38 +0800 Message-ID: <1591959682.8804.665.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Sakari Ailus CC: Tomasz Figa , Linus Walleij , Bartosz Golaszewski , Mauro Carvalho Chehab , Andy Shevchenko , Rob Herring , Mark Rutland , Nicolas Boichat , Matthias Brugger , "Cao Bing Bu" , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Sj Huang , Linux Media Mailing List , linux-devicetree , Louis Kuo , "Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?=" , Date: Fri, 12 Jun 2020 19:01:22 +0800 In-Reply-To: <20200611100322.GL16711@paasikivi.fi.intel.com> References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <20200611095333.GK16711@paasikivi.fi.intel.com> <20200611100322.GL16711@paasikivi.fi.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9664EE831528CD8C24C98DDB589FA69B119B312FFEA3696E45D9240344133E872000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgU2FrYXJpLA0KDQpPbiBUaHUsIDIwMjAtMDYtMTEgYXQgMTM6MDMgKzAzMDAsIFNha2FyaSBB aWx1cyB3cm90ZToNCj4gT24gVGh1LCBKdW4gMTEsIDIwMjAgYXQgMTE6NTc6NDNBTSArMDIwMCwg VG9tYXN6IEZpZ2Egd3JvdGU6DQo+ID4gT24gVGh1LCBKdW4gMTEsIDIwMjAgYXQgMTE6NTMgQU0g U2FrYXJpIEFpbHVzDQo+ID4gPHNha2FyaS5haWx1c0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOg0K PiA+ID4NCj4gPiA+IEhpIFRvbWFzeiwNCj4gPiA+DQo+ID4gPiBPbiBXZWQsIEp1biAxMCwgMjAy MCBhdCAwNzo0NDo1NVBNICswMDAwLCBUb21hc3ogRmlnYSB3cm90ZToNCj4gPiA+ID4gSGkgRG9u Z2NodW4sDQo+ID4gPiA+DQo+ID4gPiA+IE9uIFNhdCwgTWF5IDIzLCAyMDIwIGF0IDA0OjQxOjAz UE0gKzA4MDAsIERvbmdjaHVuIFpodSB3cm90ZToNCj4gPiA+ID4gPiBBZGQgYSBWNEwyIHN1Yi1k ZXZpY2UgZHJpdmVyIGZvciBPVjAyQTEwIGltYWdlIHNlbnNvci4NCj4gPiA+ID4gPg0KPiA+ID4g PiA+IFNpZ25lZC1vZmYtYnk6IERvbmdjaHVuIFpodSA8ZG9uZ2NodW4uemh1QG1lZGlhdGVrLmNv bT4NCj4gPiA+ID4gPiAtLS0NCj4gPiA+ID4gPiAgTUFJTlRBSU5FUlMgICAgICAgICAgICAgICAg IHwgICAgMSArDQo+ID4gPiA+ID4gIGRyaXZlcnMvbWVkaWEvaTJjL0tjb25maWcgICB8ICAgMTMg Kw0KPiA+ID4gPiA+ICBkcml2ZXJzL21lZGlhL2kyYy9NYWtlZmlsZSAgfCAgICAxICsNCj4gPiA+ ID4gPiAgZHJpdmVycy9tZWRpYS9pMmMvb3YwMmExMC5jIHwgMTAyNSArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ID4gIDQgZmlsZXMgY2hhbmdlZCwg MTA0MCBpbnNlcnRpb25zKCspDQo+ID4gPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJz L21lZGlhL2kyYy9vdjAyYTEwLmMNCj4gPiA+ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiBUaGFuayB5 b3UgZm9yIHRoZSBwYXRjaC4gUGxlYXNlIHNlZSBteSBjb21tZW50cyBpbmxpbmUuDQo+ID4gPiA+ DQo+ID4gPiA+IFtzbmlwXQ0KPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL2ky Yy9vdjAyYTEwLmMgYi9kcml2ZXJzL21lZGlhL2kyYy9vdjAyYTEwLmMNCj4gPiA+ID4gPiBuZXcg ZmlsZSBtb2RlIDEwMDY0NA0KPiA+ID4gPiA+IGluZGV4IDAwMDAwMDAuLjE2MGEwYjUNCj4gPiA+ ID4gPiAtLS0gL2Rldi9udWxsDQo+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9tZWRpYS9pMmMvb3Yw MmExMC5jDQo+ID4gPiA+IFtzbmlwXQ0KPiA+ID4gPiA+ICtzdGF0aWMgY29uc3QgY2hhciAqIGNv bnN0IG92MDJhMTBfdGVzdF9wYXR0ZXJuX21lbnVbXSA9IHsNCj4gPiA+ID4gPiArICAgIkRpc2Fi bGVkIiwNCj4gPiA+ID4gPiArICAgIkNvbG9yIEJhciIsDQo+ID4gPiA+DQo+ID4gPiA+IG5pdDog V2Ugc2hvdWxkIG5vcm1hbGl6ZSB0aGlzIHRvIG9uZSBvZiB0aGUgc3RhbmRhcmQgbmFtZXMuIFdo YXQgaXMgdGhlDQo+ID4gPiA+IHBhdHRlcm4gb24gdGhpcyBzZW5zb3I/IElzIGl0IHBlcmhhcHMg IkVpZ2h0IFZlcnRpY2FsIENvbG91ciBCYXJzIj8NCj4gPiA+ID4NCj4gPiA+ID4gPiArfTsNCj4g PiA+ID4gW3NuaXBdDQo+ID4gPiA+ID4gK3N0YXRpYyBpbnQgb3YwMmExMF9zZXRfZm10KHN0cnVj dCB2NGwyX3N1YmRldiAqc2QsDQo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICBzdHJ1 Y3QgdjRsMl9zdWJkZXZfcGFkX2NvbmZpZyAqY2ZnLA0KPiA+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgc3RydWN0IHY0bDJfc3ViZGV2X2Zvcm1hdCAqZm10KQ0KPiA+ID4gPiA+ICt7DQo+ ID4gPiA+ID4gKyAgIHN0cnVjdCBvdjAyYTEwICpvdjAyYTEwID0gdG9fb3YwMmExMChzZCk7DQo+ ID4gPiA+ID4gKyAgIHN0cnVjdCB2NGwyX21idXNfZnJhbWVmbXQgKm1idXNfZm10ID0gJmZtdC0+ Zm9ybWF0Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArICAgbXV0ZXhfbG9jaygmb3YwMmExMC0+ bXV0ZXgpOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4gRG9uJ3Qgd2Ug bmVlZCB0byBoYW5kbGUgdGhlIGNhc2Ugd2hlbiBmbXQtPndoaWNoIGlzIFY0TDJfU1VCREVWX0ZP Uk1BVF9UUlksDQo+ID4gPiA+IHdoaWNoIGlzIHVzZWQgZm9yIHRyeWluZyB0aGUgZm9ybWF0LCBi dXQgbm90IGFwcGx5aW5nIGl0IHRvIHRoZSBoYXJkd2FyZT8NCj4gPiA+DQo+ID4gPiBZZXMuDQo+ ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiA+ICsgICBpZiAob3YwMmExMC0+c3RyZWFtaW5nKSB7DQo+ ID4gPiA+ID4gKyAgICAgICAgICAgbXV0ZXhfdW5sb2NrKCZvdjAyYTEwLT5tdXRleCk7DQo+ID4g PiA+ID4gKyAgICAgICAgICAgcmV0dXJuIC1FQlVTWTsNCj4gPiA+ID4gPiArICAgfQ0KPiA+ID4g PiA+ICsNCj4gPiA+ID4gPiArICAgLyogT25seSBvbmUgc2Vuc29yIG1vZGUgc3VwcG9ydGVkICov DQo+ID4gPiA+ID4gKyAgIG1idXNfZm10LT5jb2RlID0gb3YwMmExMC0+Zm10LmNvZGU7DQo+ID4g PiA+ID4gKyAgIG92MDJhMTBfZmlsbF9mbXQob3YwMmExMC0+Y3VyX21vZGUsIG1idXNfZm10KTsN Cj4gPiA+ID4gPiArICAgb3YwMmExMC0+Zm10ID0gZm10LT5mb3JtYXQ7DQo+ID4gPiA+ID4gKw0K PiA+ID4gPiA+ICsgICBtdXRleF91bmxvY2soJm92MDJhMTAtPm11dGV4KTsNCj4gPiA+ID4gPiAr DQo+ID4gPiA+ID4gKyAgIHJldHVybiAwOw0KPiA+ID4gPiA+ICt9DQo+ID4gPiA+ID4gKw0KPiA+ ID4gPiA+ICtzdGF0aWMgaW50IG92MDJhMTBfZ2V0X2ZtdChzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNk LA0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHY0bDJfc3ViZGV2X3Bh ZF9jb25maWcgKmNmZywNCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCB2 NGwyX3N1YmRldl9mb3JtYXQgKmZtdCkNCj4gPiA+ID4gPiArew0KPiA+ID4gPiA+ICsgICBzdHJ1 Y3Qgb3YwMmExMCAqb3YwMmExMCA9IHRvX292MDJhMTAoc2QpOw0KPiA+ID4gPiA+ICsgICBzdHJ1 Y3QgdjRsMl9tYnVzX2ZyYW1lZm10ICptYnVzX2ZtdCA9ICZmbXQtPmZvcm1hdDsNCj4gPiA+ID4g PiArDQo+ID4gPiA+ID4gKyAgIG11dGV4X2xvY2soJm92MDJhMTAtPm11dGV4KTsNCj4gPiA+ID4g PiArDQo+ID4gPiA+ID4gKyAgIGZtdC0+Zm9ybWF0ID0gb3YwMmExMC0+Zm10Ow0KPiA+ID4gPg0K PiA+ID4gPiBEaXR0by4NCj4gPiA+ID4NCj4gPiA+ID4gPiArICAgbWJ1c19mbXQtPmNvZGUgPSBv djAyYTEwLT5mbXQuY29kZTsNCj4gPiA+ID4gPiArICAgb3YwMmExMF9maWxsX2ZtdChvdjAyYTEw LT5jdXJfbW9kZSwgbWJ1c19mbXQpOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArICAgbXV0ZXhf dW5sb2NrKCZvdjAyYTEwLT5tdXRleCk7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgICByZXR1 cm4gMDsNCj4gPiA+ID4gPiArfQ0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArc3RhdGljIGludCBv djAyYTEwX2VudW1fbWJ1c19jb2RlKHN0cnVjdCB2NGwyX3N1YmRldiAqc2QsDQo+ID4gPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHY0bDJfc3ViZGV2X3BhZF9jb25m aWcgKmNmZywNCj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3Qg djRsMl9zdWJkZXZfbWJ1c19jb2RlX2VudW0gKmNvZGUpDQo+ID4gPiA+ID4gK3sNCj4gPiA+ID4g PiArICAgc3RydWN0IG92MDJhMTAgKm92MDJhMTAgPSB0b19vdjAyYTEwKHNkKTsNCj4gPiA+ID4g PiArDQo+ID4gPiA+ID4gKyAgIGlmIChjb2RlLT5pbmRleCA+PSBBUlJBWV9TSVpFKHN1cHBvcnRl ZF9tb2RlcykpDQo+ID4gPiA+ID4gKyAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPiA+ DQo+ID4gPiA+IEhtbSwgc3VwcG9ydGVkX21vZGVzW10gZG9lc24ndCBzZWVtIHRvIGhvbGQgdGhl IGluZm9ybWF0aW9uIGFib3V0IG1idXMNCj4gPiA+ID4gY29kZXMuIFNob3VsZCB0aGlzIGp1c3Qg cGVyaGFwcyBiZSAiIT0gMCI/DQo+ID4gPiA+DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsgICBj b2RlLT5jb2RlID0gb3YwMmExMC0+Zm10LmNvZGU7DQo+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ICsg ICByZXR1cm4gMDsNCj4gPiA+ID4gPiArfQ0KPiA+ID4gPiBbc25pcF0NCj4gPiA+ID4gPiArc3Rh dGljIGludCBvdjAyYTEwX2VudGl0eV9pbml0X2NmZyhzdHJ1Y3QgdjRsMl9zdWJkZXYgKnNkLA0K PiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgdjRsMl9zdWJk ZXZfcGFkX2NvbmZpZyAqY2ZnKQ0KPiA+ID4gPiA+ICt7DQo+ID4gPiA+ID4gKyAgIHN0cnVjdCB2 NGwyX3N1YmRldl9mb3JtYXQgZm10ID0gew0KPiA+ID4gPiA+ICsgICAgICAgICAgIC53aGljaCA9 IGNmZyA/IFY0TDJfU1VCREVWX0ZPUk1BVF9UUlkgOiBWNEwyX1NVQkRFVl9GT1JNQVRfQUNUSVZF LA0KPiA+ID4gPiA+ICsgICAgICAgICAgIC5mb3JtYXQgPSB7DQo+ID4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAud2lkdGggPSAxNjAwLA0KPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg LmhlaWdodCA9IDEyMDAsDQo+ID4gPiA+ID4gKyAgICAgICAgICAgfQ0KPiA+ID4gPiA+ICsgICB9 Ow0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArICAgb3YwMmExMF9zZXRfZm10KHNkLCBjZmcsICZm bXQpOw0KPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiArICAgcmV0dXJuIDA7DQo+ID4gPiA+ID4gK30N Cj4gPiA+ID4gPiArDQo+ID4gPiA+DQo+ID4gPiA+IEknbSBub3QgZmFtaWxpYXIgd2l0aCB0aGlz IGluaXRfY2ZnIG9wZXJhdGlvbiBhbmQgdGhlIGRvY3VtZW50YXRpb24gaXMgdmVyeQ0KPiA+ID4g PiBzcGFyc2UgYWJvdXQgaXQuIFNha2FyaSwgaXMgdGhpcyBhIGNvcnJlY3QgaW1wbGVtZW50YXRp b24/DQo+ID4gPg0KPiA+ID4gVGhlIHB1cnBvc2UgaXMgdG8gaW5pdGlhbGlzZSBhIHBhZCBjb25m aWd1cmF0aW9uIChmb3JtYXQgYW5kIHNlbGVjdGlvbg0KPiA+ID4gcmVjdGFuZ2xlcykgdG8gdGhl IGRldmljZSBkZWZhdWx0cy4gQXMgdGhlcmUgc2VlbSB0byBiZSBubyBzZWxlY3Rpb24NCj4gPiA+ IHJlY3RhbmdsZXMsIHRoaXMgc2VlbXMgZmluZSB0byBtZS4NCj4gPiANCj4gPiBUaGFua3MuIEkg dHJhY2VkIHRoZSBjb2RlIGFuZCBjb3VsZCBvbmx5IHNlZSBvbmUgcGxhY2Ugd2hlcmUgdGhlDQo+ ID4gY2FsbGJhY2sgaXMgYmVpbmcgY2FsbGVkIGFuZCB0aGF0IHdhcyB3aXRoIGNmZyAhPSBOVUxM LiBTdGlsbCwgdGhlDQo+ID4gY29kZSBhYm92ZSB1c2VzICJjZmcgPyIgYXMgYSBjaGVjayB0byBk ZXRlcm1pbmUgd2hldGhlciBUUlkgb3IgQUNUSVZFDQo+ID4gc2hvdWxkIGJlIHBhc3NlZCB0byB3 aGljaC4gSXMgdGhhdCBhbHNvIGNvcnJlY3Q/DQo+IA0KPiBJdCBjb3VsZCBiZSB1c2VkIGluIHNl dHRpbmcgdGhlIGFjdGl2ZSBmb3JtYXQgaW4gcHJvYmUuIFRoYXQgd291bGQgcHJvYmFibHkNCj4g YmUgY2xlYW5lciB0aGFuIHdoYXQgaXQgY3VycmVudGx5IGRvZXMuDQo+IA0KDQpTYWthcmksIGRp ZCB5b3UgbWVhbiB0aGF0IHdlIG5lZWQgdG8gdXBkYXRlIF9wcm9iZSBBUEk/DQpMaWtlIHRoaXM6 DQpzdHJ1Y3QgdjRsMl9zdWJkZXZfZm9ybWF0IGZtdCA9IHsNCgkud2hpY2ggPSBWNEwyX1NVQkRF Vl9GT1JNQVRfQUNUSVZFLA0KfTsNCg0KPiBCdXQgYXBhcnQgZnJvbSB0aGF0LCB0aGUgZnJhbWV3 b3JrIGFsd2F5cyBjYWxscyBpbml0X2NmZyB3aXRoIGNmZyBub24tTlVMTC4NCj4gDQoNCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82395C433DF for ; Fri, 12 Jun 2020 11:03:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F36F2065C for ; Fri, 12 Jun 2020 11:03:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KLEWi98x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="igTHKJzI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F36F2065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QqqIcHSJUJ1bJ3PcfFtd4G92Lz+VtxcT5kpL5+PvnJg=; b=KLEWi98xFZKzFS gNms1Mw7LrcCEu8HcaAflG45aaEAZDho6JSSJmcAdKtNWIOsOWoMItQj3MuaaW4CgnHt/tMwsS+vX 2IJHKyokUjIiRNQKlJgucsHO/yusGt2bStupgW/HY7JC/fz4i7f9+hp/9RhKdkZ23VXdt3IOtYkxd NG/X5QPmjtJG0xd1BIMCUpk4csxSVtIbcCEEErTGzFAxHiHour6J4//oaS2CXgWx90M411rJ4ZtL+ sH+kgmbOLBjtnp0VP3p2T2rC5woJcYT2yHStgeYYXctZIynr0tlD6S4QHVs+IkKFUQoVA6HqtpUKn URt/7okOpIpvlF3VNIKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjhTT-0006Jd-KB; Fri, 12 Jun 2020 11:03:51 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjhTQ-0006JB-MN; Fri, 12 Jun 2020 11:03:50 +0000 X-UUID: e006689d72d84fef8f5534474b8d6ba5-20200612 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qaglRPWqGP4IdwsQlkYgHrfbKPtnhQyQo7nkYFx8tsM=; b=igTHKJzImv7DlxphxtOwvGwI+rkJhaHBD08sBPAe8E5+8xuU8waWuBHyekqNUp/vmoYB94egC6wYq3Cm6+kAL1RRztewkOeLwr0ZgyzqqLuv4Xn14gDtxXtK6O6ZJUHQ8K+JQqftMcg3HW8FxxPDJOKZBCYGH1u04a4lJsLakjI=; X-UUID: e006689d72d84fef8f5534474b8d6ba5-20200612 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1866389502; Fri, 12 Jun 2020 03:03:35 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 04:03:42 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 19:03:39 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 12 Jun 2020 19:03:38 +0800 Message-ID: <1591959682.8804.665.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Sakari Ailus Date: Fri, 12 Jun 2020 19:01:22 +0800 In-Reply-To: <20200611100322.GL16711@paasikivi.fi.intel.com> References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <20200611095333.GK16711@paasikivi.fi.intel.com> <20200611100322.GL16711@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9664EE831528CD8C24C98DDB589FA69B119B312FFEA3696E45D9240344133E872000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_040348_740968_BCD310EA X-CRM114-Status: GOOD ( 30.63 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Tomasz Figa , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Louis Kuo , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sakari, On Thu, 2020-06-11 at 13:03 +0300, Sakari Ailus wrote: > On Thu, Jun 11, 2020 at 11:57:43AM +0200, Tomasz Figa wrote: > > On Thu, Jun 11, 2020 at 11:53 AM Sakari Ailus > > wrote: > > > > > > Hi Tomasz, > > > > > > On Wed, Jun 10, 2020 at 07:44:55PM +0000, Tomasz Figa wrote: > > > > Hi Dongchun, > > > > > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > --- > > > > > MAINTAINERS | 1 + > > > > > drivers/media/i2c/Kconfig | 13 + > > > > > drivers/media/i2c/Makefile | 1 + > > > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > > > 4 files changed, 1040 insertions(+) > > > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > > > > > > > Thank you for the patch. Please see my comments inline. > > > > > > > > [snip] > > > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > > > new file mode 100644 > > > > > index 0000000..160a0b5 > > > > > --- /dev/null > > > > > +++ b/drivers/media/i2c/ov02a10.c > > > > [snip] > > > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > > > + "Disabled", > > > > > + "Color Bar", > > > > > > > > nit: We should normalize this to one of the standard names. What is the > > > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > > > > > > +}; > > > > [snip] > > > > > +static int ov02a10_set_fmt(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg, > > > > > + struct v4l2_subdev_format *fmt) > > > > > +{ > > > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > > > + struct v4l2_mbus_framefmt *mbus_fmt = &fmt->format; > > > > > + > > > > > + mutex_lock(&ov02a10->mutex); > > > > > + > > > > > > > > > > > > Don't we need to handle the case when fmt->which is V4L2_SUBDEV_FORMAT_TRY, > > > > which is used for trying the format, but not applying it to the hardware? > > > > > > Yes. > > > > > > > > > > > > + if (ov02a10->streaming) { > > > > > + mutex_unlock(&ov02a10->mutex); > > > > > + return -EBUSY; > > > > > + } > > > > > + > > > > > + /* Only one sensor mode supported */ > > > > > + mbus_fmt->code = ov02a10->fmt.code; > > > > > + ov02a10_fill_fmt(ov02a10->cur_mode, mbus_fmt); > > > > > + ov02a10->fmt = fmt->format; > > > > > + > > > > > + mutex_unlock(&ov02a10->mutex); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int ov02a10_get_fmt(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg, > > > > > + struct v4l2_subdev_format *fmt) > > > > > +{ > > > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > > > + struct v4l2_mbus_framefmt *mbus_fmt = &fmt->format; > > > > > + > > > > > + mutex_lock(&ov02a10->mutex); > > > > > + > > > > > + fmt->format = ov02a10->fmt; > > > > > > > > Ditto. > > > > > > > > > + mbus_fmt->code = ov02a10->fmt.code; > > > > > + ov02a10_fill_fmt(ov02a10->cur_mode, mbus_fmt); > > > > > + > > > > > + mutex_unlock(&ov02a10->mutex); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int ov02a10_enum_mbus_code(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg, > > > > > + struct v4l2_subdev_mbus_code_enum *code) > > > > > +{ > > > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > > > + > > > > > + if (code->index >= ARRAY_SIZE(supported_modes)) > > > > > + return -EINVAL; > > > > > > > > Hmm, supported_modes[] doesn't seem to hold the information about mbus > > > > codes. Should this just perhaps be "!= 0"? > > > > > > > > > + > > > > > + code->code = ov02a10->fmt.code; > > > > > + > > > > > + return 0; > > > > > +} > > > > [snip] > > > > > +static int ov02a10_entity_init_cfg(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg) > > > > > +{ > > > > > + struct v4l2_subdev_format fmt = { > > > > > + .which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE, > > > > > + .format = { > > > > > + .width = 1600, > > > > > + .height = 1200, > > > > > + } > > > > > + }; > > > > > + > > > > > + ov02a10_set_fmt(sd, cfg, &fmt); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > > > > I'm not familiar with this init_cfg operation and the documentation is very > > > > sparse about it. Sakari, is this a correct implementation? > > > > > > The purpose is to initialise a pad configuration (format and selection > > > rectangles) to the device defaults. As there seem to be no selection > > > rectangles, this seems fine to me. > > > > Thanks. I traced the code and could only see one place where the > > callback is being called and that was with cfg != NULL. Still, the > > code above uses "cfg ?" as a check to determine whether TRY or ACTIVE > > should be passed to which. Is that also correct? > > It could be used in setting the active format in probe. That would probably > be cleaner than what it currently does. > Sakari, did you mean that we need to update _probe API? Like this: struct v4l2_subdev_format fmt = { .which = V4L2_SUBDEV_FORMAT_ACTIVE, }; > But apart from that, the framework always calls init_cfg with cfg non-NULL. > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F83AC433E1 for ; Fri, 12 Jun 2020 11:03:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5143E2065C for ; Fri, 12 Jun 2020 11:03:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZjR3RYmj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="igTHKJzI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5143E2065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQhAoyFc1rQKF7EHEBMHKxyvUBtClJ/12rUYUrHoiRQ=; b=ZjR3RYmjixqwgm CiayLI7ZdySDr2x+KKu+IGwXyY17bFhacnmkJkT8UIbbmDJnh3tnl3iilIgihFtG5dm8N5P95HUwp MHUrVXnRUDZNuVM3SrTkAusmlZu+WRFCriuTgsjNlKaGvOknlOIay6RHnJs32PXLq/2HbaJN9Y5gK Zud81ZBrIXcHxqijgt4LBotVH+E0aZ9I9FkYR1aI9NmjTxvRBHXubZNz14bBtujGmAFWm4KXINGuF WItHhIq8+Z7/0hCfK+pZyMzQsw5E5d0h/vkGmA1xfR+KCIfPhDWtaoRcGVvunaIRM6/y8B/+Gth3L d5gDx5ZGia6H4fKIdGFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjhTU-0006KR-Gm; Fri, 12 Jun 2020 11:03:52 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjhTQ-0006JB-MN; Fri, 12 Jun 2020 11:03:50 +0000 X-UUID: e006689d72d84fef8f5534474b8d6ba5-20200612 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qaglRPWqGP4IdwsQlkYgHrfbKPtnhQyQo7nkYFx8tsM=; b=igTHKJzImv7DlxphxtOwvGwI+rkJhaHBD08sBPAe8E5+8xuU8waWuBHyekqNUp/vmoYB94egC6wYq3Cm6+kAL1RRztewkOeLwr0ZgyzqqLuv4Xn14gDtxXtK6O6ZJUHQ8K+JQqftMcg3HW8FxxPDJOKZBCYGH1u04a4lJsLakjI=; X-UUID: e006689d72d84fef8f5534474b8d6ba5-20200612 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1866389502; Fri, 12 Jun 2020 03:03:35 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 04:03:42 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 12 Jun 2020 19:03:39 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 12 Jun 2020 19:03:38 +0800 Message-ID: <1591959682.8804.665.camel@mhfsdcap03> Subject: Re: [V9, 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver From: Dongchun Zhu To: Sakari Ailus Date: Fri, 12 Jun 2020 19:01:22 +0800 In-Reply-To: <20200611100322.GL16711@paasikivi.fi.intel.com> References: <20200523084103.31276-1-dongchun.zhu@mediatek.com> <20200523084103.31276-3-dongchun.zhu@mediatek.com> <20200610194455.GK201868@chromium.org> <20200611095333.GK16711@paasikivi.fi.intel.com> <20200611100322.GL16711@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 9664EE831528CD8C24C98DDB589FA69B119B312FFEA3696E45D9240344133E872000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_040348_740968_BCD310EA X-CRM114-Status: GOOD ( 30.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Linus Walleij , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Tomasz Figa , Bartosz Golaszewski , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Louis Kuo , Matthias Brugger , Cao Bing Bu , Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On Thu, 2020-06-11 at 13:03 +0300, Sakari Ailus wrote: > On Thu, Jun 11, 2020 at 11:57:43AM +0200, Tomasz Figa wrote: > > On Thu, Jun 11, 2020 at 11:53 AM Sakari Ailus > > wrote: > > > > > > Hi Tomasz, > > > > > > On Wed, Jun 10, 2020 at 07:44:55PM +0000, Tomasz Figa wrote: > > > > Hi Dongchun, > > > > > > > > On Sat, May 23, 2020 at 04:41:03PM +0800, Dongchun Zhu wrote: > > > > > Add a V4L2 sub-device driver for OV02A10 image sensor. > > > > > > > > > > Signed-off-by: Dongchun Zhu > > > > > --- > > > > > MAINTAINERS | 1 + > > > > > drivers/media/i2c/Kconfig | 13 + > > > > > drivers/media/i2c/Makefile | 1 + > > > > > drivers/media/i2c/ov02a10.c | 1025 +++++++++++++++++++++++++++++++++++++++++++ > > > > > 4 files changed, 1040 insertions(+) > > > > > create mode 100644 drivers/media/i2c/ov02a10.c > > > > > > > > > > > > > Thank you for the patch. Please see my comments inline. > > > > > > > > [snip] > > > > > diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c > > > > > new file mode 100644 > > > > > index 0000000..160a0b5 > > > > > --- /dev/null > > > > > +++ b/drivers/media/i2c/ov02a10.c > > > > [snip] > > > > > +static const char * const ov02a10_test_pattern_menu[] = { > > > > > + "Disabled", > > > > > + "Color Bar", > > > > > > > > nit: We should normalize this to one of the standard names. What is the > > > > pattern on this sensor? Is it perhaps "Eight Vertical Colour Bars"? > > > > > > > > > +}; > > > > [snip] > > > > > +static int ov02a10_set_fmt(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg, > > > > > + struct v4l2_subdev_format *fmt) > > > > > +{ > > > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > > > + struct v4l2_mbus_framefmt *mbus_fmt = &fmt->format; > > > > > + > > > > > + mutex_lock(&ov02a10->mutex); > > > > > + > > > > > > > > > > > > Don't we need to handle the case when fmt->which is V4L2_SUBDEV_FORMAT_TRY, > > > > which is used for trying the format, but not applying it to the hardware? > > > > > > Yes. > > > > > > > > > > > > + if (ov02a10->streaming) { > > > > > + mutex_unlock(&ov02a10->mutex); > > > > > + return -EBUSY; > > > > > + } > > > > > + > > > > > + /* Only one sensor mode supported */ > > > > > + mbus_fmt->code = ov02a10->fmt.code; > > > > > + ov02a10_fill_fmt(ov02a10->cur_mode, mbus_fmt); > > > > > + ov02a10->fmt = fmt->format; > > > > > + > > > > > + mutex_unlock(&ov02a10->mutex); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int ov02a10_get_fmt(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg, > > > > > + struct v4l2_subdev_format *fmt) > > > > > +{ > > > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > > > + struct v4l2_mbus_framefmt *mbus_fmt = &fmt->format; > > > > > + > > > > > + mutex_lock(&ov02a10->mutex); > > > > > + > > > > > + fmt->format = ov02a10->fmt; > > > > > > > > Ditto. > > > > > > > > > + mbus_fmt->code = ov02a10->fmt.code; > > > > > + ov02a10_fill_fmt(ov02a10->cur_mode, mbus_fmt); > > > > > + > > > > > + mutex_unlock(&ov02a10->mutex); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int ov02a10_enum_mbus_code(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg, > > > > > + struct v4l2_subdev_mbus_code_enum *code) > > > > > +{ > > > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd); > > > > > + > > > > > + if (code->index >= ARRAY_SIZE(supported_modes)) > > > > > + return -EINVAL; > > > > > > > > Hmm, supported_modes[] doesn't seem to hold the information about mbus > > > > codes. Should this just perhaps be "!= 0"? > > > > > > > > > + > > > > > + code->code = ov02a10->fmt.code; > > > > > + > > > > > + return 0; > > > > > +} > > > > [snip] > > > > > +static int ov02a10_entity_init_cfg(struct v4l2_subdev *sd, > > > > > + struct v4l2_subdev_pad_config *cfg) > > > > > +{ > > > > > + struct v4l2_subdev_format fmt = { > > > > > + .which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE, > > > > > + .format = { > > > > > + .width = 1600, > > > > > + .height = 1200, > > > > > + } > > > > > + }; > > > > > + > > > > > + ov02a10_set_fmt(sd, cfg, &fmt); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > > > > I'm not familiar with this init_cfg operation and the documentation is very > > > > sparse about it. Sakari, is this a correct implementation? > > > > > > The purpose is to initialise a pad configuration (format and selection > > > rectangles) to the device defaults. As there seem to be no selection > > > rectangles, this seems fine to me. > > > > Thanks. I traced the code and could only see one place where the > > callback is being called and that was with cfg != NULL. Still, the > > code above uses "cfg ?" as a check to determine whether TRY or ACTIVE > > should be passed to which. Is that also correct? > > It could be used in setting the active format in probe. That would probably > be cleaner than what it currently does. > Sakari, did you mean that we need to update _probe API? Like this: struct v4l2_subdev_format fmt = { .which = V4L2_SUBDEV_FORMAT_ACTIVE, }; > But apart from that, the framework always calls init_cfg with cfg non-NULL. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel