All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	Wolfram Sang <wsa@kernel.org>,
	kernel@pengutronix.de, Krzysztof Kozlowski <krzk@kernel.org>,
	stable@vger.kernel.org
Subject: [PATCH v2 2/3] spi: spi-fsl-dspi: Initialize completion before possible interrupt
Date: Mon, 15 Jun 2020 10:07:18 +0200	[thread overview]
Message-ID: <1592208439-17594-2-git-send-email-krzk@kernel.org> (raw)
In-Reply-To: <1592208439-17594-1-git-send-email-krzk@kernel.org>

The interrupt handler calls completion and is IRQ requested before the
completion is initialized.  Logically it should be the other way.

Fixes: 4f5ee75ea171 ("spi: spi-fsl-dspi: Replace interruptible wait queue with a simple completion")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. Rework the commit msg.
---
 drivers/spi/spi-fsl-dspi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
index 023e05c53b85..080c5624bd1e 100644
--- a/drivers/spi/spi-fsl-dspi.c
+++ b/drivers/spi/spi-fsl-dspi.c
@@ -1385,6 +1385,8 @@ static int dspi_probe(struct platform_device *pdev)
 		goto poll_mode;
 	}
 
+	init_completion(&dspi->xfer_done);
+
 	ret = devm_request_irq(&pdev->dev, dspi->irq, dspi_interrupt,
 			       IRQF_SHARED, pdev->name, dspi);
 	if (ret < 0) {
@@ -1392,8 +1394,6 @@ static int dspi_probe(struct platform_device *pdev)
 		goto out_clk_put;
 	}
 
-	init_completion(&dspi->xfer_done);
-
 poll_mode:
 
 	if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) {
-- 
2.7.4


  reply	other threads:[~2020-06-15  8:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15  8:07 [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Krzysztof Kozlowski
2020-06-15  8:07 ` Krzysztof Kozlowski [this message]
2020-06-15  8:07 ` [PATCH v2 3/3] genirq: Do not test disabled IRQs with DEBUG_SHIRQ Krzysztof Kozlowski
2020-06-15 12:08   ` Mark Brown
2020-06-16 10:11     ` Krzysztof Kozlowski
2020-06-16 10:39       ` Mark Brown
2020-06-17  9:30         ` Thomas Gleixner
2020-06-15  8:17 ` [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths Marc Kleine-Budde
2020-06-15  9:23   ` Vladimir Oltean
2020-06-15 13:08     ` Krzysztof Kozlowski
2020-06-15 12:30   ` Mark Brown
2020-06-15 12:56     ` Vladimir Oltean
2020-06-15 13:10       ` Mark Brown
2020-06-15 13:12         ` Vladimir Oltean
2020-06-15 13:24           ` Mark Brown
2020-06-15 13:29             ` Vladimir Oltean
2020-06-15 13:36               ` Mark Brown
2020-06-15 13:41           ` Krzysztof Kozlowski
2020-06-15 14:23             ` Vladimir Oltean
2020-06-15 14:57               ` Krzysztof Kozlowski
2020-06-15 14:59                 ` Vladimir Oltean
2020-06-15 13:10       ` Krzysztof Kozlowski
2020-06-15 13:14         ` Vladimir Oltean
2020-06-15 13:28           ` Krzysztof Kozlowski
2020-06-15 13:33             ` Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1592208439-17594-2-git-send-email-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vladimir.oltean@nxp.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.